Commit Graph

29703 Commits

Author SHA1 Message Date
akankshamahajan15 604fd35eb2 Fix unit test failure 2026-05-01 17:18:51 -07:00
Trevor Clinkenbeard c3c646ae8e
Merge pull request #13107 from tclinkenbeard-oai/dev/tclinkenbeard/todo-cleanup
Address various `TODO` comments
2026-05-01 03:08:56 -05:00
Trevor Clinkenbeard e3e0ef7a60 Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/todo-cleanup 2026-04-30 18:49:54 -07:00
Akanksha Mahajan 54795dcc94
Design changes to pass encryption_block_size to fdbbackup command and remove knob (#13023) 2026-04-30 13:32:14 -07:00
gxglass 2416cd9e55
Add doc details about end to end flow control. Also update filenames (#13121) 2026-04-30 10:32:00 -07:00
Johannes Scheuermann cd02d9e21b
Ensure that the begin version filter is smaller than the end version filter (#13114)
* Ensure that the begin version filter is smaller than the end version filter
2026-04-30 18:16:26 +01:00
gxglass 2f0158b4c2
Remove dead code left behind by blob worker, change feed, and metacluster feature deletions (#13119)
Prior efforts (PR#12435, PR#12470, PR#12486, PR#12583, PR#12667, PR#12903) removed some experimental features. This PR cleans up some leftover pieces.

I suppose this is basically a matter of historical interest at this point but those PRs were done purely by hand (ok, with like grep and a text editor) i.e. without any AI coding assistance. So it is not surprising that there is a few percent of leftover bits here and there.

Fixes:

Remove monitorBlobWorkers() and blobRestoreCommandActor() declarations that had no implementations (linker bombs if called)
Remove fast_restore from setclass help text (previously directed operators into an ASSERT(false) crash)
Dead knob removal (13 knobs):

12 blob worker ratekeeper knobs (BW_THROTTLING_ENABLED, TARGET_BW_LAG, etc.) and BLOB_WORKER_PAGE_CACHE
Remove bwLagTarget field from RatekeeperLimits and associated plumbing in Ratekeeper
Dead code removal:

4 never-incremented storage server counters (feedBytesFetched, changeFeedMutations, changeFeedMutationsDurable, changeFeedDiskReads)
Assigned-but-never-read nonExpanded variable in StorageServer::addMutation
ClusterNameRef/ClusterName typedefs, RestoreLoader/Applier/Master forward declarations
Dead schema strings (blob_worker_lag, blob_worker_missing, unreachable_blobManager_worker, metacluster_metrics_missing)
Dead cacheKeys*/cacheChange* function implementations in SystemData.cpp
Dead tenant group code in FuzzApiCorrectness.cpp
Dead fdbcli constants (msgClusterTypeKey, msgDataClustersKey) and blobrange history filter
Dead file removal:

contrib/mockkms/ -- unused Go mock KMS server
tests/fast/EncryptionUnitTests.toml -- tests a path (/blobCipher) that no longer exists
2026-04-29 20:15:54 -07:00
Trevor Clinkenbeard 00b922b566
Merge pull request #13110 from tclinkenbeard-oai/dev/tclinkenbeard/cluster-recovery-coro2
Finish `ClusterRecovery.actor.cpp` coroutine conversion
2026-04-29 21:24:33 -05:00
Trevor Clinkenbeard aae87e7d7c Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/cluster-recovery-coro2 2026-04-29 18:15:25 -07:00
Trevor Clinkenbeard 8c883d6ca1
Merge pull request #13095 from tclinkenbeard-oai/dev/tclinkenbeard/leader-election-coro2
Convert several `LeaderElection.actor.cpp` actors to standard coroutines
2026-04-29 19:51:08 -05:00
gxglass 1f62390883
Add counters for DD and MoveKeys transactions (PR #13062 forward-ported to main) (#13101)
See PR #13062.

This has been refactored a bit compared to the code on the maintenance branches to reduce boilerplate.

* Applied SimpleCounter transaction instrumentation to 20 DD and MoveKeys functions across 4 files, matching the diff in /tmp/pr13097.diff. The 3 missing counters are for waitFailCacheServer which was deleted from the codebase

* reduce boilerplate relating to counters
2026-04-29 17:10:36 -07:00
Trevor Clinkenbeard d52a9cac98
Merge pull request #13082 from tclinkenbeard-oai/dev/tclinkenbeard/tlog-coro3
Create `ServeTLogInterface` class
2026-04-29 19:03:37 -05:00
Trevor Clinkenbeard 5074390ad2
Merge pull request #13115 from tclinkenbeard-oai/dev/tclinkenbeard/replace-map-usage
Replace `map` usage in VersionedBTree.actor.cpp
2026-04-29 18:55:44 -05:00
Trevor Clinkenbeard bd96337cf6
Merge pull request #13087 from tclinkenbeard-oai/dev/tclinkenbeard/commit-proxy-coro3
Convert several more commit proxy actors to standard coroutines
2026-04-29 18:26:41 -05:00
Pierce Lopez 4a12b44042 build: update to toml11-3.8.1 and switch to FetchContent
Switch from ExternalProject to FetchContent because it seems light-weight,
and this is a header-only library so there's not much "build" to it.
2026-04-29 19:22:59 -04:00
Pierce Lopez e402f876ae
build: more clear boost finding cmake messages (#13116)
Most importantly: message(STATUS "Found Boost @ ${Boost_DIR}")

Also make clang/g++ hint message more clear, it's a preference for
cmake to look/try boost in that dir first. (Using clang, cmake
still found plain /opt/boost becase _clang variant did not exist.)

Also wrap some long lines.
2026-04-29 19:02:55 -04:00
Trevor Clinkenbeard 231618e1ca Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/cluster-recovery-coro2 2026-04-29 14:22:46 -07:00
Trevor Clinkenbeard 3f255a01bd Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/leader-election-coro2 2026-04-29 14:17:57 -07:00
Trevor Clinkenbeard a3507dfa3a Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/tlog-coro3 2026-04-29 14:16:01 -07:00
Trevor Clinkenbeard ca2ba09e51
Merge pull request #13094 from tclinkenbeard-oai/dev/tclinkenbeard/fdbrpc-generic-coro2
Convert `fdbrpc/genericactors.actor.h` to standard coroutines
2026-04-29 16:14:24 -05:00
Trevor Clinkenbeard 644d6bca94
Merge pull request #13100 from tclinkenbeard-oai/dev/tclinkenbeard/dd-team-collection-coro
Convert several `DDTeamCollection.actor.cpp` actors to standard coroutines
2026-04-29 16:13:44 -05:00
Trevor Clinkenbeard d1311bf61f Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/commit-proxy-coro3 2026-04-29 14:13:10 -07:00
Trevor Clinkenbeard d6b896814a
Merge pull request #13098 from tclinkenbeard-oai/dev/tclinkenbeard/ss-core-coro
Convert `storageServer` actor to standard coroutine
2026-04-29 10:56:54 -05:00
Trevor Clinkenbeard c4e2f850d1 Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/ss-core-coro 2026-04-29 07:51:35 -07:00
Trevor Clinkenbeard 48e6ce5206 Replace map usage in VersionedBTree.actor.cpp 2026-04-29 14:45:03 +00:00
Trevor Clinkenbeard 8edd579c03
Merge pull request #13091 from tclinkenbeard-oai/dev/tclinkenbeard/redwood-coro
Convert more `VersionedBTree.actor.cpp` actors to standard coroutines
2026-04-29 08:24:05 -05:00
Trevor Clinkenbeard 2917acdd2e Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/ss-core-coro 2026-04-28 16:30:11 -07:00
Trevor Clinkenbeard 399c30a2b8
Merge pull request #13109 from tclinkenbeard-oai/dev/tclinkenbeard/flow-bench-coro
Convert `flow/bench` to standard coroutines
2026-04-28 18:23:53 -05:00
Trevor Clinkenbeard 31674e2784
Merge pull request #13081 from tclinkenbeard-oai/dev/tclinkenbeard/flow-test-target
Create `flow_test` target
2026-04-28 17:37:50 -05:00
Trevor Clinkenbeard e1025a7993
Merge pull request #13080 from tclinkenbeard-oai/dev/tclinkenbeard/move-simulator-up
Move FDB-specific logic out of `ISimulator`
2026-04-28 16:52:22 -05:00
Trevor Clinkenbeard 958e089513 Address review comment 2026-04-28 14:18:47 -07:00
Trevor Clinkenbeard 42788b317c Optimize AwaitableResume::await_resume for ready path 2026-04-28 20:44:59 +00:00
Trevor Clinkenbeard 91d2cc6a98 Rename Tracing.actor.cpp 2026-04-28 13:08:37 -07:00
Trevor Clinkenbeard b0651ac06d Clean up unnecessary branch 2026-04-28 13:08:37 -07:00
Trevor Clinkenbeard f3e0b00468 Rename ClusterRecovery.actor.cpp 2026-04-28 13:08:36 -07:00
Trevor Clinkenbeard 141f40b7be Convert recoverFrom to standard coroutine 2026-04-28 13:08:36 -07:00
Trevor Clinkenbeard 3d36151201 Create ProvisionalMaster class 2026-04-28 13:08:36 -07:00
gxglass 97d634166d
Update generated docs generally, and request more details about certain aspects of storage servers (#13108)
This gets filename changes throughout, and has the results of some additional prompting on storage servers.
2026-04-28 13:07:01 -07:00
Trevor Clinkenbeard 10c495edf0
Merge pull request #13075 from tclinkenbeard-oai/dev/tclinkenbeard/grey-failure-detection
Improve header file encapsulation
2026-04-28 14:45:23 -05:00
Trevor Clinkenbeard a59503b4b9 Rename flow/bench/*.actor.cpp files 2026-04-28 19:04:21 +00:00
Trevor Clinkenbeard 68b1e01df8 Convert flow/bench actors to standard coroutines 2026-04-28 18:57:32 +00:00
Trevor Clinkenbeard 6132944a9a
Merge pull request #13104 from tclinkenbeard-oai/dev/tclinkenbeard/remove-dead-code2
Remove dead code
2026-04-28 13:54:01 -05:00
Trevor Clinkenbeard e64bfbd58a Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/remove-dead-code2 2026-04-28 10:53:31 -07:00
Trevor Clinkenbeard 398fb74cef Fix spatial recipe TODO typo 2026-04-28 10:22:19 -07:00
Trevor Clinkenbeard d010cf0a87 Remove generated Java TODO comments 2026-04-28 10:22:19 -07:00
Trevor Clinkenbeard ee42f0e631 Test version JSON serialization 2026-04-28 10:22:19 -07:00
Trevor Clinkenbeard 47d772f122 Fix gRPC TODO typo 2026-04-28 10:22:19 -07:00
Trevor Clinkenbeard f2ee29d4f6 Fix constness TODO typo 2026-04-28 10:22:19 -07:00
Trevor Clinkenbeard c710b8a40e Use erase_if for tag throttler cleanup 2026-04-28 10:22:19 -07:00
Trevor Clinkenbeard bffc2d29ba
Merge pull request #13105 from tclinkenbeard-oai/dev/tclinkenbeard/fixme-cleanup
Address various `FIXME` comments
2026-04-28 12:13:39 -05:00