natas_hw
/
grpc
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
grpc/test/cpp/end2end
History
Mark D. Roth 2395bb1b86 [xDS] fix "tls" channel cred in bootstrap to actually work (#36726) 
This fixes a fairly embarrassing bug and lack of testing from #33234.  Prior to this fix, attempting to use the "tls" creds type would always cause a crash.

@gtcooke94 @matthewstevenson88 Note that the root cause of this bug was that when I wrote this code, I assumed that `grpc_tls_credentials_options` had a reasonable default for the cert verifier.  But it turns out that it doesn't do that directly; instead, we are only imposing that default in [`CredentialOptionSanityCheck()`](621aa4e5ce/src/core/lib/security/credentials/tls/tls_credentials.cc (L85)), which is called only when we call [`grpc_tls_credentials_create()`](621aa4e5ce/src/core/lib/security/credentials/tls/tls_credentials.cc (L160)), not when we directly instantiate `TlsCredentials` as my code was doing.  As part of the TlsCreds API cleanup you're working on, we should fix this so that callers get the right behavior even if they are internal callers that instantiate the TlsCreds object directly rather than calling the C-core API.

Closes #36726

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36726 from markdroth:xds_bootstrap_mtls_creds_fix dac2789e10
PiperOrigin-RevId: 637993734
 		2024-05-28 13:00:28 -07:00
..
xds [xDS] fix "tls" channel cred in bootstrap to actually work (#36726) 2024-05-28 13:00:28 -07:00
BUILD Revert "[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - BUILD (#36607)" (#36625) 2024-05-15 10:18:57 -07:00
admin_services_end2end_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
async_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
cfstream_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
channelz_service_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
client_callback_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
client_crash_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
client_crash_test_server.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
client_fork_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
client_interceptors_end2end_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
client_lb_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36548) 2024-05-08 21:21:04 -07:00
connection_attempt_injector.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
connection_attempt_injector.h EventEngine::RunAfter migration ConnectionAttemptInjector (#31865) 2022-12-13 11:14:40 -08:00
context_allocator_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
counted_service.h Revert "Revert "start splitting up xds_end2end_test (#27702)" (#27725)" (#27726) 2021-10-14 11:41:45 -07:00
crl_provider_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
delegating_channel_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
exception_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
flaky_network_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
generic_end2end_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
grpc_authz_end2end_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
grpclb_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36548) 2024-05-08 21:21:04 -07:00
health_service_end2end_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
hybrid_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
interceptors_util.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
interceptors_util.h [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASERT (#36224) 2024-04-10 01:18:20 -07:00
message_allocator_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
mock_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
nonblocking_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
orca_service_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
port_sharing_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
proto_server_reflection_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
raw_end2end_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
resource_quota_end2end_stress_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
rls_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
rls_server.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
rls_server.h Fix include guards for src/ and test/ directories (#32167) 2023-01-20 16:27:27 -08:00
server_builder_plugin_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
server_crash_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
server_crash_test_client.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
server_early_return_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
server_interceptors_end2end_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
server_load_reporting_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
service_config_end2end_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
shutdown_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
ssl_credentials_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
streaming_throughput_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
test_health_check_service_impl.cc Convert c-style comments to C++-style comments (#31923) 2022-12-22 23:01:53 -08:00
test_health_check_service_impl.h Convert c-style comments to C++-style comments (#31923) 2022-12-22 23:01:53 -08:00
test_service_impl.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
test_service_impl.h [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36677) 2024-05-21 08:03:45 -07:00
thread_stress_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
time_change_test.cc [reorg] move test/core/util -> test/core/test_util (#36446) 2024-04-29 17:06:40 -07:00
tls_credentials_test.cc [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678) 2024-05-22 21:59:06 -07:00
tls_key_export_test.cc [reorg] move src/core/lib/gpr -> src/core/util (#36543) 2024-05-15 16:32:20 -07:00