Mark D. Roth 2395bb1b86 [xDS] fix "tls" channel cred in bootstrap to actually work (#36726) ... This fixes a fairly embarrassing bug and lack of testing from #33234. Prior to this fix, attempting to use the "tls" creds type would always cause a crash. @gtcooke94 @matthewstevenson88 Note that the root cause of this bug was that when I wrote this code, I assumed that `grpc_tls_credentials_options` had a reasonable default for the cert verifier. But it turns out that it doesn't do that directly; instead, we are only imposing that default in [`CredentialOptionSanityCheck()`](621aa4e5ce/src/core/lib/security/credentials/tls/tls_credentials.cc (L85)), which is called only when we call [`grpc_tls_credentials_create()`](621aa4e5ce/src/core/lib/security/credentials/tls/tls_credentials.cc (L160)), not when we directly instantiate `TlsCredentials` as my code was doing. As part of the TlsCreds API cleanup you're working on, we should fix this so that callers get the right behavior even if they are internal callers that instantiate the TlsCreds object directly rather than calling the C-core API. Closes #36726 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36726 from markdroth:xds_bootstrap_mtls_creds_fix dac2789e10 PiperOrigin-RevId: 637993734		2024-05-28 13:00:28 -07:00
..
boringssl_spm_build	[ObjC] add boringssl swift package (#36062)	2024-03-08 17:30:11 -08:00
build	Remove epollex poller (#29160)	2022-03-21 10:27:52 -07:00
build_test	Make Buildifier Sanity Test Strict (#27807)	2021-11-03 14:57:04 -07:00
core	[Sanity] Fix sanity (#36727)	2024-05-24 17:28:17 -07:00
cpp	[xDS] fix "tls" channel cred in bootstrap to actually work (#36726)	2024-05-28 13:00:28 -07:00
csharp/codegen	[csharp codegen] Handle empty base_namespace option value to fix #34113 (#34137)	2023-08-29 14:24:52 +00:00
distrib	[OTel] Generate pkg-config file for grpcpp_otel_plugin (#36686)	2024-05-24 10:41:11 -07:00
http2_test	[Python] Migrate from yapf to black (#33138)	2023-06-09 15:08:55 -07:00
spm_build	Remove `g_glip` and `class GrpcLibraryInterface` (#30414)	2022-11-14 15:30:09 -05:00
.clang-tidy	Fix all instances of bugprone-undefined-memory-manipulation	2018-08-29 14:24:02 -07:00