Commit Graph

39665 Commits

Author SHA1 Message Date
Jan Tattermusch d56e4eb0fd
Merge pull request #19648 from jtattermusch/csharp_managed_callcreds_interop
Add per-rpc interop tests for managed grpc-dotnet client
2019-07-16 14:45:49 +02:00
Juanli Shen 34f247e497
Merge pull request #19639 from AspirinSJL/fix_pf_segv
Fix segv in pick_first
2019-07-15 19:15:09 -07:00
Arjun Roy f75400dc73
Merge pull request #19453 from arjunroy/hptbl_init
Faster hpack table creation
2019-07-15 18:14:01 -07:00
Arjun Roy fd2d2ee18e
Merge pull request #19552 from arjunroy/ch2_md_lookup_cache
Cached metadata lookup for hpack_parser.
2019-07-15 18:13:43 -07:00
Richard Belleville 7f54da6bff
Merge pull request #19556 from gnossen/subprocess_gevent
Fix segfault when forking while using gevent
2019-07-15 16:33:32 -07:00
Arjun Roy 666d73e39c Cached metadata lookup for hpack_parser. 2019-07-15 15:51:07 -07:00
Arjun Roy b1d73a01f1 Removed duplicate static table from hpack table. Removed an or instruction for
every usage of static grpc metadata. Inlined hpack table lookups for static
metadata.

This leads to faster hpack parser creation:
BM_HpackParserInitDestroy 5.32µs ± 1% 0.06µs ± 1%  -98.91% (p=0.000 n=18+19)

And slightly faster parsing:
BM_HpackParserParseHeader<RepresentativeClientInitialMetadata, OnInitialHeader>
456ns ± 1%              435ns ± 1%   -4.74%        (p=0.000 n=18+19)
BM_HpackParserParseHeader<MoreRepresentativeClientInitialMetadata,
OnInitialHeader>
1.06µs ± 2%             1.04µs ± 2%   -1.82%        (p=0.000 n=19+20)

It also yields a slight (0.5 - 1.0 microsecond) reduction in CPU time for
fullstack unary pingpong:
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/0/512
[polls/iter:3.0001                         ]            23.9µs ± 2%
23.0µs ± 1%  -3.63%          (p=0.002 n=6+6)
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/0/32768
[polls/iter:3.00015                        ]            35.1µs ± 1%
34.2µs ± 1%  -2.57%          (p=0.036 n=5+3)
BM_UnaryPingPong<MinTCP, NoOpMutator, NoOpMutator>/8/0
[polls/iter:3.00011                        ]            21.7µs ± 3%
21.2µs ± 2%  -2.44%          (p=0.017 n=6+5)
2019-07-15 15:39:31 -07:00
hcaseyal 592b840e10
Merge pull request #19624 from hcaseyal/channelz_sockets
Track channelz server sockets in the server node
2019-07-15 15:39:17 -07:00
Hope Casey-Allen 225a878e9f Track channelz server sockets in the server node 2019-07-15 13:45:20 -07:00
Richard Belleville ae825f7dae
Merge pull request #19635 from gnossen/python_release_sanity_check
Add a sanity check for the Python release process.
2019-07-15 13:05:44 -07:00
Mark D. Roth c007642f10
Merge pull request #19631 from markdroth/refcount_trace_fix
Log refcount traces if tracer enabled, even if DEBUG_LOCATION is not used.
2019-07-15 09:47:34 -07:00
Jan Tattermusch c556a02024 add per-rpc interop tests to managed grpc-dotnet client 2019-07-15 11:22:02 -04:00
apolcyn 8cd016f597
Merge pull request #18913 from sat0yu/sat0yu/fix-typo
Fix a typo in the GRPC::RpcServer constructor description
2019-07-15 00:15:43 -07:00
Juanli Shen fa4e0f040f Fix segv in pick_first 2019-07-12 17:45:04 -07:00
Richard Belleville ba761f77c5 Yapf. Pylint. Long-form birth certificate. 2019-07-12 15:21:11 -07:00
Mark D. Roth 994985be97 Log refcount traces if tracer enabled, even if DEBUG_LOCATION is not used. 2019-07-12 14:32:20 -07:00
Richard Belleville a0d9ec81a5 Add a sanity check for the Python release process.
This fixes https://github.com/grpc/grpc/issues/19632.
2019-07-12 14:11:26 -07:00
Arjun Roy 0e7188ccbb
Merge pull request #19606 from arjunroy/sb_consume
Pull() eats slice from sbuf wrapped byte buffer.
2019-07-12 10:40:15 -07:00
Muxi Yan a41cbab9ef
Merge pull request #19620 from Tony1023/cocoapods-build
Reworked cocoapods installation
2019-07-12 09:51:28 -07:00
Jan Tattermusch 36f7b1feb6
Merge pull request #19610 from mgravell/mgravell/petty-allocs
C# - remove delegate allocation and boxing from cancellation registrations
2019-07-12 14:55:36 +02:00
apolcyn 78565bf5bf
Merge pull request #19623 from apolcyn/grpclb_fallback_test
Add a test client for certain grpclb fallback scenarios
2019-07-12 00:54:55 -07:00
Alexander Polcyn 3958a53bf7 Address review comments; fix sanity 2019-07-11 19:08:27 -07:00
Tony Lu 34a6880508 Fixing formatting issues 2019-07-11 18:31:51 -07:00
Alexander Polcyn 4999420c7d Add a test client for certain grpclb fallback scenarios 2019-07-11 18:31:21 -07:00
Tony Lu aa3c2a903d Reworked hack 2019-07-11 16:04:44 -07:00
hcaseyal 79f2ad8353
Merge pull request #19611 from hcaseyal/channelz_bug
Channelz: use RefCountedPtr instead of raw pointer for ChildSocketsList
2019-07-11 15:59:42 -07:00
Yash Tibrewal 825e3dc809
Merge pull request #19531 from yashykt/nullthensched
Sched combiner closures instead of running to avoid data races
2019-07-11 14:49:32 -07:00
nanahpang 61126644e7
Merge pull request #19574 from legendtang/insufficientassert
Fix the assertion of grpc_udp_server_add_port()
2019-07-11 14:45:08 -07:00
Yang Gao 2e83ef0da0
Merge pull request #19613 from yang-g/goaway_why_not
Log transport pointer and goaway last stream id when chttp2 tracing is…
2019-07-11 14:27:00 -07:00
yang-g c7793dddde Log transport pointer and goaway last stream id when chttp tracing is enabled 2019-07-11 10:22:43 -07:00
Arjun Roy 54a3b64246 Pull() eats slice from sbuf wrapped byte buffer.
At present, a commonly used byte buffer wraps an underlying slice
buffer. This is used by grpc_call; it passes a byte buffer for send
stream ops through the filter stack and down to the transport.

Pull() is a one-way operation; given a slice-buffer backed
byte-buffer, it starts with a cursor at index=0 and increments it per
pull. There is no way for a cursor to be rewinded.

Originally Pull() would ref the slice and return a copy; the
slice remains in the underlying buffer and is eventually cleaned up
(unref'd). Thus, assuming a slice buffer of size N and assuming we
pulled all N slices then we have a total of 2N ref/unref pairs.

Since Pull() is essentially acting as a consume operation here, and
since it is a one-way operation, we simply transfer the ref rather
than create a new ref. This cuts down atomic ops. from 2N to N.

This reduces streaming latency slightly for streaming fullstack
microbenchmarks:

BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/0/1
[polls/iter:0                              ]            8.87µs ± 1%
8.91µs ± 1%  +0.45%        (p=0.002 n=20+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/0/2
[polls/iter:0                              ]            11.7µs ± 1%
11.7µs ± 1%  +0.34%        (p=0.002 n=19+19)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/8/1
[polls/iter:0                              ]            9.11µs ± 1%
9.14µs ± 1%  +0.29%        (p=0.016 n=19+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/64/1
[polls/iter:0                              ]            9.29µs ± 1%
9.27µs ± 1%  -0.23%        (p=0.029 n=18+19)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/512/2
[polls/iter:0                              ]            13.0µs ± 1%
12.9µs ± 1%  -0.52%        (p=0.000 n=20+19)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/4096/1
[polls/iter:0                              ]            11.8µs ± 1%
11.8µs ± 1%  -0.41%        (p=0.007 n=20+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/4096/2
[polls/iter:0                              ]            17.4µs ± 1%
17.2µs ± 1%  -0.73%        (p=0.000 n=19+19)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/1
[polls/iter:0                              ]            2.87µs ± 1%
2.84µs ± 1%  -1.18%        (p=0.000 n=19+18)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/8
[polls/iter:0                              ]            2.85µs ± 1%
2.84µs ± 0%  -0.38%        (p=0.022 n=20+17)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/64
[polls/iter:0                              ]            3.00µs ± 1%
2.95µs ± 1%  -1.64%        (p=0.000 n=19+19)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/512
[polls/iter:0                              ]            3.32µs ± 1%
3.23µs ± 1%  -2.62%        (p=0.000 n=20+20)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/4096
[polls/iter:0                              ]            5.38µs ± 2%
5.30µs ± 1%  -1.42%        (p=0.000 n=19+20)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/32768
[polls/iter:0                              ]            24.1µs ± 1%
24.0µs ± 0%  -0.47%        (p=0.000 n=19+18)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/0
[polls/iter:0                              ]            5.71µs ± 1%
5.69µs ± 1%  -0.36%        (p=0.010 n=19+19)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/1
[polls/iter:0                              ]            8.64µs ± 1%
8.68µs ± 1%  +0.38%        (p=0.004 n=20+18)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/1/2
[polls/iter:0                              ]            11.9µs ± 1%
11.8µs ± 1%  -0.36%        (p=0.003 n=20+18)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/64/1
[polls/iter:0                              ]            9.09µs ± 1%
9.06µs ± 1%  -0.32%        (p=0.046 n=20+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/64/2
[polls/iter:0                              ]            12.2µs ± 0%
12.1µs ± 1%  -0.35%        (p=0.001 n=19+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/512/2
[polls/iter:0                              ]            12.8µs ± 1%
12.7µs ± 1%  -0.46%        (p=0.000 n=19+19)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/4096/1
[polls/iter:0                              ]            11.7µs ± 2%
11.6µs ± 1%  -0.58%        (p=0.004 n=20+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/4096/2
[polls/iter:0                              ]            17.1µs ± 1%
17.0µs ± 1%  -0.55%        (p=0.010 n=20+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32768/1
[polls/iter:0                              ]            30.5µs ± 1%
30.6µs ± 0%  +0.27%        (p=0.003 n=20+19)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/2
[polls/iter:0                              ]             363µs ± 1%
362µs ± 1%  -0.22%        (p=0.049 n=20+20)
BM_StreamingPingPongMsgs<MinInProcessCHTTP2, NoOpMutator,
NoOpMutator>/134217728                  [polls/iter:4 writes/iter:8.5
]              266ms ± 0%              263ms ± 1%  -1.23%
(p=0.029 n=4+4)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/64
[polls/iter:0                              ]            2.95µs ± 1%
2.93µs ± 1%  -0.97%        (p=0.000 n=19+20)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/512
[polls/iter:0                              ]            3.27µs ± 1%
3.19µs ± 1%  -2.32%        (p=0.000 n=20+20)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/4096
[polls/iter:0                              ]            5.33µs ± 2%
5.26µs ± 1%  -1.30%        (p=0.000 n=20+20)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768
[polls/iter:0                              ]            24.1µs ± 1%
24.0µs ± 0%  -0.35%        (p=0.001 n=19+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/0/2/1                  [polls/iter:0
]            10.6µs ± 1%             10.6µs ± 1%  +0.45%
(p=0.014 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/1/2/0                  [polls/iter:0
]            11.3µs ± 1%             11.3µs ± 1%  -0.39%
(p=0.046 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/1/1/1                  [polls/iter:0
]            7.92µs ± 1%             7.88µs ± 1%  -0.46%
(p=0.012 n=19+18)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/1/2/1                  [polls/iter:0
]            11.0µs ± 1%             10.9µs ± 1%  -0.48%
(p=0.001 n=18+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/8/1/0                  [polls/iter:0
]            8.33µs ± 1%             8.30µs ± 1%  -0.29%
(p=0.025 n=19+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/8/2/0                  [polls/iter:0
]            11.3µs ± 1%             11.3µs ± 1%  -0.34%
(p=0.011 n=19+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/64/1/0                 [polls/iter:0
]            8.49µs ± 1%             8.41µs ± 1%  -1.01%
(p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/64/2/0                 [polls/iter:0
]            11.6µs ± 1%             11.5µs ± 1%  -0.80%
(p=0.000 n=19+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/64/1/1                 [polls/iter:0
]            8.06µs ± 1%             8.02µs ± 1%  -0.51%
(p=0.016 n=20+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/64/2/1                 [polls/iter:0
]            11.2µs ± 1%             11.1µs ± 1%  -0.69%
(p=0.000 n=19+18)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/512/1/0                [polls/iter:0
]            8.83µs ± 1%             8.71µs ± 1%  -1.34%
(p=0.000 n=20+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/512/2/0                [polls/iter:0
]            12.2µs ± 1%             12.1µs ± 1%  -1.35%
(p=0.000 n=19+17)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/512/1/1                [polls/iter:0
]            8.40µs ± 1%             8.32µs ± 1%  -0.92%
(p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/512/2/1                [polls/iter:0
]            11.9µs ± 1%             11.7µs ± 1%  -1.04%
(p=0.000 n=19+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/4096/1/0               [polls/iter:0
]            11.1µs ± 1%             11.0µs ± 1%  -0.53%
(p=0.002 n=20+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/4096/2/0               [polls/iter:0
]            16.6µs ± 1%             16.5µs ± 2%  -0.47%
(p=0.023 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/32768/1/1              [polls/iter:0
]            29.6µs ± 1%             29.7µs ± 1%  +0.36%
(p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/2097152/1/0            [polls/iter:0
]             1.59ms ± 9%             1.48ms ± 1%  -7.02%
(p=0.001 n=20+16)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/2097152/2/0            [polls/iter:0
]             3.17ms ± 9%             2.95ms ± 0%  -6.86%
(p=0.015 n=20+16)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/2097152/1/1            [polls/iter:0
]             1.59ms ± 9%             1.48ms ± 0%  -7.01%
(p=0.000 n=20+16)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/2097152/2/1            [polls/iter:0
]             3.17ms ± 9%             2.95ms ± 0%  -6.91%
(p=0.004 n=20+16)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator,
NoOpMutator>/134217728/2/1          [polls/iter:0
]              512ms ± 2%              509ms ± 2%  -0.74%
(p=0.040 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/0/1/0               [polls/iter:0
]            8.07µs ± 1%             8.02µs ± 1%  -0.62%
(p=0.001 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/0/2/0               [polls/iter:0
]            10.9µs ± 1%             10.9µs ± 1%  +0.30%
(p=0.014 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/1/1/0               [polls/iter:0
]            8.27µs ± 1%             8.24µs ± 1%  -0.40%
(p=0.040 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/1/1/1               [polls/iter:0
]            7.86µs ± 1%             7.83µs ± 1%  -0.36%
(p=0.041 n=20+19)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/1/2/1               [polls/iter:0
]            11.0µs ± 1%             10.9µs ± 1%  -0.50%
(p=0.000 n=18+19)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/8/2/1               [polls/iter:0
]            10.9µs ± 1%             10.9µs ± 1%  +0.28%
(p=0.005 n=17+19)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/64/1/0              [polls/iter:0
]            8.43µs ± 1%             8.40µs ± 1%  -0.40%
(p=0.012 n=20+18)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/64/2/1              [polls/iter:0
]            11.2µs ± 1%             11.1µs ± 1%  -0.42%
(p=0.019 n=20+18)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/512/1/0             [polls/iter:0
]            8.77µs ± 1%             8.70µs ± 1%  -0.91%
(p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/512/2/0             [polls/iter:0
]            12.2µs ± 1%             12.1µs ± 1%  -0.71%
(p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/512/2/1             [polls/iter:0
]            11.8µs ± 1%             11.7µs ± 1%  -0.78%
(p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/4096/1/0            [polls/iter:0
]            11.0µs ± 1%             11.0µs ± 1%  -0.42%
(p=0.030 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/32768/1/1           [polls/iter:0
]            29.4µs ± 1%             29.5µs ± 1%  +0.35%
(p=0.003 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/2097152/1/0         [polls/iter:0
]             1.60ms ± 8%             1.48ms ± 1%  -7.63%
(p=0.002 n=20+16)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/2097152/2/0         [polls/iter:0
]             3.20ms ± 8%             2.96ms ± 1%  -7.49%
(p=0.020 n=20+16)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/2097152/1/1         [polls/iter:0
]             1.60ms ± 8%             1.48ms ± 1%  -7.68%
(p=0.000 n=20+16)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator,
NoOpMutator>/2097152/2/1         [polls/iter:0
]             3.20ms ± 9%             2.95ms ± 1%  -7.76%
(p=0.001 n=20+16)
BM_StreamingPingPongWithCoalescingApi<MinInProcessCHTTP2, NoOpMutator,
NoOpMutator>/134217728/1/0 [polls/iter:5.8 writes/iter:9.8
]              255ms ± 2%              248ms ± 1%  -2.59%
(p=0.017 n=3+7)
BM_StreamingPingPongWithCoalescingApi<MinInProcessCHTTP2, NoOpMutator,
NoOpMutator>/134217728/2/1 [polls/iter:9.5 writes/iter:18.5
]              523ms ± 1%              512ms ± 2%  -2.09%
(p=0.016 n=5+5)
2019-07-11 10:15:20 -07:00
nanahpang 7044945ce7
Merge pull request #19572 from legendtang/errfix
Use grpc_error defs instead of NULL
2019-07-11 10:05:46 -07:00
Hope Casey-Allen e8b9e95fa2 Use RefCountedPtr instead of raw pointer 2019-07-11 09:53:13 -07:00
Wensheng Tang 8e4d14fe91
Fix the assertion of grpc_udp_server_add_port
grpc_udp_server_add_port() can return port = -1 when going fail.
@nanahpang also recommands discarding port = 0
2019-07-11 22:19:22 +08:00
mgravell 39775cf30f remove delegate allocation and boxing from cancellation registrations 2019-07-11 13:07:50 +01:00
Muxi Yan 59011087b0
Merge pull request #19541 from muxi/remove-debug
Remove debug code
2019-07-10 18:13:36 -07:00
Qiancheng Zhao b2e87698e7
Merge pull request #19588 from bigfacebear/lazy_resolving_lb_policy_creation
Lazy resolving lb policy creation
2019-07-10 16:48:43 -07:00
Qiancheng Zhao 444806583d lazy resolving lb policy creation 2019-07-10 15:26:53 -07:00
Juanli Shen 030c399a05
Merge pull request #19604 from AspirinSJL/allow_c++
Clarify std:: usage
2019-07-10 15:17:38 -07:00
Yang Gao 9536b2c9b0
Merge pull request #19603 from yang-g/status_code
Qualify the error code with StatusCode::
2019-07-10 15:06:33 -07:00
Yash Tibrewal 7e3a9b6b23 Remove error arg - reviewer comment 2019-07-10 14:54:44 -07:00
Juanli Shen a2eb267ccb Clarify std:: usage 2019-07-10 14:29:55 -07:00
yang-g 5779dd935a Qualify the error code with StatusCode:: 2019-07-10 13:52:31 -07:00
Esun Kim 0eb846f67a
Merge pull request #19555 from veblush/interop
Add v1.22.0 to interop_matrix
2019-07-10 12:29:00 -07:00
Esun Kim a60e388c5d
Merge pull request #19455 from veblush/move-out-compiler
Move compiler targets from /BUILD to /src/compiler/BUILD
2019-07-10 12:27:37 -07:00
Muxi Yan 7f5bc46f3a
Merge pull request #19322 from muxi/global-interceptor
Implement global interceptor
2019-07-10 12:23:40 -07:00
Arjun Roy ded3081176
Merge pull request #19343 from arjunroy/sbuf_tiny_add_coalesce
Coalesced some grpc_slice_buffer_tiny_add calls in hpack_enc.
2019-07-10 10:54:26 -07:00
Esun Kim bd5ed4fddd Move compiler targets from /BUILD to /src/compiler/BUILD 2019-07-10 10:53:07 -07:00
Esun Kim c01477360f Add v1.22.0 to interop_matrix 2019-07-10 10:51:41 -07:00
Lidi Zheng 6114760312
Merge pull request #19596 from lidizheng/compression-doc
Add documentation for compression enums
2019-07-10 10:38:44 -07:00