Commit Graph

54605 Commits

Author SHA1 Message Date
Yash Tibrewal 4ce4f4ea3a [OTel] Add OTel C++ as a submodule (#36032)
Closes #36032

PiperOrigin-RevId: 611657802
2024-02-29 18:06:02 -08:00
tony 5043eb4d65 [csharp] Fix csharp_ubuntu2204_x64 docker image (#36019)
Fix the docker image for C# distribution tests - csharp_ubuntu2204_x64

The package that installed the .NET 7.0 SDK is missing setting up links and thus the `dotnet` command cannot find the SDK. Setting this links has been added to the dockerfile.

**NOTE**: I'm unable to update `tools/dockerfile/distribtest/csharp_ubuntu2204_x64.current_version` as I don't have access to the artifact registry.

Closes #36019

PiperOrigin-RevId: 611590679
2024-02-29 14:10:36 -08:00
AJ Heller 73c141cb57 Add `byte_buffer` dependency back to gRPC iomgr target.
PiperOrigin-RevId: 611518672
2024-02-29 10:33:42 -08:00
Mark D. Roth de3e6f8234 [pick_first] implement non-per-call metrics (#35984)
As per gRFC A78 (https://github.com/grpc/proposal/pull/419).

Closes #35984

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35984 from markdroth:non_per_call_metrics_pf 02db004d5a
PiperOrigin-RevId: 611475162
2024-02-29 08:12:55 -08:00
Tanvi Jagtap e39bd50716 [grpc] Redacting unknown metadata types in debug logs. (#36006)
Redacting unknown metadata types in debug logs.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #36006

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36006 from tanvi-jagtap:tjagtap_redact_01 94c5738bfe
PiperOrigin-RevId: 611334483
2024-02-28 21:18:41 -08:00
Bernhard M. Wiedemann d379dc24c5
[Build Reproducibility] Sort input file list (#35687)
Sort input file list
so that the `.so` file builds in a reproducible way
in spite of non-deterministic filesystem readdir order and
http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

This patch was done while working on reproducible builds for openSUSE.




<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->

---------

Co-authored-by: Richard Belleville <rbellevi@google.com>
2024-02-28 17:05:07 -08:00
Xuan Wang 9b424b5dd4 [Python o11y] Fix Python O11Y artifacts name (#35965)
Update observability to PYPI failed because the artifact name is not correct.

This PR:
* Fix the artifacts name.
* Add step to test observability artifacts in `test_packages.sh`.
* Added `-fno-ipa-cp` compile flag.
  * We're seeing `inlining failed in call to always_inline 'vsnprintf': function body can be overwritten at link time` errors when building from source using musl libc.
  * Based on [investigation](https://gitlab.alpinelinux.org/alpine/aports/-/issues/8626), it's because we're using `-flto` flag.
  * One solution is to [disable fortify by adding this flag](https://gitlab.alpinelinux.org/alpine/aports/-/issues/8626).

After this PR, the observability artifacts have the correct name:
* [Distribution Tests Python Linux](https://pantheon.corp.google.com/storage/browser/grpc-testing-kokoro-prod/test_result_public/prod/grpc/core/pull_request/linux/grpc_distribtests_python/28687/20240223-105306/github/grpc/artifacts;tab=objects?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&e=13802955&mods=-logs_tg_prod&prefix=&forceOnObjectsSortingFiltering=false)

Also tested that the artifacts build in this PR can be successfully uploaded to testpypi:
* https://test.pypi.org/project/grpcio-observability/1.63.0.dev0

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35965

PiperOrigin-RevId: 611268154
2024-02-28 16:33:28 -08:00
Craig Tiller 493cad8ef2 [call-v3] Grab payload handling from registered method (#36017)
We were skipping reading a request payload, which led to a serialization failure, which led to UNIMPLEMENTED errors.

Closes #36017

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36017 from ctiller:goodness 606545295f
PiperOrigin-RevId: 611254339
2024-02-28 15:47:54 -08:00
AJ Heller 00c01f395c [EventEngine] Do not accept connections if the listener is shut down (#35990)
There's a race with the iomgr/EventEngine shims on listener shutdown, specifically for the PosixEventEngine implementation. This showed up as TSAN failures, such as in https://source.cloud.google.com/results/invocations/539def09-0647-4508-960a-f22b76e76dae/targets/%2F%2Ftest%2Fcore%2Fend2end:retry_cancel_after_first_attempt_starts_test@poller%3Depoll1/log. This PR alters the lifetime of the grpc_tcp_server object and its constituent members, letting the EventEngine listener manage it when EE listeners are enabled. Previously, some member objects were destroyed before the tcp server itself was destroyed.

Notes:
 * This is best reviewed once with whitespace diff turned off. Blocks was added to manage mutex lifetimes.
 * BUILD file changes are result of `fix_build_deps.py :iomgr`

Closes #35990

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35990 from drfloob:fix/proxy-listener-accept d35eed5d16
PiperOrigin-RevId: 611149345
2024-02-28 10:35:37 -08:00
Gregory Cooke d6089c336c [Security - CrlProvider] Add AKID to CertificateInfo (#35931)
This PR adds the Authority Key Identifier to CertificateInfo. This value _can be_ important in finding the right CRLs to use if there are Issuer name overlaps or a more complicated CA setup with multiple signing keys.

We should observe no behavior change in our `CrlProvider` implementations, this is just adding an important field for users who implement it themselves.

Closes #35931

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35931 from gtcooke94:AkidCheck dd048a53b6
PiperOrigin-RevId: 611143198
2024-02-28 10:19:05 -08:00
Yousuk Seung d4b5e8d11d Move work_serializer_dispatch dependency to rollouts (#36013)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #36013

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36013 from yousukseung:work-serializer 8fdf679309
PiperOrigin-RevId: 610938472
2024-02-27 18:25:19 -08:00
Zach Reyes 0d69f8dc74 Add gRPC-Go version 1.62.0 to interop matrix (#35966)
Interop run: https://fusion2.corp.google.com/ci/kokoro/prod:grpc%2Fcore%2Fexperimental%2Flinux%2Fgrpc_interop_matrix_adhoc/activity/99858b52-009a-404b-a9a7-1546e239d5d9/summary
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35966

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35966 from zasweq:go-release-interop 3fa9483786
PiperOrigin-RevId: 610848138
2024-02-27 13:08:12 -08:00
Alisha Nanda fa2bae473a [metadata] Expose metadata limits and annotation info to filter stack (#35970)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35970

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35970 from ananda1066:client_metadata b62a9ae146
PiperOrigin-RevId: 610830228
2024-02-27 12:07:35 -08:00
Vignesh Babu 338fc05c21 Add stats to tcp_posix.cc to log commonly seen I/O errnos.
PiperOrigin-RevId: 610799993
2024-02-27 10:43:44 -08:00
apolcyn 9054988785 [csharp] Use a stable/supported C# runtime in ubuntu 22.04 distribtest docker images (#35955)
The current .NET SDK in these tests is EOL, and we've been seeing strange SSL errors transiently.

Update to a supported version and remove cruft in the docker image that was there to install the older version.

TODO: submitting first with the ubuntu 22.04 image test skipped, need to follow-up with a fix and unskip the test

Closes #35955

PiperOrigin-RevId: 610798209
2024-02-27 10:34:33 -08:00
Richard Belleville 12897ab0fb [Interop] Make C++ xDS Interop Client and Server Responsive to SIGTERM (#34518)
This PR adds `tini` to the C++ interop client and server to make them responsive to SIGTERM.

Closes #34518

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/34518 from gnossen:ssa_interop_server a762b27178
PiperOrigin-RevId: 610766377
2024-02-27 08:52:21 -08:00
Mark D. Roth 40577dd585 [WRR] implement non-per-call metrics (#35977)
As per gRFC A78 (https://github.com/grpc/proposal/pull/419).

Note that these new metrics are populated only if the `wrr_delegate_to_pick_first` experiment is enabled, which is the case by default.

Closes #35977

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35977 from markdroth:non_per_call_metrics_wrr 7acea32fc4
PiperOrigin-RevId: 610760874
2024-02-27 08:32:09 -08:00
Craig Tiller 571da7be78 Make channel idle filter more aggressive in cleaning up calls
If call objects leak we never declare a channel idle, which can lead to fd leaks in other processes.

PiperOrigin-RevId: 610613450
2024-02-26 20:33:43 -08:00
Yash Tibrewal 8b4079f4dd [shutdown] Add logs when shutdown is done (#36002)
Needed for some shutdown debugging. I was thinking whether to use `fprintf` to stderr directly instead of using `gpr_log`, the reason being that grpc has shutdown and it may be bad to use `gpr_log` after shutdown. Currently atleast, we do not modify the `gpr_log` function on `init`/`shutdown` so it seems fine to continue using it. Additionally, given that this is just for own internal debugging purposes, I don't want to sprinkle `fprintf` around if it's not necessary.

Closes #36002

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36002 from yashykt:LogOnGrpcShutdown 61b9ad573a
PiperOrigin-RevId: 610515417
2024-02-26 13:51:25 -08:00
Eugene Ostroukhov 70af2c2fda [xds] xDS client per data plane target (#35730)
Closes #35730

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35730 from eugeneo:tasks/multiple-xds-clients 30b459658e
PiperOrigin-RevId: 610511488
2024-02-26 13:38:21 -08:00
Gregory Cooke a1b7e1e523 [Security] Crl helpers (#35963)
Re-applies after the revert
Fixes the Openssl 1.0.2 portability errors

Closes #35963

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35963 from gtcooke94:CrlHelpers 9cfb401a47
PiperOrigin-RevId: 610503595
2024-02-26 13:12:36 -08:00
Yousuk Seung 641213ee58 [tracing] Remove debugging annotations
PiperOrigin-RevId: 610469149
2024-02-26 11:22:52 -08:00
Jan Katins d4afc993ed
[python] Fix typo in code comment (#35981)
Found this while reading the code.
2024-02-26 09:22:44 -08:00
Craig Tiller d2efbfe449 Log gRPC experiments at INFO
Often we need to debug something after a crash and this set of breadcrumbs would be hugely beneficial.

PiperOrigin-RevId: 610285566
2024-02-25 21:37:06 -08:00
Craig Tiller 4ac804bec9 [call-v3] Correctly detect v3 filters even if the immediate base class is not ImplementCallFilter<> (#35997)
Fixes max_age filter not getting a v3 init_call implementation

Closes #35997

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35997 from ctiller:naughty df17e57e91
PiperOrigin-RevId: 610194630
2024-02-25 10:12:07 -08:00
Yousuk Seung ed065878e0 [experiments] enable work_serializer_dispatch (posix) (#35992)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35992

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35992 from yousukseung:work-serializer-windows 7b21f46dde
PiperOrigin-RevId: 610042481
2024-02-24 13:22:54 -08:00
Yousuk Seung 77879c4be7 Clarify caller should call dtor with New()
PiperOrigin-RevId: 609863609
2024-02-23 16:12:55 -08:00
Yousuk Seung ad06808bf6 [tracing] Pass index in stream for traced byte ranges
PiperOrigin-RevId: 609821314
2024-02-23 13:35:33 -08:00
Xuan Wang ca36ff84ba [Python o11y] Fix readme (#35988)
Fix `readme.rst`.

Tested locally by running `python setup.py doc`, no more errors from observability.

Only error is related to grpc_status:
```
WARNING: autodoc: failed to import module 'rpc_status' from module 'grpc_status'; the following exception was raised:
cannot import name 'status_pb2' from 'google.rpc' (unknown location)
```

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35988

PiperOrigin-RevId: 609820414
2024-02-23 13:26:20 -08:00
AJ Heller 6c29a8720e [test] Remove passthru_endpiont and its microbenchmarks (#35986)
Closes #35986

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35986 from drfloob:rm-passthru-endpoint 12c491f7f6
PiperOrigin-RevId: 609800868
2024-02-23 12:13:24 -08:00
Björn Svensson 1ad14040ef [EventEngine] Set DSCP on listener socket (#35983)
Prepare the listener socket with the configured DSCP value to mark outgoing packets correctly.
This is already done correctly for clients.

During implementation and delivery of the DSCP feature both experiments `event_engine_listener` and `event_engine_client` were default `OFF`. Unfortunately the `event_engine_listener` experiment was not enabled correctly during verification, which resulted in that the working `iomgr` codepath was used instead.
This PR adds the missing action which I now have verified correctly.

Fixes #35954

Closes #35983

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35983 from Nordix:fix-dscp 72969db88e
PiperOrigin-RevId: 609770886
2024-02-23 10:38:30 -08:00
Craig Tiller 3d32d7a15d [chaotic-good] Extend connection timeouts (#35937)
5 seconds is really too small when we've got dozens of connections being established on a busy system. We need a deadline, but it can be significantly looser.

Closes #35937

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35937 from ctiller:timeout1 dc26a82985
PiperOrigin-RevId: 609587934
2024-02-22 20:12:09 -08:00
Richard Belleville 2ad297344d [Documentation] Make Bazel requirements installable directly via pip (#35973)
This fixes the documentation generation tooling.

Closes #35973

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35973 from gnossen:requirements_bazel_fix 1e78fab008
PiperOrigin-RevId: 609544722
2024-02-22 16:56:22 -08:00
Yijie Ma fb4c043803 [Metrics] gRPC Non-Per-Call Metrics framework implementation (#35871)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35871

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35871 from yijiem:grpc-metrics 86ebe484ae
PiperOrigin-RevId: 609533796
2024-02-22 16:17:01 -08:00
Eugene Ostroukhov 5838f6840a [release] Add 1.62 to interop matrix (#35972)
Closes #35972

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35972 from eugeneo:release1.62/interop-matrix 1bc8e0f4c7
PiperOrigin-RevId: 609514657
2024-02-22 15:15:27 -08:00
AJ Heller fc412cd390 [test] Add comment about workaround (re #35969) (#35971)
Followup from #35969

This also fixes a few scenarios we had not caught earlier.

Closes #35971

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35971 from drfloob:doc 32de2d7033
PiperOrigin-RevId: 609509072
2024-02-22 14:58:27 -08:00
Stanley Cheung 18af795edf Update min PHP testing version from PHP 7.4 to 8.1 (#35964)
- PHP 7.4 and 8.0 have been EOL https://www.php.net/supported-versions.php
- See go/drop-php-8.0 for more details

Most of the changes came from `generate_projects.sh` after updating the `tools/buildgen/plugins/expand_version.py` file. The change to `tools/internal_ci/helper_scripts/prepare_build_macos_rc` is manual.

Closes #35964

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35964 from stanley-cheung:php-update-to-8_1 0c24c4eac2
PiperOrigin-RevId: 609495798
2024-02-22 14:32:42 -08:00
AJ Heller ab8a756b1d [test] Fix use-after-free in http proxy fixture (#35968)
See MSAN failure here: https://source.cloud.google.com/results/invocations/f4240bd5-960a-4736-95ba-b9408979f8e0/targets/%2F%2Ftest%2Fcore%2Fend2end:cancel_after_invoke_test@poller%3Depoll1/log

Closes #35968

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35968 from drfloob:fix-http_fixture-proxy-unref-early 5c432aff07
PiperOrigin-RevId: 609494949
2024-02-22 14:17:11 -08:00
AJ Heller 6fb93e79c2 [test] Decrease ping timeout on CancelAfterInvoke tests (#35969)
Supersedes #35967

Closes #35969

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35969 from drfloob:land/35967 30a6947343
PiperOrigin-RevId: 609471457
2024-02-22 13:05:39 -08:00
Craig Tiller 84b0bb3d1c [call-v3] Add an opt-out for call-v3 stack instantiation (#35956)
We've got a few filters in prod that are going to be awful to convert, and are getting pulled into some unit tests in hard to disable ways -- buuut we don't need them for chaotic good in the reality in which we're deploying it -- so I want an escape hatch for the moment.

Closes #35956

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35956 from ctiller:not-now-thanks f5d331b923
PiperOrigin-RevId: 609384999
2024-02-22 08:43:08 -08:00
Yijie Ma 9db40fa845 [EventEngine] Enable the EventEngine DNS Resolver on Posix (#35573)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35573

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35573 from yijiem:enable-oss-ee-dns-posix-real 1df91d1d84
PiperOrigin-RevId: 609193851
2024-02-21 18:35:54 -08:00
Matthew Stevenson 51bccbdcf9 [ssl] Support Windows system roots. (#34874)
This PR is copied from #34276, since I did not have permissions to add commits to it. That PR has been verified to work (see the top-level description). This PR just makes the gRPC tests pass (e.g. adding includes, clang formatting).

Closes #34874

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/34874 from matthewstevenson88:pull_34276 d5fb73e5b2
PiperOrigin-RevId: 609107146
2024-02-21 13:40:46 -08:00
Mark D. Roth d54074c570 [build] move byte_buffer out of grpc_base (#35960)
Fixes some internal build breakage caused by #35846.

b/326202311

Closes #35960

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35960 from markdroth:build_fix a8d4751ebd
PiperOrigin-RevId: 609089263
2024-02-21 12:43:43 -08:00
AJ Heller a82a28cde4 Revert "[Security - CrlProvider] Use a better mechanism for Crl Looku… (#35962)
…p and add some verification helpers (#35641)"

This reverts commit 310770d61d.

It breaks all portability tests.

```
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from CrlUtils
[ RUN      ] CrlUtils.HasCrlSignBitExists
/[var/local/git/grpc/test/core/tsi/ssl_transport_security_utils_test.cc:566](https://cs.corp.google.com/piper///depot/google3/var/local/git/grpc/test/core/tsi/ssl_transport_security_utils_test.cc?l=566): Failure
Value of: HasCrlSignBit(root_ca_)
  Actual: false
Expected: true

[  FAILED  ] CrlUtils.HasCrlSignBitExists (0 ms)
[----------] 1 test from CrlUtils (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CrlUtils.HasCrlSignBitExists
```

Closes #35962

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35962 from drfloob:revert-310770d61d3b25d358d877a074bebf6ae85549d0 e6a2f03309
PiperOrigin-RevId: 609075479
2024-02-21 12:00:50 -08:00
Craig Tiller 7d023ade47 [experiments] Remove completed experiments (and extend rstpit) (#35949)
Closes #35949

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35949 from ctiller:juicy 7fb4afbd69
PiperOrigin-RevId: 609037044
2024-02-21 10:11:45 -08:00
Mark D. Roth cfcbb0a535 [build] move parts of the `grpc_client_channel` BUILD target out into their own targets (#35879)
This breaks the following pieces out of the `grpc_client_channel` BUILD target:
- backend_metric_parser
- oob_backend_metric
- child_policy_handler
- backup_poller
- service_config_channel_arg_filter
- client_channel_channelz
- client_channel_internal_header
- subchannel_connector
- subchannel_pool_interface
- config_selector
- client_channel_service_config_parser
- retry_service_config_parser
- retry_throttle

The code left in the `grpc_client_channel` target will need more work to pull apart.

Closes #35879

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35879 from markdroth:client_channel_build_split f388a37edc
PiperOrigin-RevId: 608806548
2024-02-20 18:06:37 -08:00
Fred Klassen fbbdda4e51 fix TLS key logging file entry corruption on non-Windows (#32266)
On Windows I see properly formatted key logging files that include CRLF, e.g.

    CLIENT_RANDOM 1acfa70620279d4e2b2895fc510897db6b164be7c97b5e8ee2d3180a551d52ec 4214c5de0498316cedea48c767b97dcbc3cf8121c21b1c441026297796a8b96f502d06de280442b8232221f6be1fbf3a

However, on macOS and Linux see first 10 characters missing. Also there is no CR at the end of the line, e.g.

      DOM 0d462bc4dd7884a8ef0d6f493de9a3d9622e88cd22e117f41eff6a833317cb99 aeac8859bdffc000d385b23a9dbec5a6397a7e27097399c23e838617d3a22da00bcf3722d543c93015bd117b11c8a413

This fix changes "\r\n" to "\n" which Wireshark appears to accept on both Windows and macOS.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #32266

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/32266 from appneta:fix_unix_key_logging_file_corruption f0286f4124
PiperOrigin-RevId: 608748371
2024-02-20 14:53:37 -08:00
AJ Heller 851b187d54 [EventEngine] rm invalid assert (#35953)
In the case where the timer delay is <= 0, RunAfter will return an invalid handle since the callback will not be cancellable. The asserting is invalid in this case. Based on how this handle is used, it seems there is no need for a check that the handle is set. It would only matter if `finish_bdp_ping` were called again before `next_bdp_ping_timer_expired` were called, which I don't think is possible.

Closes #35953

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35953 from drfloob:fix/35943 ff0b1db553
PiperOrigin-RevId: 608729800
2024-02-20 14:03:25 -08:00
AJ Heller b6a961fa8e [EventEngine] Refactor WritesPerRpcTest to EventEngine (#35763)
Closes #35763

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35763 from drfloob:eeify-writes-per-rpc ebb79f7dd6
PiperOrigin-RevId: 608719485
2024-02-20 13:41:21 -08:00
Yousuk Seung 4356005b01 [tracing] Add a getter for write stats
PiperOrigin-RevId: 608719418
2024-02-20 13:32:39 -08:00