ea63190498
Merge pull request #19371 from yang-g/virtual_me
...
Add comments and rename internal methods
2019-06-19 12:25:05 -07:00
7b0ee41fd5
Resolve comment
2019-06-19 10:28:35 -07:00
7db36fe0a0
Add comments and rename internal methods
2019-06-17 11:18:03 -07:00
85f08100d4
Avoid using seq_cst atomic operations in grpcpp when unnecessary.
...
These cases are almost all in the callback API.
Also use atomic<intptr_t> insteda of atomic_int for consistency with
gpr_atm and grpc_core::Atomic.
2019-06-16 16:09:24 -04:00
0bee8c41f9
Merge pull request #19348 from yang-g/virtual_me
...
Mark some methods virtual
2019-06-14 10:15:11 -07:00
b216c34314
Mark some methods virtual
2019-06-13 22:15:53 -07:00
a0f5cb4528
Fix assignment operator
2019-06-13 22:08:09 -07:00
90f1c32b85
Sanity checks and return value
2019-06-13 12:29:48 -07:00
186875337c
Sync with master
2019-06-11 16:16:27 -07:00
94e7edad99
Add Delegating Channel
2019-06-11 15:07:12 -07:00
e4b992ee48
Merge branch 'master' into migrate-client-context
2019-06-10 14:01:28 -07:00
52291e5832
Fix PropogationOptions
2019-06-10 13:58:34 -07:00
cb2143406f
Merge pull request #19188 from yashykt/interceptiondocs
...
Doc Change - Add hijacking interception hook points as valid for the GetRecv* functions
2019-06-06 11:42:20 -07:00
7e18e6cf3f
Fix clang errors.
2019-06-05 16:47:29 -07:00
522ddfe273
Move ClientContext to grpc_impl
...
ClientContext is another file which needs to be moved from grpc to
grpc_impl for referencing it.
2019-06-05 16:31:39 -07:00
226e63dd0c
Move server context implementation to grpc_impl namespace and typedef the ref to it
2019-06-05 10:41:30 -07:00
f671b3d136
Add hijacking interception hook points as valid for the GetRecv* functions
2019-05-30 15:39:37 -07:00
e260de873c
Merge branch 'master' into interceptionfix
2019-05-24 17:03:11 -07:00
c58b4a3964
Clang format
2019-05-24 17:00:54 -07:00
67bdbbdf6f
Fix a bug where POST_RECV_MESSAGE is not being triggered
2019-05-24 16:58:56 -07:00
088319bc40
IWYU in core_codegen_interface
...
core_codegen_interface requires ByteBuffer in generated code and needs
to include byte_buffer.h
NO_BUG=Cleanup
2019-05-23 22:10:53 -07:00
0cafd4110a
Fix typo
2019-05-23 11:12:08 -07:00
dc9897dfe3
Merge pull request #19067 from karthikravis/channel-cq-scq-impl
...
Fold Channel and CompletionQueue into grpc_impl
2019-05-22 16:10:58 -07:00
cd0e02ae1c
Fixing formatting
2019-05-21 02:29:00 -04:00
3ec0967c1e
Fix typo for using MessageLite
2019-05-21 01:52:36 -04:00
51a2280029
Add MessageLite overloads to proto serialization
2019-05-21 01:29:47 -04:00
12ffbb8a83
Add MessageLite type to grpc's config
2019-05-21 01:27:59 -04:00
c4cb6e1787
Merge pull request #19016 from yang-g/message_allocator
...
Update the message allocator API
2019-05-20 08:49:14 -07:00
6215ccb587
resolve comments
2019-05-17 16:22:43 -07:00
03b079499c
Move CompletionQueue and Channel
2019-05-17 09:16:32 -07:00
40210d3b8a
Move Channel to grpc_impl
2019-05-17 09:12:33 -07:00
7c5bfbbb32
Resolve comments
2019-05-16 09:19:44 -07:00
51210ba922
Update the message allocator API
2019-05-16 09:19:44 -07:00
c639da7a1d
Merge branch 'master' of https://github.com/grpc/grpc into port_sharing
2019-05-16 09:07:55 -07:00
3996599392
Fix clang script errors
2019-05-15 14:30:33 -07:00
772a74aced
Revert changes to Channel
2019-05-15 14:24:17 -07:00
6be0b06c69
Revert "Fold CompletionQueue and ServerCompletionQueue into grpc_impl"
2019-05-15 13:38:34 -07:00
de57783beb
Merge with head and resolve conflict
2019-05-13 08:56:02 -07:00
af32f6ce2e
Merge branch 'master' into grpc_namespace_completion_queue
2019-05-09 14:12:52 -07:00
476f7cd81f
Merge pull request #18730 from karthikravis/grpc_namespace_channel_new
...
Fold Channel into grpc_impl from grpc namespace
2019-05-09 14:09:21 -07:00
218e290074
Merge with head and resolve conflict
2019-05-07 22:46:45 -07:00
898fc0da1e
More fixes
2019-05-07 22:45:39 -07:00
f3937f0e55
Merge pull request #18761 from jadekler/update_codes
...
docs: add note about retrying UNAVAILABLE
2019-05-04 20:23:20 -07:00
abd97b9170
Merge with head and resolve conflict
2019-04-30 23:01:01 -07:00
5de22c4bd4
Merge branch 'master' into grpc_namespace_completion_queue
2019-04-30 17:46:33 -07:00
baef4b1d60
Merge branch 'master' into grpc_namespace_channel_new
2019-04-30 17:39:48 -07:00
549230467b
Merge pull request #18720 from grpc/revert-18717-grpc_namespace_server_revert
...
Revert "Revert "Merge pull request #18458 from grpc/grpc_namespace_server""
2019-04-30 17:30:29 -07:00
9eec789a4d
Merge branch 'grpc_namespace_channel_new' into grpc_namespace_completion_queue
2019-04-30 15:51:49 -07:00
e3a0c85960
Merge branch 'master' into grpc_namespace_channel_new
2019-04-30 14:30:03 -07:00
e3c80dc35f
Merge pull request #18870 from hcaseyal/callback_stub_doc
...
Add clarification to callback API documentation
2019-04-30 14:20:37 -07:00
ac3a91edf8
Support accepting external connections.
2019-04-30 12:31:34 -07:00
5f6a57a4d0
Formatting issues
2019-04-26 13:08:25 -07:00
3433749d1b
Add clarification to callback API documentation
2019-04-24 16:37:19 -07:00
38ffd8ca84
Merge branch 'master' into grpc_namespace_credentials
2019-04-23 18:22:09 -07:00
c8a6841dfc
Merge branch 'master' into revert-18717-grpc_namespace_server_revert
2019-04-23 18:14:02 -07:00
5170c613cc
Merge pull request #18784 from yang-g/message_allocator
...
Message allocator support for callback unary
2019-04-23 15:49:49 -07:00
60bdeef9f4
Move Channel also to impl for now
2019-04-23 14:03:06 -07:00
603d014f0e
Changes to fold credentials into grpc_impl from grpc
2019-04-23 13:54:26 -07:00
39cfbf9d4a
cast and default initializer
2019-04-23 13:00:09 -07:00
41824319fa
Resolve review comments
2019-04-23 08:54:36 -07:00
1a4f5e8ade
Fix typo in comment
...
It's a ServerWriteReactor
2019-04-22 11:29:16 -07:00
20c08dbc7a
Add client-side unary reactor model
2019-04-19 16:10:08 -07:00
0939376a17
Merge pull request #18769 from SataQiu/fix-20190416
...
Fix spelling errors of include/*
2019-04-18 09:52:37 +02:00
1c186784cd
Make sure grpc::internal::Mutex has enough space for gpr_mu, std::mutex, and pthread_mutex_t.
2019-04-17 14:35:34 -04:00
2b9448a71c
Revert "Revert "Introduce C++ wrappers for gpr_mu and gpr_cv.""
...
This reverts commit d09c9f8e20
2019-04-17 14:35:29 -04:00
051d421579
Resolve sanity
2019-04-17 08:57:48 -07:00
6929cdd654
initial
2019-04-16 15:43:58 -07:00
b416019f72
fix spelling errors of include/*
2019-04-16 11:45:42 +08:00
a19d8dcfb5
docs: add note about retrying UNAVAILABLE
...
release note: no
2019-04-15 12:45:27 -06:00
1d9e442b4d
Merge pull request #18707 from SataQiu/fix-repeated-words
...
Clean up repeated words
2019-04-15 13:37:09 +02:00
d09c9f8e20
Revert "Introduce C++ wrappers for gpr_mu and gpr_cv."
...
This reverts commit a26c09dd25
2019-04-11 16:52:54 -07:00
00f736adda
Remove unecessary file
2019-04-11 15:46:08 -07:00
62fb156122
Fold CompletionQueue and ServerCompletionQueue into grpc_impl
2019-04-11 13:16:32 -07:00
2554f122c1
Remove unecessary files
2019-04-11 12:06:41 -07:00
973fa6950e
Fold Channel into grpc_impl from grpc namespace
2019-04-11 12:04:23 -07:00
ea59977fbc
Merge pull request #18687 from vjpai/cancel_order
...
C++ Callback API: Make sure that OnCancel happens after OnStarted
2019-04-10 16:15:43 -07:00
2e88231fc0
Revert "Revert "Merge pull request #18458 from grpc/grpc_namespace_server""
2019-04-10 15:04:05 -07:00
e85dd2e644
Fix build errors
2019-04-10 14:15:28 -07:00
f03b309787
Revert "Merge pull request #18458 from grpc/grpc_namespace_server"
...
This reverts commit dc1089a6d131843787cc#17932 from soheilhy/gprpp-mutex"
This reverts commit df4b6a763ddc1089a6d1
2019-04-10 13:54:05 -07:00
dad3f34207
Revert "Revert "Revert "Folding the Channel class into the grpc_impl namespace."""
2019-04-10 12:14:04 -07:00
41c6cba9f5
Make sure that OnCancel happens after OnStarted
2019-04-10 11:32:34 -07:00
891b6cf7ae
Revert "Folding CompletionQueue and ServerCompletionQueue."
2019-04-10 10:22:59 -07:00
44f92cdd17
clean up repeated words
2019-04-10 16:25:25 +08:00
d2b2f7f5a3
Merge branch 'master' into completion-queue-fold
2019-04-09 13:44:33 -07:00
918cb46011
Merge pull request #18198 from grpc/revert-18076-revert-17797-channel
...
Revert "Revert "Folding the Channel class into the grpc_impl namespace.""
2019-04-09 13:34:02 -07:00
ca11dfb349
Merge pull request #18686 from hcaseyal/callback_doc
...
Update callback API documentation
2019-04-09 12:45:06 -07:00
506ca7fc36
Fix clang script errors
2019-04-09 11:51:39 -07:00
b84d3db762
Fix build after merge from master
2019-04-09 11:11:09 -07:00
afd602ccba
Merge branch 'master' into completion-queue-fold
2019-04-09 10:46:03 -07:00
5a08d2aae7
Merge branch 'master' into revert-18076-revert-17797-channel
2019-04-09 08:22:37 -07:00
53c5bf5ced
Merge branch 'master' into revert-18076-revert-17797-channel
2019-04-08 16:04:24 -07:00
a26c09dd25
Introduce C++ wrappers for gpr_mu and gpr_cv.
...
Introduce RAII wrappers in the grpc::internal and grpc_core
namespaces, and use them in place of std::mutex and
std::condition_variable.
Note that, since std::mutex is also used by the public
C++ headers we cannot introduce these wrappers in grpc_core.
Also, note that in grpcpp we cannot use gRPC core and vice versa.
So we had to duplicate the code, once using core_codegen_interface
and once using direct calls.
2019-04-08 18:27:07 -04:00
4cb0d0d6b1
Fix errors from clang scripts
2019-04-08 13:41:19 -07:00
9875fabdd4
Merge branch 'master' into revert-18076-revert-17797-channel
2019-04-08 12:55:07 -07:00
958f373d32
Merge branch 'master' into grpc_namespace_server
2019-04-08 12:42:37 -07:00
b86e70592e
Format
2019-04-08 10:13:17 -07:00
cee3292cdf
Update callback API documentation
2019-04-08 09:11:04 -07:00
c50dd23ea7
Merge branch 'master' into grpc_namespace_server
2019-04-04 15:56:09 -07:00
dd39f78e3f
Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder
2019-04-04 15:45:42 -07:00
8a2807c2a6
Merge branch 'master' into grpc_namespace_server
2019-04-03 12:46:41 -07:00
f0d82d57e2
Merge branch 'master' into grpc_namespace_server_credentials
2019-04-01 13:59:12 -07:00
29c0aacfc0
Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder
2019-03-29 08:24:54 -07:00
847b0155d9
Promise to call OnStarted and forbid Start* until after OnStarted
2019-03-27 16:30:07 -07:00
dc3a715be4
Fix clang format code errors.
2019-03-27 14:33:58 -07:00
c399349dad
Merge branch 'master' into grpc_namespace_server
2019-03-27 14:32:10 -07:00
7068560b2b
Merge branch 'master' into grpc_namespace_server_credentials
2019-03-27 14:18:42 -07:00
0f078898d5
Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder
2019-03-27 12:50:49 -07:00
abb991be25
Further clarify some APIs by removing their comments from internal::
2019-03-27 09:46:08 -07:00
9169159f30
Comments for all callback API methods
2019-03-26 23:33:23 -07:00
996da58667
Revert "Revert "Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder""
2019-03-26 08:04:32 -07:00
e4bb7cb8bb
Revert "Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder"
2019-03-25 19:57:17 -07:00
f4fdd829d7
Merge pull request #17892 from RohanTalip/HandlerParameter-doc
...
Renamed the param in the documentation for HandleParameter to match the actual parameter.
2019-03-25 16:46:17 -07:00
88fc2a6a52
Merge pull request #18242 from grpc/grpc_namespace_serverbuilder
...
Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder
2019-03-25 15:59:01 -07:00
ad1b3e5094
Introduce grpc_byte_buffer_reader_peek and use it for Protobuf parsing.
...
grpc_byte_buffer_reader_next() copies and references the slice. This
is not always necessary since the caller will not use the slice
after destroying the byte buffer.
A prominent example is the protobuf parser, which
calls grpc_byte_buffer_reader_next() and immediately unrefs the slice
after the call. This ref() and unref() calls can be very expensive
in the hot path.
This commit introduces grpc_byte_buffer_reader_peek() which
essentialy return a pointer to the slice in the buffer, i.e.,
no copies, and no refs.
QPS of 1MiB 1 Channel callback benchmark increases by 5%.
More importantly insructions per cycle is increased by 10%.
Also add tests and benchmarks for byte_buffer_reader_peek()
This commit reaplies 509e77a5a3
2019-03-21 06:03:45 -04:00
50576179f8
Merge pull request #17978 from yashykt/interceptorcleanup1
...
Global Interceptor Registration allowed only once
2019-03-20 19:13:55 -07:00
04af168cf8
Move Server into grpc_impl from grpc
2019-03-20 13:05:36 -07:00
54171e276f
Fold server credentials from grpc to grpc_impl namespace
2019-03-20 10:00:34 -07:00
7b3a120295
Address reviewer comments
2019-03-18 16:51:15 -07:00
93f0a3f653
Address reviewer comments
2019-03-18 15:37:35 -07:00
04a6b8467c
Support callback on cancellation of server-side unary RPCs
2019-03-18 12:00:57 -07:00
322e720fe6
Merge branch 'master' into grpc_namespace_serverbuilder
2019-03-18 10:39:38 -07:00
8c3d4a7dfd
Merge pull request #18072 from vjpai/client_streaming_hold
...
C++ callback API: Add support for client-side extra-reaction operations via Holds
2019-03-16 10:27:36 -07:00
48ce4ca939
Add support for extra-reaction operations via Holds
2019-03-15 16:17:01 -07:00
3d28761029
Fixing memory leak in interceptor by removing unsued send_status_
2019-03-13 21:42:02 +01:00
3b7a47cde6
Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder
...
This change moves ServerBuilder class from grpc namespace to grpc_impl
namespace.
2019-03-04 17:01:14 -08:00
05d8ddfc6e
Support callback-based generic service
2019-03-04 13:13:12 -08:00
509e77a5a3
Introduce grpc_byte_buffer_reader_peek and use it for Protobuf parsing.
...
grpc_byte_buffer_reader_next() copies and references the slice. This
is not always necessary since the caller will not use the slice
after destroying the byte buffer.
A prominent example is the protobuf parser, which
calls grpc_byte_buffer_reader_next() and immediately unrefs the slice
after the call. This ref() and unref() calls can be very expensive
in the hot path.
This commit introduces grpc_byte_buffer_reader_peek() which
essentialy return a pointer to the slice in the buffer, i.e.,
no copies, and no refs.
QPS of 1MiB 1 Channel callback benchmark increases by 5%.
More importantly insructions per cycle is increased by 10%.
Also add tests and benchmarks for byte_buffer_reader_peek()
2019-03-04 14:17:46 -05:00
91ad888497
Revert "Revert "Folding the Channel class into the grpc_impl namespace.""
2019-02-27 16:53:23 -08:00
2eb25c871e
Avoid build errors
2019-02-26 03:08:06 -08:00
857e622e6f
Merge pull request #18098 from vjpai/try_2
...
Reduce starting callback counter to exclude client-side StartCall
2019-02-22 19:52:29 -08:00
147c61b2a4
Exclude StartCall from starting callback counter value
2019-02-20 21:13:44 -08:00
3cbf4f50ea
Remove extra semicolons after function definitions
...
We are planning to enable -Wextra-semi flag in our project but some
header files in gRPC have extra semicolons that violates the check and
blocks us from enabling the flag.
This change removes unnecessary semicolons in the code. Note that having
semicolon after the GRPC_ABSTRACT macro technically also violates the
check, but it's fine for us since they are not used in public headers,
and it will be confusing to have lines ending only with GRPC_ABSTRACT,
so I keep them as-is.
2019-02-20 17:58:30 -08:00
2ad245cb0c
Revert "Folding the Channel class into the grpc_impl namespace."
2019-02-15 09:52:15 -08:00
035442b086
Fixing header guard.
2019-02-14 21:40:31 +01:00
5847c3a87a
Reformat.
2019-02-14 20:05:59 +01:00
12b0db3e57
Folding CompletionQueue and ServerCompletionQueue.
2019-02-14 20:01:14 +01:00
73353ad281
Merge branch 'master' into interceptorcleanup1
2019-02-13 12:47:47 -08:00
50497c2317
Reviewer comments
2019-02-13 12:46:07 -08:00
63db582516
Merge branch 'master' of https://github.com/grpc/grpc into channel
2019-02-13 00:19:23 +01:00
c71b2f4fb7
Global Interceptor Registration allowed only once
2019-02-07 19:36:51 -08:00
89ee1a8b10
Improved interception docs
2019-02-07 19:18:40 -08:00
d68c0d29d9
Renamed the param in the documentation for HandleParameter to match the actual parameter.
...
This should prevent warnings like the following:
=== BUILD TARGET FirebaseFirestore OF PROJECT Pods WITH CONFIGURATION Debug ===
In file included from $PROJECT_DIR/platforms/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/stream.mm:17:
In file included from $PROJECT_DIR/platforms/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/stream.h:27:
In file included from $PROJECT_DIR/platforms/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/grpc_connection.h:28:
In file included from $PROJECT_DIR/platforms/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/grpc_stream.h:35:
In file included from $PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/generic/generic_stub.h:24:
In file included from $PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/support/async_stream.h:22:
In file included from $PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/impl/codegen/async_stream.h:26:
In file included from $PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/impl/codegen/service_type.h:24:
$PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/impl/codegen/rpc_service_method.h:49:16: warning: parameter 'rpc_requester' not found in the function declaration
[-Wdocumentation]
/// \param rpc_requester : used only by the callback API. It is a function
^~~~~~~~~~~~~
$PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/impl/codegen/rpc_service_method.h:49:16: note: did you mean 'requester'?
/// \param rpc_requester : used only by the callback API. It is a function
^~~~~~~~~~~~~
requester
1 warning generated.
2019-02-01 12:56:56 -08:00
5e2e61b6e5
Note on conditions of usage
2019-01-28 16:37:02 -08:00
3a2cfe50ec
Rever copyright changes
2019-01-28 16:18:49 -08:00
786598a6ff
Merge branch 'master' into interceptorcqavalanching
2019-01-28 11:54:39 -08:00
9dd8a13439
Restructure code to handle cases exposed by the callback api
2019-01-24 19:03:55 -08:00
cabbd35014
Reformat.
2019-01-24 23:42:12 +01:00
4dcb14ec9e
Fix codegen_test_minimal
2019-01-24 13:05:05 -08:00
d347ec7ce0
Register for cq avalanching when interceptors are going to be run
2019-01-23 19:11:51 -08:00
2fd079ff7c
Channel folding.
2019-01-23 21:40:07 +01:00
73b1a918e4
Slight update to grammar. Can probably be improved more
2019-01-08 09:28:09 -08:00
b8a542cd23
Update Send message interception methods docs
2019-01-08 09:20:15 -08:00
1730c06c48
Merge pull request #17655 from yashykt/callbackwriteoptions
...
Use the WriteOptions in Client Callback API
2019-01-08 08:15:43 -08:00
361acdbed1
Use the WriteOptions in Client Callback API
2019-01-07 17:33:16 -08:00
b35b449166
Update docs according to #17630
2019-01-07 17:20:58 -08:00
34d77aae5e
Always nullify serializer to free memory
2019-01-07 14:12:03 -08:00
dd067fd390
Merge branch 'master' into nocopyinterception
2019-01-07 10:09:06 -08:00
7d1491d64c
Address reviewer comments
2019-01-07 09:23:35 -08:00
059459a9ee
Merge branch 'master' into failhijackedrecv
2019-01-04 17:28:25 -08:00
b05ca9697b
Merge branch 'master' into failhijackedrecv
2019-01-04 11:30:03 -08:00
9b9ef64027
Add more information on the usage of FailHijackedRecvMessage
2019-01-04 11:29:57 -08:00
2b4781ca52
Use Status() instead of Status::OK to avoid issues with codegen_test_minimal
2019-01-03 18:32:10 -08:00
7eeda22d9e
s/two/three
2019-01-03 18:23:15 -08:00
df49204b97
Remove unused variable
2019-01-03 18:10:21 -08:00
4224384d39
Modifying semantics for GetSendMessage and GetSerializedSendMessage.
...
Also adding ModifySendMessage
2019-01-03 18:01:58 -08:00
bac79bdabe
Merge branch 'master' into failhijackedsend
2019-01-03 15:51:43 -08:00
50c60f03ba
Rename GetSendMessage to GetSerializedSendMessage and GetOriginalSendMessage to GetSendMessage
2019-01-03 12:21:19 -08:00
c6261f4b91
Rename new SendMessage types to SendMessagePtr
2019-01-02 14:46:52 -08:00
4aeba42528
Provide GetOriginalSendMessage for some APIs
2018-12-28 17:27:38 -08:00
24e37e249a
Merge branch 'master' into failhijackedrecv
2018-12-26 15:10:41 -08:00
5a6183f1bd
Merge branch 'master' into failhijackedsend
2018-12-26 13:33:06 -08:00
8cd1c0e379
Merge pull request #17552 from vjpai/interceptor_comments
...
Document purpose and validity of interception API
2018-12-18 22:43:49 -08:00
cfe08f35f3
Add comments explaining purpose and validity of interception API
2018-12-18 14:53:56 -08:00
3c3876a5da
Merge pull request #17544 from yashykt/factorydocs
...
Allow interceptor creators to return nullptr
2018-12-18 14:48:43 -08:00
e51a28636f
Merge pull request #17512 from hcaseyal/update_md_doc
...
Improve metadata documentation for the user
2018-12-18 14:14:57 -08:00
31a775b425
Add missing argument
2018-12-18 12:52:14 -08:00
d590583456
Allow interceptor creators to return nullptr
2018-12-18 12:10:20 -08:00
233123ae3f
Improve metadata documentation for the user
2018-12-18 11:50:17 -08:00
bb303513dc
Merge master
2018-12-18 11:40:52 -08:00
f2324e1c05
Reset the SendMessage pointer before post-interception
2018-12-16 16:01:14 -08:00
a8688d3bd3
Merge pull request #17510 from vjpai/bb_api
...
Add API comments indicating that byte buffer copy is size-independent
2018-12-14 15:18:01 -08:00
b0b4c0d9c3
Add API comments indicating that byte buffer copy is size-independent
2018-12-14 13:52:25 -08:00
23817e1738
Merge pull request #17434 from vjpai/delete
...
Delete unwanted constructor/assignment
2018-12-14 13:12:00 -08:00
e7be6223d8
Delete unwanted constructor/assignment
2018-12-06 17:10:03 -08:00
97de30d7b3
Allow the interceptor to know the method type
2018-12-06 15:51:31 -08:00
13a4977c23
Treat StartCall like a reserved callback since it is required
2018-12-06 09:02:03 -08:00
eb0b39df3d
Do OnDone as the actual last thing so that the reactor can be reused.
2018-12-05 16:04:26 -08:00
606177bbc8
Document that ClientContext must remain alive for duration of RPC
2018-12-03 20:00:08 -08:00
2a0c0d7ad6
Streaming API for callback servers
2018-11-30 16:14:21 -08:00
2b5d45ab38
Fix clang-tidy and golden file issues
2018-11-30 04:13:41 -08:00
28dd7981d6
clang-format
2018-11-30 04:13:40 -08:00
ea1156da3f
Stop exposing streaming object class
2018-11-30 04:13:40 -08:00
dac2066a1c
Make StartCall() a releasing operation so that you can pile up ops
2018-11-30 04:13:40 -08:00
fa45ffd418
Address reviewer comments
2018-11-30 04:13:40 -08:00
d7eb26648d
Client callback streaming
2018-11-30 04:13:40 -08:00
8fb11e6d5e
Apply the conversion on the status irrespective of whether Pluck returned true
2018-11-21 14:11:59 -08:00
544f2a5abb
Necessary change after #17219
2018-11-21 14:00:16 -08:00
00c9c40004
Remove extraneous logging statements
2018-11-15 16:01:14 -08:00
d4ebd30eb2
Add method to get status of send message op on POST_SEND_MESSAGE
2018-11-15 15:57:43 -08:00
0911e489e3
Add a method to check whether the message was received successfully
2018-11-15 13:55:56 -08:00
a9bee9b7ed
Make Pluck use the changes made in FinalizeResult
2018-11-14 17:48:35 -08:00
5d7d6c0fbd
Add method to fail hijacked send messages
2018-11-14 17:35:26 -08:00
0e29d7b9bc
Properly clear metadata and other structs when reusing ServerContext
2018-11-13 12:44:56 -08:00
565edf5297
Add safety checks
2018-11-09 19:51:11 -08:00
699c10386d
Add method to fail recv msg for hijacked rpcs
2018-11-09 19:43:00 -08:00
a803f96e5a
Add comment on cancellation being forever alone in the batch
2018-11-06 15:32:05 -08:00
193b4b57ec
Merge pull request #17072 from yashykt/interceptor_cancellation
...
Interceptors should see a Cancellation notification
2018-11-06 14:56:24 -08:00
1e850944e9
Release the CallbackWithSuccessTag from a server context completionop
2018-11-06 11:49:17 -08:00
526d2e6004
Refactoring of CallbackWithSuccessTag
2018-11-06 11:20:50 -08:00
f055c1cfd2
Remove unnecessary header
2018-11-05 14:35:55 -08:00
f240af0cb8
Add GPR_CODEGEN_DEBUG_ASSERT
2018-11-05 13:56:06 -08:00
6faa17c6ca
s/new/post-1.0
2018-11-02 11:46:10 -07:00
3ac7f2d24c
Merge pull request #17053 from yashykt/global_interceptor
...
Add global client interceptor factory
2018-11-02 08:56:16 -07:00
ded9434e4c
Add array header for complaining compiler
2018-11-01 18:36:40 -07:00
382fe4b475
Add override back to GetInterceptedChannel
2018-11-01 18:17:02 -07:00
ddcadad5b5
Add note on hijacking
2018-11-01 16:26:04 -07:00
b732e9c403
Make client interceptors see notification even if Cancel was done before the RPC was issued. Also add tests
2018-11-01 16:14:40 -07:00
fd88dcaf55
Add cancellation notification
2018-11-01 11:58:46 -07:00
3ece34d45c
Let us clean a few things before getting started
2018-10-31 15:29:26 -07:00
857e79ce00
Improve documentation
2018-10-31 14:35:54 -07:00
932abf48a3
Address reviewer comments.
2018-10-31 01:02:07 -07:00
2f47137a6e
Add support for IsCancelled check
2018-10-30 23:15:59 -07:00
b460622c2d
Address reviewer comments
2018-10-30 12:35:56 -07:00
47d0d5bf1f
Merge branch 'master' into server_callback
2018-10-30 12:29:35 -07:00
0390b29e15
Register global interceptors functionality
2018-10-30 02:43:01 -07:00
3c1ca6bf39
Merge pull request #17034 from yashykt/interceptorcleanup
...
Get ClientContext included with ChannelInterface, and slight more cle…
2018-10-30 00:12:55 -07:00
84e763f10a
Experimental C++ server callback unary API
2018-10-29 13:41:25 -07:00
371b1d99d5
Add call as param to MethodHandler::Deserialize to allow arena use
2018-10-29 02:10:00 -07:00
bfd1935afc
Add note on the experimental nature of the additional method in ServerInterface
2018-10-29 01:56:12 -07:00
85ddf5c713
Get ClientContext included with ChannelInterface, and slight more cleanup
2018-10-29 00:14:05 -07:00
01313976e1
Merge pull request #16842 from yashykt/interceptors
...
Experimental API for Client and Server Interception
2018-10-28 23:36:59 -07:00
395edbfa24
Replace size_t initialization from false to 0
2018-10-27 20:14:06 -07:00
2475744c75
Change index to size_t
2018-10-26 18:14:55 -07:00
005eb29298
Missed reviewer comments
2018-10-26 16:52:18 -07:00
1ea195b6f3
Reviewer comments except for void * fixed
2018-10-26 16:11:48 -07:00
6a5f39db3c
Separate out interceptorbatchmethodimpl to a different file
2018-10-26 15:47:16 -07:00
c2e3fde9b5
Rename call.h to call_op_set.h and call_wrapper.h to call.h
2018-10-26 15:15:48 -07:00
91faa8e8f0
Fix an outdated comment
...
Fix the outdated commment in ServerCompletionQueue constructor
2018-10-26 10:49:52 -07:00
cc21d32c77
Some cleanup
2018-10-26 00:13:55 -07:00
312feb4202
Adding generic rpc and unimplemented rpc test for server interceptors
2018-10-25 21:43:49 -07:00
3896dabb85
Merge branch 'master' into interceptors
2018-10-25 19:50:10 -07:00
a094b7b312
Added server async tests
2018-10-25 19:24:30 -07:00
63921c7f63
Merge pull request #16992 from morganchen12/warnings
...
Fix warnings in doc comments
2018-10-25 17:04:42 -07:00
56f1d3d697
clang-format
2018-10-25 11:06:32 -07:00
4fa389b137
Unifying grpc build hacks
2018-10-24 17:25:51 -07:00
482641501c
Revert "Revert "Refactor Channelz Service to Support Internal Build""
...
This reverts commit 2eafaccba6
2018-10-24 17:22:22 -07:00
281de1bb30
Solve memory leak due to double setting of set_server_rpc_info
2018-10-24 15:54:08 -07:00
2eafaccba6
Revert "Refactor Channelz Service to Support Internal Build"
2018-10-24 15:44:50 -07:00
6f4f17a3d0
Fix documentation warnings
2018-10-24 15:29:19 -07:00
22dc39ae66
Change CatchingCallback function to be varargs for broader use
2018-10-24 02:28:57 -07:00
62280b42c7
Add client streaming, server streaming and bidi streaming tests
2018-10-23 21:08:39 -07:00
66cc56bb03
Another server side test
2018-10-23 15:33:08 -07:00
4da91c1156
First test for server interception
2018-10-23 13:56:36 -07:00
97134a69be
Refactor to support internal build
2018-10-22 17:08:31 -07:00
d8cfd96fb2
Adding tests using the callback API
2018-10-22 16:43:43 -07:00
b358ef85dc
Merge branch 'master' into interceptors
2018-10-22 10:39:27 -07:00
9b83b7d19e
Adding intercepted channel
2018-10-22 02:42:03 -07:00
3a17f5b05e
Working on tests
2018-10-21 23:06:21 -07:00
ce4bd108ea
Fix CallOpSet copy/assignment to reset cq_tag
2018-10-19 17:17:34 -07:00
52765e9cb1
Don't expose internal functions.. Add a layer of indirection namely InternalInterceptorBatchMethods
2018-10-19 17:07:05 -07:00
456231b26d
Server side interception for CompletionOp and AsyncRequest
2018-10-18 22:43:49 -07:00
adca91f6cf
Server interception for SyncRequest
2018-10-18 16:07:00 -07:00
d042a5acf1
some tests fail
2018-10-17 22:05:48 -07:00
0b785ae8cf
Remove unneeded file
2018-10-17 14:37:35 -07:00
af621c7705
Add method to register server creators
2018-10-17 12:32:53 -07:00
b232bacf27
Starting on server interceptors
2018-10-16 14:11:07 -07:00
f9fe345553
Add more tests for client interceptors
2018-10-16 14:11:07 -07:00
cc8c27950c
Change types to use C++ types rather than core types
2018-10-16 14:10:48 -07:00
6fb7bd23bf
s/GPR_ASSERT/GPR_CODEGEN_ASSERT and few more bugs
2018-10-16 14:10:30 -07:00
6f05a711e6
Adding a test
2018-10-16 14:10:17 -07:00
63bdf4e236
More changes for client interception
2018-10-16 14:10:02 -07:00
5d831da9d1
Adding hook points for interception. Code compiles and tests still run
2018-10-16 14:09:34 -07:00
f4e65787b6
Merge remote-tracking branch 'upstream/master' into health_checking_service
2018-10-15 13:12:26 -07:00
130eeeaeb9
Merge branch 'master' into interceptors_initial
2018-10-02 14:49:17 -07:00
e04a819c12
Merge pull request #16657 from g-easy/deadline
...
Document that set_deadline() uses absolute time.
2018-10-01 18:58:44 -07:00
b741edf37e
Error fixes
2018-09-27 17:34:19 -07:00
a1598c5abf
Create interfaces and initial plumbing for interception API
2018-09-26 19:25:30 -07:00
be1ce0c4cc
Revert "Merge pull request #16600 from grpc/revert-16574-health_checking_service"
...
This reverts commit de11358660107d10ea73
2018-09-25 11:42:57 -07:00
17fc4d4029
Address reviewer comments
2018-09-20 10:52:48 -07:00
0db69018b0
Use GPR_CODEGEN_ASSERT in impl/codegen
2018-09-20 00:58:29 -07:00
fc1e35444b
Reset status field in tag as well as func
2018-09-20 00:39:49 -07:00
9e6511ae2e
Make the core callback interface API so that it can be used in generated code
2018-09-19 23:57:56 -07:00
0131c7bbb3
Document that set_deadline() uses absolute time.
2018-09-19 14:26:59 -07:00
d177c8fe46
Merge pull request #16384 from yashykt/doc1
...
Improve documentation on lifetime of message and status
2018-09-18 14:26:08 -07:00
73d89a66f9
Catch exceptions in user callbacks
2018-09-14 16:56:19 -07:00
5f2bb7a7d4
s/GRPC/gRPC
2018-09-12 11:14:18 -07:00
3bc10c0f44
Merge pull request #16492 from vjpai/client_callback
...
EXPERIMENTAL: C++ generic client-side unary callback API
2018-09-12 09:03:49 -07:00
20778b0c46
Address reviewer comments
2018-09-11 09:14:57 -07:00
42d9becd91
Revert "Second attempt: Implement Watch method in health check service."
2018-09-10 14:06:52 -07:00
a8247c833c
Merge pull request #16574 from markdroth/health_checking_service
...
Second attempt: Implement Watch method in health check service.
2018-09-07 11:53:16 -07:00
605a42d90a
fix #13939
2018-09-05 21:40:58 +02:00
6d2c8f8072
Revert "Merge pull request #16512 from grpc/revert-16351-health_checking_service"
...
This reverts commit 4ee0f4c7905ee9b5e7b5
2018-09-05 10:27:54 -07:00
4e6ed86a04
Merge pull request #16407 from ncteisen/lazy-metadata
...
Lazily Fill Metadata Map
2018-08-31 12:05:16 -07:00
5474e92292
Allocate using call arenas
2018-08-31 10:11:38 -07:00
6b6bdbbb76
Address reviewer and clang-tidy comments
2018-08-30 15:46:27 -07:00
8bf52535d1
Provide a generic client-side unary callback API
2018-08-30 15:46:27 -07:00
14a858123d
Revert "Implement Watch method in health check service."
2018-08-29 21:36:41 -07:00
58e99b6377
Use strncmp over grpc_slice_str_cmp
2018-08-29 10:30:31 -07:00
ca77fcd7cd
Reviewer comments
2018-08-29 07:46:48 -07:00
743d40d635
Lazily fill metadata map
2018-08-28 17:00:20 -07:00
4d985efe19
Merge pull request #16351 from markdroth/health_checking_service
...
Implement Watch method in health check service.
2018-08-28 11:59:22 -07:00
99ce3e19af
Implement Watch method in health check service.
2018-08-28 08:51:52 -07:00
3ad8df35f0
Merge pull request #16383 from vjpai/tidy
...
Cast an index to size_t to avoid sign-conversion warning
2018-08-23 14:59:32 -07:00
f80af5a7c7
Formatting
2018-08-17 14:58:01 -07:00
356fff684a
Improve documentation on lifetime of message and status
2018-08-17 14:55:05 -07:00
616b5d798a
Cast an index to size_t to avoid sign-conversion warning
2018-08-17 13:38:48 -07:00
61dabce400
Merge pull request #16289 from AspirinSJL/warn_api_use
...
Add warning about AsyncNotifyWhenDone bug
2018-08-16 15:23:36 -07:00
14ad82a76d
Create a new method handler for resource exhaustion and tie into thread mgr
2018-08-14 16:23:21 -07:00
bbb97318e8
Merge branch 'master' into callback_cq
2018-08-13 11:07:22 -07:00
e58d400ba2
Fix type reference in documentation
2018-08-10 17:13:42 -07:00
b7b1e77943
Fix minor typo in documentation
2018-08-10 14:38:33 -07:00
e84096bbe5
Experimental infrastructure for callback-based CQ
2018-08-10 14:33:22 -07:00
5e9994bf30
Add warning about AsyncNotifyWhenDone bug
2018-08-09 14:40:26 -07:00
f48d3d5d98
Initialize member in default ctor
2018-07-17 12:06:31 -07:00
be40b0d3a8
Add server load reporting service
2018-07-13 19:52:59 -07:00
c5336fcf8b
Drop a spurious assert, since ServerReader can SendInitialMetadata
2018-07-06 14:21:14 -07:00
7d474811ab
Reviewer feedback
2018-06-29 14:59:59 -07:00
a0a59537d2
s/CodegenGeneric/Raw/g
2018-06-28 18:52:01 -07:00
8db7788d46
Merge branch 'master' of https://github.com/grpc/grpc into serialization
2018-06-28 00:12:02 -07:00
73a124fcfb
Wire to socket doc change
2018-06-20 13:34:33 -07:00
0d878eae6c
Fix build
2018-06-20 07:59:06 -07:00
d170b83e0d
Allow AsyncServer with one generic to compile
2018-06-20 07:59:05 -07:00
93a90e6132
Support codegen generic on server side
2018-06-20 07:59:05 -07:00
500e3399b6
Address reviewer comments
2018-06-12 00:58:18 -07:00
1b8969b973
Add useful comment on ServerInterface::Shutdown
2018-06-12 00:53:19 -07:00
801e566622
handle empty slice explicitly
2018-06-08 10:29:07 -07:00
92c4e0fee0
Rename ProtoBuffer helpers
2018-04-12 17:19:54 -07:00
e91cfed3a2
Merge pull request #14934 from ncteisen/typos
...
Fix typos
2018-04-09 10:36:10 -07:00
cf5b2666e1
Make GrpcProtoBufferReaderWriter public
2018-04-06 07:05:27 -07:00
4a719088ca
Fix typos
2018-04-04 10:26:57 -07:00
2e3d410846
fixup! Use bbuf_ptr
2018-04-02 11:16:41 -07:00
8016d35aca
fixup! Fix formatting
2018-04-02 10:56:45 -07:00
f76069a593
fixup! Fix the payload ownership issue
2018-03-30 10:44:43 -07:00
4df7438960
Fix ServerInterface::PayloadAsyncRequest to work with ByteBuffer
2018-03-30 10:15:27 -07:00
a4da2d2a54
Eliminate existence of SneakyCallOpSet, some server cleanup
2018-03-22 19:09:01 -07:00
cdddc8ce42
Desneak client unary call, avoid Hyrum's Law (used for 1-thread simplicity)
2018-03-20 08:46:28 -07:00
ba46afe3e2
Delete status_test that has no coverage; replace with static_asserts
2018-03-15 11:30:59 -07:00
589e2cfe09
Update completion_queue.h
2018-03-13 09:52:00 -07:00
626a65e877
Added protected default constructor
2018-03-13 09:46:08 -07:00
1d603248f2
forgot to add completion_queue.h doh!
2018-03-12 10:37:52 -07:00
e1a7283dd3
moved Next implementation to CC file.
2018-02-26 14:55:56 -08:00
8065000697
Remove "final" keyword and make methods protected.
...
This adds extensibility to the API and makes custom implementation
of the server possible.
2018-02-23 14:51:46 -08:00
f258b56f43
fix non-virtual-dtor
...
compiling with -Wnon-virtual-dtor works with this patch
2018-02-16 12:42:05 +01:00
0e00c43082
Move headers from grpc++ to grpcpp
2018-02-15 14:49:34 -08:00
Yang Gao