Commit Graph

644 Commits

Author SHA1 Message Date
Vijay Pai 7eebba3781 Fixes needed to make roll-forward of StartCall and corking work 2020-06-16 13:06:16 -07:00
Vijay Pai 278671072f
Revert "Revert "Fix StartCall: make corking work and allow concurrent Start*"" 2020-06-16 12:20:19 -07:00
Vijay Pai b269fdbf8b Don't mark server RPC canceled if finished with non-OK status 2020-06-11 10:15:05 -07:00
Karthik Ravi Shankar 934cf3e3df Move ServerBuilder back to ::grpc from ::grpc_impl
Revert #18510
2020-06-10 22:47:29 -07:00
Karthik Ravi Shankar 11c54ada0d
Revert "Fix StartCall: make corking work and allow concurrent Start*" 2020-06-02 11:11:06 -07:00
Jacob Dlougach 35ab5bc616
Include <memory> for std::unique_ptr
Currently `#include <grpcpp/support/interceptor.h>` in some compilers (gcc 8, for example) will fail due to missing `<memory>` include. This PR fixes this issue.
2020-05-21 14:17:45 +01:00
Vijay Pai 899cbcab96 Fix StartCall: make corking work and allow concurrent Start* 2020-05-20 10:02:22 -07:00
Yash Tibrewal 8051d956af
Merge pull request #22429 from pavelsimo/patch-1
Fix typo in CallOpSet comments
2020-05-08 06:35:33 -07:00
Yash Tibrewal 6a6481cb83 Reviewer comments 2020-04-30 15:44:48 -07:00
Yash Tibrewal e714d0fcb8 Reviewer comments 2020-04-28 13:24:23 -07:00
Yash Tibrewal edbae5d8e6 Fix interceptor batch method FailHijackedRecvMessage for async APIs 2020-04-22 23:05:57 -07:00
Vijay Pai 397b3ee72e
Do a debug-check of API use 2020-03-31 16:03:44 -07:00
Vijay Pai 03fffe0fcb
Document that AddMultipleHolds argument must be positive 2020-03-31 13:42:32 -07:00
Vijay Pai ee3952f72b
Merge pull request #22483 from vjpai/lambdify
Remove all std::mem_fn and std::bind from service definitions and setup
2020-03-26 23:52:06 -07:00
Kislay Kishore bf3954c8cc
Fix typo
clinet -> client
2020-03-26 09:45:11 +05:30
Vijay Pai c86cfc305c Remove all std::mem_fn and std::bind from service definitions and setup 2020-03-25 16:48:36 -07:00
Pavel Simó b91d433ba4
Fix typo 2020-03-20 14:13:51 +01:00
Vijay Pai 33f4b8336e Add useful comments 2020-03-17 14:29:34 -07:00
Esun Kim 415d41f9e8 Rerun clang-formatter-7 2020-03-03 10:46:55 -08:00
Vijay Pai e859aa8169
Update server_callback_impl.h 2020-02-27 14:16:25 -08:00
Vijay Pai 3620abf059 Properly follow precise conditions for callback inlining 2020-02-20 01:34:30 +00:00
Yash Tibrewal 820ee53030
Merge pull request #22000 from yashykt/unusedparams
Remove some unused parameter warnings
2020-02-13 16:23:19 -08:00
Esun Kim fd72a70e7d Update by review 2020-02-13 09:11:51 -08:00
Yash Tibrewal 4a02ff7747 Remove some unused parameter warnings 2020-02-12 17:56:34 -08:00
Esun Kim 89908faede Delete default TimePoint constructor to detect error at compile time 2020-02-12 12:20:36 -08:00
Vijay Pai 06ca713df0 Instantiate tracking members regardless of NDEBUG 2020-02-11 13:54:25 -08:00
Vijay Pai 6b2aeec9f3 Revert "Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"""" 2020-02-11 13:50:53 -08:00
Nicolas Noble de76cf8522
Stop using ByteSize as it's deprecated.
Fixes #21603
2020-01-29 10:46:19 -08:00
Lidi Zheng 312b31c264
Merge pull request #21806 from grpc/revert-21767-revert-21725-revert-21680-cq_ordering
Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"""
2020-01-27 16:34:45 -08:00
Lidi Zheng cd086cb3e4
Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)""" 2020-01-27 14:10:44 -08:00
Vijay Pai a801ccbdc8 Reinterpret_cast after in-place new... 2020-01-24 12:25:51 -08:00
Vijay Pai 1f0cdd5aad Construct DefaultReactor lazily since not always needed 2020-01-23 08:52:21 -08:00
Vijay Pai 16f2250585 Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"" 2020-01-22 21:58:35 -08:00
Vijay Pai 64281e8c79 Clarify ownership in comments 2020-01-21 10:45:04 -08:00
Jan Tattermusch e7d5ca0b46
Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)" 2020-01-20 14:42:29 +01:00
Vijay Pai 6466c7f166 Log an error (in dbg mode) if CQ is Shutdown before its Server(s) 2020-01-16 11:51:44 -08:00
Vijay Pai 2f0362ee3a
Remove unused (and defective) constructor 2020-01-05 16:27:30 -08:00
Vijay Pai 4062025312 Check for negative on NextMessageSize 2019-12-18 22:20:31 -08:00
Vijay Pai c758bf9571 clang-fmt 2019-12-16 13:43:55 -08:00
Vijay Pai bffc5701e6 Fix cancellation 2019-12-16 13:39:21 -08:00
Vijay Pai 377a32c0ce
Merge pull request #21443 from vjpai/fix_bug_21210
Move operations out of lock in Bind functions
2019-12-11 21:48:36 -08:00
Vijay Pai 19404f516c
Merge pull request #21405 from vjpai/deexperimentalize_codegen
De-experimentalize generated callback code
2019-12-11 18:50:13 -08:00
Vijay Pai d82b3124fe Move operations out of lock in Bind functions 2019-12-11 16:34:46 -08:00
Vijay Pai 8d9d8326f5 De-experimentalize generated code 2019-12-11 16:21:23 -08:00
Esun Kim 169e775958
Revert "Generic API: assert when sending uninitialized byte buffer" 2019-12-11 12:58:34 -08:00
Hope Casey-Allen 89e5c2f45a Add assert for API misuse 2019-12-06 14:45:00 -08:00
Vijay Pai 62e01dd922 Add non-experimental:: versions under ifdef 2019-12-04 06:27:41 -08:00
Vijay Pai 1c5aa3c0ad Remove namespace experimental here also 2019-12-03 21:37:55 -08:00
Vijay Pai eac7b5ee49 port_platform should be included since that's where NONEXPERIMENTAL is specified 2019-12-03 20:20:39 -08:00
Vijay Pai 2c87eaabd4 De-experimentalize generic features of callback API under an ifdef 2019-12-03 12:24:13 -08:00
Vijay Pai 94a8c5888a Remove namespace experimental from namespace grpc_impl 2019-12-02 15:36:05 -08:00
Yash Tibrewal b4d6916552
Merge pull request #20567 from yashykt/docupdate
Stronger guarantee on failure of read/write operations
2019-11-25 11:59:10 -08:00
Vijay Pai be6979202b Revamp server-side C++ callback API, message allocator, and mocking 2019-11-20 16:56:18 -08:00
Hope Casey-Allen 3bbfb76b64 Add comment about thread safety 2019-11-19 14:44:30 -08:00
Esun Kim f40a702441 Clean up headers 2019-11-15 09:38:31 -08:00
Vijay Pai 300252a857
Constify parameter struct since all fields set at construction
Improve readability
2019-11-07 02:35:04 -08:00
Yash Tibrewal a980df6293 Add documentation around peer, auth_context and census_context properties of ClientContext 2019-10-24 14:34:58 -07:00
nanahpang 8619219081
Merge pull request #20681 from nanahpang/fix_gpr_log_error
Comment out lines that cause error "undefined reference to gpr_log"
2019-10-18 16:12:11 -07:00
Yash Tibrewal 9f9288fbb9
Merge pull request #20246 from yashykt/credentials_expose
Experimental method to get a debugging only view into credentials
2019-10-18 15:24:54 -07:00
Na-Na Pang 58b352343e comment out grpc_log 2019-10-18 14:52:18 -07:00
Vijay Pai 20458806e8 Remove asserts from impl/codegen 2019-10-17 05:20:41 -07:00
Vijay Pai 9d6b7da2a8
Merge pull request #20628 from vjpai/for_include
Use range-based fors in include/grpcpp
2019-10-17 05:10:15 -07:00
Vijay Pai 9274674906 Revert one change back to an iterated loop rather than range-based 2019-10-16 23:43:38 -07:00
Vijay Pai e5470b9785
Merge pull request #20622 from vjpai/api_misuse
Improve logging on API misuse assert
2019-10-16 15:58:58 -07:00
Vijay Pai d8d157effa Use range-based fors in include/grpcpp 2019-10-16 12:07:42 -07:00
Vijay Pai 6f9fe64626 Improve logging on API misuse assert 2019-10-16 10:44:10 -07:00
Christian Maurer 24f19ae069 c++ remove win32 conversion warning 2019-10-15 15:10:25 +02:00
Yash Tibrewal ed45c8f845 Stronger guarantee on failure of read/write operations 2019-10-10 15:03:46 -07:00
Yash Tibrewal 7fdb49bd3f Doc update - Finish can be called only once 2019-10-03 15:29:30 -07:00
Soheil Hassas Yeganeh a1310498ee Fix the internal build and test failure introduced in #20329 2019-10-02 23:46:08 -04:00
Soheil Hassas Yeganeh 20983f1e0e
Merge pull request #20329 from soheilhy/call-op-str
Avoid creating and copying strings when Status is OK in FinishOp.
2019-10-02 08:36:18 -04:00
Vijay Pai c379323b31
Merge pull request #20302 from chrisse74/master
c++: remove shadowing warnings
2019-09-23 18:32:06 -07:00
Soheil Hassas Yeganeh 184d881b21 Avoid creating and copying strings when Status is OK in FinishOp.
```
BM_PumpStreamClientToServer<InProcess>/0               [polls/iter:0                              ]            1.22µs ± 1%             1.21µs ± 2%  -0.73%        (p=0.002 n=19+19)
BM_PumpStreamClientToServer<InProcess>/8               [polls/iter:0                              ]            1.33µs ± 1%             1.33µs ± 1%  -0.71%        (p=0.000 n=18+18)
BM_PumpStreamClientToServer<InProcess>/134217728       [polls/iter:0                              ]              161ms ± 1%              160ms ± 1%  -0.67%        (p=0.002 n=16+20)
BM_PumpStreamServerToClient<InProcess>/0               [polls/iter:0                              ]            1.22µs ± 1%             1.21µs ± 1%  -1.51%        (p=0.000 n=18+18)
BM_PumpStreamServerToClient<InProcess>/1               [polls/iter:0                              ]            1.32µs ± 1%             1.31µs ± 1%  -0.81%        (p=0.000 n=16+20)
BM_PumpStreamServerToClient<InProcess>/8               [polls/iter:0                              ]            1.33µs ± 1%             1.32µs ± 1%  -0.97%        (p=0.000 n=17+20)
BM_PumpStreamServerToClient<InProcess>/64              [polls/iter:0                              ]            1.36µs ± 1%             1.36µs ± 1%  -0.43%        (p=0.020 n=17+20)
BM_PumpStreamServerToClient<InProcess>/32768           [polls/iter:0                              ]            10.9µs ± 2%             10.8µs ± 2%  -0.71%        (p=0.022 n=18+20)
BM_PumpStreamClientToServer<MinInProcess>/0            [polls/iter:0                              ]            1.21µs ± 1%             1.20µs ± 1%  -0.89%        (p=0.000 n=18+19)
BM_PumpStreamServerToClient<MinInProcess>/0            [polls/iter:0                              ]            1.22µs ± 1%             1.20µs ± 1%  -1.40%        (p=0.000 n=18+19)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/0                                                   [polls/iter:0                              ]            6.48µs ± 5%             6.25µs ± 4%  -3.45%        (p=0.000 n=20+17)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/1/0                                                   [polls/iter:0                              ]            6.60µs ± 6%             6.36µs ± 2%  -3.66%        (p=0.000 n=20+18)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/1                                                   [polls/iter:0                              ]            6.61µs ± 7%             6.37µs ± 3%  -3.59%        (p=0.000 n=20+17)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/1/1                                                   [polls/iter:0                              ]            6.65µs ± 6%             6.48µs ± 3%  -2.57%        (p=0.000 n=20+18)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/8                                                   [polls/iter:0                              ]            6.56µs ± 5%             6.35µs ± 3%  -3.29%        (p=0.000 n=20+18)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/8/8                                                   [polls/iter:0                              ]            6.64µs ± 6%             6.55µs ± 5%  -1.43%        (p=0.050 n=19+19)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/64                                                  [polls/iter:0                              ]            6.64µs ± 6%             6.50µs ± 4%  -2.10%        (p=0.030 n=20+19)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/64/64                                                 [polls/iter:0                              ]            6.72µs ± 4%             6.56µs ± 1%  -2.34%        (p=0.000 n=18+16)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/512/0                                                 [polls/iter:0                              ]            6.69µs ± 2%             6.55µs ± 2%  -2.12%        (p=0.000 n=17+18)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/512                                                 [polls/iter:0                              ]            6.71µs ± 2%             6.55µs ± 2%  -2.39%        (p=0.000 n=17+17)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/512/512                                               [polls/iter:0                              ]            6.97µs ± 3%             6.82µs ± 1%  -2.16%        (p=0.000 n=18+16)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/4096/0                                                [polls/iter:0                              ]            7.74µs ± 1%             7.60µs ± 1%  -1.81%        (p=0.000 n=20+16)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/4096                                                [polls/iter:0                              ]            7.77µs ± 2%             7.63µs ± 2%  -1.74%        (p=0.000 n=18+19)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/4096/4096                                             [polls/iter:0                              ]            8.98µs ± 1%             8.92µs ± 2%  -0.61%        (p=0.028 n=20+19)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/32768/0                                               [polls/iter:0                              ]            15.9µs ± 1%             15.8µs ± 0%  -0.80%        (p=0.000 n=19+15)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/32768                                               [polls/iter:0                              ]            16.3µs ± 1%             16.2µs ± 2%  -0.77%        (p=0.005 n=20+19)
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/0                                              [polls/iter:0                              ]            86.2µs ± 1%             86.1µs ± 0%  -0.18%        (p=0.036 n=19+15)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/0                                                [polls/iter:0                              ]            6.44µs ± 6%             6.28µs ± 6%  -2.50%        (p=0.044 n=20+19)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/1/0                                                [polls/iter:0                              ]            6.62µs ± 5%             6.39µs ± 5%  -3.50%        (p=0.008 n=20+19)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/1/1                                                [polls/iter:0                              ]            6.57µs ± 7%             6.39µs ± 4%  -2.71%        (p=0.001 n=20+16)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/64/0                                               [polls/iter:0                              ]            6.41µs ± 2%             6.35µs ± 6%  -0.84%        (p=0.001 n=18+17)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/512/0                                              [polls/iter:0                              ]            6.60µs ± 3%             6.51µs ± 4%  -1.33%        (p=0.002 n=18+18)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/512                                              [polls/iter:0                              ]            6.62µs ± 2%             6.47µs ± 1%  -2.25%        (p=0.000 n=17+17)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/512/512                                            [polls/iter:0                              ]            6.87µs ± 1%             6.76µs ± 1%  -1.54%        (p=0.000 n=18+17)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/4096/0                                             [polls/iter:0                              ]            7.65µs ± 2%             7.59µs ± 3%  -0.82%        (p=0.006 n=18+18)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/4096                                             [polls/iter:0                              ]            7.66µs ± 1%             7.54µs ± 2%  -1.52%        (p=0.000 n=18+19)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/4096/4096                                          [polls/iter:0                              ]            8.91µs ± 2%             8.80µs ± 1%  -1.20%        (p=0.000 n=18+18)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32768/0                                            [polls/iter:0                              ]            15.8µs ± 0%             15.7µs ± 0%  -0.80%        (p=0.000 n=17+16)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/32768                                            [polls/iter:0                              ]            16.3µs ± 2%             16.1µs ± 1%  -1.21%        (p=0.000 n=20+19)
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32768/32768                                        [polls/iter:0                              ]            25.6µs ± 2%             25.4µs ± 1%  -0.66%        (p=0.002 n=19+18)
BM_UnaryPingPong<InProcess, Client_AddMetadata<RandomBinaryMetadata<31>, 1>, NoOpMutator>/0/0               [polls/iter:0                              ]            7.16µs ± 5%             7.05µs ± 2%  -1.45%        (p=0.012 n=19+19)
BM_UnaryPingPong<InProcess, Client_AddMetadata<RandomBinaryMetadata<100>, 1>, NoOpMutator>/0/0              [polls/iter:0                              ]            7.29µs ± 5%             7.12µs ± 2%  -2.43%        (p=0.001 n=20+19)
BM_UnaryPingPong<InProcess, Client_AddMetadata<RandomBinaryMetadata<10>, 2>, NoOpMutator>/0/0               [polls/iter:0                              ]            7.66µs ± 3%             7.56µs ± 2%  -1.28%        (p=0.001 n=17+17)
BM_UnaryPingPong<InProcess, Client_AddMetadata<RandomBinaryMetadata<31>, 2>, NoOpMutator>/0/0               [polls/iter:0                              ]            7.83µs ± 3%             7.70µs ± 2%  -1.60%        (p=0.000 n=18+19)
BM_UnaryPingPong<InProcess, Client_AddMetadata<RandomBinaryMetadata<100>, 2>, NoOpMutator>/0/0              [polls/iter:0                              ]            7.96µs ± 2%             7.83µs ± 2%  -1.54%        (p=0.000 n=17+19)
BM_UnaryPingPong<InProcess, NoOpMutator, Server_AddInitialMetadata<RandomBinaryMetadata<10>, 1>>/0/0        [polls/iter:0                              ]            7.13µs ± 5%             6.93µs ± 2%  -2.73%        (p=0.000 n=20+19)
BM_UnaryPingPong<InProcess, NoOpMutator, Server_AddInitialMetadata<RandomBinaryMetadata<31>, 1>>/0/0        [polls/iter:0                              ]            7.14µs ± 2%             7.01µs ± 2%  -1.88%        (p=0.000 n=17+19)
BM_UnaryPingPong<InProcess, NoOpMutator, Server_AddInitialMetadata<RandomBinaryMetadata<100>, 1>>/0/0       [polls/iter:0                              ]            7.24µs ± 2%             7.09µs ± 2%  -2.17%        (p=0.000 n=18+20)
BM_UnaryPingPong<InProcess, Client_AddMetadata<RandomAsciiMetadata<10>, 1>, NoOpMutator>/0/0                [polls/iter:0                              ]            6.96µs ± 1%             6.93µs ± 2%  -0.53%        (p=0.004 n=17+18)
BM_UnaryPingPong<InProcess, Client_AddMetadata<RandomAsciiMetadata<31>, 1>, NoOpMutator>/0/0                [polls/iter:0                              ]            7.08µs ± 2%             6.99µs ± 1%  -1.32%        (p=0.000 n=17+19)
BM_UnaryPingPong<InProcess, Client_AddMetadata<RandomAsciiMetadata<100>, 1>, NoOpMutator>/0/0               [polls/iter:0                              ]            7.26µs ± 3%             7.19µs ± 1%  -1.01%        (p=0.000 n=17+20)
BM_UnaryPingPong<InProcess, NoOpMutator, Server_AddInitialMetadata<RandomAsciiMetadata<10>, 1>>/0/0         [polls/iter:0                              ]            7.09µs ± 4%             6.89µs ± 1%  -2.84%        (p=0.000 n=19+19)
BM_UnaryPingPong<InProcess, NoOpMutator, Server_AddInitialMetadata<RandomAsciiMetadata<31>, 1>>/0/0         [polls/iter:0                              ]            7.14µs ± 2%             7.05µs ± 2%  -1.39%        (p=0.000 n=16+19)
BM_UnaryPingPong<InProcess, NoOpMutator, Server_AddInitialMetadata<RandomAsciiMetadata<100>, 1>>/0/0        [polls/iter:0                              ]            7.37µs ± 4%             7.18µs ± 1%  -2.62%        (p=0.000 n=18+18)
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/0/0                                                         [polls/iter:3.00009                        ]            23.6µs ± 0%             23.5µs ± 0%  -0.47%          (p=0.024 n=6+3)
BM_UnaryPingPong<UDS, NoOpMutator, NoOpMutator>/0/0                                                         [polls/iter:3.00012                        ]            20.7µs ± 1%             20.4µs ± 0%  -1.50%          (p=0.029 n=4+4)
BM_UnaryPingPong<MinUDS, NoOpMutator, NoOpMutator>/0/0                                                      [polls/iter:3.00017                        ]            19.9µs ± 1%             19.7µs ± 1%  -1.22%          (p=0.029 n=4+4)
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/1/2                                           [polls/iter:12.0001                        ]             62.2µs ± 2%             61.2µs ± 1%  -1.54%          (p=0.029 n=9+5)
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/64/2                                          [polls/iter:12.0001                        ]             64.6µs ± 1%             63.1µs ± 0%  -2.28%          (p=0.003 n=7+5)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/0/0                                     [polls/iter:0                              ]             5.71µs ± 1%             5.65µs ± 1%  -1.00%        (p=0.000 n=19+18)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/0/1                                     [polls/iter:0                              ]             8.46µs ± 1%             8.39µs ± 1%  -0.82%        (p=0.000 n=19+19)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/0/2                                     [polls/iter:0                              ]             11.1µs ± 1%             11.0µs ± 1%  -0.42%        (p=0.013 n=20+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/1/1                                     [polls/iter:0                              ]             8.72µs ± 1%             8.66µs ± 1%  -0.80%        (p=0.000 n=20+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/1/2                                     [polls/iter:0                              ]             11.6µs ± 1%             11.5µs ± 1%  -0.37%        (p=0.012 n=20+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/8/1                                     [polls/iter:0                              ]             8.72µs ± 1%             8.66µs ± 1%  -0.64%        (p=0.000 n=19+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/64/1                                    [polls/iter:0                              ]             8.86µs ± 1%             8.82µs ± 1%  -0.47%        (p=0.000 n=20+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/64/2                                    [polls/iter:0                              ]             11.8µs ± 1%             11.7µs ± 1%  -0.49%        (p=0.000 n=19+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/512/1                                   [polls/iter:0                              ]             9.14µs ± 1%             9.08µs ± 0%  -0.65%        (p=0.000 n=20+16)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/512/2                                   [polls/iter:0                              ]             12.3µs ± 0%             12.3µs ± 1%  -0.43%        (p=0.000 n=19+19)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/4096/1                                  [polls/iter:0                              ]             11.2µs ± 1%             11.1µs ± 1%  -0.60%        (p=0.000 n=19+20)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/1                                [polls/iter:0                              ]              169µs ± 1%              171µs ± 2%  +0.98%        (p=0.000 n=20+19)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/2                                [polls/iter:0                              ]              329µs ± 1%              331µs ± 2%  +0.66%        (p=0.007 n=18+19)
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/2097152/1                               [polls/iter:0                              ]              2.08ms ±10%             2.14ms ± 1%  +3.13%        (p=0.043 n=20+15)
BM_StreamingPingPongMsgs<TCP, NoOpMutator, NoOpMutator>/8                                         [polls/iter:4.00007                        ]             16.4µs ± 2%             16.1µs ± 0%  -2.00%          (p=0.036 n=5+3)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/0                                   [polls/iter:0                              ]             2.45µs ± 1%             2.44µs ± 1%  -0.60%        (p=0.006 n=20+20)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/1                                   [polls/iter:0                              ]             2.65µs ± 1%             2.67µs ± 1%  +0.75%        (p=0.000 n=20+20)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/8                                   [polls/iter:0                              ]             2.65µs ± 1%             2.67µs ± 1%  +0.85%        (p=0.000 n=20+20)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/512                                 [polls/iter:0                              ]             2.96µs ± 1%             2.98µs ± 1%  +0.52%        (p=0.009 n=20+20)
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/4096                                [polls/iter:0                              ]             4.83µs ± 2%             4.88µs ± 4%  +1.19%        (p=0.005 n=19+20)
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/512/2                                      [polls/iter:12.0001                        ]             64.2µs ± 1%             63.4µs ± 1%  -1.36%          (p=0.017 n=5+6)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/0                                  [polls/iter:0                              ]             5.71µs ± 1%             5.63µs ± 1%  -1.51%        (p=0.000 n=18+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/1                                  [polls/iter:0                              ]             8.43µs ± 1%             8.34µs ± 1%  -1.10%        (p=0.000 n=20+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/2                                  [polls/iter:0                              ]             11.0µs ± 1%             11.0µs ± 0%  -0.57%        (p=0.000 n=19+15)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/1/1                                  [polls/iter:0                              ]             8.68µs ± 1%             8.59µs ± 1%  -1.07%        (p=0.000 n=17+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/1/2                                  [polls/iter:0                              ]             11.5µs ± 1%             11.4µs ± 1%  -0.34%        (p=0.002 n=19+19)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/8/1                                  [polls/iter:0                              ]             8.71µs ± 1%             8.59µs ± 1%  -1.47%        (p=0.000 n=20+18)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/64/1                                 [polls/iter:0                              ]             8.82µs ± 1%             8.76µs ± 1%  -0.75%        (p=0.000 n=20+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/64/2                                 [polls/iter:0                              ]             11.7µs ± 1%             11.7µs ± 1%  -0.48%        (p=0.000 n=20+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/512/1                                [polls/iter:0                              ]             9.13µs ± 1%             9.04µs ± 1%  -0.96%        (p=0.000 n=20+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/4096/1                               [polls/iter:0                              ]             11.1µs ± 1%             11.0µs ± 1%  -0.67%        (p=0.002 n=19+20)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32768/1                              [polls/iter:0                              ]             28.1µs ± 1%             28.0µs ± 1%  -0.54%        (p=0.016 n=19+18)
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/16777216/2                           [polls/iter:0                              ]              64.1ms ± 5%             65.2ms ± 4%  +1.66%        (p=0.020 n=19+19)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/0                                [polls/iter:0                              ]             2.43µs ± 1%             2.42µs ± 1%  -0.50%        (p=0.000 n=19+18)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/1                                [polls/iter:0                              ]             2.62µs ± 1%             2.64µs ± 0%  +0.55%        (p=0.000 n=20+18)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/8                                [polls/iter:0                              ]             2.62µs ± 1%             2.64µs ± 1%  +0.64%        (p=0.000 n=20+19)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/64                               [polls/iter:0                              ]             2.71µs ± 1%             2.71µs ± 1%  -0.32%        (p=0.015 n=19+19)
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/512                              [polls/iter:0                              ]             2.94µs ± 1%             2.95µs ± 1%  +0.32%        (p=0.024 n=20+19)
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/1/0    [polls/iter:5.75 writes/iter:10            ]               419ms ± 0%              417ms ± 1%  -0.55%          (p=0.030 n=5+7)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/0/0/0                  [polls/iter:0                              ]             5.36µs ± 1%             5.27µs ± 1%  -1.80%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/0/0/1                  [polls/iter:0                              ]             5.36µs ± 1%             5.28µs ± 1%  -1.51%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/0/1/0                  [polls/iter:0                              ]             7.65µs ± 1%             7.59µs ± 1%  -0.76%        (p=0.000 n=17+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/0/2/0                  [polls/iter:0                              ]             10.4µs ± 1%             10.3µs ± 1%  -0.44%        (p=0.021 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/0/1/1                  [polls/iter:0                              ]             7.22µs ± 2%             7.12µs ± 1%  -1.36%        (p=0.000 n=18+18)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/1/1/0                  [polls/iter:0                              ]             7.91µs ± 1%             7.84µs ± 1%  -0.96%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/1/2/0                  [polls/iter:0                              ]             10.8µs ± 1%             10.8µs ± 1%  -0.44%        (p=0.008 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/1/1/1                  [polls/iter:0                              ]             7.48µs ± 2%             7.36µs ± 1%  -1.65%        (p=0.000 n=18+18)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/1/2/1                  [polls/iter:0                              ]             10.4µs ± 1%             10.3µs ± 1%  -0.50%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/8/1/0                  [polls/iter:0                              ]             7.89µs ± 1%             7.84µs ± 1%  -0.58%        (p=0.000 n=19+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/8/1/1                  [polls/iter:0                              ]             7.47µs ± 1%             7.40µs ± 1%  -0.94%        (p=0.000 n=18+18)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/64/2/0                 [polls/iter:0                              ]             11.0µs ± 1%             10.9µs ± 1%  -0.31%        (p=0.034 n=19+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/64/1/1                 [polls/iter:0                              ]             7.77µs ± 7%             7.49µs ± 1%  -3.67%        (p=0.000 n=20+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/64/2/1                 [polls/iter:0                              ]             10.6µs ± 1%             10.6µs ± 1%  -0.45%        (p=0.001 n=19+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/512/1/0                [polls/iter:0                              ]             8.30µs ± 1%             8.26µs ± 1%  -0.50%        (p=0.002 n=19+18)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/512/1/1                [polls/iter:0                              ]             7.87µs ± 1%             7.76µs ± 1%  -1.36%        (p=0.000 n=19+18)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/512/2/1                [polls/iter:0                              ]             11.1µs ± 1%             11.1µs ± 1%  -0.38%        (p=0.013 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/4096/1/0               [polls/iter:0                              ]             10.4µs ± 2%             10.3µs ± 2%  -0.85%        (p=0.009 n=20+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/4096/2/0               [polls/iter:0                              ]             15.5µs ± 2%             15.4µs ± 2%  -0.65%        (p=0.033 n=20+20)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/4096/1/1               [polls/iter:0                              ]             10.0µs ± 1%              9.8µs ± 2%  -1.54%        (p=0.000 n=20+19)
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/4096/2/1               [polls/iter:0                              ]             15.1µs ± 2%             15.0µs ± 2%  -0.56%        (p=0.049 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/0/0/0               [polls/iter:0                              ]             5.27µs ± 1%             5.18µs ± 1%  -1.64%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/0/0/1               [polls/iter:0                              ]             5.27µs ± 1%             5.19µs ± 1%  -1.52%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/0/1/0               [polls/iter:0                              ]             7.58µs ± 1%             7.49µs ± 1%  -1.17%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/0/2/0               [polls/iter:0                              ]             10.2µs ± 1%             10.1µs ± 1%  -0.97%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/0/1/1               [polls/iter:0                              ]             7.16µs ± 1%             7.11µs ± 3%  -0.67%        (p=0.011 n=19+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/0/2/1               [polls/iter:0                              ]             9.81µs ± 1%             9.76µs ± 1%  -0.56%        (p=0.001 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/1/1/0               [polls/iter:0                              ]             7.82µs ± 1%             7.72µs ± 1%  -1.31%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/1/2/0               [polls/iter:0                              ]             10.7µs ± 1%             10.6µs ± 1%  -0.82%        (p=0.000 n=19+19)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/1/1/1               [polls/iter:0                              ]             7.38µs ± 1%             7.28µs ± 1%  -1.26%        (p=0.000 n=18+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/1/2/1               [polls/iter:0                              ]             10.3µs ± 1%             10.2µs ± 1%  -0.57%        (p=0.000 n=19+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/8/1/0               [polls/iter:0                              ]             7.81µs ± 1%             7.74µs ± 1%  -0.90%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/8/2/0               [polls/iter:0                              ]             10.6µs ± 1%             10.6µs ± 1%  -0.50%        (p=0.001 n=18+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/8/1/1               [polls/iter:0                              ]             7.42µs ± 1%             7.32µs ± 1%  -1.24%        (p=0.000 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/8/2/1               [polls/iter:0                              ]             10.3µs ± 1%             10.2µs ± 1%  -0.45%        (p=0.002 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/64/1/0              [polls/iter:0                              ]             7.93µs ± 1%             7.84µs ± 0%  -1.20%        (p=0.000 n=19+18)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/64/2/0              [polls/iter:0                              ]             10.9µs ± 1%             10.8µs ± 1%  -0.60%        (p=0.000 n=18+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/64/1/1              [polls/iter:0                              ]             7.56µs ± 3%             7.43µs ± 1%  -1.64%        (p=0.000 n=19+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/64/2/1              [polls/iter:0                              ]             10.5µs ± 1%             10.5µs ± 1%  -0.64%        (p=0.000 n=20+19)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/512/1/0             [polls/iter:0                              ]             8.24µs ± 1%             8.14µs ± 1%  -1.18%        (p=0.000 n=19+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/512/2/0             [polls/iter:0                              ]             11.4µs ± 2%             11.4µs ± 1%  -0.54%        (p=0.003 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/512/1/1             [polls/iter:0                              ]             7.84µs ± 2%             7.73µs ± 1%  -1.42%        (p=0.000 n=19+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/512/2/1             [polls/iter:0                              ]             11.0µs ± 1%             11.0µs ± 1%  -0.39%        (p=0.004 n=19+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/4096/1/0            [polls/iter:0                              ]             10.3µs ± 1%             10.2µs ± 2%  -0.74%        (p=0.002 n=18+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/4096/2/0            [polls/iter:0                              ]             15.3µs ± 2%             15.3µs ± 2%  -0.59%        (p=0.035 n=20+20)
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/4096/1/1            [polls/iter:0                              ]             9.92µs ± 2%             9.71µs ± 1%  -2.12%        (p=0.000 n=20+20)
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/8/2                                           [polls/iter:12.0001                        ]             62.2µs ± 2%             61.2µs ± 0%  -1.65%          (p=0.002 n=8+5)
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/512/2                                         [polls/iter:12.0001                        ]             65.5µs ± 2%             64.7µs ± 3%  -1.13%          (p=0.045 n=8+5)
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/262144/1                                      [polls/iter:8.00022                        ]              325µs ± 1%              321µs ± 0%  -1.21%          (p=0.036 n=5+3)
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/1/2                                        [polls/iter:12.0001                        ]             61.3µs ± 2%             60.1µs ± 1%  -2.01%          (p=0.008 n=7+6)
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/0/2                                           [polls/iter:12                             ]             61.1µs ± 1%             59.9µs ± 1%  -1.95%          (p=0.016 n=5+5)
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/64/2                                       [polls/iter:12.0001                        ]             63.5µs ± 1%             62.4µs ± 1%  -1.75%          (p=0.008 n=6+8)
BM_StreamingPingPongWithCoalescingApi<InProcessCHTTP2, NoOpMutator, NoOpMutator>/134217728/1/1    [polls/iter:5.75 writes/iter:10.25         ]               414ms ± 1%              419ms ± 0%  +1.29%          (p=0.033 n=7+3)
BM_StreamingPingPong<TCP, NoOpMutator, NoOpMutator>/512/2                                         [polls/iter:12.0002                        ]             65.6µs ± 2%             64.6µs ± 1%  -1.52%          (p=0.043 n=6+8)
BM_StreamingPingPongMsgs<TCP, NoOpMutator, NoOpMutator>/32768                                     [polls/iter:4.00009                        ]             42.8µs ± 1%             42.3µs ± 0%  -1.15%          (p=0.048 n=6+3)
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/64/2                                       [polls/iter:12.0002                        ]             63.6µs ± 1%             62.4µs ± 1%  -1.86%          (p=0.032 n=4+5)
BM_StreamingPingPong<MinTCP, NoOpMutator, NoOpMutator>/4096/2                                     [polls/iter:12.0002                        ]             69.1µs ± 1%             68.4µs ± 0%  -0.97%          (p=0.036 n=5+3)
```
2019-09-22 01:36:54 -04:00
Joshua Haberman cf857cb063 Removed custom int64 typedef in favor of int64_t.
ByteCount() now returns int64_t in all configurations
so there is no longer any need for typedef indirection here.
2019-09-20 09:35:53 -07:00
Christian Maurer 738b199f62 Removing shadowing-warnings. PayloadAsyncRequest inherits these fields from BaseAsyncRequest. 2019-09-19 14:57:28 +02:00
Yash Tibrewal a4cf948b2f Experimental method to get a debugging only view into credentials 2019-09-12 12:31:29 -07:00
Karthik Ravi Shankar 939830aa15
Merge pull request #20030 from karthikravis/move-method-handler
Make MethodHandler and related interfaces generic
2019-09-10 21:45:08 -07:00
Arjun Roy a979ad4b0b
Merge pull request #20210 from arjunroy/arena_squish_unary_callback
Coalesced arena allocs in callback unary C++ code.
2019-09-10 21:20:08 -07:00
Arjun Roy db861a2546 Coalesced arena allocs in callback unary C++ code. 2019-09-10 15:19:04 -07:00
Karthik Ravi Shankar 7ec1a9663d Merge branch 'master' into move-method-handler 2019-09-06 12:21:29 -07:00
Yash Tibrewal 97f1f57dab Allow call credentials to be set even after the call is created but before initial metadata is sent 2019-09-05 18:13:59 -07:00
Vijay Pai 1a2129980c
Merge pull request #19647 from pszemus/master
Fixed "implicitly-declared operator= is deprecated" error from gcc 9
2019-09-05 10:08:18 -07:00
Karthik Ravi Shankar db7365753e Fix the compile error due to ByteBuffer in method_handler_impl.h 2019-09-03 16:08:48 -07:00
Karthik Ravi Shankar a1c0d3442f Merge branch 'master' into move-method-handler 2019-09-03 14:47:45 -07:00
hcaseyal 311bf04ec9
Merge pull request #19788 from chrisse74/master
remove all unused-parameter warnings in C++
2019-09-03 13:58:13 -07:00
Karthik Ravi Shankar 29bb3ef973 Remove redundant MethodHandler friend declarations 2019-08-28 14:01:48 -07:00
Karthik Ravi Shankar 28b0671235 Make MethodHandler and related interfaces generic 2019-08-21 16:12:48 -07:00
yang-g fd106bf1ac Add accessor declaration for ClientContext 2019-08-14 12:38:59 -07:00
Soheil Hassas Yeganeh eadd5ea110 Directly use the ZeroCopyInputStream for grpc::GenericDeserialize.
There is no need to use CodedInputStream, wrapping a
ZeroCopyInputStream.

Suggested by: Gerben Stavenga
2019-08-12 22:44:56 -04:00
Yash Tibrewal 01ec829945 Mark private methods of DelegatingChannel final (other than WaitForStateChangeImpl and NotifyOnStateChangeImpl) 2019-08-01 16:25:11 -07:00
Yash Tibrewal 3653439ba6 Merge master and move to experimental 2019-08-01 16:15:31 -07:00
Christian Maurer 46dddacdf3 remove all unused-parameter warnings 2019-07-30 13:10:53 +02:00
Arjun Roy b47d22f7f2 Mark assert failure path as unlikely in codegen.
Also, change an assert to debug assert in callback cpp.
2019-07-18 12:52:18 -07:00
Przemysław Sobala 9e65a88762 Fixed "implicitly-declared operator=" error from gcc 9 2019-07-15 16:11:35 +02:00
Moiz Haidry d8c0182360 Expose some of the internal codegen interfaces 2019-07-02 12:32:14 -07:00
Moiz Haidry bf994e48d9 Move grpc async, callback and sync implementation to grpc_impl namespace 2019-07-01 14:05:54 -07:00
Karthik Ravi Shankar d33c02748f Merge branch 'master' into continue-migration-to-impl 2019-06-26 09:29:36 -07:00
Karthik Ravi Shankar 8b91dc5fd2 Move more of usage to grpc_impl
1) Create server_context_impl and completion_queue_impl headers.
2) Move more of usage of ClientContext, ServerContext to grpc_impl
2019-06-22 17:17:29 -07:00
Moiz Haidry fbd5957ee8 Sanity and build fixes 2019-06-21 12:28:55 -07:00
Moiz Haidry 3ce20819cf Modify codegen to use grpc_impl namespace and other cleanups 2019-06-21 10:51:57 -07:00
Yang Gao ea63190498
Merge pull request #19371 from yang-g/virtual_me
Add comments and rename internal methods
2019-06-19 12:25:05 -07:00
yang-g 7b0ee41fd5 Resolve comment 2019-06-19 10:28:35 -07:00
yang-g 7db36fe0a0 Add comments and rename internal methods 2019-06-17 11:18:03 -07:00
Soheil Hassas Yeganeh 85f08100d4 Avoid using seq_cst atomic operations in grpcpp when unnecessary.
These cases are almost all in the callback API.

Also use atomic<intptr_t> insteda of atomic_int for consistency with
gpr_atm and grpc_core::Atomic.
2019-06-16 16:09:24 -04:00
Yang Gao 0bee8c41f9
Merge pull request #19348 from yang-g/virtual_me
Mark some methods virtual
2019-06-14 10:15:11 -07:00
yang-g b216c34314 Mark some methods virtual 2019-06-13 22:15:53 -07:00
yang-g a0f5cb4528 Fix assignment operator 2019-06-13 22:08:09 -07:00
Yash Tibrewal 90f1c32b85 Sanity checks and return value 2019-06-13 12:29:48 -07:00
Moiz Haidry 186875337c Sync with master 2019-06-11 16:16:27 -07:00
Yash Tibrewal 94e7edad99 Add Delegating Channel 2019-06-11 15:07:12 -07:00
Karthik Ravi Shankar e4b992ee48 Merge branch 'master' into migrate-client-context 2019-06-10 14:01:28 -07:00
Karthik Ravi Shankar 52291e5832 Fix PropogationOptions 2019-06-10 13:58:34 -07:00
Yash Tibrewal cb2143406f
Merge pull request #19188 from yashykt/interceptiondocs
Doc Change - Add hijacking interception hook points as valid for the GetRecv* functions
2019-06-06 11:42:20 -07:00
Karthik Ravi Shankar 7e18e6cf3f Fix clang errors. 2019-06-05 16:47:29 -07:00
Karthik Ravi Shankar 522ddfe273 Move ClientContext to grpc_impl
ClientContext is another file which needs to be moved from grpc to
grpc_impl for referencing it.
2019-06-05 16:31:39 -07:00
Moiz Haidry 226e63dd0c Move server context implementation to grpc_impl namespace and typedef the ref to it 2019-06-05 10:41:30 -07:00
Yash Tibrewal f671b3d136 Add hijacking interception hook points as valid for the GetRecv* functions 2019-05-30 15:39:37 -07:00
Yash Tibrewal e260de873c Merge branch 'master' into interceptionfix 2019-05-24 17:03:11 -07:00
Yash Tibrewal c58b4a3964 Clang format 2019-05-24 17:00:54 -07:00
Yash Tibrewal 67bdbbdf6f Fix a bug where POST_RECV_MESSAGE is not being triggered 2019-05-24 16:58:56 -07:00
Karthik Ravi Shankar 088319bc40 IWYU in core_codegen_interface
core_codegen_interface requires ByteBuffer in generated code and needs
to include byte_buffer.h

NO_BUG=Cleanup
2019-05-23 22:10:53 -07:00
Juanli Shen 0cafd4110a Fix typo 2019-05-23 11:12:08 -07:00
Karthik Ravi Shankar dc9897dfe3
Merge pull request #19067 from karthikravis/channel-cq-scq-impl
Fold Channel and CompletionQueue into grpc_impl
2019-05-22 16:10:58 -07:00
kwasimensah cd0e02ae1c
Fixing formatting 2019-05-21 02:29:00 -04:00
kwasimensah 3ec0967c1e
Fix typo for using MessageLite 2019-05-21 01:52:36 -04:00
kwasimensah 51a2280029
Add MessageLite overloads to proto serialization 2019-05-21 01:29:47 -04:00
kwasimensah 12ffbb8a83
Add MessageLite type to grpc's config 2019-05-21 01:27:59 -04:00
Yang Gao c4cb6e1787
Merge pull request #19016 from yang-g/message_allocator
Update the message allocator API
2019-05-20 08:49:14 -07:00
yang-g 6215ccb587 resolve comments 2019-05-17 16:22:43 -07:00
Karthik Ravi Shankar 03b079499c Move CompletionQueue and Channel 2019-05-17 09:16:32 -07:00
Karthik Ravi Shankar 40210d3b8a Move Channel to grpc_impl 2019-05-17 09:12:33 -07:00
yang-g 7c5bfbbb32 Resolve comments 2019-05-16 09:19:44 -07:00
yang-g 51210ba922 Update the message allocator API 2019-05-16 09:19:44 -07:00
yang-g c639da7a1d Merge branch 'master' of https://github.com/grpc/grpc into port_sharing 2019-05-16 09:07:55 -07:00
Karthik Ravi Shankar 3996599392 Fix clang script errors 2019-05-15 14:30:33 -07:00
Karthik Ravi Shankar 772a74aced Revert changes to Channel 2019-05-15 14:24:17 -07:00
Karthik Ravi Shankar 6be0b06c69
Revert "Fold CompletionQueue and ServerCompletionQueue into grpc_impl" 2019-05-15 13:38:34 -07:00
yang-g de57783beb Merge with head and resolve conflict 2019-05-13 08:56:02 -07:00
Karthik Ravi Shankar af32f6ce2e Merge branch 'master' into grpc_namespace_completion_queue 2019-05-09 14:12:52 -07:00
Karthik Ravi Shankar 476f7cd81f
Merge pull request #18730 from karthikravis/grpc_namespace_channel_new
Fold Channel into grpc_impl from grpc namespace
2019-05-09 14:09:21 -07:00
yang-g 218e290074 Merge with head and resolve conflict 2019-05-07 22:46:45 -07:00
yang-g 898fc0da1e More fixes 2019-05-07 22:45:39 -07:00
sanjaypujare f3937f0e55
Merge pull request #18761 from jadekler/update_codes
docs: add note about retrying UNAVAILABLE
2019-05-04 20:23:20 -07:00
yang-g abd97b9170 Merge with head and resolve conflict 2019-04-30 23:01:01 -07:00
Karthik Ravi Shankar 5de22c4bd4 Merge branch 'master' into grpc_namespace_completion_queue 2019-04-30 17:46:33 -07:00
Karthik Ravi Shankar baef4b1d60 Merge branch 'master' into grpc_namespace_channel_new 2019-04-30 17:39:48 -07:00
Karthik Ravi Shankar 549230467b
Merge pull request #18720 from grpc/revert-18717-grpc_namespace_server_revert
Revert "Revert "Merge pull request #18458 from grpc/grpc_namespace_server""
2019-04-30 17:30:29 -07:00
Karthik Ravi Shankar 9eec789a4d Merge branch 'grpc_namespace_channel_new' into grpc_namespace_completion_queue 2019-04-30 15:51:49 -07:00
Karthik Ravi Shankar e3a0c85960 Merge branch 'master' into grpc_namespace_channel_new 2019-04-30 14:30:03 -07:00
hcaseyal e3c80dc35f
Merge pull request #18870 from hcaseyal/callback_stub_doc
Add clarification to callback API documentation
2019-04-30 14:20:37 -07:00
yang-g ac3a91edf8 Support accepting external connections. 2019-04-30 12:31:34 -07:00
Karthik Ravi Shankar 5f6a57a4d0 Formatting issues 2019-04-26 13:08:25 -07:00
Hope Casey-Allen 3433749d1b Add clarification to callback API documentation 2019-04-24 16:37:19 -07:00
Karthik Ravi Shankar 38ffd8ca84 Merge branch 'master' into grpc_namespace_credentials 2019-04-23 18:22:09 -07:00
Karthik Ravi Shankar c8a6841dfc Merge branch 'master' into revert-18717-grpc_namespace_server_revert 2019-04-23 18:14:02 -07:00
Yang Gao 5170c613cc
Merge pull request #18784 from yang-g/message_allocator
Message allocator support for callback unary
2019-04-23 15:49:49 -07:00
Karthik Ravi Shankar 60bdeef9f4 Move Channel also to impl for now 2019-04-23 14:03:06 -07:00
Karthik Ravi Shankar 603d014f0e Changes to fold credentials into grpc_impl from grpc 2019-04-23 13:54:26 -07:00
yang-g 39cfbf9d4a cast and default initializer 2019-04-23 13:00:09 -07:00
yang-g 41824319fa Resolve review comments 2019-04-23 08:54:36 -07:00
Vijay Pai 1a4f5e8ade
Fix typo in comment
It's a ServerWriteReactor
2019-04-22 11:29:16 -07:00
Vijay Pai 20c08dbc7a Add client-side unary reactor model 2019-04-19 16:10:08 -07:00
Jan Tattermusch 0939376a17
Merge pull request #18769 from SataQiu/fix-20190416
Fix spelling errors of include/*
2019-04-18 09:52:37 +02:00
Soheil Hassas Yeganeh 1c186784cd Make sure grpc::internal::Mutex has enough space for gpr_mu, std::mutex, and pthread_mutex_t. 2019-04-17 14:35:34 -04:00
Soheil Hassas Yeganeh 2b9448a71c Revert "Revert "Introduce C++ wrappers for gpr_mu and gpr_cv.""
This reverts commit d09c9f8e20.
2019-04-17 14:35:29 -04:00
yang-g 051d421579 Resolve sanity 2019-04-17 08:57:48 -07:00
yang-g 6929cdd654 initial 2019-04-16 15:43:58 -07:00
SataQiu b416019f72 fix spelling errors of include/* 2019-04-16 11:45:42 +08:00
Jean de Klerk a19d8dcfb5 docs: add note about retrying UNAVAILABLE
release note: no
2019-04-15 12:45:27 -06:00
Jan Tattermusch 1d9e442b4d
Merge pull request #18707 from SataQiu/fix-repeated-words
Clean up repeated words
2019-04-15 13:37:09 +02:00
Alexander Polcyn d09c9f8e20 Revert "Introduce C++ wrappers for gpr_mu and gpr_cv."
This reverts commit a26c09dd25.
2019-04-11 16:52:54 -07:00
Karthik Ravi Shankar 00f736adda Remove unecessary file 2019-04-11 15:46:08 -07:00
Karthik Ravi Shankar 62fb156122 Fold CompletionQueue and ServerCompletionQueue into grpc_impl 2019-04-11 13:16:32 -07:00
Karthik Ravi Shankar 2554f122c1 Remove unecessary files 2019-04-11 12:06:41 -07:00
Karthik Ravi Shankar 973fa6950e Fold Channel into grpc_impl from grpc namespace 2019-04-11 12:04:23 -07:00
Vijay Pai ea59977fbc
Merge pull request #18687 from vjpai/cancel_order
C++ Callback API: Make sure that OnCancel happens after OnStarted
2019-04-10 16:15:43 -07:00
Karthik Ravi Shankar 2e88231fc0
Revert "Revert "Merge pull request #18458 from grpc/grpc_namespace_server"" 2019-04-10 15:04:05 -07:00
Soheil Hassas Yeganeh e85dd2e644 Fix build errors 2019-04-10 14:15:28 -07:00
Karthik Ravi Shankar f03b309787 Revert "Merge pull request #18458 from grpc/grpc_namespace_server"
This reverts commit dc1089a6d1, reversing
changes made to 31843787cc.

This change also includes - Revert "Merge pull request #17932 from soheilhy/gprpp-mutex"

This reverts commit df4b6a763d, reversing
changes made to dc1089a6d1.
2019-04-10 13:54:05 -07:00
Karthik Ravi Shankar dad3f34207
Revert "Revert "Revert "Folding the Channel class into the grpc_impl namespace.""" 2019-04-10 12:14:04 -07:00
Vijay Pai 41c6cba9f5 Make sure that OnCancel happens after OnStarted 2019-04-10 11:32:34 -07:00
Karthik Ravi Shankar 891b6cf7ae
Revert "Folding CompletionQueue and ServerCompletionQueue." 2019-04-10 10:22:59 -07:00
SataQiu 44f92cdd17 clean up repeated words 2019-04-10 16:25:25 +08:00
Karthik Ravi Shankar d2b2f7f5a3 Merge branch 'master' into completion-queue-fold 2019-04-09 13:44:33 -07:00
Karthik Ravi Shankar 918cb46011
Merge pull request #18198 from grpc/revert-18076-revert-17797-channel
Revert "Revert "Folding the Channel class into the grpc_impl namespace.""
2019-04-09 13:34:02 -07:00
hcaseyal ca11dfb349
Merge pull request #18686 from hcaseyal/callback_doc
Update callback API documentation
2019-04-09 12:45:06 -07:00
Karthik Ravi Shankar 506ca7fc36 Fix clang script errors 2019-04-09 11:51:39 -07:00
Karthik Ravi Shankar b84d3db762 Fix build after merge from master 2019-04-09 11:11:09 -07:00
Karthik Ravi Shankar afd602ccba Merge branch 'master' into completion-queue-fold 2019-04-09 10:46:03 -07:00
Karthik Ravi Shankar 5a08d2aae7 Merge branch 'master' into revert-18076-revert-17797-channel 2019-04-09 08:22:37 -07:00
Karthik Ravi Shankar 53c5bf5ced Merge branch 'master' into revert-18076-revert-17797-channel 2019-04-08 16:04:24 -07:00
Soheil Hassas Yeganeh a26c09dd25 Introduce C++ wrappers for gpr_mu and gpr_cv.
Introduce RAII wrappers in the grpc::internal and grpc_core
namespaces, and use them in place of std::mutex and
std::condition_variable.

Note that, since std::mutex is also used by the public
C++ headers we cannot introduce these wrappers in grpc_core.

Also, note that in grpcpp we cannot use gRPC core and vice versa.
So we had to duplicate the code, once using core_codegen_interface
and once using direct calls.
2019-04-08 18:27:07 -04:00
Karthik Ravi Shankar 4cb0d0d6b1 Fix errors from clang scripts 2019-04-08 13:41:19 -07:00
Karthik Ravi Shankar 9875fabdd4 Merge branch 'master' into revert-18076-revert-17797-channel 2019-04-08 12:55:07 -07:00
Karthik Ravi Shankar 958f373d32 Merge branch 'master' into grpc_namespace_server 2019-04-08 12:42:37 -07:00
Hope Casey-Allen b86e70592e Format 2019-04-08 10:13:17 -07:00
Hope Casey-Allen cee3292cdf Update callback API documentation 2019-04-08 09:11:04 -07:00
Karthik Ravi Shankar c50dd23ea7 Merge branch 'master' into grpc_namespace_server 2019-04-04 15:56:09 -07:00
Karthik Ravi Shankar dd39f78e3f Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder 2019-04-04 15:45:42 -07:00
Karthik Ravi Shankar 8a2807c2a6 Merge branch 'master' into grpc_namespace_server 2019-04-03 12:46:41 -07:00
Karthik Ravi Shankar f0d82d57e2 Merge branch 'master' into grpc_namespace_server_credentials 2019-04-01 13:59:12 -07:00
Karthik Ravi Shankar 29c0aacfc0 Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder 2019-03-29 08:24:54 -07:00
Vijay Pai 847b0155d9 Promise to call OnStarted and forbid Start* until after OnStarted 2019-03-27 16:30:07 -07:00
Karthik Ravi Shankar dc3a715be4 Fix clang format code errors. 2019-03-27 14:33:58 -07:00
Karthik Ravi Shankar c399349dad Merge branch 'master' into grpc_namespace_server 2019-03-27 14:32:10 -07:00
Karthik Ravi Shankar 7068560b2b Merge branch 'master' into grpc_namespace_server_credentials 2019-03-27 14:18:42 -07:00
Karthik Ravi Shankar 0f078898d5 Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder 2019-03-27 12:50:49 -07:00
Vijay Pai abb991be25 Further clarify some APIs by removing their comments from internal:: 2019-03-27 09:46:08 -07:00
Vijay Pai 9169159f30 Comments for all callback API methods 2019-03-26 23:33:23 -07:00
Karthik Ravi Shankar 996da58667
Revert "Revert "Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder"" 2019-03-26 08:04:32 -07:00
Karthik Ravi Shankar e4bb7cb8bb
Revert "Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder" 2019-03-25 19:57:17 -07:00
Vijay Pai f4fdd829d7
Merge pull request #17892 from RohanTalip/HandlerParameter-doc
Renamed the param in the documentation for HandleParameter to match the actual parameter.
2019-03-25 16:46:17 -07:00
Karthik Ravi Shankar 88fc2a6a52
Merge pull request #18242 from grpc/grpc_namespace_serverbuilder
Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder
2019-03-25 15:59:01 -07:00
Soheil Hassas Yeganeh ad1b3e5094 Introduce grpc_byte_buffer_reader_peek and use it for Protobuf parsing.
grpc_byte_buffer_reader_next() copies and references the slice. This
is not always necessary since the caller will not use the slice
after destroying the byte buffer.

A prominent example is the protobuf parser, which
calls grpc_byte_buffer_reader_next() and immediately unrefs the slice
after the call. This ref() and unref() calls can be very expensive
in the hot path.

This commit introduces grpc_byte_buffer_reader_peek() which
essentialy return a pointer to the slice in the buffer, i.e.,
no copies, and no refs.

QPS of 1MiB 1 Channel callback benchmark increases by 5%.
More importantly insructions per cycle is increased by 10%.

Also add tests and benchmarks for byte_buffer_reader_peek()

This commit reaplies 509e77a5a3
2019-03-21 06:03:45 -04:00
Vijay Pai 50576179f8
Merge pull request #17978 from yashykt/interceptorcleanup1
Global Interceptor Registration allowed only once
2019-03-20 19:13:55 -07:00
Karthik Ravi Shankar 04af168cf8 Move Server into grpc_impl from grpc 2019-03-20 13:05:36 -07:00
Karthik Ravi Shankar 54171e276f Fold server credentials from grpc to grpc_impl namespace 2019-03-20 10:00:34 -07:00
Vijay Pai 7b3a120295 Address reviewer comments 2019-03-18 16:51:15 -07:00
Vijay Pai 93f0a3f653 Address reviewer comments 2019-03-18 15:37:35 -07:00
Vijay Pai 04a6b8467c Support callback on cancellation of server-side unary RPCs 2019-03-18 12:00:57 -07:00
Karthik Ravi Shankar 322e720fe6 Merge branch 'master' into grpc_namespace_serverbuilder 2019-03-18 10:39:38 -07:00
Vijay Pai 8c3d4a7dfd
Merge pull request #18072 from vjpai/client_streaming_hold
C++ callback API: Add support for client-side extra-reaction operations via Holds
2019-03-16 10:27:36 -07:00
Vijay Pai 48ce4ca939 Add support for extra-reaction operations via Holds 2019-03-15 16:17:01 -07:00
Norman Link 3d28761029 Fixing memory leak in interceptor by removing unsued send_status_ 2019-03-13 21:42:02 +01:00
Karthik Ravi Shankar 3b7a47cde6 Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder
This change moves ServerBuilder class from grpc namespace to grpc_impl
namespace.
2019-03-04 17:01:14 -08:00
Vijay Pai 05d8ddfc6e Support callback-based generic service 2019-03-04 13:13:12 -08:00
Soheil Hassas Yeganeh 509e77a5a3 Introduce grpc_byte_buffer_reader_peek and use it for Protobuf parsing.
grpc_byte_buffer_reader_next() copies and references the slice. This
is not always necessary since the caller will not use the slice
after destroying the byte buffer.

A prominent example is the protobuf parser, which
calls grpc_byte_buffer_reader_next() and immediately unrefs the slice
after the call. This ref() and unref() calls can be very expensive
in the hot path.

This commit introduces grpc_byte_buffer_reader_peek() which
essentialy return a pointer to the slice in the buffer, i.e.,
no copies, and no refs.

QPS of 1MiB 1 Channel callback benchmark increases by 5%.
More importantly insructions per cycle is increased by 10%.

Also add tests and benchmarks for byte_buffer_reader_peek()
2019-03-04 14:17:46 -05:00
Nicolas Noble 91ad888497
Revert "Revert "Folding the Channel class into the grpc_impl namespace."" 2019-02-27 16:53:23 -08:00
Vijay Pai 2eb25c871e Avoid build errors 2019-02-26 03:08:06 -08:00
Vijay Pai 857e622e6f
Merge pull request #18098 from vjpai/try_2
Reduce starting callback counter to exclude client-side StartCall
2019-02-22 19:52:29 -08:00
Vijay Pai 147c61b2a4 Exclude StartCall from starting callback counter value 2019-02-20 21:13:44 -08:00
Yuwei Huang 3cbf4f50ea Remove extra semicolons after function definitions
We are planning to enable -Wextra-semi flag in our project but some
header files in gRPC have extra semicolons that violates the check and
blocks us from enabling the flag.

This change removes unnecessary semicolons in the code. Note that having
semicolon after the GRPC_ABSTRACT macro technically also violates the
check, but it's fine for us since they are not used in public headers,
and it will be confusing to have lines ending only with GRPC_ABSTRACT,
so I keep them as-is.
2019-02-20 17:58:30 -08:00
Nicolas Noble 2ad245cb0c
Revert "Folding the Channel class into the grpc_impl namespace." 2019-02-15 09:52:15 -08:00
Nicolas "Pixel" Noble 035442b086 Fixing header guard. 2019-02-14 21:40:31 +01:00
Nicolas "Pixel" Noble 5847c3a87a Reformat. 2019-02-14 20:05:59 +01:00
Nicolas "Pixel" Noble 12b0db3e57 Folding CompletionQueue and ServerCompletionQueue. 2019-02-14 20:01:14 +01:00
Yash Tibrewal 73353ad281 Merge branch 'master' into interceptorcleanup1 2019-02-13 12:47:47 -08:00
Yash Tibrewal 50497c2317 Reviewer comments 2019-02-13 12:46:07 -08:00
Nicolas "Pixel" Noble 63db582516 Merge branch 'master' of https://github.com/grpc/grpc into channel 2019-02-13 00:19:23 +01:00
Yash Tibrewal c71b2f4fb7 Global Interceptor Registration allowed only once 2019-02-07 19:36:51 -08:00
Yash Tibrewal 89ee1a8b10 Improved interception docs 2019-02-07 19:18:40 -08:00
Rohan Talip d68c0d29d9 Renamed the param in the documentation for HandleParameter to match the actual parameter.
This should prevent warnings like the following:

=== BUILD TARGET FirebaseFirestore OF PROJECT Pods WITH CONFIGURATION Debug ===
In file included from $PROJECT_DIR/platforms/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/stream.mm:17:
In file included from $PROJECT_DIR/platforms/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/stream.h:27:
In file included from $PROJECT_DIR/platforms/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/grpc_connection.h:28:
In file included from $PROJECT_DIR/platforms/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/grpc_stream.h:35:
In file included from $PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/generic/generic_stub.h:24:
In file included from $PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/support/async_stream.h:22:
In file included from $PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/impl/codegen/async_stream.h:26:
In file included from $PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/impl/codegen/service_type.h:24:
$PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/impl/codegen/rpc_service_method.h:49:16: warning: parameter 'rpc_requester' not found in the function declaration
      [-Wdocumentation]
    /// \param rpc_requester : used only by the callback API. It is a function
               ^~~~~~~~~~~~~
$PROJECT_DIR/platforms/ios/build/emulator/grpcpp.framework/Headers/impl/codegen/rpc_service_method.h:49:16: note: did you mean 'requester'?
    /// \param rpc_requester : used only by the callback API. It is a function
               ^~~~~~~~~~~~~
               requester
1 warning generated.
2019-02-01 12:56:56 -08:00
Yash Tibrewal 5e2e61b6e5 Note on conditions of usage 2019-01-28 16:37:02 -08:00
Yash Tibrewal 3a2cfe50ec Rever copyright changes 2019-01-28 16:18:49 -08:00
Yash Tibrewal 786598a6ff Merge branch 'master' into interceptorcqavalanching 2019-01-28 11:54:39 -08:00
Yash Tibrewal 9dd8a13439 Restructure code to handle cases exposed by the callback api 2019-01-24 19:03:55 -08:00
Nicolas "Pixel" Noble cabbd35014 Reformat. 2019-01-24 23:42:12 +01:00
Yash Tibrewal 4dcb14ec9e Fix codegen_test_minimal 2019-01-24 13:05:05 -08:00
Yash Tibrewal d347ec7ce0 Register for cq avalanching when interceptors are going to be run 2019-01-23 19:11:51 -08:00
Nicolas "Pixel" Noble 2fd079ff7c Channel folding. 2019-01-23 21:40:07 +01:00