Commit Graph

18611 Commits

Author SHA1 Message Date
Andrés de la Peña 9a0af4112e Fix legacy clustering serialization for paging with compact storage
patch by Andrés de la Peña; reviewed by Berenguer Blasi and Piotr Kołaczkowski for CASSANDRA-17507
2023-01-23 11:40:45 +00:00
Benedict Elliott Smith bb2c16c677
EndpointState is mutable, so we must copy it before trying to serialize
patch by Benedict Elliott Smith; reviewed by Mick Semb Wever for CASSANDRA-18164
2023-01-20 11:24:30 +01:00
Stefan Miklosovic 590d629302 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-18 15:05:33 +01:00
Stefan Miklosovic 815f7de346 Merge branch 'cassandra-3.11' into cassandra-4.0 2023-01-18 15:02:40 +01:00
Stefan Miklosovic fc3ad6525f Merge branch 'cassandra-3.0' into cassandra-3.11 2023-01-18 14:58:38 +01:00
German Eichberger 8ecd7616fe Default role is created with zero timestamp
patch by German Eichberger; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-12525

Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
2023-01-18 14:56:22 +01:00
Paulo Motta c9968a8e95 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-16 21:47:46 -05:00
Stefan Miklosovic 6e6846892a Fix sstable loading of keyspaces named snapshots or backups
Patch by Stefan Miklosovic; Reviewed by Paulo Motta for CASSANDRA-14013

Co-authored-by: Paulo Motta <paulo@apache.org>
2023-01-16 21:45:17 -05:00
David Capwell 5be1038c5d Streaming progress virtual table lock contention can trigger TCP_USER_TIMEOUT and fail streaming
patch by David Capwell; reviewed by Abe Ratnofsky, Jon Meredith for CASSANDRA-18110
2023-01-12 09:46:54 -08:00
Bereng 438346aaa6 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-12 08:19:48 +01:00
Bereng a83de9bcd2 Merge branch 'cassandra-3.11' into cassandra-4.0 2023-01-12 08:18:13 +01:00
Bereng b8a87abba4 Do not leak 2015 synthetic memtable Epoch
patch by Berenguer Blasi; reviewed by Caleb Rackliffe for CASSANDRA-18118
2023-01-12 08:15:19 +01:00
Jordan West 073f7c36fa Return empty denylist entry instead of null on failure to load
Patch by Jordan West; Reviewed by Josh McKenzie for CASSANDRA-18116
2023-01-07 13:42:02 -08:00
Marcus Eriksson fabc6e7c7b Merge branch 'cassandra-4.0' into cassandra-4.1 2022-12-23 14:59:59 +01:00
Marcus Eriksson ee266d283e Avoid ConcurrentModificationException in STCS/DTCS/TWCS.getSSTables
Patch by marcuse; reviewed by Aleksey Yeschenko for CASSANDRA-17977
2022-12-23 14:58:56 +01:00
Marcus Eriksson 203c61abaf Merge branch 'cassandra-4.0' into cassandra-4.1 2022-12-23 14:44:19 +01:00
Marcus Eriksson 95e26ad1ab Merge branch 'cassandra-3.11' into cassandra-4.0 2022-12-23 14:43:01 +01:00
Marcus Eriksson 0767c83416 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-12-23 14:41:50 +01:00
Marcus Eriksson 730b898b74 Don't group TWCS sstables for anticompaction
Patch by marcuse; reviewed by Aleksey Yeschenko for CASSANDRA-17970
2022-12-23 13:38:53 +01:00
Stefan Miklosovic 97f9ff7da3 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-12-20 10:16:14 +01:00
Stefan Miklosovic ace3920239 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-12-20 10:12:07 +01:00
Stefan Miklosovic baa9d0327f Merge branch 'cassandra-3.0' into cassandra-3.11 2022-12-20 10:04:43 +01:00
Stefan Miklosovic f55b2fb1b3 Do not spam the logs with MigrationCoordinator not being able to pull schemas
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-18096
2022-12-20 09:59:28 +01:00
Mick Semb Wever f869a2bb59
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Restore custom param types over messaging system
2022-12-17 15:50:19 -08:00
Mick Semb Wever f01d2b4a3c
Restore custom param types over messaging system
patch by Mick Semb Wever; reviewed by Aleksey Yeschenko for CASSANDRA-17981
2022-12-17 15:48:26 -08:00
Marianne Lyne Manaog 81c616826a Fix ContentionStrategy backoff and Clock.waitUntil
Also for CASSANDRA-18087

patch by Matt Fleming, Marianne Lyne Manaog, Benedict Elliott Smith; reviewed by Joshua Mckenzie, Ariel Weisberg for CASSANDRA-18086

Co-authored-by: Marianne Lyne Manaog <marianne.manaog@datastax.com>
Co-authored-by: Matt Fleming <matt@codeblueprint.co.uk>
Co-authored-by: Benedict Elliott Smith <benedict@apple.com>
2022-12-07 15:20:48 -05:00
Yifan Cai 27fff06bb7 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-12-05 18:57:01 -08:00
Yifan Cai f22263cd8a Merge branch 'cassandra-3.11' into cassandra-4.0 2022-12-05 18:52:22 -08:00
Yifan Cai eb91e2c354 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-12-05 18:50:28 -08:00
Yifan Cai 473656c1d5 Fix incorrect resource name in LIST PERMISSION output
patch by Yifan Cai; reviewed by Berenguer Blasi, Sam Tunnicliffe for CASSANDRA-17848
2022-12-05 18:48:36 -08:00
Jordan West 13d495aa7d fix intermittent failures in nodetool toppartitions caused by failure to validate invalid bytes
Patch by Jordan West; Reviewed by Brandon Williams and Cheng Wang for CASSANDRA-17254
2022-11-29 18:25:04 -08:00
Branimir Lambov 9f58d76f38 Avoid schema mismatch problems on memtable API misconfiguration
patch by Branimir Lambov; reviewed by Caleb Rackliffe for CASSANDRA-18040
2022-11-16 10:30:16 +02:00
Stefan Miklosovic 19f55cf0b8 Start Paxos auto repair in CassandraDaemon
This patch also renames PaxosRepairTest2 to PaxosRepair2Test to be picked up by CI.

patch by Stefan Miklosovic; reviewed by Benedict Elliott Smith for CASSANDRA-18029
2022-11-14 13:52:03 +01:00
Alex Sorokoumov 5cd012736e VIntCoding handles BB with less than 8 bytes
Without this fix VIntCoding#writeUnsignedVInt(long, ByteBuffer) throws
a runtime error if the BB size is less than 8 bytes. This method also
silently does not write to BB if it has less than 8 bytes left.

patch by Alex Sorokoumov; reviewed by Benjamin Lerer for CASSANDRA-15215
2022-11-11 19:52:37 +01:00
Stefan Miklosovic 207045030e Merge branch 'cassandra-4.0' into cassandra-4.1 2022-11-11 13:57:16 +01:00
Stefan Miklosovic 2638051af1 Harden parsing of boolean values in CQL in PropertyDefinitions
patch by Stefan Miklosovic; reviewed by Aleksey Yeschenko for CASSANDRA-17878
2022-11-11 13:38:44 +01:00
Brandon Williams 106bc89d74 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-11-10 13:37:59 -06:00
Natnael Adere 35826b7447 Fix error message about type hints (CASSANDRA-17915)
Patch by Natnael Adere; reviewed by blerer and brandonwilliams for
CASSANDRA-17915
2022-11-10 13:35:56 -06:00
Jacek Lewandowski e12dc48c87 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-11-09 17:22:11 +01:00
Jacek Lewandowski 67c530171c Merge branch 'cassandra-3.11' into cassandra-4.0 2022-11-09 17:20:08 +01:00
Jacek Lewandowski 9213335f59 Fix Splitter sometimes creating more splits than requested
Spliter.splitOwnedRanges for some inputs creates an extra split. For example, when we request 7 ranges from 0..31 range, it will return 8 ranges. There is an assertion in that method which verifies whether it returns the requested number of splits. Since those numbers differs, when Cassandra is be started with assertions enabled, it would fail.

patch by Jacek Lewandowski; reviewed by Marcus Eriksson for CASSANDRA-18013
2022-11-09 17:17:01 +01:00
Aleksey Yeschenko c100d34a1a
Restore streaming_keep_alive_period functionality on the netty control streaming channel
patch by Aleksey Yeschenko, Mick Semb Wever; reviewed by Mick Semb Wever, Berenguer Blasi for CASSANDRA-17768

Co-authored-by: Aleksey Yeschenko <aleksey@apache.org
Co-authored-by: Mick Semb Wever <mck@apache.org>
2022-11-09 11:39:07 +01:00
Doug Rohrer a805e32675 Move Schema.FORCE_LOAD_KEYSPACES and Schema.FORCE_LOAD_KEYSPACES_PROP to CassandraRelevantProps
patch by Doug Rohrer; reviewed by Brandon Williams and Jacek Lewandowski for CASSANDRA-17783
2022-11-08 08:18:40 +01:00
Marianne Lyne Manaog acda6fad68 Bug fix for WriteTimeoutException when using Paxos v2 with a single datacenter
patch by Marianne Lyne Manaog; reviewed by Branimir Lambov and Benedict Elliott Smith for CASSANDRA-17999
2022-11-07 14:59:03 +02:00
Stefan Miklosovic 0e21007b4f Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-27 16:06:19 +02:00
Stefan Miklosovic 35ef5b9957 Fix possible race condition on repair snapshots
patch by Stefan Miklosovic; reviewed by David Capwell for CASSANDRA-17955
2022-10-27 15:50:37 +02:00
Maxim Chanturiay dd53a609c6 Add --resolve-ip option to nodetool gossipinfo
patch by Maxim Chanturiay; reviewed by Stefan Miklosovic and Caleb Rackliffe for CASSANDRA-17934
2022-10-27 11:19:20 +02:00
Ekaterina Dimitrova 1df5dd671e Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-20 13:59:09 -04:00
Ekaterina Dimitrova ce1584ccc8 Fix ASM bytecode version inconsistency
patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi and Benedict Elliot Smith for CASSANDRA-17873
2022-10-20 13:10:33 -04:00
Mick Semb Wever fbb3079144
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Fix JMX security vulnerabilities
2022-10-18 22:55:59 +02:00
Mick Semb Wever 9a24fa81e5
Merge branch 'cassandra-3.11' into cassandra-4.0
* cassandra-3.11:
  Fix JMX security vulnerabilities
2022-10-18 22:53:37 +02:00
Mick Semb Wever 95d0a936f9
Merge branch 'cassandra-3.0' into cassandra-3.11
* cassandra-3.0:
  Fix JMX security vulnerabilities
2022-10-18 22:50:49 +02:00
Abe Ratnofsky b2660bcf78
Fix JMX security vulnerabilities
patch by Abe Ratnofsky; reviewed by Jon Meredith, Mick Semb Wever, Sam Tunnicliffe for CASSANDRA-17921
2022-10-18 22:47:49 +02:00
Stefan Miklosovic 15b54687a5 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-11 23:20:35 +02:00
Stefan Miklosovic 488c0c75a8 Remove empty cq4 log files to prevent BinLog from failing to start
This patch also backports CASSANDRA-17595.

patch by Stefan Miklosovic; reviewed by Caleb Rackliffe for CASSANDRA-17933
2022-10-11 23:13:13 +02:00
Aleksey Yeschenko 3fc9bc033a Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-11 15:43:49 +01:00
Piotr Kołaczkowski e13356d75d Fix multiple BufferPool bugs
patch by Piotr Kołaczkowski; reviewed by Aleksey Yeschenko for
CASSANDRA-16681
2022-10-11 15:42:30 +01:00
Ariel Weisberg 9524c22990 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-06 14:11:34 -04:00
Andy Tolbert 3bdd2caa22 Fix StorageService.getNativeaddress handling of IPv6 addresses
StorageService.getNativeaddress does not currently correctly handle
IPv6 addresses correctly when NATIVE_ADDRESS_AND_PORT are not present in
that it simply concatenates the IP address with the default native port,
e.g.:

0:0:0:0:0:0:5a:3:9042

This does not parse into an InetSocketAddress as the address and port
can't be disambiguated.

Such a case would usually be present when there are 3.x nodes present in a
cluster with 4.0 nodes.

Change updates RPC_ADDRESS and else case to create InetAddressAndPort instances
with DatabaseDescriptor.getNativeTransportPort and returns the
getHostAddress(withPort) which properly bracket encodes the address,
e.g.:

[0:0:0:0:0:0:5a:3]:9042

which can be parsed as an InetSocketAddress.

patch by Andy Tolbert; reviewed by Ariel Weisberg, Brandon Williams for CASSANDRA-17945
2022-10-06 14:10:58 -04:00
Aleksey Yeschenko 0b083d3e73 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-06 15:34:49 +01:00
Aleksey Yeschenko 4e1d31e729 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-10-06 15:27:49 +01:00
Piotr Kołaczkowski dc2acba043 Make LongBufferPoolTest insensitive to timing
This commit changes the way how LongBufferPoolTest verifies
that all buffers were freed and recycled. Now, the delay between
rounds can be arbitrarily short and timing does not affect the
validity of checks.

patch by Piotr Kołaczkowski; reviewed by Aleksey Yeschenko for
CASSANDRA-16681
2022-10-05 15:46:10 +01:00
Stefan Miklosovic 5d3c747719 add checkstyle modules for checking redundant and unused imports in Java code
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-17876

Co-authored-by: Ling Mao <maoling@apache.org>
2022-09-26 21:41:15 +02:00
Josh McKenzie 3608f67076 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-09-20 14:18:09 -04:00
Josh McKenzie 22ec7eee7f Mitigate direct buffer memory OOM on replacements
Patch by Jon Meredith; reviewed by Josh McKenzie for CASSANDRA-17895

Co-authored-by: Jon Meredith <jonmeredith@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-09-20 14:16:24 -04:00
Josh McKenzie 1f90c9eb3d Merge branch 'cassandra-4.0' into cassandra-4.1 2022-09-20 12:57:51 -04:00
Josh McKenzie 29c0ad80c9 Fix repair failure on assertion if two peers have overlapping mismatching ranges
Patch by Marcus Eriksson; reviewed by Benedict Elliott Smith and Josh McKenzie for CASSANDRA-17900

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-09-20 12:55:24 -04:00
Ekaterina Dimitrova 4c85c6a403 key_cache_save_period, row_cache_save_period, counter_cache_save_period are not deprecated and we should not emit deprecation warning on startup for them
Patch by Ekaterina Dimitrova; reviewed by Stefan Miklosovic for CASSANDRA-17904
2022-09-19 18:10:36 -04:00
Jacek Lewandowski d8bbeb9e39 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-09-16 09:55:07 +02:00
Jacek Lewandowski 76be530a36 Fix schema reset functionality
Patch by Jacek Lewandowski, reviewed by Andrés de la Peña and Ekaterina Dimitrova for CASSANDRA-17819
2022-09-16 09:50:03 +02:00
Josh McKenzie 3f46c7d88b Merge branch 'cassandra-4.0' into cassandra-4.1
# Conflicts:
#	CHANGES.txt
2022-09-12 12:45:42 -04:00
Josh McKenzie ac25d6929e Better handle null state in Gossip schema migration to avoid NPE
Patch by Marcus Eriksson; reviewed by Josh McKenzie and Alex Petrov for CASSANDRA-17864

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-09-12 12:43:54 -04:00
David Capwell d25adb498a upsert with adder support is not consistent with numbers and strings in LWT
patch by David Capwell; reviewed by Benedict Elliott Smith, Caleb Rackliffe for CASSANDRA-17857
2022-09-06 18:07:18 -07:00
Brandon Williams 46700918f8 Catch NSE race condition and return after failing connections
Patch by brandonwilliams; reviewed by adelapena and aleksey for
CASSANDRA-17618
2022-09-06 11:54:20 -05:00
Jon Meredith 6748b8b7ea Speculative execution threshold unit mismatch
patch by Jon Meredith; reviewed by Caleb Rackliffe, Yifan Cai for CASSANDRA-17877
2022-09-06 10:01:18 -06:00
Marcus Eriksson cd576a0d14 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-29 13:28:32 +02:00
Marcus Eriksson 5beab63b55 Improve the way we handle repair message timeouts to avoid hanging repairs
Patch by marcuse; reviewed by David Capwell for CASSANDRA-17613
2022-08-29 13:27:16 +02:00
Jacek Lewandowski 726b67b1e4 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-26 17:39:46 +02:00
Jacek Lewandowski 2b492f17b9 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-08-26 17:19:59 +02:00
Jacek Lewandowski 04c3e816e8 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-08-26 17:17:07 +02:00
Jacek Lewandowski a78db628b0 Fix scrubber falling into infinite loop
Fixes scrubber falling into infinite loop when the last partition is broken in data file and compression is enabled.

Patch by Jacek Lewandowski, reviewed by Brandon Williams, for CASSANDRA-17862
2022-08-26 17:06:10 +02:00
Josh McKenzie 704141541a Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-24 15:24:11 -04:00
Josh McKenzie 73bea0ac1e Merge branch 'cassandra-3.11' into cassandra-4.0
-s ours; applying 4.0+ patch for CASSANDRA-17840
2022-08-24 15:23:52 -04:00
Josh McKenzie ab481be81d Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters
Patch by Alex Petrov; reviewed by Josh McKenzie, Sam Tunnicliffe, and Aleksey Yeschenko for CASSANDRA-17840

Co-authored-by: Alex Petrov <oleksandr.petrov@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-08-24 15:04:21 -04:00
Francisco Guerrero 83c169ec9e Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle
patch by Francisco Guerrero; reviewed by Ekaterina Dimitrova, Yifan Cai for CASSANDRA-17677
2022-08-19 14:19:53 -07:00
Josh McKenzie b95a6931f5 Merge branch 'cassandra-4.0' into cassandra-4.1
# Conflicts:
#	CHANGES.txt
#	src/java/org/apache/cassandra/repair/consistent/CoordinatorSession.java
2022-08-19 12:34:33 -04:00
Josh McKenzie 0353df7542 Prevent infinite loop in repair coordinator on FailSession
Patch by Marcus Eriksson; reviewed by David Capwell, Blake Eggleston, and Josh McKenzie for CASSANDRA-17834

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-08-19 12:33:24 -04:00
Yifan Cai 590de42a06 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-16 15:24:34 -07:00
Yifan Cai 84e10d0cad Fix race condition on updating cdc size and advancing to next segment
patch by Yifan Cai; reviewed by Josh McKenzie for CASSANDRA-17792
2022-08-16 15:21:37 -07:00
Jacek Lewandowski c1d89c32d2 Fix a race condition where a keyspace can be opened while it is being removed
patch by Jacek Lewandowski; reviewed by Andrés de la Peña and Ekaterina Dimitrova for CASSANDRA 17658
2022-08-12 13:26:16 +02:00
Andrés de la Peña 16be1ab073 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-12 10:31:30 +01:00
Andrés de la Peña 174e0dc399 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-08-12 10:28:42 +01:00
Andrés de la Peña 4e410fc46d Document usage of closed token intervals in manual compaction
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-17575
2022-08-12 10:21:19 +01:00
Brandon Williams f5dc9a1c1e Set default FD in DD client initialization
Patch by Doug Rohrer; reviewed by brandonwilliams and maedhroz for
CASSANDRA-17782
2022-08-10 14:09:52 -05:00
Blake Eggleston 2bc4a36179 Use seeded crc for PaxosBallotTracker checksum
Patch by Blake Eggleston; Reviewed by Benedict Elliot Smith for CASSANDRA-17793
2022-08-09 08:58:27 -07:00
Ekaterina Dimitrova a7d7708976 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-08 13:02:48 -04:00
Ekaterina Dimitrova e5e13c02cc Fix default value for compaction_throughput_mb_per_sec in Config class to match the one in cassandra.yaml
patch by Ekaterina Dimimtrova; reviewed by Francisco Guerrero, Michael Semb Wever for CASSANDRA-17790
2022-08-08 12:45:36 -04:00
Runtian Liu 299bfaed35 Fix missing state resetting on CompressedRandomAccessReader read errors
patch by Runtian Liu; reviewed by Andrés de la Peña and Berenguer Blasi for CASSANDRA-17314
2022-08-08 13:52:10 +01:00
Caleb Rackliffe 5e39c54678 Avoid initializing schema via SystemKeyspace.getPreferredIP() with the BulkLoader tool
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-17740

Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Jon Meredith <jmeredithco@gmail.com>
2022-08-05 15:31:40 -05:00
Ekaterina Dimitrova dd08314ed6 Uncomment prepared_statements_cache_size, key_cache_size, counter_cache_size, index_summary_capacity which were
commented out by mistake in a previous patch;
Fix breaking change with cache_load_timeout; cache_load_timeout_seconds <=0 and cache_load_timeout=0 are equivalent
and they both mean disabled;
Deprecate public method setRate(final double throughputMbPerSec) in Compaction Manager in favor of
setRateInBytes(final double throughputBytesPerSec);
Revert breaking change removal of StressCQLSSTableWriter.Builder.withBufferSizeInMB(int size). Deprecate it in favor
of StressCQLSSTableWriter.Builder.withBufferSizeInMiB(int size);
Fix precision issues, add new -m flag (for nodetool/setstreamthroughput, nodetool/setinterdcstreamthroughput,
nodetool/getstreamthroughput and nodetoo/getinterdcstreamthroughput), add new -d flags (nodetool/getstreamthroughput,
 nodetool/getinterdcstreamthroughput, nodetool/getcompactionthroughput);
Fix a bug with precision in nodetool/compactionstats;
Deprecate StorageService methods and add new ones for stream_throughput_outbound, inter_dc_stream_throughput_outbound,
compaction_throughput_outbound in the JMX MBean `org.apache.cassandra.db:type=StorageService`;
Removed getEntireSSTableStreamThroughputMebibytesPerSec in favor of new getEntireSSTableStreamThroughputMebibytesPerSecAsDouble
in the JMX MBean `org.apache.cassandra.db:type=StorageService`;
Removed getEntireSSTableInterDCStreamThroughputMebibytesPerSec in favor of getEntireSSTableInterDCStreamThroughputMebibytesPerSecAsDouble
in the JMX MBean `org.apache.cassandra.db:type=StorageService`

Patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, Francisco Guerrero for CASSANDRA-17225
2022-08-01 19:05:13 -04:00
Ekaterina Dimitrova fe28f482db Fix sstable_preemptive_open_interval_in_mb disabled value - backward compatibility
patch by Ekaterina Dimitrova; reviewed by Andres de la Pena and Jon Meredith for CASSANDRA-17737
2022-07-29 13:26:31 -04:00
Ekaterina Dimitrova 222f66e093 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-28 16:21:47 -04:00
Ekaterina Dimitrova 04901913d6 Fix Setting Virtual Table to update after startup config properties gc_log_threshold_in_ms, gc_warn_threshold_in_ms, conf.index_summary_capacity_in_mb, prepared_statements_cache_size_mb, key_cache_size_in_mb, counter_cache_size_in_mb
patch by Ekaterina Dimitrova; reviewed by Andres de la Pena for CASSANDRA-17737
2022-07-28 16:17:55 -04:00
Caleb Rackliffe 3a0936b61f Remove usages of Path#toFile() in the snapshot apparatus
patch by Caleb Rackliffe; reviewed by David Capwell and Benedict Elliot Smith for CASSANDRA-17769
2022-07-27 15:04:03 -05:00
Stefan Miklosovic 8533a6764b Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-27 15:01:14 +02:00
Stefan Miklosovic 6388fd3a16 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-07-27 14:34:35 +02:00
Stefan Miklosovic afaeb93020 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-07-27 14:21:56 +02:00
Stefan Miklosovic a7b53217bd fix restarting of services on gossipping-only member
patch by Stefan Miklosovic; reviewed by Brandon Williams (CASSANDRA-17752)
2022-07-27 14:13:25 +02:00
Ekaterina Dimitrova 1c70149ef5 Fix Settings Virtual Table to update paxos_variant after startup and rename enable_uuid_sstable_identifiers to uuid_sstable_identifiers_enabled as per our config naming conventions
patch by Ekaterina Dimitrova; reviewed by Brandon Williams for CASSANDRA-17738
2022-07-25 10:08:09 -04:00
Stefan Miklosovic 15b7d678e9 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-23 22:33:48 +02:00
Stefan Miklosovic a1ac1efbb7 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-07-23 22:27:20 +02:00
Stefan Miklosovic e83d95d1ac creating of a keyspace on insufficient number of replicas should filter out gosspping-only members
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-17759
2022-07-23 22:22:06 +02:00
Brandon Williams 962247a493 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-22 11:30:13 -05:00
Brandon Williams a53bb7ab82 Remove extra write to system table for prepared statements
Patch by brandonwilliams; reviewed by maedhroz for CASSANDRA-17764
2022-07-22 11:28:25 -05:00
Ekaterina Dimitrova 9beeaf87bd Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-22 09:41:38 -04:00
Ekaterina Dimitrova 860ec627a1 Fix issues with index_summary_resize_interval and index_summary_capacity
patch by Ekaterina Dimitrova; reviewed by Andres de la Pena for CASSANDRA-17735
2022-07-22 09:25:54 -04:00
Ekaterina Dimitrova 46d9cbe2f6 min_tracked_partition_size_bytes parameter from 4.1 alpha1 was renamed to min_tracked_partition_size
patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi for CASSANDRA-17733
2022-07-15 12:34:14 -04:00
Bereng ada958eaf7 org.apache.cassandra.db.commitlog.GroupCommitLogTest tests failing on trunk
patch by Berenguer Blasi; reviewed by Andres de la Peña for CASSANDRA-17232
2022-07-14 06:56:19 +02:00
Blake Eggleston cdc0ce1fa3 Prevent premature initialization of paxos metadata files during tests
Patch by Blake Eggleston; review by Benjamin Lerer and Berenguer Blasi for CASSANDRA-17489
2022-07-11 17:41:37 +02:00
Benedict Elliott Smith 067121da63 Paxos v2 Linearizability Violation
patch by Benedict; reviewed by Blake Eggleston for CASSANDRA-17530
2022-07-12 12:28:59 +01:00
Marten Kenbeek dd51df6734 Only use statically defined subcolumns when determining column definition for supercolumn cell
Patch by Marten Kenbeek; review by Benjamin Lerer and Brandon Williams for CASSANDRA-14113
2022-07-11 16:46:12 +02:00
Bereng 1d80dd0086 Fix flaky test - org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate
patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-17653
2022-07-11 09:44:28 +02:00
Bereng f77a7a29e8 Update the CQL version for the 4.1 release
Patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-17570
2022-07-08 09:15:27 +02:00
Benjamin Lerer 50e7a3f5df Merge branch cassandra-4.0 into cassandra-4.1 2022-07-07 14:00:55 +02:00
Benedict Elliott Smith c378874a9f Utilise BTree improvements to reduce garbage and improve throughput
Patch by Benedict Elliott Smith; review by Branimir Lambov and Benjamin Lerer for CASSANDRA-15511
2022-07-07 13:52:52 +02:00
Francisco Guerrero a250126f0f Remove commons-lang dependency during build runtime
patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRA-17724
2022-07-06 17:41:12 -07:00
Caleb Rackliffe 15bdf2e8e7 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-05 18:41:46 -05:00
Caleb Rackliffe 924cd8f52c Make sure delayed timeout task in StreamTransferTask cannot prevent clean shutdown
patch by Caleb Rackliffe; reviewed by David Capwell for CASSANDRA-17706
2022-07-05 18:33:19 -05:00
Francisco Guerrero a9725b681b Fix AbstractCell#toString throws MarshalException for cell in collection
patch by Francisco Guerrero; reviewed by Caleb Rackliffe, Yifan Cai for CASSANDRA-17695
2022-06-29 18:05:09 -07:00
Brandon Williams b75d56fd38 Add new compactionstats output behind --vtable
Patch by brandonwilliams; reviewed by edimitrov and dcapwell for
CASSANDRA-17683
2022-06-29 10:08:44 -05:00
Jakub Żytka 60b54425ed Fix commitLogUpperBound initialization in AbstractMemtableWithCommitlog
so that it is always available when writeBarrier gets initialized.

Harden Memtable API so that it is apparent that getting commitLogUpperBound
is valid only after it is fully established.

patch by Jakub Żytka and Dan Jatnieks;
reviewed by Dan Jatnieks, Jeremiah D Jordan and Caleb Rackliffe for CASSANDRA-17587
2022-06-29 12:08:42 +03:00
Akın Tekeoğlu 07e5876c43 Add toBytesInLong to IntKibibytesBound to support widening to long in getBatchSizeFailThreshold
patch by Akin Tekeoglu; reviewed by Ekaterina Dimitrova and Andres de la Peña for CASSANDRA-17650
2022-06-28 18:10:42 -04:00
Ekaterina Dimitrova 495d609c89 Fix widening from mebibytes to bytes in IntMebibytesBound 2022-06-28 14:41:46 -04:00
Ekaterina Dimitrova dcb4768345 nodetool clientstats columns should be under a separate flag - --config-options
patch by Ekaterina Dimitrova; reviewed by Brandon Williams for CASSANDRA-17715
2022-06-27 19:23:06 -04:00
Andrés de la Peña 33730d9d06 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-27 15:15:21 +01:00
Andrés de la Peña 90e2502c6c Merge branch 'cassandra-3.11' into cassandra-4.0 2022-06-27 15:14:35 +01:00
Andrés de la Peña bc8a260471 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-06-27 15:13:45 +01:00
Andrés de la Peña 09692d5a58 Fix writetime and ttl functions forbidden for collections instead of multicell columns
patch by Andrés de la Peña; reviewed by Berenguer Blasi for CASSANDRA-17628
2022-06-27 15:09:35 +01:00
Bereng 1d39a388ba Revert "Update the CQL version for the 4.1 release"
This reverts commit a508ac06e9.
2022-06-21 11:06:10 +02:00
Bereng a508ac06e9 Update the CQL version for the 4.1 release
patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-17570
2022-06-21 08:13:21 +02:00
Stefan Miklosovic 89df37d4bb Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-16 19:29:23 +02:00
Stefan Miklosovic 7da28ef378 SSL storage port in sstableloader is deprecated
this is the follow-up commit which deprecates ssl storage port for backward compatibility

patch by Stefan Miklosovic; reviewed by Jon Meredith for CASSANDRA-17602
2022-06-16 19:26:02 +02:00
Brandon Williams 96ef1d231c Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-16 09:01:24 -05:00
Brandon Williams 51ce71881c filter out dead replicas for counter writes
Patch by brandonwilliams; reviewed by adelapena for CASSANDRA-17411
2022-06-16 09:00:02 -05:00
Brandon Williams 7f38db348e Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-16 06:00:57 -05:00
Brandon Williams c3998ef601 Return an empty collection when a node is not a member
Patch by brandonwilliams; reviewed by adelapena for CASSANDRA-17680
2022-06-16 05:59:42 -05:00
Stefan Miklosovic 67632edc51 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-13 10:43:17 +02:00
Stefan Miklosovic 2531dd1eba remove ssl storage port from sstableloader
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-17602
2022-06-13 10:36:56 +02:00
Stefan Miklosovic 457e16c27e fix flaky GossipInfoTableTest
patch by Stefan Miklosovic; reviewed by Andrés de la Peña for CASSANDRA-17584
2022-06-07 22:15:11 +02:00
Sathyanarayanan Saravanamuthu 9b4784bdb7 Fix missed nowInSec values in QueryProcessor
patch by Sathyanarayanan Saravanamuthu; reviewed by Andrés de la Peña, Benjamin Lerer and Ekaterina Dimitrova for CASSANDRA-17458

Co-authored-by: Sathyanarayanan Saravanamuthu <sathya.kplm@outlook.com>
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
2022-06-07 13:03:19 +01:00
Ekaterina Dimitrova 2eac2590bf Revert removal of withBufferSizeInMB(int size) to CQLSSTableWriter.Builder and deprecate it in favor of withBufferSizeIniB(int size);update the docs
patch by Ekaterina Dimitrova; reviewed by Michael Semb Wever for CASSANDRA-17675
2022-06-02 15:31:23 -04:00
Caleb Rackliffe 663e51d928 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-02 12:10:52 -05:00
Caleb Rackliffe a00d8fd5ba Ensure FileStreamTask cannot compromise shared channel proxy for system table when interrupted
patch by Caleb Rackliffe; reviewed by Jon Meredith and David Capwell for CASSANDRA-17663
2022-06-02 11:59:19 -05:00
Paulo Motta a604c0d4de Remove expired snapshots of dropped tables after restart
Patch by Paulo Motta; reviewed by Stefan Miklosovic for CASSANDRA-17619

Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
2022-05-29 09:57:49 +02:00
David Capwell 76648a6534 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-05-25 14:01:32 -07:00
David Capwell fb8bf30c6d jvm-dtest upgrade failures due to 3.x Ping not allowing serialize
patch by David Capwell; reviewed by Jon Meredith for CASSANDRA-17660
2022-05-25 14:00:14 -07:00
Brandon Williams 00250199c0 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-05-24 06:01:28 -05:00
Brandon Williams 7ea24711cc silence benign SslClosedEngineException
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-17565
2022-05-24 05:58:06 -05:00
Ekaterina Dimitrova a67a2a2441 Handle config parameters upper bound on startup; Fix auto_snapshot_ttl and paxos_purge_grace_period min unit validations
patch by Ekaterina Dimitrova and Andres de la Pena; reviewed by Andres de la Pena and Caleb Rackliffe for CASSANDRA-17571

Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
2022-05-20 14:27:20 -04:00
Andrés de la Peña c1d163abad Merge branch 'cassandra-4.0' into cassandra-4.1 2022-05-20 11:52:34 +01:00
Andrés de la Peña 5cf6db30f6 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-05-20 11:47:06 +01:00
Andrés de la Peña 0e1d068d92 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-05-20 11:43:56 +01:00
Doug Rohrer ffc4c89c3d Fix issue where frozen maps may not be serialized in the correct order
patch by Doug Rohrer, Francisco Guerrero and Yifan Cai; reviewed by Andrés de la Peña and Caleb Rackliffe for CASSANDRA-17623

Co-authored-by: Doug Rohrer <drohrer@apple.com>
Co-authored-by: Francisco Guerrero <frank.guerrero@gmail.com>
Co-authored-by: Yifan Cai <ycai@apache.org>
2022-05-20 11:38:19 +01:00
Ekaterina Dimitrova c635f198f6 Fix leak of non-standard Java types in our Exceptions as clients using JMX are unable to handle them
Remove useless validation that leads to unnecessary additional read of cassandra.yaml on startup
patch by Ekaterina Dimitrova; review by David Capwell for CASSANDRA-17638
2022-05-19 14:35:02 -04:00
David Capwell f451c2b028 jvm-dtest unhandled exceptions failing the test no longer work
patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-17549
2022-05-13 10:14:26 -07:00
Brandon Williams 7dbea1a8cb Merge branch 'cassandra-4.0' into cassandra-4.1 2022-05-13 06:56:49 -05:00
Brandon Williams ac0266be69 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-05-13 06:54:03 -05:00
Brandon Williams d043217ff0 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-05-13 06:50:40 -05:00
Maciej Sokol 5d427ff6e5 Fsync TOC and Digest files after they're written
Patch by Maciej Sokol; reviewed by brandonwilliams and bereng for
CASSANDRA-10709
2022-05-13 06:41:07 -05:00
Ekaterina Dimitrova f57c8d2c25 Fix repair_request_timeout_in_ms and remove paxos_auto_repair_threshold_mb
patch by Benedict Elliott Smith and Ekaterina Dimitrova; reviewed by Benedict Elliott Smith and Blake Eggleston for CASSANDRA-17557
2022-05-10 21:05:41 -04:00
David Capwell 89fbb1acf4 Incremental repair leaks SomeRepairFailedException after switch away from flatMap
patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-17620
2022-05-10 15:24:54 -07:00
David Capwell 6396562f71 StorageService read threshold get methods throw NullPointerException due to not handling null configs
patch by David Capwell; reviewed by Berenguer Blasi for CASSANDRA-17593
2022-05-10 12:41:33 -07:00
Alex Sorokoumov 9f3bc65727 Reject oversized mutations on client and internode connection
Patch by Alex Sorokoumov; reviewed by Andres de la Peña and Josh McKenzie for CASSANDRA-17456
2022-05-09 10:57:14 +02:00
Benedict Elliott Smith 596daeb7f0 Optimise BTree build, update and transform operations
Patch Benedict Elliott Smith; reviewed by Branimir Lambov and Benjamin Lerer for CASSANDRA-15510
2022-05-06 18:15:16 +02:00
Josh McKenzie 030831c5f5 Rename truncate_drop guardrail to drop_truncate_table
Patch by Josh McKenzie; reviewed by Andres de la Pena for CASSANDRA-17592
2022-05-06 11:48:45 -04:00
Brandon Williams c9ed13c425 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-05-05 05:57:06 -05:00
Brandon Williams a524cd4907 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-05-05 05:55:11 -05:00
Brandon Williams aeced876b5 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-05-05 05:55:00 -05:00
Jermy Li 61d4cccb0b Fix URISyntaxException in nodetool with updated Java
Patch by Jermy Li; reviewed by bereng and brandonwilliams for
CASSANDRA-17581
2022-05-05 05:53:47 -05:00
David Capwell 559b17f71d nodetool enablefullquerylog can NPE when directory has no files
patch by David Capwell; reviewed by Jon Meredith for CASSANDRA-17595
2022-05-04 09:32:39 -07:00
Marcus Eriksson 3b648ca09e Use TimeUUID serializer for BATCH_REMOVE_REQ
Patch by marcuse; reviewed by Benedict Elliott Smith for CASSANDRA-17451
2022-05-04 08:18:33 +02:00
Paulo Motta 7741eacc54 Add auto_snapshot_ttl configuration
Patch by Paulo Motta; Reviewed by Stefan Miklosovic for CASSANDRA-16790

Co-authored-by: fibersel <0583463@gmail.com>
2022-04-30 17:28:17 -03:00
Paulo Motta 31aa17a2a3 List snapshots of dropped tables
Patch by Paulo Motta; Reviewed by Stefan Miklosovic and Brandon Williams or CASSANDRA-16843
2022-04-29 19:00:34 -03:00
Jacek Lewandowski 458bfd16c7 Add information info whether sstables are dropped or not to SchemaChangeListener
patch by Jacek Lewandowski; reviewed by Alex Petrov for CASSANDRA-17582
2022-04-29 13:44:25 -04:00
Branimir Lambov e4e19e33fa Add memtable API (CEP-11)
patch by Branimir Lambov; reviewed by Andrés de la Peña and Caleb Rackliffe for CASSANDRA-17034
2022-04-29 14:56:20 +03:00
Jacek Lewandowski 77d6bbf25a Save sstable id as string in activity table
patch by Jacek Lewandowski; reviewed by Andrés de la Peña and Ekaterina Dimitrova for CASSANDRA-17585
2022-04-29 12:37:01 +01:00
Stefan Miklosovic bd36cb9f6b implement startup check to prevent Cassandra to potentially spread zombie data
patch by Stefan Miklosovic; reviwed by Paulo Motta and Brandon Williams for CASSANDRA-17180
2022-04-29 13:22:51 +02:00
Marcus Eriksson 7ce140bd1d Fail starting when the same parameter exists more than once in cassandra.yaml
Patch by marcuse; reviewed by David Capwell and Ekaterina Dimitrova for CASSANDRA-17379
2022-04-29 10:31:20 +02:00
Savni Nagarkar da7c662227 Migrate threshold for minimum keyspace replication factor to guardrails
patch by Savni Nagarkar; reviewed by Andres de la Peña, David Capwell for CASSANDRA-17212
2022-04-28 20:14:36 -07:00
Stefan Miklosovic 2180a34bbb Revert "Add a system property to set hostId if not yet initialized"
This reverts commit 33ff36cc42.

patch by Stefan Miklosovic; reviewed by Brandon Williams and Sam Tunnicliffe for CASSANDRA-14582
2022-04-28 15:09:46 +02:00
Jon Meredith 0c37176673 Merge branch 'cassandra-4.0' into trunk 2022-04-27 12:06:52 -06:00
Jon Meredith 2405d523fa Merge branch 'cassandra-3.11' into cassandra-4.0 2022-04-27 12:03:28 -06:00
Jon Meredith 804098e68b Merge branch 'cassandra-3.0' into cassandra-3.11 2022-04-27 12:01:08 -06:00
Jon Meredith 2fdbda6ac9 Schema mutations may not be completed on drain
patch by Jon Meredith; reviewed by Caleb Rackliffe for CASSANDRA-17524
2022-04-27 11:59:47 -06:00
Josh McKenzie 6bd373f5d2 Add guardrail to disallow TRUNCATE and DROP TABLE commands
Patch by Josh McKenzie; reviewed by Aleksey Yeschenko for CASSANDRA-17558
2022-04-27 11:52:24 -04:00
Savni Nagarkar f444c40286 Add guardrail to disallow querying with ALLOW FILTERING
patch by Savni Nagarkar; reviewed by Andres de la Peña, David Capwell and Josh McKenzie for CASSANDRA-17370
2022-04-26 18:26:17 +01:00
Marcus Eriksson 545809616c Track top partitions by size and tombstone count
Patch by marcuse; reviewed by David Capwell and Yifan Cai for CASSANDRA-16310
2022-04-26 14:59:37 +02:00
Andrés de la Peña 49cc352916 Make GuardrailDiskUsageTest deterministic
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-17576
2022-04-23 20:25:06 +01:00
David Capwell 3409e5d9b3 Enhance SnakeYAML properties to be reusable outside of YAML parsing, support camel case conversion to snake case, and add support to ignore properties
patch by David Capwell; reviewed by Caleb Rackliffe, Stefan Miklosovic for CASSANDRA-17166
2022-04-22 20:17:45 -07:00
David Capwell 2b90ac1a16 nodetool compact should support using a key string to find the range to avoid operators having to manually do this
patch by David Capwell; reviewed by Marcus Eriksson for CASSANDRA-17537
2022-04-22 15:37:01 -07:00
Benedict Elliott Smith 018c8e0d5e Optimise BTree build, update and transform operations
Patch Benedict Elliott Smith; reviewed by Branimir Lambov and Benjamin Lerer for CASSANDRA-15510
2022-04-22 19:27:19 +02:00
Andrés de la Peña b3842de5cf Add guardrail for data disk usage
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova and Stefan Miklosovic for CASSANDRA-17150

Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
Co-authored-by: Zhao Yang <jasonstack.zhao@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
2022-04-22 16:36:07 +01:00
Tibor Répási c26dc06a28 add datapaths subcommand to nodetool
patch by Tibor Repasi; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-17568
2022-04-22 14:48:37 +02:00
Benjamin Lerer 1ad8bf67a9 Allow to aggregate by time intervals
Patch by Benjamin Lerer; review by Andres De la Pena and Yifan Cai for CASSANDRA-11871

The patch allow to use pure monotonic functions on the last attribute of the GROUP BY clause and introduce some floor functions that can be use to group by time range.

A function is pure if:
    1. The function return values are identical for identical arguments
    2. The function application has no side effects

A function is monotonic if it is either entirely nonincreasing or nondecreasing.
2022-04-22 10:59:42 +02:00
David Capwell 7db3285e7b Migrate track_warnings to more standard naming conventions and use latest configuration types rather than long
patch by David Capwell; reviewed by Andres de la Peña, Caleb Rackliffe for CASSANDRA-17560
2022-04-21 14:32:25 -07:00
ROCHETEAU Antoine d80bb323c9 CONTAINS and CONTAINS KEY support for Lightweight Transactions
patch by ROCHETEAU Antoine; reviewed by Benjamin Lerer, Berenguer Blasi for CASSANDRA-10537
2022-04-21 09:16:07 +02:00
Ekaterina Dimitrova dac738d2eb Transfer config parameters to the new types; Fix corner case for permissions_update_interval, roles_update_interval, credentials_update_interval;Fix typo in Config annotation; Made Converters type safe and fixed a few cases where converters used the wrong type; o should be provided with unit to DataStorageSpec and DurationStorageSpec; Fix null bug in DataStorageSpec and DurationSpec
patch by Ekaterina Dimitrova, David Capwell; reviewed by David Capwell and Caleb Rackliffe for CASSANDRA-17431

Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
Co-authored-by: David Capwell <dcapwell@apache.org>
2022-04-20 10:20:30 -04:00
Ekaterina Dimitrova 03ef67c9d5 Merge branch 'cassandra-4.0' into trunk 2022-04-17 14:39:19 -04:00
Ekaterina Dimitrova a46e467737 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-04-17 14:29:18 -04:00
Ekaterina Dimitrova eeb89ea53b Merge branch 'cassandra-3.0' into cassandra-3.11 2022-04-17 14:22:57 -04:00
Ekaterina Dimitrova fb66800a00 Fix data corruption in AbstractCompositeType due to static boolean byte buffers
patch by Stefania Alborghetti and Marcus Eriksson; reviewed by Marcus Eriksson, Benjamin Lerer and Ekaterina Dimitrova for CASSANDRA-14752

Co-authored-by: Stefania Alborghetti <stefania.alborghetti@datastax.com>
Co-authored-by: Marcuse Eriksson <marcuse@apache.orgp>
2022-04-17 14:02:49 -04:00
Stefan Miklosovic 74bb6d8496 Shutdown ScheduledExecutors as part of node drainage
patch by Stefan Miklosovic; reviewed by Jon Meredith for CASSANDRA-17493
2022-04-13 22:18:28 +02:00
Josh McKenzie 47cac5c49b Provide JMX endpoint to allow transient logging of blocking read repairs
Patch by Josh McKenzie; reviewed by David Capwell for CASSANDRA-17471

Co-authored-by: Aleksey Yeschenko <aleksey@apache.org>
Co-aurhoted-by: Josh McKenzie <jmckenzie@apache.org>
2022-04-13 11:11:55 -04:00
Josh McKenzie 72af1f75fc Add guardrail for GROUP BY queries
Patch by Josh McKenzie; reviewed by David Capwell and Andres de la Pena for CASSANDRA-17509
2022-04-13 11:04:08 -04:00
Savni Nagarkar 20175bf77e Remove guardrails global enable flag
patch by Savni Nagarkar; reviewed by Andrés de la Peña and Joshua McKenzie for CASSANDRA-17499
2022-04-12 11:28:55 +01:00
Jon Meredith e3b3a59c6c Merge branch 'cassandra-4.0' into trunk 2022-04-08 14:41:36 -06:00
Jon Meredith ce6a65cb29 Clean up schema migration coordinator and tests
patch by Jon Meredith; reviewed by David Capwell for CASSANDRA-17533
2022-04-08 14:39:33 -06:00
David Capwell 2fde9af74f Clients using JMX are unable to handle non-standard java types but we leak this into our interfaces
patch by David Capwell; reviewed by Alex Petrov, Andres de la Peña for CASSANDRA-17527
2022-04-08 13:22:20 -07:00
Caleb Rackliffe af90c36340 Reduce histogram snapshot long[] allocation overhead during speculative read and write threshold updates
patch by Caleb Rackliffe; reviewed by Josh McKenzie for CASSANDRA-17523
2022-04-07 15:33:31 -05:00
Josh McKenzie 910bbb9b5f Add guardrail to disallow creation of secondary indexes
Patch by Josh McKenzie; reviewed by Chris Lohfink for CASSANDRA-17498
2022-04-07 15:53:23 -04:00
Josh McKenzie 105d69fdc5 Add guardrail to disallow creation of uncompressed sstables
Patch by Josh McKenzie; reviewed by David Capwell for CASSANDRA-17504
2022-04-07 15:33:34 -04:00
Josh McKenzie 01c4404fff Add guardrail to disallow creation of new COMPACT STORAGE tables
Patch by Josh McKenzie; reviewed by Caleb Rackliffe for CASSANDRA-17522
2022-04-07 14:08:47 -04:00
David Capwell 828d98e9d7 repair vtables should expose a completed field due to lack of filtering options in CQL
patch by David Capwell; reviewed by Chris Lohfink, Zhao Yang for CASSANDRA-17520
2022-04-06 13:12:08 -07:00
Jogesh Anand e137c7c34c Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
patch by Jogesh Anand; reviewed by Benjamin Lerer, Berenguer Blasi for CASSANDRA-16916
2022-04-04 11:35:16 +02:00
Jon Meredith fa7185ef02 Streaming sessions longer than 3 minutes fail with timeout
patch by Jon Meredith; reviewed by Benedict Elliott Smith, Caleb Rackliffe for CASSANDRA-17510
2022-04-01 17:01:50 -06:00
David Capwell ffa1e9cf5a Add ability to track state in repair
patch by David Capwell; reviewed by Zhao Yang for CASSANDRA-15399
2022-04-01 10:11:42 -07:00
Brandon Williams f32d2b06de Upgrade slf4j to 1.7.25
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-17474
2022-03-31 07:21:25 -05:00
Caleb Rackliffe 57ab3afcf1 reduce hot-path object allocations required to record local/remote requests against the client request metrics
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-17424

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
2022-03-29 11:55:55 -05:00
Caleb Rackliffe 7b58b79fe2 Merge branch 'cassandra-4.0' into trunk 2022-03-28 15:40:17 -05:00
Caleb Rackliffe 0089858819 Shut repair task executor down without interruption to avoid compromising shared channel proxies
patch by Caleb Rackliffe; reviewed by David Capwell, Marcus Eriksson, and Josh McKenzie for CASSANDRA-17466
2022-03-28 15:30:53 -05:00
Josh McKenzie 3d9365096b Disallow removal of a DC from system_auth replication settings
Patch by Josh McKenzie; reviewed by Jon Meredith for CASSANDRA-17478

Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
Co-authored-by: Nachiket Patil <nachiket_patil@apple.com>
2022-03-28 14:01:35 -04:00
Andrés de la Peña 8a3b9260a9 Add guardrail for the number of fields per UDT
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-17385
2022-03-28 17:50:15 +01:00
Stefan Miklosovic 7c1ed6c409 Merge branch 'cassandra-4.0' into trunk 2022-03-28 14:27:08 +02:00
Yash Ladha d0458abdb3 generate valid KEYSPACE / MATERIALIZED VIEW for CQL for views
patch by Yash Ladha; reviewed by Benjamin Lerer for CASSANDRA-17266

Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
2022-03-26 10:16:48 +01:00
Josh McKenzie 10103d353c Add required -f option to nodetool verify
Patch by Josh McKenzie; reviewed by Marcus Eriksson, Berenguer Blasi, and Caleb Rackliffe for CASSANDRA-17017

Co-authored by Josh McKenzie <jmckenzie@apache.org>
Co-authored by Chris Lohfink <clohfink@apple.com>
2022-03-24 11:54:16 -04:00
Brandon Williams a64e218d0f Merge branch 'cassandra-4.0' into trunk 2022-03-23 09:22:47 -05:00
Brandon Williams 4f5feac0df Fix timestamp tz parsing
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-17467
2022-03-23 09:21:38 -05:00
Jacek Lewandowski 0040fea379 Implement sstable generation identifier as uuid
Patch by Jacek Lewandowski; reviewed by Andrés de la Peña, Benjamin Lerer and Dan Jatnieks for CASSANDRA-17048
2022-03-23 11:50:33 +00:00
Bereng 30ad754d7e Pre hashed passwords in CQL
patch by Robert Stupp and Berenguer Blasi; reviewed by Andres de la Peña for CASSANDRA-17334

Co-authored-by: Robert Stupp <snazy@snazy.de>
Co-authored-by: Berenguer Blasi <berenguerblasi@gmail.com>
2022-03-23 07:20:14 +01:00
Josh McKenzie fbd6b04791 Log largest memtable on flush at info rather than debug
Patch by Josh McKenzie; reviewed by Brandon Williams for CASSANDRA-17472
2022-03-22 15:18:44 -04:00
Caleb Rackliffe 4ea3e4c505 Add native transport rate limiter options to example cassandra.yaml, and expose metric for dispatch rate
patch by Caleb Rackliffe; reviewed by Josh McKenzie for CASSANDRA-17423
2022-03-21 11:39:28 -05:00
Andrés de la Peña 143a5e8b06 Add diagnostic events for guardrails
patch by Andrés de la Peña; reviewed by Berenguer Blasi and Stefan Miklosovic for CASSANDRA-17197

Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
Co-authored-by: Aleksandr Sorokoumov <aleksandr.sorokoumov@gmail.com>
2022-03-21 15:52:25 +00:00
Bereng 2f84f492a2 Revert "Pre hashed passwords in CQL"
This reverts commit 6946b304e9.
2022-03-21 13:19:31 +01:00
Bereng 6946b304e9 Pre hashed passwords in CQL
patch by Berenguer Blasi; reviewed by Andres de la Peña for CASSANDRA-17334
2022-03-21 11:18:05 +01:00
Stefan Miklosovic 8714f92685 Merge branch 'cassandra-4.0' into trunk 2022-03-20 16:06:35 +01:00
Stefan Miklosovic d48df9169d make sstableloader honour native port option
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-17210
2022-03-20 15:24:33 +01:00
Jon Meredith e417fea126 Merge branch 'cassandra-4.0' into trunk 2022-03-19 08:05:52 -06:00
Jon Meredith f8be6ea60c Merge branch 'cassandra-3.11' into cassandra-4.0 2022-03-19 08:03:34 -06:00
Jon Meredith 311e26bf05 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-03-19 08:02:15 -06:00
Jon Meredith 647ec92db1 ConnectionLimitHandler may leaks connection count if remote connection drops
patch by Jon Meredith; reviewed by Caleb Rackliffe for CASSANDRA-17252
2022-03-19 08:00:58 -06:00
Benjamin Lerer 34a7eba4b8 Merge branch cassandra-4.0 into trunk 2022-03-18 15:08:15 +01:00
cclive1601 e773bbd9c6 Reject snapshot names with special character
Patch by Maxwell Guo, Saranya Krishnakumar and Francisco Guerrero; review
by Benjamin Lerer, Chris Lohfink, Stefan Miklosovic for CASSANDRA-15297

This commit also adds unit tests for the snapshot nodetool command.

Co-authored-by: Saranya Krishnakumar <saranya_k@apple.com>
Co-authored-by: Francisco Guerrero <francisco.guerrero@apple.com>
2022-03-18 15:00:24 +01:00
Doug Rohrer f1c1694e43 Support DELETE in CQLSSTableWriter
patch by Doug Rohrer, Eric Evans; reviewed by Sam Tunnicliffe, Yifan Cai for CASSANDRA-14797
2022-03-17 13:25:00 -07:00
Jon Meredith 431c692b88 Failed inbound internode authentication failures generate ugly warning with stack trace
patch by Jon Meredith; reviewed by David Capwell for CASSANDRA-17068
2022-03-16 15:41:27 -06:00
Maciej Sokol f7009cf340 emit warning on keyspace creation when replication factor is bigger than the number of nodes
patch by Maciej Sokol; reviewed by Brandon Williams and Stefan Miklosovic for CASSANDRA-16747
2022-03-16 21:42:50 +01:00
Francisco Guerrero 61be4d8362 expose gossip information in system_views.gossip_info virtual table
patch by Francisco Guerrero; reviewed by Stefan Miklosovic and Yifan Cai for CASSANDRA-17002

This commit adds a new virtual table that exposes the gossip information in tabular format.

The information is the same as the information presented through the `nodetool gossipinfo`
command, but the virtual table splits the version and value from `VersionedValue` into two
different columns. This is intented to help clients reading the vtable without the need of
parsing the version:value information (as it currently stands in gossipinfo).

The token value does not have a column. This is consistent with the gossipinfo output which
always renders ":<hidden>" for the Token value. Only the token_version column is available.
2022-03-16 01:41:10 +01:00
Andrés de la Peña 935bcf1e87 Add guardrails for collection items and size
patch by Andrés de la Peña; reviewed by Berenguer Blasi for CASSANDRA-17153
2022-03-15 13:31:41 +00:00
Jacek Lewandowski 56ec75cc65 Fix file overwriting in PathUtils
Patch by Jacek Lewandowski, reviewed by Benedict for CASSANDRA-17439
2022-03-15 10:58:26 +00:00
Paulo Motta 951645a1fc Merge branch 'cassandra-4.0' into trunk 2022-03-14 17:25:04 -03:00
Paulo Motta 5f50c797bc Merge branch 'cassandra-3.11' into cassandra-4.0 2022-03-14 17:18:21 -03:00
Paulo Motta 95a6223057 Fix snapshot true size calculation
Patch by Paulo Motta; Reviewed by Brandon Williams and Benjamin Lerer for CASSANDRA-17267
2022-03-14 17:17:37 -03:00
Andrés de la Peña 0ecd48001f Improve guardrails messages
Guardrail messages include a specific mention of the guardrail framework and the name of the violated guardrail,
so users know what is producing the wanrning or failure. Also, guardrails throw their own type of exception.

patch by Andrés de la Peña; reviewed by Josh McKenzie for CASSANDRA-17430
2022-03-14 17:05:18 +00:00
Andrés de la Peña a41040ccdc Add guardrails for read/write consistency levels
patch by Andrés de la Peña; reviewed by Caleb Rackliffe for CASSANDRA-17188

Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
Co-authored-by: Aleksandr Sorokoumov <aleksandr.sorokoumov@gmail.com>
2022-03-11 15:36:39 +00:00
Jacek Lewandowski 2b2c6decfa Refactor schema management to allow for schema source pluggability
Patch by Jacek Lewandowski, reviewed by Alex Petrov for CASSANDRA-17044.
2022-03-11 11:03:43 +01:00
Benedict Elliott Smith d2923275e3 CEP-14: Paxos Improvements
This work encompasses a range of improvements to Paxos, summarised as:

 - The introduction of Paxos Repair for ensuring consistency during range movements
 - The reduction of network round-trips by a factor of 2x for reads and writes

patch by Benedict Elliott Smith and Blake Eggleston; reviewed by Alex Petrov, Aleksey Yeschenko and Sam Tunnicliffe for CASSANDRA-17164
2022-03-10 16:30:12 +00:00
Benedict Elliott Smith 8960b4d851 [CASSANDRA-17177] List Appends Are Not Linearizable 2022-03-10 16:30:12 +00:00
Benedict Elliott Smith 5a0d6154d1 [CASSANDRA-17176] Introduce TimeUUID
patch by Benedict; reviewed by Blake Eggleston for CASSANDRA-17176
2022-03-10 16:30:12 +00:00
Andrés de la Peña eb960b1917 Merge branch 'cassandra-4.0' into trunk 2022-03-10 13:28:47 +00:00
Andrés de la Peña bdeafa0b79 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-03-10 13:18:55 +00:00
Andrés de la Peña fcdb3d154e Merge branch 'cassandra-3.0' into cassandra-3.11 2022-03-10 13:08:38 +00:00
Maciej Sokol c52b5ab95c Disallow CONTAINS for UPDATE and DELETE
patch by Maciej Sokol; reviewed by Andres de la Peña and Benjamin Lerer for CASSANDRA-15266
2022-03-10 13:05:42 +00:00
Marcus Eriksson 60675cc275 Remove and ban use of Instant.now
Patch by marcuse; reviewed by Benedict Elliott Smith for CASSANDRA-17414
2022-03-09 10:57:50 +01:00
Brandon Williams ca218cc012 Merge branch 'cassandra-4.0' into trunk 2022-03-08 17:23:30 -06:00
Brandon Williams 04c1289bb9 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-03-08 17:20:50 -06:00
Jan Karlsson b18a9f0337 Validate existence of DCs when repairing
Patch by Jan Karlsson; reviewed by bereng and brandonwilliams for
CASSANDRA-17407
2022-03-08 17:19:31 -06:00
Stefan Miklosovic 67b14e47c3 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-03-08 21:45:56 +01:00
Stefan Miklosovic 4a15c5ad5a filter out NULL_VERSION entries from peers table in ConfiguredLimit
patch by Stefan Miklosovic; reviewed by Brandon Williams and Sam Tunnicliffe for CASSANDRA-16518
2022-03-08 18:10:51 +01:00
Stefan Miklosovic 8def4fd7fb dropping of a materialized view creates a snapshot with dropped- prefix
patch by Stefan Miklosovic; reviewed by Paulo Motta for CASSANDRA-17415
2022-03-08 14:46:10 +01:00
Andrés de la Peña 3233c82311 Add guardrail for SELECT IN terms and their cartesian product
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-17187

Co-authored-by: Aleksandr Sorokoumov <aleksandr.sorokoumov@gmail.com>
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
2022-03-08 11:08:29 +00:00
Tibor Répási 537d02d25f Expose all client options via system_views.clients and nodetool clientstats
patch by Tibor Repasi reviewed by Benjamin Lerer, Berenguer Blasi, Ekaterina Dimitrova for CASSANDRA-16378
2022-03-08 11:12:37 +01:00
Stefan Miklosovic ae50cbd1ad deprecate property windows_timer_interval
patch by Stefan Miklosovic; reviewed by Ekaterina Dimitrova and Berenguer Blasi for CASSANDRA-17404
2022-03-08 08:27:18 +01:00
Andrés de la Peña 0d8126dd14 Merge branch 'cassandra-4.0' into trunk 2022-03-07 16:30:02 +00:00
jacek-lewandowski a690f339ab Fix ObjectSizes implementation and usages
patch by Jacek Lewandowski; reviewed by Andrés de la Peña and Branimir Lambov for CASSANDRA-17402
2022-03-07 16:22:30 +00:00
Yifan Cai df9586da33 Merge branch 'cassandra-4.0' into trunk 2022-03-04 10:45:23 -08:00
Bernardo Botella Corbi fd5e2ad74e Fix race condition bug during local session repair
patch by Bernardo Botella Corbi; reviewed by Berenguer Blasi, Yifan Cai for CASSANDRA-17335
2022-03-04 10:43:43 -08:00
Brandon Williams 754fc5d075 Fix bad merge one last time. 2022-03-02 13:35:00 -06:00
Dmitry Potepalov a8bbd22d37 Fix ignored streaming encryption settings in sstableloader
Patch by Dmitry Potepalov; reviewed by bereng and brandonwilliams for
CASSANDRA-17367

Encryption settings were silently lost in BulkLoadConnectionFactory.
Forced the bulk loader test to do some actual streaming besides just
handshaking on the native port, the test does not pass without the
change in BulkLoadConnectionFactory.
2022-03-02 08:00:40 -06:00
Dmitry Potepalov 0e249fd15e Fix ignored streaming encryption settings in sstableloader
Patch by Dmitry Potepalov; reviewed by bereng and brandonwilliams for
CASSANDRA-17367

Encryption settings were silently lost in BulkLoadConnectionFactory.
Forced the bulk loader test to do some actual streaming besides just
handshaking on the native port, the test does not pass without the
change in BulkLoadConnectionFactory.
2022-03-02 07:45:13 -06:00
David Capwell e87a1e0c0a Expose streaming as a vtable
patch by David Capwell; reviewed by Dinesh Joshi, Paulo Motta for CASSANDRA-17390
2022-03-01 14:33:21 -08:00
Bereng e780b5a45b Error out on noop GRANT/REVOKE
patch by Berenguer Blasi; reviewed by Andres de la Peña for CASSANDRA-17333
2022-02-28 07:17:37 +01:00
Stefan Miklosovic eac9d92562 make startup checks configurable
patch by Stefan Miklosovic; reviewed by Paulo Motta for CASSANDRA-17220
2022-02-28 00:36:53 +01:00
Yifan Cai b83da7d978 Correct size unit to mebibypes 2022-02-25 14:38:43 -08:00
Ekaterina Dimitrova 75bea27e5e Merge branch 'cassandra-4.0' into trunk 2022-02-25 16:05:23 -05:00
Aleksandr Sorokoumov a8b67e3dd9 Streaming tasks handle empty SSTables correctly
patch by Aleksandr Sorokoumov; reviewed by Marcus Eriksson and Zhao Yang for CASSANDRA-16349
2022-02-25 15:45:45 -05:00
Serban Teodorescu 193d4ef3a7 Prevent SSTableLoader from doing unnecessary work
patch by Serban Teodorescu; reviewed by Aleksandr Sorokoumov, Marcus Eriksson and Zhao Yang for CASSANDRA-16349
2022-02-25 15:45:33 -05:00
Ekaterina Dimitrova 12e2c159f8 Forward port from cassandra-4.0(CASSANDRA-17377) - deprecation of otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages, otc_backlog_expiration_interval_ms
patch by Ekaterina Dimitrova; reviewed by David Capwell for CASSANDRA-17378
2022-02-25 12:42:37 -05:00
Ekaterina Dimitrova 65fcc79b62 Revert removal of deprecated max_streaming_retries into Config, revert name change to user_defined_function_warn_timeout and user_defined_function_fail_timeout
patch by Ekaterina Dimitrova; reviewed by David Capwell for CASSANDRA-17378
2022-02-25 12:39:44 -05:00
Ekaterina Dimitrova 769f6b3122 Merge branch 'cassandra-4.0' into trunk 2022-02-25 11:54:34 -05:00
Ekaterina Dimitrova 22a4ae16e4 Deprecate JavaScript user-defined functions
patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi and Marcus Eriksson for CASSANDRA-17280
2022-02-25 11:32:25 -05:00
tejavadali 7ea0a4aa41 Add guardrail for number of partition keys on IN queries
patch by Krishna Vadali; reviewed by Andrés de la Peña and Berenguer Blasi for CASSANDRA-17186
2022-02-23 12:47:27 +00:00
Marcus Eriksson c69e37eca7 Merge branch 'cassandra-4.0' into trunk 2022-02-17 10:39:33 +01:00
Marcus Eriksson 702824a99d Merge branch 'cassandra-3.11' into cassandra-4.0 2022-02-17 10:36:54 +01:00
Marcus Eriksson e53ad64612 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-02-17 10:30:27 +01:00
Marcus Eriksson b58a5c86e8 LeveledCompactionStrategy disk space check improvements
Patch by marcuse; reviewed by Caleb Rackliffe for CASSANDRA-17272
2022-02-17 10:25:43 +01:00
Yifan Cai 8327744c1a Fix improper CDC commit log segments deletion in non-blocking mode
patch by Yifan Cai; reviewed by Josh McKenzie for CASSANDRA-17233
2022-02-16 22:56:18 -08:00
Marcus Eriksson e56bf105a1 Merge branch 'cassandra-4.0' into trunk 2022-02-16 11:09:55 +01:00
Marcus Eriksson 2687cf1edf Merge branch 'cassandra-3.11' into cassandra-4.0 2022-02-16 11:08:20 +01:00
Marcus Eriksson eeec360e75 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-02-16 10:14:41 +01:00
Marcus Eriksson 85c202d8a8 Lazy transaction log replica creation allows incorrect replica content divergence during anticompaction
Patch by marcuse; reviewed by Caleb Rackliffe for CASSANDRA-17273
2022-02-16 10:12:14 +01:00
Alex Petrov 81922c5a7b Intoduce Harry to the tree
Patch by Alex Petrov; reviewed by Caleb Rackliffe and Abe Ratnofsky for CASSANDRA-16262.
2022-02-16 09:00:36 +01:00
Ekaterina Dimitrova 537ad9e17b Deprecate otc_coalescing_strategy, otc_coalescing_window_us, otc_coalescing_enough_coalesced_messages,
otc_backlog_expiration_interval_ms (CASSANDRA-17377)
patch by Ekaterina Dimitrova; reviewed by Brandon Williams for CASSANDRA-17377
2022-02-12 20:17:30 -05:00
Manish Ghildiyal 5cf62c6c02 Add support for string concatenations through the + operator
Patch by Manish Ghildiyal; review by Benjamin Lerer, Berenguer Blassi,
Brandon Williams for CASSANDRA-17190
2022-02-11 15:39:06 +01:00
Marcus Eriksson 9649cb1358 Merge branch 'cassandra-4.0' into trunk 2022-02-11 14:09:50 +01:00
Paul Chandler c60ad61b3b Improve start up processing of Incremental Repair information read from system.repairs
Patch by Paul Chandler, reviewed by Brandon Williams and Marcus Eriksson for CASSANDRA-17342
2022-02-11 14:07:51 +01:00
Yifan Cai 3a6f690731 Limit the maximum hints size per host
patch by Yifan Cai; reviewed by Dinesh Joshi, Francisco Guerrero for CASSANDRA-17142
2022-02-10 17:18:29 -08:00
Michael Burman ce7502a110 Add a virtual table for exposing batch metrics
Patch by Michael Burman; review by Aleksei Zotov, Benjamin Lerer and Ekaterina Dimitrova for CASSANDRA-17225
2022-02-10 09:47:09 +01:00
Andrés de la Peña 8e1c8f9863 Flatten guardrails config
patch by Andrés de la Peña; reviewed by David Capwell for CASSANDRA-17353
2022-02-09 18:31:37 +00:00
Francisco Guerrero 543608ba39 Instance failed to start up due to NPE in StartupClusterConnectivityChecker
patch by Francisco Guerrero; reviewed by Stefan Miklosovic, Yifan Cai for CASSANDRA-17347
2022-02-09 10:22:35 -08:00
David Capwell f0c97132c9 Make vtables accessible via internode messaging
patch by David Capwell; reviewed by Aleksey Yeschenko for CASSANDRA-17295
2022-02-08 17:09:01 -08:00
Maulin Vasavada 3655b26adf Add support for PEM based key material for SSL
patch by Maulin Vasavada; reviewed by Jon Meredith and Stefan Miklosovic for CASSANDRA-17031
2022-02-07 22:18:14 +01:00
Marcus Eriksson 210793f943 Merge branch 'cassandra-4.0' into trunk 2022-02-07 13:01:12 +01:00
Marcus Eriksson 66d792adda Merge branch 'cassandra-3.11' into cassandra-4.0 2022-02-07 13:00:46 +01:00
Marcus Eriksson b022aecfa6 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-02-07 13:00:23 +01:00
Marcus Eriksson 5c9ba06dd3 Extend operator control over the UDF threading model
Patch by marcuse; reviewed by Sam Tunnicliffe and Benedict Elliott Smith for CASSANDRA-17352
2022-02-07 12:59:39 +01:00
Alex Petrov e256b98172 Merge branch 'cassandra-4.0' into trunk 2022-02-07 11:55:39 +01:00
Alex Petrov 371add40ae Merge branch 'cassandra-3.11' into cassandra-4.0 2022-02-07 11:26:13 +01:00
Alex Petrov 5d0aeb1996 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-02-07 11:10:54 +01:00
Alex Petrov 242f7f9b18 Fix Prepared Statements behaviours after 15252
Patch by Alex Petrov; reviewed by Marcus Eriksson for CASSANDR-17248.

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
2022-02-07 11:06:14 +01:00
Ekaterina Dimitrova 9f56bf4ca7 Remove old Duration class in favor of DurationSpec class
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:39:53 -05:00
Ekaterina Dimitrova c51a7c66fc Bulk change of units around the code to support the move to the new configuration framework
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:28:57 -05:00
Ekaterina Dimitrova 6d5203615f Transfer parameters to the newly introduced configuration framework (7)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:28:48 -05:00
Ekaterina Dimitrova 23138252f2 Transfer parameters to the newly introduced configuration framework (6)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:28:40 -05:00
Ekaterina Dimitrova 1315d0c96f Transfer parameters to the newly introduced configuration framework (5)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:28:32 -05:00
Ekaterina Dimitrova ed48f3c017 Transfer parameters to the newly introduced configuration framework (4)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:28:23 -05:00
Ekaterina Dimitrova 755fd9446b Transfer parameters to the newly introduced configuration framework (3)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:28:14 -05:00
Ekaterina Dimitrova d85f7f7c2d Transfer parameters to the newly introduced configuration framework (2)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:28:04 -05:00
Ekaterina Dimitrova b9e2ab75f8 Extend DurationSpec and DataStorageSpec for smallest unit and transfer denylist parameters to the new framework
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:27:47 -05:00
Ekaterina Dimitrova a3258d66bc Transfer parameters to the newly introduced configuration framework (1)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:27:37 -05:00
Ekaterina Dimitrova 5bb4bab12f DataRate parameters transition to the new framework
Fix the DB descriptorRefTest which failed on the previous commit
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:27:27 -05:00
Ekaterina Dimitrova 9c6b382058 Backward compatibility framework for configuration parameters
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:27:18 -05:00
Ekaterina Dimitrova db9f7a67ec Add new custom types and unit tests for configuration
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, David Capwell, Michael Semb Wever and Benjamin Lerer for CASSANDRA-15234
2022-02-05 22:27:03 -05:00
Stefan Miklosovic da47849b50 Remove Windows-specific classes and related code
patch by Stefan Miklosovic; reviewed by Joshua McKenzie, Bowen Song, Berenguer Blasi for CASSANDRA-16956
2022-02-05 15:41:33 +01:00
Caleb Rackliffe 28eea6e8cd Runtime-configurable YAML option to prohibit USE statements
patch by Caleb Rackliffe; reviewed by David Capwell for CASSANDRA-17318
2022-02-04 14:24:51 -06:00
David Capwell df16b3750d When streaming sees a ClosedChannelException this triggers the disk failure policy
patch by David Capwell, Francisco Guerrero; reviewed by Caleb Rackliffe, Dinesh Joshi for CASSANDRA-17116
2022-02-04 11:36:52 -08:00
Jon Meredith 6614c08c64 Merge branch 'cassandra-4.0' into trunk 2022-02-03 14:28:58 -07:00
Jon Meredith 965fe0decf Merge branch 'cassandra-3.11' into cassandra-4.0 2022-02-03 14:27:16 -07:00
Jon Meredith beb456305a Merge branch 'cassandra-3.0' into cassandra-3.11 2022-02-03 14:24:05 -07:00
Jon Meredith 9ff28fc717 Fixes for intermittent in-JVM dtest failures
patch by Jon Meredith, Caleb Rackliffe, Marcus Eriksson, Benedict Elliott Smith <benedict@apache.org>; reviewed by Caleb Rackliffe for CASSANDRA-17256
2022-02-03 14:22:46 -07:00
Aleksandr Sorokoumov 35dbcc2c2d CASSANDRA-15215 Use DataOutputPlus.writeBytes in VIntCoding.writeUnsignedVInt
In the cases where VInt occupies less than or equal to 8 bytes
and the underlying buffer has at least 8 bytes, VIntCoding writes the
entire register in a single operation and then adjusts the buffer position.

Co-authored-by: Benedict Elliott Smith <benedict@apache.org>
Co-authored-by: Branimir Lambov <branimir.lambov@datastax.com>
2022-02-02 12:13:04 +00:00
Shailaja Koppu 945a4fc23a Add a virtual table for exposing prepared statements metrics
patch by Shailaja Koppu; reviewed by Ekaterina Dimitrova, Francisco Guerrero, Yifan Cai for CASSANDRA-17224
2022-02-01 12:45:51 -08:00
Andrés de la Peña ecfe7e809b Merge branch 'cassandra-4.0' into trunk 2022-01-26 11:50:33 +00:00
Andrés de la Peña 67f913a706 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-01-26 11:43:14 +00:00
Andrés de la Peña bfab1fda88 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-01-26 11:38:48 +00:00
Andrés de la Peña 40bf53359c Fix conversion from megabits to bytes in streaming rate limiter
patch by Andrés de la Peña; reviewed by Berenguer Blasi for CASSANDRA-17243
2022-01-26 11:34:51 +00:00
Bereng 02dad368f1 Merge branch 'cassandra-4.0' into trunk 2022-01-26 08:14:28 +01:00
Bereng 95257c0805 Sstableverify unit test operate on SSTables
patch by Brian Houser; reviewed by Andres de la Peña, Berenguer Blasi for CASSANDRA-17009

Co-authored-by: Brian Houser <brianh@amazon.com>
Co-authored-by: Berenguer Blasi <berenguerblasi@gmail.com>
2022-01-26 08:09:03 +01:00
Bereng ff4d63d392 Merge branch 'cassandra-4.0' into trunk 2022-01-25 07:11:04 +01:00
Bereng 85248da628 PasswordObfuscator should not assume PASSWORD is the last item in the WITH clause
patch by Berenguer Blasi; reviewed by Benjamin Lerer, Ekaterina Dimitrova for CASSANDRA-16801
2022-01-25 07:08:48 +01:00
Francisco Guerrero e0a61f73b9 Revert "Add unix time conversion functions"
This reverts commit 8ddcd43b0c.
2022-01-19 16:30:15 -06:00
Marcus Eriksson 96c80f0b89 Merge branch 'cassandra-4.0' into trunk 2022-01-17 14:13:54 +01:00
Marcus Eriksson 9a1bb62822 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-01-17 14:09:45 +01:00
Marcus Eriksson b5d0626824 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-01-17 14:08:03 +01:00
Marcus Eriksson b1a8a56c56 Avoid race in AbstractReplicationStrategy endpoint caching
Patch by marcuse; reviewed by Alex Petrov and Jon Meredith for CASSANDRA-16673

Co-authored-by: Jon Meredith <jonmeredith@apache.org>
2022-01-17 14:06:25 +01:00
Marcus Eriksson df1a2d4c3d Merge branch 'cassandra-4.0' into trunk 2022-01-17 09:13:32 +01:00
Marcus Eriksson 98e798f567 Don't block gossip when clearing repair snapshots
Patch by marcuse; reviewed by David Capwell for CASSANDRA-17168
2022-01-17 09:11:00 +01:00
Brandon Williams 76f8333e9b Use abolute path when checking file stores
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-17084
2022-01-14 11:55:11 -06:00
Josh McKenzie 89c6addb50 Prewarm role and credentials caches to avoid timeouts at startup
Patch by Blake Eggleston; reviewed by Sam Tunnicliffe, Jason Brown, and Caleb Rackliffe for CASSANDRA-16958

Co-authored by: Blake Eggleston <bdeggleston@gmail.com>
Co-authored by: Josh McKenzie <jmckenzie@apache.org>
2022-01-13 15:45:19 -05:00
Aleksei Zotov bc20bddceb Make capacity/validity/updateinterval/activeupdate for Auth Caches configurable via nodetool
patch by Aleksei Zotov; reviewed by Josh McKenzie for CASSANDRA-17063
2022-01-10 13:19:22 +04:00
Ekaterina Dimitrova 7bd2764962 Merge branch 'cassandra-4.0' into trunk 2022-01-08 15:36:14 -05:00
Ekaterina Dimitrova 1a05fcf52b Deduplicate warnings for deprecated parameters (changed names)
patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe for CASSANDRA-17160
2022-01-08 15:31:06 -05:00
Kanthi Subramanian 9b291f18ab Add startup check for read_ahead_kb setting
Patch by Kanthi Subramanian; Reviewed by Paulo Motta and Brandon Williams for CASSANDRA-16436

Closes #1354
2022-01-03 18:39:17 -03:00
Paulo Motta 481c103951 Merge branch 'cassandra-4.0' into trunk 2022-01-03 11:57:42 -03:00
tejavadali c420d754d8 CASSANDRA-16308: Add droppable tombstone metrics to nodetool tablestats
patch by Krishna Vadali; reviewed by Paulo Motta and Brandon Williams for CASSANDRA-16308

Closes #1359
2022-01-03 11:56:14 -03:00
Benjamin Lerer 11952fae77 Avoid unecessary array allocations and initializations when performing query checks
patch by Benjamin Lerer; reviewed by Caleb Rackliffe  for CASSANDRA-17209
2021-12-20 14:02:48 +01:00
Andrés de la Peña 95522f85d5 Add guardrail for list operations that require read before write
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-17154
2021-12-17 16:50:20 +00:00
Andrés de la Peña bae92ee139 Migrate thresholds for number of keyspaces and tables to guardrails
This adds a new guardrail for limiting the number of keyspaces. It also  marks the previous not-guardrail thresholds
for keyspaces and tables as deprecated in favour of the equivalent guardrails. GuardrailsOptions is modified to always
log updates on guardrails config. A small refactor decouples guardrails from their configuration interfaces.

patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-17195
2021-12-17 16:33:00 +00:00
Josh McKenzie f4a2135c5b Remove strong ref loop in LogTransaction.SSTableTidier
Patch by Josh McKenzie; reviewed by Benedict Elliott Smith for CASSANDRA-17205
2021-12-17 11:22:01 -05:00
Kowalczyk bf1446cd85 Add guardrail for query page size
patch by Bartlomiej; reviewed by Andrés de la Peña and Brandon Williams for CASSANDRA-17189
2021-12-16 17:20:58 +00:00
Kowalczyk 75482d0a8c Simplify SchemaCQLHelperTest methods
Patch by Bartlomiej Kowalczyk; reviewed by Ekaterina Dimitrova and
Benjamin Lerer for CASSANDRA-17181
2021-12-15 18:37:10 +01:00
Francisco Guerrero a41cdd64b2 Allow column_index_size_in_kb to be configurable through nodetool
patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRA-17121
2021-12-14 11:28:39 -08:00
Stefan Miklosovic c64ff69bd9 Emit a metric for number of local read and write calls
patch by Damien Stevenson; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-10023
2021-12-13 18:46:19 +01:00
Brandon Williams e99a8da161 Don't clean when enabling FQL via JMX
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-17136
2021-12-09 16:06:48 -06:00
Brandon Williams aa82e3e427 Don't clean when enabling FQL via JMX
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-17136
2021-12-09 16:05:16 -06:00
Joseph Lynch 97b47c3b5f Merge branch 'cassandra-4.0' into trunk 2021-12-09 10:31:39 -05:00
Joseph Lynch e73d05bf85 Merge branch 'cassandra-3.11' into cassandra-4.0 2021-12-09 10:29:08 -05:00
Joseph Lynch 1fce84f983 Merge branch 'cassandra-3.0' into cassandra-3.11 2021-12-09 10:26:00 -05:00
Venkata Harikrishna Nukala 1911a887e8 Fix slow keycache load which blocks startup for tables with many sstables.
Patch by Venkata Harikrishna Nukala; reviewed by Marcus Eriksson and Joseph Lynch for CASSANDRA-14898
2021-12-09 10:14:16 -05:00
Yifan Cai d9460a04da Add non-blocking mode for CDC writes
patch by Yifan Cai; reviewed by Josh McKenzie for CASSANDRA-17001
2021-12-05 21:16:41 -08:00
Andrés de la Peña 7871a28542 Add guardrails framework prototype
patch by Andrés de la Peña; reviewed by David Capwell and Stefan Miklosovic for CASSANDRA-17147

Co-authored-by: Sylvain Lebresne <lebresne@gmail.com>
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
Co-authored-by: Aleksandr Sorokoumov <aleksandr.sorokoumov@gmail.com>
Co-authored-by: Zhao Yang <jasonstack.zhao@gmail.com>
Co-authored-by: Jakub Żytka <jakub.zytka@datastax.com>
2021-12-03 15:20:20 +00:00
Jacek Lewandowski cede538e02 Relax schema synchronization when opening a keyspace
Patch by Jacek Lewandowski; Reviewed by Branimir Lambov and Alex Petrov for CASSANDRA-17071.
2021-12-03 12:47:57 +01:00
Josh McKenzie 8e28dc0eba Harden resource management on SSTable components to prevent future leaks
Patch by Josh McKenzie; reviewed by Caleb Rackliffe and Marcus Erikkson for CASSANDRA-17174
2021-12-01 12:35:45 -05:00
Alex Petrov 92dc415902 Tolerate local files in data dir during startup
Patch by Alex Petrov; reviewed by Aleksey Yeschenko, Jon Meredith, and Caleb Rackliffe for CASSANDRA-17082

Co-authored-by: Alex Petrov <oleksandr.petrov@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2021-12-01 12:29:23 -05:00
Benedict Elliott Smith 209c35aa62 [CEP-10] Phase 4: Cluster and Code Simulation
patch by Benedict; reviewed by Sam Tunnicliffe for CASSANDRA-17008

Co-authored-by: Benedict Elliott Smith <benedict@apache.org>
Co-authored-by: Sam Tunnicliffe <samt@apache.org>
Co-authored-by: Alex Petrov <oleksandr.petrov@gmail.com>
2021-11-30 16:05:54 +00:00
Benedict Elliott Smith eae581a5f0 [CEP-10] Cluster and Code Simulations: Minor improvements
- Simplify Semaphore
- Future improvements
- ScheduledExecutorPlus improvements for simulator compatibility
- Debug leaks in Ref or BufferPool
- Support use of TokenMetadata without initialising Cassandra
- Additional system properties and simulator flags
- Permit Clock initialisation within separate ClassLoader
- Introduce BallotGenerator

patch by Benedict; reviewed by Sam Tunnicliffe for CASSANDRA-17008
2021-11-30 16:05:50 +00:00
Benedict Elliott Smith 31bea0b0d4 [CEP-10] Cluster and Code Simulations: Minor fixes
- fix repair timeout
- fix secondary index flushing
- fix race condition with Ref
- fix resource leaks
- fix incorrect exists()
- fix repair error reporting when null exception message
- fix dtest use of System.nanoTime

patch by Benedict; reviewed by Sam Tunnicliffe for CASSANDRA-17008
2021-11-30 16:05:44 +00:00
Benedict Elliott Smith 951d72cd92 [CEP-10] Phase 4: Support CAS Add Operations
Co-authored-by: Benedict Elliott Smith <benedict@apache.org>
Co-authored-by: Sam Tunnicliffe <samt@apache.org>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
2021-11-22 11:47:03 +00:00
Benedict Elliott Smith a965699c9e [CEP-10] Phase 3: Use paxos variant to specify behaviour
Co-authored-by: Benedict Elliott Smith <benedict@apache.org>
Co-authored-by: Sam Tunnicliffe <samt@apache.org>
2021-11-22 11:43:23 +00:00
Benedict Elliott Smith b6916017ca [CEP-10] Phase 3: Synchronized Legacy Paxos
patch by Benedict Elliott Smith and Blake Eggleston; reviewed by Sam Tunnicliffe for CASSANDRA-16934
2021-11-22 11:42:08 +00:00
David Capwell dcd7b0d35f repair prepare message would produce a wrong error message if network timeout happened rather than reply wait timeout
patch by David Capwell; reviewed by Berenguer Blasi for CASSANDRA-16992
2021-11-19 14:33:08 -08:00
Yifan Cai 4aab2c79b9 Increase the buckets count for timer histogram
patch by Yifan Cai; reviewed by Caleb Rackliffe for CASSANDRA-17155
2021-11-19 09:35:37 -08:00