Commit Graph

18611 Commits

Author SHA1 Message Date
Cameron Zemek 64d953fdca
Wait for live endpoints in gossip waiting to settle
patch by Cameron Zemek; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-18543
2023-06-15 12:59:13 +02:00
Brandon Williams 1f6b37d189 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-06-14 11:35:40 -05:00
Brandon Williams 2fcdaa5b76 Merge branch 'cassandra-3.11' into cassandra-4.0 2023-06-14 11:35:22 -05:00
ningzi.zhan 1eccb2bc1f Fix error message handling when trying to use CLUSTERING ORDER with non-clustering column
Patch by Ningzi Zhan and Tomasz Lasica; reviewed by brandonwilliams,
edimitrova and Maxwell Guo for CASSANDRA-17818

Co-Authored-By: Tomek Lasica <tomasz.lasica@datastax.com>
2023-06-14 11:34:03 -05:00
Jacek Lewandowski b0cf9ba219 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Track the amount of read data per row
2023-06-12 11:26:03 +02:00
Jacek Lewandowski 5143bd81e8 Track the amount of read data per row
If an sstable is corrupted in a nasty way, we may read invalid cell sizes and try to read much more data for a row than we should. In rare scenarios this can lead even to OOMs.

This simple fix adds tracking and limiting the amount of data that is read per row. Row has its size stored in preamble which can be used as a limit. If the deserialization code tries to read more than that, it will simply fail with EOF which will prevent more serious problems later.

Patch by Jacek Lewandowski; reviewed by Berenguer Blasi and Maxwell Guo for CASSANDRA-18513

# Conflicts:
#	src/java/org/apache/cassandra/db/rows/UnfilteredSerializer.java
2023-06-12 11:26:02 +02:00
Stefan Miklosovic 867c074dda
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-06-06 16:17:57 +02:00
Stefan Miklosovic f368b9dc1e
Merge branch 'cassandra-3.11' into cassandra-4.0 2023-06-06 16:14:34 +02:00
mghildiy 03da864bab
Add keyspace and table name to exception message during ColumnSubselection deserialization
patch by Manish Ghildiyal; reviewed by Brandon Williams and Stefan Miklosovic for CASSANDRA-18346
2023-06-06 16:00:26 +02:00
Stefan Miklosovic aa7ed179d3
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-06-05 15:58:04 +02:00
rgitt 5655a33bc0
Fix Down nodes counter in nodetool describecluster
patch by Goel Ranju; reviewed by Brandon Williams and Stefan Miklosovic for CASSANDRA-18512
2023-06-05 15:56:38 +02:00
Jon Meredith 208a71c008 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-31 12:12:50 -06:00
Jon Meredith 57293e8281 Merge branch 'cassandra-3.11' into cassandra-4.0 2023-05-31 12:04:29 -06:00
Doug Rohrer 43ec184391 Add support for JMX in the in-jvm dtest framework
patch by Doug Rohrer; reviewed by Alex Petrov, Jon Meredith, Francisco Guerrero Hernandez for CASSANDRA-18511
2023-05-31 12:02:26 -06:00
Stefan Miklosovic 441285d58e
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-30 22:19:11 +02:00
Stefan Miklosovic f66adb0278
Remove unnecessary shuffling of GossipDigests in Gossiper#makeRandomGossipDigest
This patch also fixes the bug when creating GossipDigests in case epState in
Gossiper#makeRandomGossipDigest was null. Previously, if it was null, it used
generation and maxVersion of the last non-null epState instead of zeros.

patch by Cameron Zemek; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-18546
2023-05-30 21:44:07 +02:00
Marcus Eriksson 72fc04d238 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-25 08:43:15 +02:00
Marcus Eriksson aafb4d1944 Improve nodetool enable{audit,fullquery}log
Patch by marcuse; reviewed by Dinesh Joshi and Mick Semb Wever for CASSANDRA-18550
2023-05-25 08:41:12 +02:00
Brandon Williams 93efe0ee04 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-24 09:37:11 -05:00
ningzi.zhan 54528bff20 Report network cache info in nodetool
Patch by Ningzi Zhan; reviewed by brandonwilliams and smiklosovic for
CASSANDRA-18400
2023-05-24 09:36:32 -05:00
Stefan Miklosovic 621faf7740
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-18 22:37:44 +02:00
Stefan Miklosovic ff820290dd
Merge branch 'cassandra-3.11' into cassandra-4.0 2023-05-18 22:37:07 +02:00
Ivan Senic 3ca94d65d3
Remove unnecessary String.format invocation in QueryProcessor when getting a prepared statement from cache
patch by Ivan Senic; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-17202
2023-05-18 22:36:27 +02:00
David Capwell 446a9d1d01 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-18 10:38:00 -07:00
Tobias Lindaaker 1053e3b475 Partial compaction can resurrect deleted data
patch by Tobias Lindaaker, Marcus Eriksson; reviewed by David Capwell, Marcus Eriksson for CASSANDRA-18507
2023-05-18 10:34:45 -07:00
Stefan Miklosovic 402e2f2f73
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-17 12:04:24 +02:00
Stefan Miklosovic 2bb634a339
Merge branch 'cassandra-3.11' into cassandra-4.0 2023-05-17 12:02:37 +02:00
Stefan Miklosovic f5c42f428c
Merge branch 'cassandra-3.0' into cassandra-3.11 2023-05-17 12:01:35 +02:00
Stefan Miklosovic b8e21fb80a
Validate the existence of a datacenter in nodetool rebuild
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-14319
2023-05-17 12:00:19 +02:00
Brandon Williams 67d73469b4 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-16 09:01:21 -05:00
Brandon Williams b791644fda Allow internal address to change with reconnecting snitches
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-16718
2023-05-16 09:00:14 -05:00
Stefan Miklosovic d7917a5144
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-11 15:58:49 +02:00
Bernardo Botella Corbi 75194201f1
Fix quoting in toCqlString methods of UDTs and aggregates
patch by Bernardo Botella Corbi, reviewed by Stefan Miklosovic, Benjamin Lerer and Yifan Cai for CASSANDRA-17918
2023-05-11 15:48:21 +02:00
Jon Meredith 7f4e9bb67b Merge branch 'cassandra-4.0' into cassandra-4.1 2023-05-09 17:55:24 -06:00
Jon Meredith ae995eb3d3 NPE when deserializing malformed collections from client
patch by Jon Meredith; reviewed by Caleb Rackliffe for CASSANDRA-18505
2023-05-09 17:47:49 -06:00
Mick Semb Wever 82dc54c3a8
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Improve 'Not enough space for compaction' logging messages
2023-05-04 12:25:00 +02:00
Henrik Ingo 65c99bfc42
Improve 'Not enough space for compaction' logging messages
Adds separate WARN level messages to the check itself in Directories.

 patch by Henrik Ingo; reviewed by Mick Semb Wever, Brad Schoening, Claude Warren, Kan Maung, maxwellguo  for CASSANDRA-18260
2023-05-04 12:23:00 +02:00
Stefan Miklosovic ba72d90141
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-04-27 11:20:09 +02:00
Stefan Miklosovic c4a305d17a
Merge branch 'cassandra-3.11' into cassandra-4.0 2023-04-27 11:18:37 +02:00
Stefan Miklosovic c74c9bb037
Merge branch 'cassandra-3.0' into cassandra-3.11 2023-04-27 11:16:41 +02:00
Stefan Miklosovic db78e746d7
Do not remove SSTables when cause of FSReadError is OutOfMemoryError while using best_effort disk failure policy
patch by Stefan Miklosovic; reviewed by Brandon Williams and Maxwell Guo for CASSANDRA-18336
2023-04-27 10:47:07 +02:00
Stefan Miklosovic e733edb6cc
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-04-26 13:43:19 +02:00
Stefan Miklosovic 5bcee5c06a
Merge branch 'cassandra-3.11' into cassandra-4.0 2023-04-26 13:41:02 +02:00
Stefan Miklosovic 81e78192cb
Merge branch 'cassandra-3.0' into cassandra-3.11 2023-04-26 13:36:40 +02:00
Stefan Miklosovic 4f348786bd
Do not remove truncated_at entry in system.local while dropping an index
patch by Stefan Miklosovic; reviewed by Caleb Rackliffe for CASSANDRA-18105
2023-04-26 11:00:06 +02:00
Jon Meredith 1d926e8c6f Merge branch 'cassandra-4.0' into cassandra-4.1 2023-04-25 12:08:39 -06:00
Jon Meredith 09c1e67598 Incremental repairs fail on mixed IPv4/v6 addresses serializing SyncRequest
patch by Jon Meredith; reviewed by Caleb Rackliffe for CASSANDRA-18474
2023-04-25 12:00:26 -06:00
Jon Meredith 4c13df58cb Merge branch 'cassandra-4.0' into cassandra-4.1 2023-04-21 10:55:55 -06:00
Jon Meredith cd9bed0aea Deadlock updating sstable metadata if disk boundaries need reloading
patch by Jon Meredith; reviewed by Marcus Eriksson for CASSANDRA-18443
2023-04-21 10:47:55 -06:00
Andrés de la Peña 2208235ce9 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-04-17 14:50:18 +01:00
Andrés de la Peña 3f67827387 Merge branch 'cassandra-3.11' into cassandra-4.0 2023-04-17 14:48:27 +01:00
Andrés de la Peña 08b9471a1e Fix sstable_count metric missing from tablestats json/yaml output
patch by Andrés de la Peña; reviewed by Brandon Williams and Ekaterina Dimitrova for CASSANDRA-18448
2023-04-17 14:36:01 +01:00
Maulin Vasavada bd49f6ff26
Allow keystore and truststore passwords to be nullable
patch by Maulin Vasavada; reviewed by Stefan Miklosovic and Caleb Rackliffe for CASSANDRA-18124
2023-04-14 14:02:51 +02:00
Stefan Miklosovic 5869dc0dac
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-04-14 11:49:08 +02:00
Maciej Sokol 2fce3025c4
Fix nested selection of reversed collections
patch by Maciej Sokol; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-17913
2023-04-14 11:33:46 +02:00
Josh McKenzie 085765a07c Merge branch 'cassandra-4.0' into cassandra-4.1 2023-04-03 16:12:59 -04:00
Josh McKenzie f6fce7ab51 Improve debuggability and correctness of ref detection
This patch is a backport of CASSANDRA-17205 and also raises
logging level to 'error' from 'warn' in StrongLeakDetector.

Patch by jmckenzie; reviewed by smiklosovic for CASSANDRA-18332
2023-04-03 16:03:33 -04:00
Caleb Rackliffe 853ae8c840 Avoid loading the preferred IP for BulkLoader streaming
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-18370

Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Jon Meredith <jonmeredith@apache.org>
2023-03-31 11:57:29 -05:00
Jacek Lewandowski 14936d0bd3 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Save host id to system.local and flush immediately after startup
2023-03-31 17:34:19 +02:00
Jacek Lewandowski 4b9c18235a Merge branch 'cassandra-3.11' into cassandra-4.0
* cassandra-3.11:
  Save host id to system.local and flush immediately after startup
2023-03-31 17:30:20 +02:00
Jacek Lewandowski ee586b53c2 Merge branch 'cassandra-3.0' into cassandra-3.11
* cassandra-3.0:
  Save host id to system.local and flush immediately after startup
  Remove asf.yaml from non-trunk branches
  Notify the corresponding JIRA issue as soon as the PR is raised
2023-03-31 17:30:19 +02:00
Jacek Lewandowski f96659c530 Save host id to system.local and flush immediately after startup
patch by Adriano Bonacin and Jacek Lewandowski; reviewed by Stefan Miklosovic and Sam Tunnicliffe for CASSANDRA-18153
2023-03-31 17:30:18 +02:00
Stefan Miklosovic 6f401a8725
Return snapshots with dots in their name in nodetool listsnapshots
patch by Stefan Miklosovic; reviewed by Paulo Motta for CASSANDRA-18371
2023-03-28 19:00:40 +02:00
Stefan Miklosovic 4ac89e6451
Fix NPE when loading snapshots and data directory is one directory from root
patch by Stefan Miklosovic; reviewed by Paulo Motta for CASSANDRA-18359
2023-03-26 23:29:28 +02:00
Paulo Motta 7c2f97cd29 Do not submit hints when hinted_handoff_enabled=false
- Remove dead WriteCallbackInfo code

Patch by Paulo Motta, Aleksey Yeschenko; Reviewed by Stefan Miklosovic, Claude Warren for CASSANDRA-18304

Co-authored-by: Aleksey Yeschenko <aleksey@apache.org>
2023-03-24 12:17:17 -04:00
Jacek Lewandowski 955cf156c8 Merge branch 'cassandra-3.0' into cassandra-3.11
* cassandra-3.0:
  Fix RepairJob unnecessarily reporting cancellation error
2023-03-21 10:08:12 +01:00
Jacek Lewandowski f6a04ca81f Fix RepairJob unnecessarily reporting cancellation error
patch by Jacek Lewandowski; reviewed by Brandon Williams for CASSANDRA-17701
2023-03-21 10:04:24 +01:00
David Capwell d5b1483703 Incompatible file system thrown while running Simulator
patch by David Capwell; reviewed by Brandon Williams, Caleb Rackliffe for CASSANDRA-18320
2023-03-15 16:19:04 -07:00
Jacek Lewandowski deb8abd2fd Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Fix the ordering of sstables when running sstableupgrade tool
2023-03-14 15:18:37 +01:00
Jacek Lewandowski 5104008db9 Merge branch 'cassandra-3.11' into cassandra-4.0
* cassandra-3.11:
  Fix the ordering of sstables when running sstableupgrade tool
2023-03-14 15:16:22 +01:00
Jacek Lewandowski 58d06d34ab Merge branch 'cassandra-3.0' into cassandra-3.11
* cassandra-3.0:
  Fix the ordering of sstables when running sstableupgrade tool
2023-03-14 15:14:31 +01:00
Claude Warren 8df69c8016 Fix the ordering of sstables when running sstableupgrade tool
patch by Claude Warren; reviewed by Jacek Lewandowski and Stefan Miklosovic for CASSANDRA-18143
2023-03-14 14:52:53 +01:00
Jacek Lewandowski 8ba3888fcf Merge branch 'cassandra-4.0' into cassandra-4.1 2023-03-13 09:57:11 +01:00
Jaroslaw Grabowski 3cfb222122 Fix BufferPool.memoryInUse counter
The counter was incorrectly decremented by the size of the unused portion of the provided buffer.
It is now decremented by the number of bytes actually returned to the pool (that may be different than "size"). The number is calculated as a difference between original and resulting buffer capacity.

patch by Jaroslaw Grabowski <jtgrabowski>, reviewed by Jacek Lewandowski <jacek-lewandowski> for CASSANDRA-18311
2023-03-13 09:51:33 +01:00
Stefan Miklosovic b7eaa2d209
Deprecate org.apache.cassandra.hadoop code
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-16984
2023-03-12 21:34:29 +01:00
Brandon Williams 0ea1d384d4 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-03-09 10:04:31 -06:00
Brandon Williams a874e02eec Merge branch 'cassandra-3.11' into cassandra-4.0 2023-03-09 10:03:14 -06:00
Brandon Williams 326b5aceb1 Merge branch 'cassandra-3.0' into cassandra-3.11 2023-03-09 10:02:21 -06:00
Brandon Williams be574fc34b Fix default file system error handler for disk_failure_policy die
Patch by Runtian Liu; reviewed by brandonwilliams and smiklosovic for
CASSANDRA-18294
2023-03-09 10:00:49 -06:00
Jacek Lewandowski 5f7175d59d Small fixes around Schema management
- Denormalize distributedAndLocalKeyspaces to remove perf degradation
- Set updated schema version once applied

patch by Jacek Lewandowski, reviewed by Stefan Miklosovic for CASSANDRA-18291
2023-03-09 08:12:10 +01:00
Jon Meredith 6adcff8f30 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-03-07 10:36:16 -07:00
Benedict Elliott Smith 40f9ca60f1 Improve memtable allocator accounting when updating AtomicBTreePartition
patch by Benedict Elliott Smith; reviewed by Benjamin Lerer, Jon Meredith for CASSANDRA-18125
2023-03-07 10:28:32 -07:00
Stefan Miklosovic 9860c1e9d9
Fix copying of JAR of a trigger to temporary file
While testing the fix for trigger, we fixed the corresponding
trigger example. While on it, we detected that ssl-factory example was
not working either so it is fixed in this commit as well.

patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-18264
2023-02-17 16:36:42 +01:00
Stefan Miklosovic cfe9641fbe
Fix possible NoSuchFileException when removing a snapshot
patch by Stefan Miklosovic; reviewed by Jacek Lewandowski for CASSANDRA-18211

Co-authored-by: Jacek Lewandowski <lewandowski.jacek@gmail.com>
2023-02-17 15:42:03 +01:00
Stefan Miklosovic bbe936a236
Merge branch 'cassandra-4.0' into cassandra-4.1 2023-02-07 15:53:51 +01:00
Stefan Miklosovic b8494a8275
Log warning message on aggregation queries without key or on multiple keys
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-18219
2023-02-07 15:47:36 +01:00
Brandon Williams 209ba28b4d Merge branch 'cassandra-4.0' into cassandra-4.1 2023-02-02 11:46:31 -06:00
yongj 0c58fbb8dd Add cache type information for maximum memory usage warning message
Patch by Yong Jiang; reviewed by brandonwilliams and smiklosovic for
CASSANDRA-18184
2023-02-02 11:45:52 -06:00
Jacek Lewandowski dcc19cf865 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-02-01 09:47:12 +01:00
Jacek Lewandowski 9bf128aaa3 Improve unit tests performance
- Don't flush schema on every schema update in unit tests
- Use unix command to delete test data
- Shorten teardown
- Stable processor count presented by JMX on Jenkins, CircleCI and local

Patch by <jacek-lewandowski>, reviewed by <michaelsembwever> and <josh-mckenzie> for CASSANDRA-17427
2023-02-01 09:40:50 +01:00
Brandon Williams 5dbeee258c Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-30 07:05:42 -06:00
Maciej Sokol 0b7e3a8ee7 Connect to listen address when own broadcast address is requested
Patch by Maciej Sokol; reviewed by brandonwilliams and smiklosovic for
CASSANDRA-18200
2023-01-30 07:04:41 -06:00
David Capwell 1c71e57f46 PaxosPrepare may add instances to the Electorate that are not in gossip
patch by David Capwell; reviewed by Blake Eggleston for CASSANDRA-18194
2023-01-27 12:31:02 -08:00
Brandon Williams 53156c24e1 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-24 06:34:48 -06:00
Brandon Williams 5f54d64c78 Merge branch 'cassandra-3.11' into cassandra-4.0 2023-01-24 06:32:43 -06:00
Brandon Williams 92245b0f07 Merge branch 'cassandra-3.0' into cassandra-3.11 2023-01-24 06:30:11 -06:00
Brandon Williams e7f55ab8c3 switch to SafeConstructor
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-18150
2023-01-24 06:27:29 -06:00
Paulo Motta da2dd2bfbc Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-23 17:27:58 -05:00
lzurovchak1 8bb9c72f58 Add safeguard so cleanup fails when node has pending ranges
Patch by Lindsey Zurovchak; Reviewed by Paulo Motta, Stefan Miklosovic for CASSANDRA-16418

Closes #2061
2023-01-23 17:26:47 -05:00
Andrés de la Peña 6c96e2fd41 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-23 11:42:24 +00:00
Andrés de la Peña 9a0af4112e Fix legacy clustering serialization for paging with compact storage
patch by Andrés de la Peña; reviewed by Berenguer Blasi and Piotr Kołaczkowski for CASSANDRA-17507
2023-01-23 11:40:45 +00:00
Benedict Elliott Smith bb2c16c677
EndpointState is mutable, so we must copy it before trying to serialize
patch by Benedict Elliott Smith; reviewed by Mick Semb Wever for CASSANDRA-18164
2023-01-20 11:24:30 +01:00
Stefan Miklosovic 590d629302 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-18 15:05:33 +01:00
Stefan Miklosovic 815f7de346 Merge branch 'cassandra-3.11' into cassandra-4.0 2023-01-18 15:02:40 +01:00
Stefan Miklosovic fc3ad6525f Merge branch 'cassandra-3.0' into cassandra-3.11 2023-01-18 14:58:38 +01:00
German Eichberger 8ecd7616fe Default role is created with zero timestamp
patch by German Eichberger; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-12525

Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
2023-01-18 14:56:22 +01:00
Paulo Motta c9968a8e95 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-16 21:47:46 -05:00
Stefan Miklosovic 6e6846892a Fix sstable loading of keyspaces named snapshots or backups
Patch by Stefan Miklosovic; Reviewed by Paulo Motta for CASSANDRA-14013

Co-authored-by: Paulo Motta <paulo@apache.org>
2023-01-16 21:45:17 -05:00
David Capwell 5be1038c5d Streaming progress virtual table lock contention can trigger TCP_USER_TIMEOUT and fail streaming
patch by David Capwell; reviewed by Abe Ratnofsky, Jon Meredith for CASSANDRA-18110
2023-01-12 09:46:54 -08:00
Bereng 438346aaa6 Merge branch 'cassandra-4.0' into cassandra-4.1 2023-01-12 08:19:48 +01:00
Bereng a83de9bcd2 Merge branch 'cassandra-3.11' into cassandra-4.0 2023-01-12 08:18:13 +01:00
Bereng b8a87abba4 Do not leak 2015 synthetic memtable Epoch
patch by Berenguer Blasi; reviewed by Caleb Rackliffe for CASSANDRA-18118
2023-01-12 08:15:19 +01:00
Jordan West 073f7c36fa Return empty denylist entry instead of null on failure to load
Patch by Jordan West; Reviewed by Josh McKenzie for CASSANDRA-18116
2023-01-07 13:42:02 -08:00
Marcus Eriksson fabc6e7c7b Merge branch 'cassandra-4.0' into cassandra-4.1 2022-12-23 14:59:59 +01:00
Marcus Eriksson ee266d283e Avoid ConcurrentModificationException in STCS/DTCS/TWCS.getSSTables
Patch by marcuse; reviewed by Aleksey Yeschenko for CASSANDRA-17977
2022-12-23 14:58:56 +01:00
Marcus Eriksson 203c61abaf Merge branch 'cassandra-4.0' into cassandra-4.1 2022-12-23 14:44:19 +01:00
Marcus Eriksson 95e26ad1ab Merge branch 'cassandra-3.11' into cassandra-4.0 2022-12-23 14:43:01 +01:00
Marcus Eriksson 0767c83416 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-12-23 14:41:50 +01:00
Marcus Eriksson 730b898b74 Don't group TWCS sstables for anticompaction
Patch by marcuse; reviewed by Aleksey Yeschenko for CASSANDRA-17970
2022-12-23 13:38:53 +01:00
Stefan Miklosovic 97f9ff7da3 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-12-20 10:16:14 +01:00
Stefan Miklosovic ace3920239 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-12-20 10:12:07 +01:00
Stefan Miklosovic baa9d0327f Merge branch 'cassandra-3.0' into cassandra-3.11 2022-12-20 10:04:43 +01:00
Stefan Miklosovic f55b2fb1b3 Do not spam the logs with MigrationCoordinator not being able to pull schemas
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-18096
2022-12-20 09:59:28 +01:00
Mick Semb Wever f869a2bb59
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Restore custom param types over messaging system
2022-12-17 15:50:19 -08:00
Mick Semb Wever f01d2b4a3c
Restore custom param types over messaging system
patch by Mick Semb Wever; reviewed by Aleksey Yeschenko for CASSANDRA-17981
2022-12-17 15:48:26 -08:00
Marianne Lyne Manaog 81c616826a Fix ContentionStrategy backoff and Clock.waitUntil
Also for CASSANDRA-18087

patch by Matt Fleming, Marianne Lyne Manaog, Benedict Elliott Smith; reviewed by Joshua Mckenzie, Ariel Weisberg for CASSANDRA-18086

Co-authored-by: Marianne Lyne Manaog <marianne.manaog@datastax.com>
Co-authored-by: Matt Fleming <matt@codeblueprint.co.uk>
Co-authored-by: Benedict Elliott Smith <benedict@apple.com>
2022-12-07 15:20:48 -05:00
Yifan Cai 27fff06bb7 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-12-05 18:57:01 -08:00
Yifan Cai f22263cd8a Merge branch 'cassandra-3.11' into cassandra-4.0 2022-12-05 18:52:22 -08:00
Yifan Cai eb91e2c354 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-12-05 18:50:28 -08:00
Yifan Cai 473656c1d5 Fix incorrect resource name in LIST PERMISSION output
patch by Yifan Cai; reviewed by Berenguer Blasi, Sam Tunnicliffe for CASSANDRA-17848
2022-12-05 18:48:36 -08:00
Jordan West 13d495aa7d fix intermittent failures in nodetool toppartitions caused by failure to validate invalid bytes
Patch by Jordan West; Reviewed by Brandon Williams and Cheng Wang for CASSANDRA-17254
2022-11-29 18:25:04 -08:00
Branimir Lambov 9f58d76f38 Avoid schema mismatch problems on memtable API misconfiguration
patch by Branimir Lambov; reviewed by Caleb Rackliffe for CASSANDRA-18040
2022-11-16 10:30:16 +02:00
Stefan Miklosovic 19f55cf0b8 Start Paxos auto repair in CassandraDaemon
This patch also renames PaxosRepairTest2 to PaxosRepair2Test to be picked up by CI.

patch by Stefan Miklosovic; reviewed by Benedict Elliott Smith for CASSANDRA-18029
2022-11-14 13:52:03 +01:00
Alex Sorokoumov 5cd012736e VIntCoding handles BB with less than 8 bytes
Without this fix VIntCoding#writeUnsignedVInt(long, ByteBuffer) throws
a runtime error if the BB size is less than 8 bytes. This method also
silently does not write to BB if it has less than 8 bytes left.

patch by Alex Sorokoumov; reviewed by Benjamin Lerer for CASSANDRA-15215
2022-11-11 19:52:37 +01:00
Stefan Miklosovic 207045030e Merge branch 'cassandra-4.0' into cassandra-4.1 2022-11-11 13:57:16 +01:00
Stefan Miklosovic 2638051af1 Harden parsing of boolean values in CQL in PropertyDefinitions
patch by Stefan Miklosovic; reviewed by Aleksey Yeschenko for CASSANDRA-17878
2022-11-11 13:38:44 +01:00
Brandon Williams 106bc89d74 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-11-10 13:37:59 -06:00
Natnael Adere 35826b7447 Fix error message about type hints (CASSANDRA-17915)
Patch by Natnael Adere; reviewed by blerer and brandonwilliams for
CASSANDRA-17915
2022-11-10 13:35:56 -06:00
Jacek Lewandowski e12dc48c87 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-11-09 17:22:11 +01:00
Jacek Lewandowski 67c530171c Merge branch 'cassandra-3.11' into cassandra-4.0 2022-11-09 17:20:08 +01:00
Jacek Lewandowski 9213335f59 Fix Splitter sometimes creating more splits than requested
Spliter.splitOwnedRanges for some inputs creates an extra split. For example, when we request 7 ranges from 0..31 range, it will return 8 ranges. There is an assertion in that method which verifies whether it returns the requested number of splits. Since those numbers differs, when Cassandra is be started with assertions enabled, it would fail.

patch by Jacek Lewandowski; reviewed by Marcus Eriksson for CASSANDRA-18013
2022-11-09 17:17:01 +01:00
Aleksey Yeschenko c100d34a1a
Restore streaming_keep_alive_period functionality on the netty control streaming channel
patch by Aleksey Yeschenko, Mick Semb Wever; reviewed by Mick Semb Wever, Berenguer Blasi for CASSANDRA-17768

Co-authored-by: Aleksey Yeschenko <aleksey@apache.org
Co-authored-by: Mick Semb Wever <mck@apache.org>
2022-11-09 11:39:07 +01:00
Doug Rohrer a805e32675 Move Schema.FORCE_LOAD_KEYSPACES and Schema.FORCE_LOAD_KEYSPACES_PROP to CassandraRelevantProps
patch by Doug Rohrer; reviewed by Brandon Williams and Jacek Lewandowski for CASSANDRA-17783
2022-11-08 08:18:40 +01:00
Marianne Lyne Manaog acda6fad68 Bug fix for WriteTimeoutException when using Paxos v2 with a single datacenter
patch by Marianne Lyne Manaog; reviewed by Branimir Lambov and Benedict Elliott Smith for CASSANDRA-17999
2022-11-07 14:59:03 +02:00
Stefan Miklosovic 0e21007b4f Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-27 16:06:19 +02:00
Stefan Miklosovic 35ef5b9957 Fix possible race condition on repair snapshots
patch by Stefan Miklosovic; reviewed by David Capwell for CASSANDRA-17955
2022-10-27 15:50:37 +02:00
Maxim Chanturiay dd53a609c6 Add --resolve-ip option to nodetool gossipinfo
patch by Maxim Chanturiay; reviewed by Stefan Miklosovic and Caleb Rackliffe for CASSANDRA-17934
2022-10-27 11:19:20 +02:00
Ekaterina Dimitrova 1df5dd671e Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-20 13:59:09 -04:00
Ekaterina Dimitrova ce1584ccc8 Fix ASM bytecode version inconsistency
patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi and Benedict Elliot Smith for CASSANDRA-17873
2022-10-20 13:10:33 -04:00
Mick Semb Wever fbb3079144
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Fix JMX security vulnerabilities
2022-10-18 22:55:59 +02:00
Mick Semb Wever 9a24fa81e5
Merge branch 'cassandra-3.11' into cassandra-4.0
* cassandra-3.11:
  Fix JMX security vulnerabilities
2022-10-18 22:53:37 +02:00
Mick Semb Wever 95d0a936f9
Merge branch 'cassandra-3.0' into cassandra-3.11
* cassandra-3.0:
  Fix JMX security vulnerabilities
2022-10-18 22:50:49 +02:00
Abe Ratnofsky b2660bcf78
Fix JMX security vulnerabilities
patch by Abe Ratnofsky; reviewed by Jon Meredith, Mick Semb Wever, Sam Tunnicliffe for CASSANDRA-17921
2022-10-18 22:47:49 +02:00
Stefan Miklosovic 15b54687a5 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-11 23:20:35 +02:00
Stefan Miklosovic 488c0c75a8 Remove empty cq4 log files to prevent BinLog from failing to start
This patch also backports CASSANDRA-17595.

patch by Stefan Miklosovic; reviewed by Caleb Rackliffe for CASSANDRA-17933
2022-10-11 23:13:13 +02:00
Aleksey Yeschenko 3fc9bc033a Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-11 15:43:49 +01:00
Piotr Kołaczkowski e13356d75d Fix multiple BufferPool bugs
patch by Piotr Kołaczkowski; reviewed by Aleksey Yeschenko for
CASSANDRA-16681
2022-10-11 15:42:30 +01:00
Ariel Weisberg 9524c22990 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-06 14:11:34 -04:00
Andy Tolbert 3bdd2caa22 Fix StorageService.getNativeaddress handling of IPv6 addresses
StorageService.getNativeaddress does not currently correctly handle
IPv6 addresses correctly when NATIVE_ADDRESS_AND_PORT are not present in
that it simply concatenates the IP address with the default native port,
e.g.:

0:0:0:0:0:0:5a:3:9042

This does not parse into an InetSocketAddress as the address and port
can't be disambiguated.

Such a case would usually be present when there are 3.x nodes present in a
cluster with 4.0 nodes.

Change updates RPC_ADDRESS and else case to create InetAddressAndPort instances
with DatabaseDescriptor.getNativeTransportPort and returns the
getHostAddress(withPort) which properly bracket encodes the address,
e.g.:

[0:0:0:0:0:0:5a:3]:9042

which can be parsed as an InetSocketAddress.

patch by Andy Tolbert; reviewed by Ariel Weisberg, Brandon Williams for CASSANDRA-17945
2022-10-06 14:10:58 -04:00
Aleksey Yeschenko 0b083d3e73 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-10-06 15:34:49 +01:00
Aleksey Yeschenko 4e1d31e729 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-10-06 15:27:49 +01:00
Piotr Kołaczkowski dc2acba043 Make LongBufferPoolTest insensitive to timing
This commit changes the way how LongBufferPoolTest verifies
that all buffers were freed and recycled. Now, the delay between
rounds can be arbitrarily short and timing does not affect the
validity of checks.

patch by Piotr Kołaczkowski; reviewed by Aleksey Yeschenko for
CASSANDRA-16681
2022-10-05 15:46:10 +01:00
Stefan Miklosovic 5d3c747719 add checkstyle modules for checking redundant and unused imports in Java code
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-17876

Co-authored-by: Ling Mao <maoling@apache.org>
2022-09-26 21:41:15 +02:00
Josh McKenzie 3608f67076 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-09-20 14:18:09 -04:00
Josh McKenzie 22ec7eee7f Mitigate direct buffer memory OOM on replacements
Patch by Jon Meredith; reviewed by Josh McKenzie for CASSANDRA-17895

Co-authored-by: Jon Meredith <jonmeredith@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-09-20 14:16:24 -04:00
Josh McKenzie 1f90c9eb3d Merge branch 'cassandra-4.0' into cassandra-4.1 2022-09-20 12:57:51 -04:00
Josh McKenzie 29c0ad80c9 Fix repair failure on assertion if two peers have overlapping mismatching ranges
Patch by Marcus Eriksson; reviewed by Benedict Elliott Smith and Josh McKenzie for CASSANDRA-17900

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-09-20 12:55:24 -04:00
Ekaterina Dimitrova 4c85c6a403 key_cache_save_period, row_cache_save_period, counter_cache_save_period are not deprecated and we should not emit deprecation warning on startup for them
Patch by Ekaterina Dimitrova; reviewed by Stefan Miklosovic for CASSANDRA-17904
2022-09-19 18:10:36 -04:00
Jacek Lewandowski d8bbeb9e39 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-09-16 09:55:07 +02:00
Jacek Lewandowski 76be530a36 Fix schema reset functionality
Patch by Jacek Lewandowski, reviewed by Andrés de la Peña and Ekaterina Dimitrova for CASSANDRA-17819
2022-09-16 09:50:03 +02:00
Josh McKenzie 3f46c7d88b Merge branch 'cassandra-4.0' into cassandra-4.1
# Conflicts:
#	CHANGES.txt
2022-09-12 12:45:42 -04:00
Josh McKenzie ac25d6929e Better handle null state in Gossip schema migration to avoid NPE
Patch by Marcus Eriksson; reviewed by Josh McKenzie and Alex Petrov for CASSANDRA-17864

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-09-12 12:43:54 -04:00
David Capwell d25adb498a upsert with adder support is not consistent with numbers and strings in LWT
patch by David Capwell; reviewed by Benedict Elliott Smith, Caleb Rackliffe for CASSANDRA-17857
2022-09-06 18:07:18 -07:00
Brandon Williams 46700918f8 Catch NSE race condition and return after failing connections
Patch by brandonwilliams; reviewed by adelapena and aleksey for
CASSANDRA-17618
2022-09-06 11:54:20 -05:00
Jon Meredith 6748b8b7ea Speculative execution threshold unit mismatch
patch by Jon Meredith; reviewed by Caleb Rackliffe, Yifan Cai for CASSANDRA-17877
2022-09-06 10:01:18 -06:00
Marcus Eriksson cd576a0d14 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-29 13:28:32 +02:00
Marcus Eriksson 5beab63b55 Improve the way we handle repair message timeouts to avoid hanging repairs
Patch by marcuse; reviewed by David Capwell for CASSANDRA-17613
2022-08-29 13:27:16 +02:00
Jacek Lewandowski 726b67b1e4 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-26 17:39:46 +02:00
Jacek Lewandowski 2b492f17b9 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-08-26 17:19:59 +02:00
Jacek Lewandowski 04c3e816e8 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-08-26 17:17:07 +02:00
Jacek Lewandowski a78db628b0 Fix scrubber falling into infinite loop
Fixes scrubber falling into infinite loop when the last partition is broken in data file and compression is enabled.

Patch by Jacek Lewandowski, reviewed by Brandon Williams, for CASSANDRA-17862
2022-08-26 17:06:10 +02:00
Josh McKenzie 704141541a Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-24 15:24:11 -04:00
Josh McKenzie 73bea0ac1e Merge branch 'cassandra-3.11' into cassandra-4.0
-s ours; applying 4.0+ patch for CASSANDRA-17840
2022-08-24 15:23:52 -04:00
Josh McKenzie ab481be81d Fix potential IndexOutOfBoundsException in PagingState in mixed mode clusters
Patch by Alex Petrov; reviewed by Josh McKenzie, Sam Tunnicliffe, and Aleksey Yeschenko for CASSANDRA-17840

Co-authored-by: Alex Petrov <oleksandr.petrov@gmail.com>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-08-24 15:04:21 -04:00
Francisco Guerrero 83c169ec9e Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle
patch by Francisco Guerrero; reviewed by Ekaterina Dimitrova, Yifan Cai for CASSANDRA-17677
2022-08-19 14:19:53 -07:00
Josh McKenzie b95a6931f5 Merge branch 'cassandra-4.0' into cassandra-4.1
# Conflicts:
#	CHANGES.txt
#	src/java/org/apache/cassandra/repair/consistent/CoordinatorSession.java
2022-08-19 12:34:33 -04:00
Josh McKenzie 0353df7542 Prevent infinite loop in repair coordinator on FailSession
Patch by Marcus Eriksson; reviewed by David Capwell, Blake Eggleston, and Josh McKenzie for CASSANDRA-17834

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Josh McKenzie <jmckenzie@apache.org>
2022-08-19 12:33:24 -04:00
Yifan Cai 590de42a06 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-16 15:24:34 -07:00
Yifan Cai 84e10d0cad Fix race condition on updating cdc size and advancing to next segment
patch by Yifan Cai; reviewed by Josh McKenzie for CASSANDRA-17792
2022-08-16 15:21:37 -07:00
Jacek Lewandowski c1d89c32d2 Fix a race condition where a keyspace can be opened while it is being removed
patch by Jacek Lewandowski; reviewed by Andrés de la Peña and Ekaterina Dimitrova for CASSANDRA 17658
2022-08-12 13:26:16 +02:00
Andrés de la Peña 16be1ab073 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-12 10:31:30 +01:00
Andrés de la Peña 174e0dc399 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-08-12 10:28:42 +01:00
Andrés de la Peña 4e410fc46d Document usage of closed token intervals in manual compaction
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-17575
2022-08-12 10:21:19 +01:00
Brandon Williams f5dc9a1c1e Set default FD in DD client initialization
Patch by Doug Rohrer; reviewed by brandonwilliams and maedhroz for
CASSANDRA-17782
2022-08-10 14:09:52 -05:00
Blake Eggleston 2bc4a36179 Use seeded crc for PaxosBallotTracker checksum
Patch by Blake Eggleston; Reviewed by Benedict Elliot Smith for CASSANDRA-17793
2022-08-09 08:58:27 -07:00
Ekaterina Dimitrova a7d7708976 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-08-08 13:02:48 -04:00
Ekaterina Dimitrova e5e13c02cc Fix default value for compaction_throughput_mb_per_sec in Config class to match the one in cassandra.yaml
patch by Ekaterina Dimimtrova; reviewed by Francisco Guerrero, Michael Semb Wever for CASSANDRA-17790
2022-08-08 12:45:36 -04:00
Runtian Liu 299bfaed35 Fix missing state resetting on CompressedRandomAccessReader read errors
patch by Runtian Liu; reviewed by Andrés de la Peña and Berenguer Blasi for CASSANDRA-17314
2022-08-08 13:52:10 +01:00
Caleb Rackliffe 5e39c54678 Avoid initializing schema via SystemKeyspace.getPreferredIP() with the BulkLoader tool
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-17740

Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Jon Meredith <jmeredithco@gmail.com>
2022-08-05 15:31:40 -05:00
Ekaterina Dimitrova dd08314ed6 Uncomment prepared_statements_cache_size, key_cache_size, counter_cache_size, index_summary_capacity which were
commented out by mistake in a previous patch;
Fix breaking change with cache_load_timeout; cache_load_timeout_seconds <=0 and cache_load_timeout=0 are equivalent
and they both mean disabled;
Deprecate public method setRate(final double throughputMbPerSec) in Compaction Manager in favor of
setRateInBytes(final double throughputBytesPerSec);
Revert breaking change removal of StressCQLSSTableWriter.Builder.withBufferSizeInMB(int size). Deprecate it in favor
of StressCQLSSTableWriter.Builder.withBufferSizeInMiB(int size);
Fix precision issues, add new -m flag (for nodetool/setstreamthroughput, nodetool/setinterdcstreamthroughput,
nodetool/getstreamthroughput and nodetoo/getinterdcstreamthroughput), add new -d flags (nodetool/getstreamthroughput,
 nodetool/getinterdcstreamthroughput, nodetool/getcompactionthroughput);
Fix a bug with precision in nodetool/compactionstats;
Deprecate StorageService methods and add new ones for stream_throughput_outbound, inter_dc_stream_throughput_outbound,
compaction_throughput_outbound in the JMX MBean `org.apache.cassandra.db:type=StorageService`;
Removed getEntireSSTableStreamThroughputMebibytesPerSec in favor of new getEntireSSTableStreamThroughputMebibytesPerSecAsDouble
in the JMX MBean `org.apache.cassandra.db:type=StorageService`;
Removed getEntireSSTableInterDCStreamThroughputMebibytesPerSec in favor of getEntireSSTableInterDCStreamThroughputMebibytesPerSecAsDouble
in the JMX MBean `org.apache.cassandra.db:type=StorageService`

Patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe, Francisco Guerrero for CASSANDRA-17225
2022-08-01 19:05:13 -04:00
Ekaterina Dimitrova fe28f482db Fix sstable_preemptive_open_interval_in_mb disabled value - backward compatibility
patch by Ekaterina Dimitrova; reviewed by Andres de la Pena and Jon Meredith for CASSANDRA-17737
2022-07-29 13:26:31 -04:00
Ekaterina Dimitrova 222f66e093 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-28 16:21:47 -04:00
Ekaterina Dimitrova 04901913d6 Fix Setting Virtual Table to update after startup config properties gc_log_threshold_in_ms, gc_warn_threshold_in_ms, conf.index_summary_capacity_in_mb, prepared_statements_cache_size_mb, key_cache_size_in_mb, counter_cache_size_in_mb
patch by Ekaterina Dimitrova; reviewed by Andres de la Pena for CASSANDRA-17737
2022-07-28 16:17:55 -04:00
Caleb Rackliffe 3a0936b61f Remove usages of Path#toFile() in the snapshot apparatus
patch by Caleb Rackliffe; reviewed by David Capwell and Benedict Elliot Smith for CASSANDRA-17769
2022-07-27 15:04:03 -05:00
Stefan Miklosovic 8533a6764b Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-27 15:01:14 +02:00
Stefan Miklosovic 6388fd3a16 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-07-27 14:34:35 +02:00
Stefan Miklosovic afaeb93020 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-07-27 14:21:56 +02:00
Stefan Miklosovic a7b53217bd fix restarting of services on gossipping-only member
patch by Stefan Miklosovic; reviewed by Brandon Williams (CASSANDRA-17752)
2022-07-27 14:13:25 +02:00
Ekaterina Dimitrova 1c70149ef5 Fix Settings Virtual Table to update paxos_variant after startup and rename enable_uuid_sstable_identifiers to uuid_sstable_identifiers_enabled as per our config naming conventions
patch by Ekaterina Dimitrova; reviewed by Brandon Williams for CASSANDRA-17738
2022-07-25 10:08:09 -04:00
Stefan Miklosovic 15b7d678e9 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-23 22:33:48 +02:00
Stefan Miklosovic a1ac1efbb7 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-07-23 22:27:20 +02:00
Stefan Miklosovic e83d95d1ac creating of a keyspace on insufficient number of replicas should filter out gosspping-only members
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-17759
2022-07-23 22:22:06 +02:00
Brandon Williams 962247a493 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-22 11:30:13 -05:00
Brandon Williams a53bb7ab82 Remove extra write to system table for prepared statements
Patch by brandonwilliams; reviewed by maedhroz for CASSANDRA-17764
2022-07-22 11:28:25 -05:00
Ekaterina Dimitrova 9beeaf87bd Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-22 09:41:38 -04:00
Ekaterina Dimitrova 860ec627a1 Fix issues with index_summary_resize_interval and index_summary_capacity
patch by Ekaterina Dimitrova; reviewed by Andres de la Pena for CASSANDRA-17735
2022-07-22 09:25:54 -04:00
Ekaterina Dimitrova 46d9cbe2f6 min_tracked_partition_size_bytes parameter from 4.1 alpha1 was renamed to min_tracked_partition_size
patch by Ekaterina Dimitrova; reviewed by Berenguer Blasi for CASSANDRA-17733
2022-07-15 12:34:14 -04:00
Bereng ada958eaf7 org.apache.cassandra.db.commitlog.GroupCommitLogTest tests failing on trunk
patch by Berenguer Blasi; reviewed by Andres de la Peña for CASSANDRA-17232
2022-07-14 06:56:19 +02:00
Blake Eggleston cdc0ce1fa3 Prevent premature initialization of paxos metadata files during tests
Patch by Blake Eggleston; review by Benjamin Lerer and Berenguer Blasi for CASSANDRA-17489
2022-07-11 17:41:37 +02:00
Benedict Elliott Smith 067121da63 Paxos v2 Linearizability Violation
patch by Benedict; reviewed by Blake Eggleston for CASSANDRA-17530
2022-07-12 12:28:59 +01:00
Marten Kenbeek dd51df6734 Only use statically defined subcolumns when determining column definition for supercolumn cell
Patch by Marten Kenbeek; review by Benjamin Lerer and Brandon Williams for CASSANDRA-14113
2022-07-11 16:46:12 +02:00
Bereng 1d80dd0086 Fix flaky test - org.apache.cassandra.cql3.validation.operations.InsertUpdateIfConditionTest.testConditionalUpdate
patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-17653
2022-07-11 09:44:28 +02:00
Bereng f77a7a29e8 Update the CQL version for the 4.1 release
Patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-17570
2022-07-08 09:15:27 +02:00
Benjamin Lerer 50e7a3f5df Merge branch cassandra-4.0 into cassandra-4.1 2022-07-07 14:00:55 +02:00
Benedict Elliott Smith c378874a9f Utilise BTree improvements to reduce garbage and improve throughput
Patch by Benedict Elliott Smith; review by Branimir Lambov and Benjamin Lerer for CASSANDRA-15511
2022-07-07 13:52:52 +02:00
Francisco Guerrero a250126f0f Remove commons-lang dependency during build runtime
patch by Francisco Guerrero; reviewed by Dinesh Joshi, Yifan Cai for CASSANDRA-17724
2022-07-06 17:41:12 -07:00
Caleb Rackliffe 15bdf2e8e7 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-07-05 18:41:46 -05:00
Caleb Rackliffe 924cd8f52c Make sure delayed timeout task in StreamTransferTask cannot prevent clean shutdown
patch by Caleb Rackliffe; reviewed by David Capwell for CASSANDRA-17706
2022-07-05 18:33:19 -05:00
Francisco Guerrero a9725b681b Fix AbstractCell#toString throws MarshalException for cell in collection
patch by Francisco Guerrero; reviewed by Caleb Rackliffe, Yifan Cai for CASSANDRA-17695
2022-06-29 18:05:09 -07:00
Brandon Williams b75d56fd38 Add new compactionstats output behind --vtable
Patch by brandonwilliams; reviewed by edimitrov and dcapwell for
CASSANDRA-17683
2022-06-29 10:08:44 -05:00
Jakub Żytka 60b54425ed Fix commitLogUpperBound initialization in AbstractMemtableWithCommitlog
so that it is always available when writeBarrier gets initialized.

Harden Memtable API so that it is apparent that getting commitLogUpperBound
is valid only after it is fully established.

patch by Jakub Żytka and Dan Jatnieks;
reviewed by Dan Jatnieks, Jeremiah D Jordan and Caleb Rackliffe for CASSANDRA-17587
2022-06-29 12:08:42 +03:00
Akın Tekeoğlu 07e5876c43 Add toBytesInLong to IntKibibytesBound to support widening to long in getBatchSizeFailThreshold
patch by Akin Tekeoglu; reviewed by Ekaterina Dimitrova and Andres de la Peña for CASSANDRA-17650
2022-06-28 18:10:42 -04:00
Ekaterina Dimitrova 495d609c89 Fix widening from mebibytes to bytes in IntMebibytesBound 2022-06-28 14:41:46 -04:00
Ekaterina Dimitrova dcb4768345 nodetool clientstats columns should be under a separate flag - --config-options
patch by Ekaterina Dimitrova; reviewed by Brandon Williams for CASSANDRA-17715
2022-06-27 19:23:06 -04:00
Andrés de la Peña 33730d9d06 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-27 15:15:21 +01:00
Andrés de la Peña 90e2502c6c Merge branch 'cassandra-3.11' into cassandra-4.0 2022-06-27 15:14:35 +01:00
Andrés de la Peña bc8a260471 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-06-27 15:13:45 +01:00
Andrés de la Peña 09692d5a58 Fix writetime and ttl functions forbidden for collections instead of multicell columns
patch by Andrés de la Peña; reviewed by Berenguer Blasi for CASSANDRA-17628
2022-06-27 15:09:35 +01:00
Bereng 1d39a388ba Revert "Update the CQL version for the 4.1 release"
This reverts commit a508ac06e9.
2022-06-21 11:06:10 +02:00
Bereng a508ac06e9 Update the CQL version for the 4.1 release
patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-17570
2022-06-21 08:13:21 +02:00
Stefan Miklosovic 89df37d4bb Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-16 19:29:23 +02:00
Stefan Miklosovic 7da28ef378 SSL storage port in sstableloader is deprecated
this is the follow-up commit which deprecates ssl storage port for backward compatibility

patch by Stefan Miklosovic; reviewed by Jon Meredith for CASSANDRA-17602
2022-06-16 19:26:02 +02:00
Brandon Williams 96ef1d231c Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-16 09:01:24 -05:00
Brandon Williams 51ce71881c filter out dead replicas for counter writes
Patch by brandonwilliams; reviewed by adelapena for CASSANDRA-17411
2022-06-16 09:00:02 -05:00
Brandon Williams 7f38db348e Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-16 06:00:57 -05:00
Brandon Williams c3998ef601 Return an empty collection when a node is not a member
Patch by brandonwilliams; reviewed by adelapena for CASSANDRA-17680
2022-06-16 05:59:42 -05:00
Stefan Miklosovic 67632edc51 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-13 10:43:17 +02:00
Stefan Miklosovic 2531dd1eba remove ssl storage port from sstableloader
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-17602
2022-06-13 10:36:56 +02:00
Stefan Miklosovic 457e16c27e fix flaky GossipInfoTableTest
patch by Stefan Miklosovic; reviewed by Andrés de la Peña for CASSANDRA-17584
2022-06-07 22:15:11 +02:00
Sathyanarayanan Saravanamuthu 9b4784bdb7 Fix missed nowInSec values in QueryProcessor
patch by Sathyanarayanan Saravanamuthu; reviewed by Andrés de la Peña, Benjamin Lerer and Ekaterina Dimitrova for CASSANDRA-17458

Co-authored-by: Sathyanarayanan Saravanamuthu <sathya.kplm@outlook.com>
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
2022-06-07 13:03:19 +01:00
Ekaterina Dimitrova 2eac2590bf Revert removal of withBufferSizeInMB(int size) to CQLSSTableWriter.Builder and deprecate it in favor of withBufferSizeIniB(int size);update the docs
patch by Ekaterina Dimitrova; reviewed by Michael Semb Wever for CASSANDRA-17675
2022-06-02 15:31:23 -04:00
Caleb Rackliffe 663e51d928 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-06-02 12:10:52 -05:00
Caleb Rackliffe a00d8fd5ba Ensure FileStreamTask cannot compromise shared channel proxy for system table when interrupted
patch by Caleb Rackliffe; reviewed by Jon Meredith and David Capwell for CASSANDRA-17663
2022-06-02 11:59:19 -05:00
Paulo Motta a604c0d4de Remove expired snapshots of dropped tables after restart
Patch by Paulo Motta; reviewed by Stefan Miklosovic for CASSANDRA-17619

Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
2022-05-29 09:57:49 +02:00
David Capwell 76648a6534 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-05-25 14:01:32 -07:00
David Capwell fb8bf30c6d jvm-dtest upgrade failures due to 3.x Ping not allowing serialize
patch by David Capwell; reviewed by Jon Meredith for CASSANDRA-17660
2022-05-25 14:00:14 -07:00
Brandon Williams 00250199c0 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-05-24 06:01:28 -05:00
Brandon Williams 7ea24711cc silence benign SslClosedEngineException
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-17565
2022-05-24 05:58:06 -05:00
Ekaterina Dimitrova a67a2a2441 Handle config parameters upper bound on startup; Fix auto_snapshot_ttl and paxos_purge_grace_period min unit validations
patch by Ekaterina Dimitrova and Andres de la Pena; reviewed by Andres de la Pena and Caleb Rackliffe for CASSANDRA-17571

Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>
Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
2022-05-20 14:27:20 -04:00
Andrés de la Peña c1d163abad Merge branch 'cassandra-4.0' into cassandra-4.1 2022-05-20 11:52:34 +01:00
Andrés de la Peña 5cf6db30f6 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-05-20 11:47:06 +01:00
Andrés de la Peña 0e1d068d92 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-05-20 11:43:56 +01:00
Doug Rohrer ffc4c89c3d Fix issue where frozen maps may not be serialized in the correct order
patch by Doug Rohrer, Francisco Guerrero and Yifan Cai; reviewed by Andrés de la Peña and Caleb Rackliffe for CASSANDRA-17623

Co-authored-by: Doug Rohrer <drohrer@apple.com>
Co-authored-by: Francisco Guerrero <frank.guerrero@gmail.com>
Co-authored-by: Yifan Cai <ycai@apache.org>
2022-05-20 11:38:19 +01:00
Ekaterina Dimitrova c635f198f6 Fix leak of non-standard Java types in our Exceptions as clients using JMX are unable to handle them
Remove useless validation that leads to unnecessary additional read of cassandra.yaml on startup
patch by Ekaterina Dimitrova; review by David Capwell for CASSANDRA-17638
2022-05-19 14:35:02 -04:00
David Capwell f451c2b028 jvm-dtest unhandled exceptions failing the test no longer work
patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-17549
2022-05-13 10:14:26 -07:00
Brandon Williams 7dbea1a8cb Merge branch 'cassandra-4.0' into cassandra-4.1 2022-05-13 06:56:49 -05:00
Brandon Williams ac0266be69 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-05-13 06:54:03 -05:00
Brandon Williams d043217ff0 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-05-13 06:50:40 -05:00
Maciej Sokol 5d427ff6e5 Fsync TOC and Digest files after they're written
Patch by Maciej Sokol; reviewed by brandonwilliams and bereng for
CASSANDRA-10709
2022-05-13 06:41:07 -05:00
Ekaterina Dimitrova f57c8d2c25 Fix repair_request_timeout_in_ms and remove paxos_auto_repair_threshold_mb
patch by Benedict Elliott Smith and Ekaterina Dimitrova; reviewed by Benedict Elliott Smith and Blake Eggleston for CASSANDRA-17557
2022-05-10 21:05:41 -04:00
David Capwell 89fbb1acf4 Incremental repair leaks SomeRepairFailedException after switch away from flatMap
patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-17620
2022-05-10 15:24:54 -07:00
David Capwell 6396562f71 StorageService read threshold get methods throw NullPointerException due to not handling null configs
patch by David Capwell; reviewed by Berenguer Blasi for CASSANDRA-17593
2022-05-10 12:41:33 -07:00
Alex Sorokoumov 9f3bc65727 Reject oversized mutations on client and internode connection
Patch by Alex Sorokoumov; reviewed by Andres de la Peña and Josh McKenzie for CASSANDRA-17456
2022-05-09 10:57:14 +02:00
Benedict Elliott Smith 596daeb7f0 Optimise BTree build, update and transform operations
Patch Benedict Elliott Smith; reviewed by Branimir Lambov and Benjamin Lerer for CASSANDRA-15510
2022-05-06 18:15:16 +02:00
Josh McKenzie 030831c5f5 Rename truncate_drop guardrail to drop_truncate_table
Patch by Josh McKenzie; reviewed by Andres de la Pena for CASSANDRA-17592
2022-05-06 11:48:45 -04:00
Brandon Williams c9ed13c425 Merge branch 'cassandra-4.0' into cassandra-4.1 2022-05-05 05:57:06 -05:00
Brandon Williams a524cd4907 Merge branch 'cassandra-3.11' into cassandra-4.0 2022-05-05 05:55:11 -05:00
Brandon Williams aeced876b5 Merge branch 'cassandra-3.0' into cassandra-3.11 2022-05-05 05:55:00 -05:00
Jermy Li 61d4cccb0b Fix URISyntaxException in nodetool with updated Java
Patch by Jermy Li; reviewed by bereng and brandonwilliams for
CASSANDRA-17581
2022-05-05 05:53:47 -05:00
David Capwell 559b17f71d nodetool enablefullquerylog can NPE when directory has no files
patch by David Capwell; reviewed by Jon Meredith for CASSANDRA-17595
2022-05-04 09:32:39 -07:00
Marcus Eriksson 3b648ca09e Use TimeUUID serializer for BATCH_REMOVE_REQ
Patch by marcuse; reviewed by Benedict Elliott Smith for CASSANDRA-17451
2022-05-04 08:18:33 +02:00
Paulo Motta 7741eacc54 Add auto_snapshot_ttl configuration
Patch by Paulo Motta; Reviewed by Stefan Miklosovic for CASSANDRA-16790

Co-authored-by: fibersel <0583463@gmail.com>
2022-04-30 17:28:17 -03:00
Paulo Motta 31aa17a2a3 List snapshots of dropped tables
Patch by Paulo Motta; Reviewed by Stefan Miklosovic and Brandon Williams or CASSANDRA-16843
2022-04-29 19:00:34 -03:00
Jacek Lewandowski 458bfd16c7 Add information info whether sstables are dropped or not to SchemaChangeListener
patch by Jacek Lewandowski; reviewed by Alex Petrov for CASSANDRA-17582
2022-04-29 13:44:25 -04:00
Branimir Lambov e4e19e33fa Add memtable API (CEP-11)
patch by Branimir Lambov; reviewed by Andrés de la Peña and Caleb Rackliffe for CASSANDRA-17034
2022-04-29 14:56:20 +03:00
Jacek Lewandowski 77d6bbf25a Save sstable id as string in activity table
patch by Jacek Lewandowski; reviewed by Andrés de la Peña and Ekaterina Dimitrova for CASSANDRA-17585
2022-04-29 12:37:01 +01:00
Stefan Miklosovic bd36cb9f6b implement startup check to prevent Cassandra to potentially spread zombie data
patch by Stefan Miklosovic; reviwed by Paulo Motta and Brandon Williams for CASSANDRA-17180
2022-04-29 13:22:51 +02:00
Marcus Eriksson 7ce140bd1d Fail starting when the same parameter exists more than once in cassandra.yaml
Patch by marcuse; reviewed by David Capwell and Ekaterina Dimitrova for CASSANDRA-17379
2022-04-29 10:31:20 +02:00
Savni Nagarkar da7c662227 Migrate threshold for minimum keyspace replication factor to guardrails
patch by Savni Nagarkar; reviewed by Andres de la Peña, David Capwell for CASSANDRA-17212
2022-04-28 20:14:36 -07:00
Stefan Miklosovic 2180a34bbb Revert "Add a system property to set hostId if not yet initialized"
This reverts commit 33ff36cc42.

patch by Stefan Miklosovic; reviewed by Brandon Williams and Sam Tunnicliffe for CASSANDRA-14582
2022-04-28 15:09:46 +02:00
Jon Meredith 0c37176673 Merge branch 'cassandra-4.0' into trunk 2022-04-27 12:06:52 -06:00
Jon Meredith 2405d523fa Merge branch 'cassandra-3.11' into cassandra-4.0 2022-04-27 12:03:28 -06:00
Jon Meredith 804098e68b Merge branch 'cassandra-3.0' into cassandra-3.11 2022-04-27 12:01:08 -06:00
Jon Meredith 2fdbda6ac9 Schema mutations may not be completed on drain
patch by Jon Meredith; reviewed by Caleb Rackliffe for CASSANDRA-17524
2022-04-27 11:59:47 -06:00
Josh McKenzie 6bd373f5d2 Add guardrail to disallow TRUNCATE and DROP TABLE commands
Patch by Josh McKenzie; reviewed by Aleksey Yeschenko for CASSANDRA-17558
2022-04-27 11:52:24 -04:00
Savni Nagarkar f444c40286 Add guardrail to disallow querying with ALLOW FILTERING
patch by Savni Nagarkar; reviewed by Andres de la Peña, David Capwell and Josh McKenzie for CASSANDRA-17370
2022-04-26 18:26:17 +01:00
Marcus Eriksson 545809616c Track top partitions by size and tombstone count
Patch by marcuse; reviewed by David Capwell and Yifan Cai for CASSANDRA-16310
2022-04-26 14:59:37 +02:00
Andrés de la Peña 49cc352916 Make GuardrailDiskUsageTest deterministic
patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-17576
2022-04-23 20:25:06 +01:00
David Capwell 3409e5d9b3 Enhance SnakeYAML properties to be reusable outside of YAML parsing, support camel case conversion to snake case, and add support to ignore properties
patch by David Capwell; reviewed by Caleb Rackliffe, Stefan Miklosovic for CASSANDRA-17166
2022-04-22 20:17:45 -07:00
David Capwell 2b90ac1a16 nodetool compact should support using a key string to find the range to avoid operators having to manually do this
patch by David Capwell; reviewed by Marcus Eriksson for CASSANDRA-17537
2022-04-22 15:37:01 -07:00