Commit Graph

18611 Commits

Author SHA1 Message Date
Jonathan Ellis 71b3b3c736 fix compaction bug -- only one of the SSTR constructors was adding to openedFiles. (fixes regression from #413).
patch by jbellis; reviewed by Eric Evans for CASSANDRA-425

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@812230 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 17:18:41 +00:00
Jonathan Ellis 313f053ecd merge from 0.4 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@812228 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 17:15:48 +00:00
Jonathan Ellis 7bfe8df549 Revert "remove sstableLock. re-order a few ops so that we can never "lose" data temporarily -- always remove old sstable references _after_ adding the new ones. so at worst a few read ops will merge data from an sstable that is obsolete -- this is ok and better than Stop The World locking"
and "CASSANDRA-414 combine addToList and storeLocation; rename to addSSTable"

These were works in progress (and broken); accidentally committed w/ the 418 fix.

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@812164 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 14:47:28 +00:00
Jonathan Ellis dec8490e5e clean up inaccurate comments; remaining double-increment code.
patch by jbellis; reviewed by Sammy Yu for CASSANDRA-418

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@812163 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 14:45:13 +00:00
Jonathan Ellis 090b6a21d2 remove sstableLock. re-order a few ops so that we can never "lose" data temporarily -- always remove old sstable references _after_ adding the new ones. so at worst a few read ops will merge data from an sstable that is obsolete -- this is ok and better than Stop The World locking
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@812162 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 14:45:09 +00:00
Jonathan Ellis 8be0d7de6a CASSANDRA-414 combine addToList and storeLocation; rename to addSSTable
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@812161 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 14:45:04 +00:00
Eric Evans 67fc385718 merging from 0.4 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@811489 13f79535-47bb-0310-9956-ffa450edef68
2009-09-04 16:52:43 +00:00
Jonathan Ellis 53895adf95 merge from 0.4 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@810997 13f79535-47bb-0310-9956-ffa450edef68
2009-09-03 15:33:46 +00:00
Jonathan Ellis 204bec65ef clarify open/get code and r/m unnecessary synchronization; it's confusing. (openedFiles is backed by a NonBlockingHashMap and all our uses of it are threadsafe w/o extra locking)
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@810695 13f79535-47bb-0310-9956-ffa450edef68
2009-09-02 20:30:43 +00:00
Jonathan Ellis ab392a6ee7 remove buggy concurrentlinkedhashmap library and lru cache. too late in 0.4 to try to debug the library -- will revisit for 0.5. patch by jbellis; reviewed by Chris Goffinet for CASSANDRA-405
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@810540 13f79535-47bb-0310-9956-ffa450edef68
2009-09-02 15:04:16 +00:00
Jonathan Ellis fe28c47406 merge from 0.4 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@810335 13f79535-47bb-0310-9956-ffa450edef68
2009-09-02 02:02:30 +00:00
Eric Evans e2af28a6e3 merged from cassandra-0.4 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@810282 13f79535-47bb-0310-9956-ffa450edef68
2009-09-01 22:25:00 +00:00
Jonathan Ellis 64c38a2657 inline BatchMutation into batch_insert params
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-403

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809793 13f79535-47bb-0310-9956-ffa450edef68
2009-09-01 01:52:03 +00:00
Jonathan Ellis 33ac4dddb0 r/m unused code. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809752 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 21:31:25 +00:00
Jonathan Ellis 781dfe4b6b allow setting the logging level at runtime via mbean.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-402

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809746 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 21:14:27 +00:00
Jonathan Ellis 7bf57616e6 r/m unused import
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809719 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 19:49:14 +00:00
Jonathan Ellis bbd170187b organize api methods by type (retrieval or modification). patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809718 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 19:48:24 +00:00
Jonathan Ellis 35cd1761f6 change default comparator to BytesType
patch by jbellis; reviewed by Chris Goffinet for CASSANDRA-400

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809645 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 16:07:37 +00:00
Jonathan Ellis fa1d99ac96 add forwards-compatible ConsistencyLevel parameter to get_key_range. Currently it is a no-op. patch by Chris Goffinet; reviewed by jbellis for CASSANDRA-322
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809639 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 15:50:58 +00:00
Jun Rao 533dcad919 Deadlock with SelectorManager.doProcess and TcpConnection.write; patch by Sammy Yu and junrao; reviewed by Chris Goffinet for CASSANDRA-392
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809629 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 15:44:42 +00:00
Jonathan Ellis eb83251bda r/m unnecessary IReplicationStrategy interface. r/m LoadVerbHandler and unused endpoint-related code. rename AbstractStrategy -> AbstractReplicationStrategy and getEndpoint methods.
patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-393

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809586 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 13:35:46 +00:00
Jonathan Ellis 86abfe1027 r/m special case of local destination when writing with ConsistencyLevel.ZERO, since it causes blocking for commitlog. (MessagingService still optimizes out the network write/read.) Patch by Chris Goffinet; reviewed by jbellis for CASSANDRA-399
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809216 13f79535-47bb-0310-9956-ffa450edef68
2009-08-29 22:39:58 +00:00
Jonathan Ellis 8c3693c6b0 move Map creation into default constructor so we don't waste object creation when the non-default constructor is used
patch by jbellis

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@809001 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 19:33:05 +00:00
Jonathan Ellis dc794169b8 Fixes to make BinaryMemtable useful. Highlights are configurable threads for [binary]memtable flushing and flushAndShutdown JMX/nodeprobe directive.
patch by Chris Goffinet; reviewed by jbellis for CASSANDRA-337

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808942 13f79535-47bb-0310-9956-ffa450edef68
2009-08-28 16:27:58 +00:00
Jonathan Ellis 40641c73a6 remove multiget_count until/unless there is a demonstrated need for it. patch by jbellis for CASSANDRA-70
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808597 13f79535-47bb-0310-9956-ffa450edef68
2009-08-27 20:11:49 +00:00
Jonathan Ellis 6690c51359 Update AsyncResult to know when it started waiting so you can get() multiple Results in serial but have them wait in parallel. Use this to implement multiget methods. Remove unused MultiAsyncResult code and StorageProxy methods using it.
Patch by Chris Goffinet; reviewed by jbellis for CASSANDRA-70

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808589 13f79535-47bb-0310-9956-ffa450edef68
2009-08-27 20:07:12 +00:00
Jonathan Ellis ba88f55d1f fix getUsedDiskSpace to look at data directories recursively. Patch by Sammy Yu; reviewed by jbellis for CASSANDRA-394
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808546 13f79535-47bb-0310-9956-ffa450edef68
2009-08-27 17:22:03 +00:00
Jonathan Ellis 021ab75a5f add midpoint method to IPartitioner. patch by Stu Hood; reviewed by jbellis for CASSANDRA-242
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808206 13f79535-47bb-0310-9956-ffa450edef68
2009-08-26 22:20:23 +00:00
Jonathan Ellis f8fa6d2431 refactors COPP to use BytesToken. patch by Stu Hood; reviewed by jbellis for CASSANDRA-242
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808205 13f79535-47bb-0310-9956-ffa450edef68
2009-08-26 22:20:13 +00:00
Jonathan Ellis 847f3b0293 1. Switch bootstrapNodes in TokenMetadata to Map<Token,EndPoint> so RackUnawareStrategy can use it.
2. Fix AbstractStrategy and RackUnawareStrategy to incorporate the bootstrapping nodes for
getHintedStorageEndPoints through StorageService.getNStorageEndPointMap (now used by insert and
insertBlocking after 383)
3. Add unit test fot RackUnawareStrategy to test if bootstrapping nodes are being returned correctly.

patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-375

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808161 13f79535-47bb-0310-9956-ffa450edef68
2009-08-26 19:04:07 +00:00
Jonathan Ellis 489143566d add more (debug) logging to log recovery process. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808151 13f79535-47bb-0310-9956-ffa450edef68
2009-08-26 18:33:46 +00:00
Jonathan Ellis 0fc2d87e2b combine batch_insert and batch_insert_super the way we did get_slice and get_slice_super
patch by jbellis.  reviewed by Chris Goffinet and Evan Weaver for CASSANDRA-388

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@808045 13f79535-47bb-0310-9956-ffa450edef68
2009-08-26 15:11:27 +00:00
Jun Rao c4992f48ce Expose ring map to client for more direct access; patch by junrao; reviewed by jbellis for CASSANDRA-197
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@807431 13f79535-47bb-0310-9956-ffa450edef68
2009-08-24 23:39:27 +00:00
Jonathan Ellis a2899de137 [fixed version] avoid opening multiple writers for the current file; the buffered nature of the global logWriter_ could cause problems
patch by jbellis; reviewed for CASSANDRA-370 by Sammy Yu

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@807399 13f79535-47bb-0310-9956-ffa450edef68
2009-08-24 22:03:35 +00:00
Jonathan Ellis eb49a18acd need to include column container's deletion status when determining whether to include a column in the live count.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-386

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@807395 13f79535-47bb-0310-9956-ffa450edef68
2009-08-24 21:48:20 +00:00
Jonathan Ellis 39d97f3892 Revert "CASSANDRA-370 avoid opening multiple writers for the current file; the buffered nature of the global logWriter_ could cause problems"
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@807381 13f79535-47bb-0310-9956-ffa450edef68
2009-08-24 21:13:32 +00:00
Jonathan Ellis 12cbf75280 read(bytes) doesn't automatically throw EOFException if it reads less than asked for, so we need to check for that.
patch by jbellis; reviewed by Sammy Yu for CASSANDRA-370

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@807365 13f79535-47bb-0310-9956-ffa450edef68
2009-08-24 20:32:00 +00:00
Jonathan Ellis 5fd4ff7747 CASSANDRA-370 avoid opening multiple writers for the current file; the buffered nature of the global logWriter_ could cause problems
patch by jbellis; reviewed by Sammy Yu for CASSANDRA-370

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@807364 13f79535-47bb-0310-9956-ffa450edef68
2009-08-24 20:31:56 +00:00
Jonathan Ellis 3917094f04 allow blocking write to create hints if not enough of the "correct" nodes are live, but enough are to fulfil the requested consistency level. patch by Sandeep Tata; reviewed by jbellis and Michael Greene for CASSANDRA-383
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@807305 13f79535-47bb-0310-9956-ffa450edef68
2009-08-24 16:49:21 +00:00
Eric Evans dcabc0e343 print right side of range in nodeprobe ring output
Patch by Sammy Yu and Michael Greene; reviewed by eevans for CASSANDRA-382

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806362 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 21:17:59 +00:00
Jonathan Ellis 568933f5c4 change LongType to read longs in big endian order to be consistent with network order and the UUID types.
patch by jbellis and Evan Weaver; reviewed by Michael Greene for CASSANDRA-384

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806342 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 20:37:45 +00:00
Jonathan Ellis c8dbd6a402 finish removing Groovy. patch by Michael Greene; reviewed by jbellis for CASSANDRA-380
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806305 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 19:00:58 +00:00
Jonathan Ellis 51401247c1 remove groovy jar, half-baked Callout code. patch by Michael Greene; reviewed by jbellis for CASSANDRA-380
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806267 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 17:24:33 +00:00
Jonathan Ellis 6be6f84d39 sanity check start, finish slice args
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-376

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806245 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 16:37:14 +00:00
Jonathan Ellis d7e492410a remove authorship comments. patch by Michael Greene; reviewed by jbellis for CASSANDRA-379
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806032 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 03:31:24 +00:00
Jonathan Ellis c0df773c99 add getPendingTasks to CommitLogExecutorService
patch by jbellis; reviewed by Michael Greene for CASSANDRA-369

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806030 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 03:13:19 +00:00
Jonathan Ellis e959b2c7f6 rename getInitialToken to getToken; it doesn't actually have anything to do w/ initial or default tokens. log token on startup.
patch by jbellis; reviewed by Sammy Yu for CASSANDRA-364

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806016 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 01:03:31 +00:00
Jonathan Ellis 8a72a27cf1 rename underscores away
patch by jbellis; reviewed by Sammy Yu for CASSANDRA-364

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@806015 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 01:03:20 +00:00
Jonathan Ellis 0c5cd149a3 Add "bootstrap mode" to node startup. This causes the node to tell the
nodes that have data it needs to send it the data, and not otherwise
participate in reads or writes until the bootstrap is complete.
patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-195

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@805968 13f79535-47bb-0310-9956-ffa450edef68
2009-08-19 20:51:06 +00:00
Jonathan Ellis bb464c1f37 use the subcomparator when toStringing slice commands on subcolumns. this exposes a couple bugs: fix getString in non-string types to accept byte[0], and fix a test to send a long to a LongType subcolumn. patch by jbellis and Evan Weaver for CASSANDRA-377
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@805868 13f79535-47bb-0310-9956-ffa450edef68
2009-08-19 16:27:20 +00:00
Jonathan Ellis 007df950fc add missing while loop on periodic commitlog sync thread.
patch by jbellis; reviewed by Chris Goffinet for CASSANDRA-367

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@805615 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 22:49:20 +00:00
Jonathan Ellis 0004623029 fix typo setting syncperiod. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@805505 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 17:24:55 +00:00
Jonathan Ellis db18318c0a do timed sync if we're not doing it in the executor process()
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@805211 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 23:34:23 +00:00
Jonathan Ellis eb886e9999 make StorageTable.StorageMetadata a singleton, so multiple initMetadatas are safe.
patch by Bill de hOra and jbellis; reviewed by Michael Greene for CASSANDRA-358

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@804372 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 21:00:18 +00:00
Jonathan Ellis 5f4734eaa8 rename dispatchMessage overload w/ identical erased signature to make JDK7 (and the Java spec) happy. patch by Michael Greene; reviewed by jbellis for CASSNADRA-366
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@804359 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 20:20:50 +00:00
Jonathan Ellis 1aeca2b625 add license headers to new-since-0.3 files.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-365

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@804294 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 16:52:55 +00:00
Jonathan Ellis 7158863861 Fixes for saving Token in SystemTable. patch by jbellis and Sammy Yu for CASSANDRA-362
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@804045 13f79535-47bb-0310-9956-ffa450edef68
2009-08-13 22:16:01 +00:00
Jonathan Ellis ddf00a509a give up on trying to optimize startWith -- it's basically impossible when replication factor > 1 b/c of the range wrap point.
patch by jbellis; tested by Mark Robson for CASSANDRA-348

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@803716 13f79535-47bb-0310-9956-ffa450edef68
2009-08-12 21:27:24 +00:00
Eric Evans cd66ac8326 CASSANDRA-361 cleanup left-over references to Cql
Patch by Michael Greene (+ regeneration of thrift code); reviewed
by eevans for CASSANDRA-361

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@803355 13f79535-47bb-0310-9956-ffa450edef68
2009-08-12 02:59:55 +00:00
Jonathan Ellis 3ec8258db6 expose threadpool's pendingtasks via nodeprobe. patch by Sammy Yu; reviewed by jbellis for CASSANDRA-360
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@803285 13f79535-47bb-0310-9956-ffa450edef68
2009-08-11 20:40:10 +00:00
Jonathan Ellis a461792de9 Move CFSerializer into its own file. Rename deserializeEmpty to deserializeFromSSTableNoColumns; add serializeForSSTable and serializeWithIndexes to do the without-metadata serialization. Add SSTableReader.makeColumnFamily to create the CF skeleton w/o reading any data.
patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-233

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@803284 13f79535-47bb-0310-9956-ffa450edef68
2009-08-11 20:34:21 +00:00
Jonathan Ellis ac414f9a52 add back read latency stats for CFS.getColumnFamily. patch by Sammy Yu; reviewed by jbellis for CASSANDRA-359
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@803240 13f79535-47bb-0310-9956-ffa450edef68
2009-08-11 18:27:20 +00:00
Jonathan Ellis 850e865440 use CFS executor for BMt flushes.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-337

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@803211 13f79535-47bb-0310-9956-ffa450edef68
2009-08-11 17:17:21 +00:00
Jonathan Ellis 7ea2c96852 add settings for buffer sizes; make unconfigurable ones more sane.
patch by jbellis; reviewed by Jun Rao and Eric Evans for CASSANDRA-355

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@803135 13f79535-47bb-0310-9956-ffa450edef68
2009-08-11 14:13:47 +00:00
Jonathan Ellis 9f570c192d respect "start" filter argument for subcolumns.
patch by jbellis; reviewed by Even Weaver for CASSANDRA-357

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802978 13f79535-47bb-0310-9956-ffa450edef68
2009-08-11 02:09:40 +00:00
Jonathan Ellis 480650b826 fix typo breaking CompareSubcolumnsWith. fix timeuuid compare with byte[0].
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-357

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802977 13f79535-47bb-0310-9956-ffa450edef68
2009-08-11 02:09:33 +00:00
Jonathan Ellis 7f63092fed fix build failure. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802969 13f79535-47bb-0310-9956-ffa450edef68
2009-08-11 00:50:19 +00:00
Jonathan Ellis 6b7a1c300f switch "!isAscending" for "reversed."
patch by jbellis, Carl Bystrom, and Bill de hOra. reviewed by Eric Evans for CASSANDRA-311

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802953 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 23:17:08 +00:00
Jonathan Ellis 5a31842278 check column-level bloom filter during name-based slicing.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-325

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802950 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 22:52:08 +00:00
Eric Evans 8455ebfe87 CASSANDRA-296 remove CQL
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802911 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 19:35:01 +00:00
Eric Evans 38c2556834 CASSANDRA-296 remove CQL support from the CLI
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802909 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 19:34:45 +00:00
Eric Evans e3f6bd529f CASSANDRA-296 fix grammar breakage
Changeset ada820 was an attempt to make hostname parsing less stupid,
(i.e. don't allow underscores; do allow hyphens; allow IP addresses).
It didn't entirely fix the problems it set out to and it broke
parsing of anything that used the "Identifier" lexer, (for example
the thrift {get,set} ... commands).

This changeset partially reverts ada820 until a proper fix to
hostname parsing can be found.

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802908 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 19:34:38 +00:00
Eric Evans bf6236ddf6 CASSANDRA-241 optional support for framed transport
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802898 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 18:57:03 +00:00
Jonathan Ellis ceb4a10808 use the existing collectReducedColumns api to make subcolumn slices conform as expected to filter semantics
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-356

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802827 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 15:30:12 +00:00
Jonathan Ellis cee37599f6 rename, clean up collectColumns methods
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-356

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802826 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 15:29:58 +00:00
Jonathan Ellis 15354b4906 Combine thrift slice methods. Now we have one get() method, one get_slice(), and one get_count().
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-329

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802640 13f79535-47bb-0310-9956-ffa450edef68
2009-08-10 02:51:35 +00:00
Jonathan Ellis 9d6f4752b6 reduce buffer sizes for test suite since it forces lots of small flushes. reduces NameSortTest from ~30s back to < 10s.
patch by jbellis for CASSANDRA-339

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802276 13f79535-47bb-0310-9956-ffa450edef68
2009-08-08 00:59:14 +00:00
Jonathan Ellis d748648b23 fix broken casts. patch by Bill de hOra; reviewed by jbellis for CASSANDRA-338
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802267 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 23:29:50 +00:00
Jonathan Ellis fa53f58871 make default OPP non-collating (compare is faster).
patch by jbellis; reviewed by Sammy Yu for CASSANDRA-339

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802186 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 20:57:08 +00:00
Jonathan Ellis e24925d49e add SSTableWriter buffer size option; increase default.
patch by jbellis; reviewed by Sammy Yu for CASSANDRA-339

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802185 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 20:57:02 +00:00
Jonathan Ellis 8a9c25ae0e - switch from trying to get the next endpoint by increasing offset to asking tokenMetadata for "the next
one." this will always be correct where the offset approach will not (usually you want offset to just be 1,
but sometimes you have to keep increasing it if no results are found but the range is still not finished)
 - merge results differently when the endpoint responsible for where the ring wraps is involved, since
that endpoint can hold keys from both the beginning and end of the range.

patch by jbellis; tested by Mark Robson for CASSANDRA-348

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802180 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 20:48:45 +00:00
Jonathan Ellis fba03ce691 move getKeyRange to CFS, where it encapsulates better.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-345

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802098 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 17:35:25 +00:00
Jonathan Ellis 9a9371d1ef include index and bloom filter in snapshots. patch by Sammy Yu; reviewed by jbellis for CASSANDRA-353
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802093 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 17:08:16 +00:00
Jonathan Ellis cb0e6a348f human-readable error for bad CommitLogSyncDelay.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-349

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802092 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 17:03:32 +00:00
Jonathan Ellis d221a41719 tests + fix for bsearch returning not-found-to-the-right
patch by jbellis; reviewed by Jun Rao for CASSANDRA-351

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802078 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 16:24:54 +00:00
Jonathan Ellis 671912ef57 final cleanup of SSTableSliceIterator, now with less unnecessary copying of Columns around
patch by jbellis; reviewed by Jun Rao for CASSANDRA-332

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802075 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 16:24:25 +00:00
Jonathan Ellis 4a0860e4fe avoid copying variables to ColumnGroupReader that it can get from the parent class. rename underscored variables.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-332

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802074 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 16:24:17 +00:00
Jonathan Ellis c011c67182 move comparator out of IndexInfo
patch by jbellis; reviewed by Jun Rao for CASSANDRA-332

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802073 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 16:24:12 +00:00
Jonathan Ellis a9c6a1e7d6 always write at least one index (with first and last column of the range) for the columns in row. this vastly simplifies column reading code and makes indexing bugs much more obvious (since there is only one read path each for names / slices now).
patch by jbellis; reviewed by Jun Rao for CASSANDRA-332

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802072 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 16:24:04 +00:00
Jonathan Ellis 0f2a76bb5b don't serialize unused column count into column index. remove DataInput/Output round-tripping from ColumnGroupReader
patch by jbellis; reviewed by Jun Rao for CASSANDRA-332

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@802071 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 16:23:53 +00:00
Jonathan Ellis 449a444c7d fix range query buglet; add debug logging
patch by jbellis; tested by Mark Robson for CASSANDRA-348

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@801676 13f79535-47bb-0310-9956-ffa450edef68
2009-08-06 15:34:22 +00:00
Jonathan Ellis e1e6a6c554 Improve the speed of RandomPartitioner comparator. patch by Sammy Yu; reviewed by jbellis for CASSANDRA-346
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@801493 13f79535-47bb-0310-9956-ffa450edef68
2009-08-06 01:55:29 +00:00
Jonathan Ellis 88b0ee7be4 fix more findbugs complaints. patch by Michael Greene; reviewed by jbellis for CASSANDRA-338
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@801228 13f79535-47bb-0310-9956-ffa450edef68
2009-08-05 13:38:40 +00:00
Jonathan Ellis ee3e388a80 fix SC.serializedSize. patch by jbellis; reviewed by Chris Goffinet for CASSANDRA-341
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@801048 13f79535-47bb-0310-9956-ffa450edef68
2009-08-05 02:37:45 +00:00
Jonathan Ellis 939709f977 fix NPE on iterator close. patch by jbellis; reviewed by Chris Goffinet for CASSANDRA-341
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@801047 13f79535-47bb-0310-9956-ffa450edef68
2009-08-05 02:37:40 +00:00
Jonathan Ellis 7bd9590c07 Rename UUIDType to LexicalUUIDType and add TimeUUIDType.
patch by jbellis; reviewed by Michael Koziarski for CASSANDRA-334

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@800573 13f79535-47bb-0310-9956-ffa450edef68
2009-08-03 21:27:04 +00:00
Jonathan Ellis 6c49231027 Bootstrap code + tests. Patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-213
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@800561 13f79535-47bb-0310-9956-ffa450edef68
2009-08-03 20:59:32 +00:00
Jonathan Ellis 07330c1cfa brings findbugs count from 266 -> 250 bugs by fixing some scopes, removing some dead code, and not implementing Serializable unnecessarily. patch by Michael Greene; reviewed for CASSANDRA-338 by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@800547 13f79535-47bb-0310-9956-ffa450edef68
2009-08-03 20:33:24 +00:00
Jonathan Ellis 6703ecffe1 forgot SSTable part of last.
patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-213

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@800442 13f79535-47bb-0310-9956-ffa450edef68
2009-08-03 16:03:15 +00:00
Jonathan Ellis b685882535 renames and cleanup for bootstrap-related code.
patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-213

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@800440 13f79535-47bb-0310-9956-ffa450edef68
2009-08-03 16:01:00 +00:00
Jonathan Ellis 2514d6dc64 fix spelling, indents from old SequenceFile code
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799951 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:31:33 +00:00
Jonathan Ellis 45514cf1be remove AbstractWriter. all it was providing was append methods, which are inlined into SSTableWriter now; the rest was all wrappers. also, rename some variables in SST/SSTW.
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799950 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:31:24 +00:00
Jonathan Ellis d1f4234d26 r/m SequenceFile. ColumnGroupReader moved to SSTableSliceIterator mostly unchanged for now. (finish cleaning this up in #332)
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799949 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:31:15 +00:00
Jonathan Ellis 28df101aaa replace SF.next with code in NamesIterator that doesn't rewrite data through an extra layer of DataOutput/Input
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799948 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:31:08 +00:00
Jonathan Ellis b2397a763e SF shouldn't duplicate position checking that was already done by SSTable. move utility methods to IndexHelper. fix off-by-4 in dataSizeReturned.
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799947 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:31:01 +00:00
Jonathan Ellis 4c2d91c213 r/m code in SF.next handling being called multiple times, since it can only be called once.
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799946 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:30:55 +00:00
Jonathan Ellis 8203a6cfb2 r/m special case that no column names=all columns; add test for no-columns cases.
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799945 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:30:49 +00:00
Jonathan Ellis 0f95411c03 r/m SF.next(DataOutput) in favor of more-efficient IteratingRow.
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799944 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:30:40 +00:00
Jonathan Ellis c31d44ae89 move next, getColumnGroupReader out of SSTableReader.
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799943 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:30:23 +00:00
Jonathan Ellis 22dc26bb9d make CommitLog use a raw BufferedRandomAccessFile instead of overloading AbstractWriter/IFileReader unnecessarily. the set of AW features used by both CommitLog and SSTable was nil.
patch by jbellis; reviewed by Stu Hood for CASSANDRA-330

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799942 13f79535-47bb-0310-9956-ffa450edef68
2009-08-01 22:30:14 +00:00
Jonathan Ellis da9778d509 unmix line endings in Table.java. patch by Jeff Hodges; reviewed by jbellis for CASSANDRA-333
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799743 13f79535-47bb-0310-9956-ffa450edef68
2009-07-31 20:42:54 +00:00
Jonathan Ellis 70ce402fdd Make range queries continue on the next node when necessary.
Patch by Arin Sarkissian; reviewed by jbellis for CASSANDRA-212

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799684 13f79535-47bb-0310-9956-ffa450edef68
2009-07-31 18:29:52 +00:00
Jonathan Ellis 9164940f41 allow start of [] to mean "start with the largest value" when ascending=false. patch by Jun Rao; reviewed by jbellis for CASSANDRA-263
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799632 13f79535-47bb-0310-9956-ffa450edef68
2009-07-31 15:06:35 +00:00
Jonathan Ellis 066ef58a96 run source files through dos2unix to standardize on \n line endings. patch by Jeff Hodges; reviewed by Michael Greene for CASSANDRA-111
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799331 13f79535-47bb-0310-9956-ffa450edef68
2009-07-30 15:30:21 +00:00
Jonathan Ellis edf2226079 add CompareSubcolumnsWith to describe_keyspace. patch by Evan Weaver; reviewed by Michael Greene for CASSANDRA-326
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799320 13f79535-47bb-0310-9956-ffa450edef68
2009-07-30 15:18:03 +00:00
Jonathan Ellis 5782d175a0 table -> keyspace in stress.py. patch by Michael Greene; reviewed by jbellis for CASSANDRA-271
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799313 13f79535-47bb-0310-9956-ffa450edef68
2009-07-30 15:11:43 +00:00
Jonathan Ellis 572b5f852d table -> keyspace
patch by jbellis; reviewed by Michael Greene for CASSANDRA-271

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799140 13f79535-47bb-0310-9956-ffa450edef68
2009-07-30 00:29:28 +00:00
Jonathan Ellis 56a846ba1c Pluggable replicaplacement, endpointsnitch classes (take 2). patch by Sammy Yu; reviewed by jbellis for CASSANDRA-323
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799065 13f79535-47bb-0310-9956-ffa450edef68
2009-07-29 20:39:01 +00:00
Jonathan Ellis bd05521131 Revert "Pluggable replicaplacement, endpointsnitch classes." Breaks test suite.
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799045 13f79535-47bb-0310-9956-ffa450edef68
2009-07-29 20:10:38 +00:00
Jonathan Ellis 51dbca6927 Pluggable replicaplacement, endpointsnitch classes. patch by Sammy Yu; reviewed by jbellis for CASSANDRA-323
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@799043 13f79535-47bb-0310-9956-ffa450edef68
2009-07-29 20:05:46 +00:00
Jonathan Ellis bfb5006420 add isTraceEnabled checks similar to isDebugEnabled. patch by jbellis for CASSANDRA-174
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798980 13f79535-47bb-0310-9956-ffa450edef68
2009-07-29 17:05:47 +00:00
Jonathan Ellis f856364274 add more if-isDebugEnabled lines to reduce overhead when logging at INFO or higher. patch by Michael Greene; reviewed by jbellis for CASSANDRA-174
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798979 13f79535-47bb-0310-9956-ffa450edef68
2009-07-29 17:00:18 +00:00
Jonathan Ellis 8588982b85 combine switchMemtable and enqueueFlush so that they always operate on the same object. move forceFlush guts from MT to CFS since it encapsulates better there
patch by jbellis; reviewed by Brandon Williams for CASSANDRA-320

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798935 13f79535-47bb-0310-9956-ffa450edef68
2009-07-29 15:05:07 +00:00
Jonathan Ellis ab6d4b9a64 pass consistency_level param from thrift to internals. patch by Gasol Wu; reviewed by jbellis for CASSANDRA-232
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798509 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 12:51:03 +00:00
Jonathan Ellis acd50bd901 add ConsistencyLevel parameter to read ops. patch by Sammy Yu; reviewed by jbellis for CASSANDRA-232
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798390 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 04:06:56 +00:00
Jonathan Ellis 574cb8f549 Use arrayblockingqueue in commitlog executor; this cleans up the code a bit (performance is unaffected since the writes and syncs are far more expensive than any queue ops)
patch by jbellis; reviewed by Jun Rao for CASSANDRA-182

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798373 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 02:46:11 +00:00
Jonathan Ellis fbe6c4a854 add config options for commitlog syncing
patch by jbellis; reviewed by Jun Rao for CASSANDRA-182

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798372 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 02:46:27 +00:00
Jonathan Ellis 35ff447ba4 custom CommitLogExecutorService that can fsync per multiple CL additions
patch by jbellis; reviewed by Jun Rao for CASSANDRA-182

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798371 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 02:45:55 +00:00
Jonathan Ellis 88a30f182a move log ops to callables on a threadpoolexecutor instead of synchronizing. this prepares the way to merge multiple add() calls into a single sync.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-182

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798370 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 02:45:50 +00:00
Jonathan Ellis 68bd9489b7 naive fsync-after-each-log-entry
patch by jbellis; reviewed by Jun Rao for CASSANDRA-182

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798369 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 02:46:02 +00:00
Jonathan Ellis 5e5d8385be mv AbstractWriter to its own top-level class and remove redundant IFileWriter
patch by jbellis; reviewed by Jun Rao for CASSANDRA-182

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798368 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 02:45:40 +00:00
Jonathan Ellis bf9caf8feb handle incomplete CL entries on recover
patch by jbellis; reviewed by Jun Rao for CASSANDRA-182

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798367 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 02:45:33 +00:00
Jonathan Ellis 1332c0ed65 use CSLS instead of NBHS for memtablesPendingFlush. See explanation here: http://sourceforge.net/tracker/?func=detail&aid=2828100&group_id=194172&atid=948362
patch by jbellis; reviewed by Brandon Williams for CASSANDRA-157

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798316 13f79535-47bb-0310-9956-ffa450edef68
2009-07-27 22:40:38 +00:00
Jonathan Ellis d76bbca3e2 add ConsistencyLevel Thrift enum to avoid client having to compute quorum size. patch by Sammy Yu; reviewed by jbellis for CASSANDRA-300
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798298 13f79535-47bb-0310-9956-ffa450edef68
2009-07-27 21:44:47 +00:00
Jonathan Ellis e3aef8e0ed fix bug in comparing-to-empty-array; realize that we need compare-to-empty-array to specify start/finish of slices.
patch by jbellis; reviewed by Stu Hood for CASSANDRA-119

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798273 13f79535-47bb-0310-9956-ffa450edef68
2009-07-27 20:19:53 +00:00
Jonathan Ellis 38d81587ac finish snapshot support. patch by Sammy Yu; reviewed by jbellis and Michael Greene for CASSANDRA-279
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798228 13f79535-47bb-0310-9956-ffa450edef68
2009-07-27 17:28:57 +00:00
Jonathan Ellis 67deae8e40 fix cli/thrift map key regression. patch by Gasol Wu; reviewed by jbellis for CASSANDRA-317
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@798019 13f79535-47bb-0310-9956-ffa450edef68
2009-07-27 04:15:49 +00:00
Jonathan Ellis 227b270134 standardize more method and parameter names on underscores instead of camelcase. patch by Michael Greene; reviewed by jbellis for CASSANDRA-312
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@797674 13f79535-47bb-0310-9956-ffa450edef68
2009-07-24 22:32:21 +00:00
Jonathan Ellis cf01ea1c49 Return standard/super designation to introspection and fix typo in DD. patch by Michael Greene; reviewed by jbellis for CASSANDRA-314
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@797209 13f79535-47bb-0310-9956-ffa450edef68
2009-07-23 20:11:57 +00:00
Jonathan Ellis 8d4b161f09 close temporary logWriters to avoid leaking FD. patch by Brandon Williams; reviewed by jbellis for CASSANDRA-313
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@797173 13f79535-47bb-0310-9956-ffa450edef68
2009-07-23 17:57:26 +00:00
Jonathan Ellis 058eef0806 return columns from desc query in desc order. patch by Jun Rao; reviewed by jbellis for CASSANDRA-196
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796881 13f79535-47bb-0310-9956-ffa450edef68
2009-07-22 21:13:35 +00:00
Jonathan Ellis 878991bb32 r/m unwanted logger.debug, pointed out by Michael Greene. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796559 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 22:08:34 +00:00
Eric Evans 32d964ff54 better handling of file names with spaces on windows
- Quote path names in startup bat file
- Pass File object instead of URI when parsing storage-conf.xml

Patch by Michael Greene; reviewed by eevans for CASSANDRA-307

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796345 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 15:21:59 +00:00
Jonathan Ellis b866f81415 add SubcolumnCompareWith option and subcolumnComparator code.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-304

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796132 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 03:01:55 +00:00
Jonathan Ellis 438f387705 add BytesType comparator (like AsciiType but doesn't require that the bytes mean anything)
patch by jbellis; reviewed by Eric Evans for CASSANDRA-304

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796131 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 03:01:42 +00:00
Jonathan Ellis 985d96a52c rename DD.getType -> getComparator
patch by jbellis; reviewed by Eric Evans for CASSANDRA-304

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796130 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 03:01:35 +00:00
Jonathan Ellis e425474af2 add get_slice for supercolumn, tests. add back updated TimeSortTest. we need to pass gcBefore to the filters so Slice can count correctly.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-303

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796129 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 02:58:20 +00:00
Jonathan Ellis 986cee6806 change String column names to byte[] to allow user-defined ordering.
patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-185

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796108 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 01:36:52 +00:00
Jonathan Ellis 8ff63a92ba r/m time-sorted columns.
patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-185

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796107 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 01:36:10 +00:00
Jonathan Ellis 7435fc82c0 introduce column() compatibility layer to make writing tests a little less verbose.
patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-185

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@796106 13f79535-47bb-0310-9956-ffa450edef68
2009-07-21 01:35:47 +00:00
Eric Evans bad8fb5fae allow separate config of thrift bind address
This patch adds a new configuration directive 'ThriftAddress', an
analogue to ListenAddress for the thrift service.

If left unconfigured, the thrift service will fall back to the same
default as ListenAddress (i.e., InetAddress.getLocalHost). Unlike
ListenAddress, it is OK to set ThriftAddress to 0.0.0.0 which
will result in the service listening on all interfaces.

Patch by eevans; reviewed by Michael Greene for CASSANDRA-288

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@795205 13f79535-47bb-0310-9956-ffa450edef68
2009-07-17 19:45:22 +00:00
Eric Evans f04b9d3ed4 remove ganglia analytics package
Patch by eevans; reviewed by Michael Greene for CASSANDRA-297

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@794876 13f79535-47bb-0310-9956-ffa450edef68
2009-07-16 21:40:59 +00:00
Jonathan Ellis 840a64dcb9 move data files into per-table subdirectories. patch by Arin Sarkissian; reviewed by Michael Greene and jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@794784 13f79535-47bb-0310-9956-ffa450edef68
2009-07-16 19:10:06 +00:00
Jonathan Ellis 715b60d147 fix not including tombstone-only keys in keyRange.
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-286

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@794475 13f79535-47bb-0310-9956-ffa450edef68
2009-07-16 00:39:01 +00:00
Jonathan Ellis ff764ff22b r/m offset from slice api; we could live with being inefficient but not with breaking read repair.
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-286

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@794474 13f79535-47bb-0310-9956-ffa450edef68
2009-07-16 00:38:53 +00:00
Jonathan Ellis 0b1aeda97c missed one: rename column.column_name -> column.name
patch by jbellis; reviewed by Evan Weaver and Sandeep Tata for CASSANDRA-139

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@794431 13f79535-47bb-0310-9956-ffa450edef68
2009-07-15 22:04:57 +00:00
Jonathan Ellis 85ba194e7c update system tests; fix get_column_count
patch by jbellis; reviewed by Evan Weaver and Sandeep Tata for CASSANDRA-139

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@794430 13f79535-47bb-0310-9956-ffa450edef68
2009-07-15 22:04:51 +00:00
Jonathan Ellis f2da00fb0f thrift changes to remove : api.
use ColumnPath, ColumnParent, etc. structs to encapsulate optional SuperColumns (and occasionally, optional Columns).
patch by jbellis; reviewed by Evan Weaver and Sandeep Tata for CASSANDRA-139

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@794429 13f79535-47bb-0310-9956-ffa450edef68
2009-07-15 22:04:43 +00:00
Jonathan Ellis 9c5274b4cd rename confusing "random" magic number variables. patch by jbellis; reviewed by Michael Greene for CASSANDRA-74
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@794079 13f79535-47bb-0310-9956-ffa450edef68
2009-07-14 21:46:43 +00:00
Jonathan Ellis 4b4459c0d1 r/m ZooKeeper vestiges. patch by Michael Greene; reviewed by jbellis for CASSANDRA-291
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@793691 13f79535-47bb-0310-9956-ffa450edef68
2009-07-13 20:05:04 +00:00
Jonathan Ellis dd4f4be2b4 add IdentityQueryFilter and finish removing IFilter.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-287

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@793055 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 17:49:18 +00:00
Jonathan Ellis 7b6fb2b36c add TimeQueryFilter; remove old TimeFilter.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-287

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@793054 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 17:49:06 +00:00
Jonathan Ellis 48093358fb replace namesfilter with NamesQueryFilter. mv filter code into separate package.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-287

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@793053 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 17:49:01 +00:00
Jonathan Ellis 4d1395e0fa refactor out QueryFilter, SliceQueryFilter.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-287

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@793052 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 17:48:49 +00:00
Jonathan Ellis 7762e06571 rename lock_ -> sstableLock_.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-287

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@793051 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 17:48:45 +00:00
Jonathan Ellis f5a787af72 r/m unused (and dangerous) RowReadCommand.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-287

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@793050 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 17:48:41 +00:00
Eric Evans 0e4135933a add PendingTasks attribute to NodeProbe cfstats output
Patch by Sammy Yu; reviewed by Arin Sarkissian for CASSANDRA-285

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@792597 13f79535-47bb-0310-9956-ffa450edef68
2009-07-09 16:18:39 +00:00
Eric Evans 8c04ffd52a added CFS pending tasks JMX attribute
Patch by eevans; reviewed by Arin Sarkissian for CASSANDRA-173

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@792343 13f79535-47bb-0310-9956-ffa450edef68
2009-07-08 22:49:08 +00:00
Eric Evans aaa6eee87d expose CF write count/latency via JMX
Patch by Sammy Yu; reviewed by Eric Evans for CASSANDRA-272


git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@792161 13f79535-47bb-0310-9956-ffa450edef68
2009-07-08 14:24:25 +00:00
Jonathan Ellis 4e3a4404c9 spelling fixes. patch by Michael Greene; reviewed by jbellis for CASSANDRA-281
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@792126 13f79535-47bb-0310-9956-ffa450edef68
2009-07-08 12:56:23 +00:00
Jonathan Ellis 2b18bade55 make get_key_range act on a single CF.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-280

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791961 13f79535-47bb-0310-9956-ffa450edef68
2009-07-07 19:57:37 +00:00
Jonathan Ellis 23fa1bc0bd combine range version of get_slice into get_slice itself.
patch by jbellis; reviewed by Michael Greene for CASSANDRA-277

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791872 13f79535-47bb-0310-9956-ffa450edef68
2009-07-07 15:40:46 +00:00
Jonathan Ellis e324ef9051 disallow specifying ColumnSort on supercolumns. patch by jbellis; reviewed by Evan Weaver for CASSANDRA-251
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791598 13f79535-47bb-0310-9956-ffa450edef68
2009-07-06 20:07:52 +00:00
Jonathan Ellis b54de30a02 per-table key cache size.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-259

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791592 13f79535-47bb-0310-9956-ffa450edef68
2009-07-06 19:58:13 +00:00
Jonathan Ellis d6c0b0f259 refactor sstable into SSTable, SSTableReader, and SSTableWriter.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-259

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791591 13f79535-47bb-0310-9956-ffa450edef68
2009-07-06 19:58:05 +00:00
Jonathan Ellis 013d59fc00 add concurrentlinkedhashmap cache and config option. config option is NOT yet wired up to control cache sizes.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-259

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791590 13f79535-47bb-0310-9956-ffa450edef68
2009-07-06 19:57:50 +00:00
Jonathan Ellis 26aefa2f4a encapsulate bloom filter access into sstable.getPosition
patch by jbellis; reviewed by Jun Rao for CASSANDRA-259

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791589 13f79535-47bb-0310-9956-ffa450edef68
2009-07-06 19:57:44 +00:00
Jonathan Ellis cdd8b17062 add offset support to get_slice. patch by Jun Rao; reviewed by jbellis for CASSANDRA-261
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791553 13f79535-47bb-0310-9956-ffa450edef68
2009-07-06 17:50:16 +00:00
Jonathan Ellis 0172497ad2 minor code cleanups. patch by Edward Ribeiro; reviewed by jbellis for CASSANDRA-273
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@791059 13f79535-47bb-0310-9956-ffa450edef68
2009-07-04 05:55:09 +00:00
Jonathan Ellis ca56a3eab3 more consistent checking of thrift parameters; fixes multiple bugs.
patch by jbellis; reviewed by Evan Weaver for CASSANDRA-266

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@789979 13f79535-47bb-0310-9956-ffa450edef68
2009-06-30 22:06:56 +00:00
Jonathan Ellis 83b203e61e add test catching buggy update of header on flush; refactor so there is only one version of code doing those writes (the correct one).
patch by jbellis; reviewed by Jun Rao for CASSANDRA-264

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@789465 13f79535-47bb-0310-9956-ffa450edef68
2009-06-29 22:07:49 +00:00
Jonathan Ellis f2cab86892 don't remove commitlog files when replay fails; you lose the chance to fix a bug, as well as your data.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-264

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@789464 13f79535-47bb-0310-9956-ffa450edef68
2009-06-29 22:07:41 +00:00
Jonathan Ellis 0077af40fd add isDebugEnabled check for logger.debug for performance. patch by goffinet; reviewed by jbellis for CASSANDRA-174
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788914 13f79535-47bb-0310-9956-ffa450edef68
2009-06-27 01:22:49 +00:00
Jonathan Ellis af82ca7ae1 Enhance describeTable to return Map of Column Family so that it can be programatically parsed. patch by Sammy Yu; reviewed by jbellis for CASSANDRA-258
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788895 13f79535-47bb-0310-9956-ffa450edef68
2009-06-26 22:37:42 +00:00
Jonathan Ellis 261340a342 r/m http server (use cli, nodeprobe, jmx as necessary instead).
patch by jbellis and Eric Evans for CASSANDRA-211

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788892 13f79535-47bb-0310-9956-ffa450edef68
2009-06-26 22:29:12 +00:00
Jonathan Ellis fe2bd0103f r/m refactor from CASSANDRA-249 that caused infinite recursion. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788781 13f79535-47bb-0310-9956-ffa450edef68
2009-06-26 17:38:22 +00:00
Jonathan Ellis f55dd06ec5 avoid optimization of not checking older memtable and SSTables if we find _an_ answer early on; it causes bugs
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788776 13f79535-47bb-0310-9956-ffa450edef68
2009-06-26 17:26:36 +00:00
Jonathan Ellis b9da215e06 some gms tests. patch by johano; reviewed by jbellis for CASSANDRA-249
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788771 13f79535-47bb-0310-9956-ffa450edef68
2009-06-26 17:22:40 +00:00
Jonathan Ellis 68564e1549 s/intepret/interpret/
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788770 13f79535-47bb-0310-9956-ffa450edef68
2009-06-26 17:22:30 +00:00
Jonathan Ellis 3a7a33ce0f fix tombstone bug in get_columns_since.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-217

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788518 13f79535-47bb-0310-9956-ffa450edef68
2009-06-25 21:27:00 +00:00
Jonathan Ellis adaff5f215 reformat. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788517 13f79535-47bb-0310-9956-ffa450edef68
2009-06-25 21:26:53 +00:00
Jonathan Ellis 6342512a34 CASSANDRA-217 rename get_slice_from to get_slice. implement get_slice_super in terms of SliceFrom too.
(time-based columns can continue to be sliced with get_columns_since)

patch by jbellis; reviewed by Eric Evans for CASSANDRA-217

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788516 13f79535-47bb-0310-9956-ffa450edef68
2009-06-25 21:26:33 +00:00
Jonathan Ellis 963a1b3bfd add tests for supercolumnfamily removal; fix bugs.
(both the assert removal and the "if" removal are bug fixes.)

patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-255

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788511 13f79535-47bb-0310-9956-ffa450edef68
2009-06-25 21:07:45 +00:00
Jonathan Ellis 27d66d8269 add asserts. patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-255
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788510 13f79535-47bb-0310-9956-ffa450edef68
2009-06-25 21:07:35 +00:00
Jonathan Ellis 4e7f8deac0 switch to passing a single filename to open an sstable for writing. this makes open-for-read and open-for-write consistent.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-254

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788473 13f79535-47bb-0310-9956-ffa450edef68
2009-06-25 19:14:07 +00:00
Jonathan Ellis 4283f0d879 add private constructor that doesn't init writers
patch by jbellis; reviewed by Eric Evans for CASSANDRA-254

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788472 13f79535-47bb-0310-9956-ffa450edef68
2009-06-25 19:13:59 +00:00
Jonathan Ellis 064a59cdb0 cleanup CFS.onstart
patch by jbellis; reviewed by Jun Rao for CASSANDRA-235

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788146 13f79535-47bb-0310-9956-ffa450edef68
2009-06-24 19:25:21 +00:00
Jonathan Ellis b516ce8176 DBManager obscures rather than clarifies what is going on. Remove it.
At some point we stopped calling DBManager.instance(), so Table.onStart was
not getting called.  Move that into CassandraDaemon so we don't rely on a side
effect to run it.

patch by jbellis; reviewed by Jun Rao for CASSANDRA-235

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788145 13f79535-47bb-0310-9956-ffa450edef68
2009-06-24 19:25:17 +00:00
Jonathan Ellis 81dd8ee5f6 use normal Table for system metadata
patch by jbellis; reviewed by Jun Rao for CASSANDRA-235

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788144 13f79535-47bb-0310-9956-ffa450edef68
2009-06-24 19:25:33 +00:00
Jonathan Ellis 682736ee5e r/m recycle cf and undocumented/incomplete Loader code using it
patch by jbellis; reviewed by Jun Rao for CASSANDRA-235

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788143 13f79535-47bb-0310-9956-ffa450edef68
2009-06-24 19:25:04 +00:00
Jonathan Ellis 5cdc75d760 move Hints cf to SYSTEM_TABLE
patch by jbellis; reviewed by Jun Rao for CASSANDRA-235

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@788142 13f79535-47bb-0310-9956-ffa450edef68
2009-06-24 19:24:56 +00:00
Jonathan Ellis a89e782556 merge from 0.3 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787767 13f79535-47bb-0310-9956-ffa450edef68
2009-06-23 17:57:04 +00:00
Jonathan Ellis f9a1343d92 make static methods of SSTable that take a filename and then use the cache to grab an sstable object, simple non-static methods instead
patch by jbellis; reviewed by Eric Evans for CASSANDRA-224

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787762 13f79535-47bb-0310-9956-ffa450edef68
2009-06-23 17:48:18 +00:00
Jonathan Ellis 2f322a8bd0 encapsulate sstable bloom filter
patch by jbellis; reviewed by Eric Evans for CASSANDRA-224

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787761 13f79535-47bb-0310-9956-ffa450edef68
2009-06-23 17:48:08 +00:00
Jonathan Ellis 2493c9a565 encapsulate sstable index
patch by jbellis; reviewed by Eric Evans for CASSANDRA-224

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787760 13f79535-47bb-0310-9956-ffa450edef68
2009-06-23 17:48:18 +00:00
Jonathan Ellis a2f9b40183 refactor read-only constructor to SSTable.open
patch by jbellis; reviewed by Eric Evans for CASSANDRA-224

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787759 13f79535-47bb-0310-9956-ffa450edef68
2009-06-23 17:47:53 +00:00
Jonathan Ellis d48d8fcbf7 r/m unused code dealing with sstables, and ConcurrentWriter / FastConcurrentWriter. mmap is not faster than write() for sequential I/O, which is what the vast majority of our writes are. mmap _does_ have an advantage when we seek back to the start of a commitlog segment to update the headers after memtable flush, but we do that infrequently enough that it's not worth the disadvantages (primarily, blowing up if we exceed the 4MB size).
patch by jbellis; reviewed by Eric Evans for CASSANDRA-224

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787758 13f79535-47bb-0310-9956-ffa450edef68
2009-06-23 17:47:45 +00:00
Jonathan Ellis bf660bb97f fix more null table parameters.
patch by jbellis; reviewed by goffinet for CASSANDRA-79

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787408 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 21:18:18 +00:00
Jonathan Ellis 509cbb85de remove table_ from CommitLog and add multitable tests.
patch by jbellis; reviewed by goffinet for CASSANDRA-79

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787407 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 21:18:12 +00:00
Jonathan Ellis 5ccebd43c9 fix columnfamily id generation in the face of multiple tables and rip out TableMetadata serialization, which only complicates things needlessly.
patch by jbellis; reviewed by goffinet for CASSANDRA-79

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787406 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 21:18:02 +00:00
Jonathan Ellis cc373761dc cleanup of table.open.
patch by jbellis; reviewed by goffinet for CASSANDRA-79

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787405 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 21:17:58 +00:00
Jonathan Ellis 3673e28186 multitable support.
fix CF table dependencies, making CommitLogTest pass.  Also fixes CASSANDRA-188 in passing.

fix tablename being null bugs by always parsing tablename from filename.

fix last part of SequenceFile.

patch by jbellis; reviewed by goffinet for CASSANDRA-79

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787404 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 21:17:46 +00:00
Jonathan Ellis 9aeef94db8 Pass and write table parameter as needed throughout the codebase to add multitable support.
(Many places cheated and just assumed that tables.get(0) was the only table.)
Patch builds but does not yet pass tests.

Patch by goffinet; reviewed by jbellis for CASSANDRA-79

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787403 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 21:17:59 +00:00
Jonathan Ellis 1a66c10695 more CommitLog cleanup. patch by jbellis; reviewed by Jun Rao for CASSANDRA-243
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787284 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 15:49:57 +00:00
Jonathan Ellis 38f6446d08 rename "end" parameter to "finish" to avoid conflict w/ ruby keyword. patch by Stu Hood; reviewed by jbellis for CASSANDRA-247
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787258 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 14:46:27 +00:00
Jonathan Ellis b6645156bc replace new Foo(...) with Foo.valueOf. patch by Edward Ribeiro; reviewed by jbellis for CASSANDRA-246
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@787249 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 14:38:19 +00:00
Jonathan Ellis 1a23f9934f r/m new String() redundancy. patch by Edward Ribeiro; reviewed by jbellis for CASSANDRA-244
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@786888 13f79535-47bb-0310-9956-ffa450edef68
2009-06-20 19:22:28 +00:00
Jonathan Ellis d9e69b4024 switch from byte[] to BitSet in CommitLogHeader. patch by jbellis; reviewed by goffinet for CASSANDRA-237
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@786245 13f79535-47bb-0310-9956-ffa450edef68
2009-06-18 20:22:18 +00:00
Jonathan Ellis 5b99a22032 update comments, perform some renames, r/m unused code.
patch by jbellis; reviewed by goffinet for CASSANDRA-237

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@786244 13f79535-47bb-0310-9956-ffa450edef68
2009-06-18 20:22:14 +00:00
Jonathan Ellis a0c2b2a380 add CommitLog and RecoveryManager tests. patch by jbellis; reviewed by goffinet for CASSANDRA-237
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@786243 13f79535-47bb-0310-9956-ffa450edef68
2009-06-18 20:22:10 +00:00
Jonathan Ellis 15955bf03e minor cleanup of Row code. patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-199
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@786242 13f79535-47bb-0310-9956-ffa450edef68
2009-06-18 20:17:29 +00:00
Jonathan Ellis 03f6f244a3 merge from 0.3 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@786176 13f79535-47bb-0310-9956-ffa450edef68
2009-06-18 17:30:04 +00:00
Jonathan Ellis a116ef72e8 rethrow IOException with more details. patch by jbellis; reviewed by Jun Rao for CASSANDRA-202
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@786025 13f79535-47bb-0310-9956-ffa450edef68
2009-06-18 11:46:39 +00:00
Jonathan Ellis c1545f5214 fix off-by-one error in Range.contains(Token): the endpoint (right) of the range is always supposed to be exclusive, but it was inclusive in the non-wrapping case. patch by Stu Hood; reviewed by jbellis for CASSANDRA-236
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@785697 13f79535-47bb-0310-9956-ffa450edef68
2009-06-17 16:08:39 +00:00
Jonathan Ellis 01adb7a1aa add nodeprobe cli tool. patch by Eric Evans; reviewed by jbellis for CASSANDRA-211
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@785178 13f79535-47bb-0310-9956-ffa450edef68
2009-06-16 12:38:30 +00:00
Jonathan Ellis b356537196 r/m CM and CRAF. patch by jbellis; reviewed by Stu Hood for CASSANDRA-230
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@784842 13f79535-47bb-0310-9956-ffa450edef68
2009-06-15 16:20:04 +00:00
Jonathan Ellis 24fcbf4a95 switch singleton implementation from double-checked-locking to synchronized (code is not performance-sensitive). patch by Edward Ribeiro; reviewed by jbellis for CASSANDRA-228
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@784780 13f79535-47bb-0310-9956-ffa450edef68
2009-06-15 13:42:30 +00:00
Jonathan Ellis 6a2da22975 r/m unused Constants.java. patch by jbellis; reviewed by Edward Ribeiro for CASSANDRA-227
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@784495 13f79535-47bb-0310-9956-ffa450edef68
2009-06-14 01:14:34 +00:00
Jonathan Ellis cd2139ee7c system.exit on oome. patch by jbellis; reviewed by Eric Evans for CASSANDRA-218
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@783388 13f79535-47bb-0310-9956-ffa450edef68
2009-06-10 15:12:18 +00:00
Jonathan Ellis 72e6eea9e4 split sstable into data, index, and bloom filter files. this allows us to avoid saving up index chunks
in memory until the sstable data is completely written, while still allowing fast scanning of the index
on startup.  it also simplifies the sstable/sequencefile code considerably.
patch by jbellis; reviewed by Jun Rao for  CASSANDRA-208

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@783077 13f79535-47bb-0310-9956-ffa450edef68
2009-06-09 17:46:42 +00:00
Jonathan Ellis f685f4dec8 expose compaction via JMX. patch by Eric Evans; reviewed by jbellis for CASSANDRA-211
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@782774 13f79535-47bb-0310-9956-ffa450edef68
2009-06-08 20:37:38 +00:00
Jonathan Ellis b244a2e645 rename Table.doGC to forceCleanup. patch by Eric Evans; reviewed by jbellis for CASSANDRA-211
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@782773 13f79535-47bb-0310-9956-ffa450edef68
2009-06-08 20:37:31 +00:00
Jonathan Ellis d342288f36 cleanup SSTable-related code. patch by jbellis; reviewed by Jun Rao for CASSANDRA-208
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@782744 13f79535-47bb-0310-9956-ffa450edef68
2009-06-08 19:45:00 +00:00
Jonathan Ellis f6d0154e23 merge from 0.3 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@782740 13f79535-47bb-0310-9956-ffa450edef68
2009-06-08 19:37:57 +00:00
Jonathan Ellis 8f9e6a4516 To make available the Cassandra specific information available on the
node detail page:

- Exposed the existing StorageService.getLoadInfo()
- Created StorageService.getCurrentGenerationNumber() and added to
  MBean interface.

patch by Eric Evans; reviewed by jbellis for CASSANDRA-211

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@782629 13f79535-47bb-0310-9956-ffa450edef68
2009-06-08 13:59:52 +00:00
Jonathan Ellis 7520b4356b add getRangeToEndPointMap to JMX. Requires making Token and Range Serializable. Patch by Eric Evans; reviewed by jbellis for CASSANDRA-211
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@782182 13f79535-47bb-0310-9956-ffa450edef68
2009-06-06 02:45:20 +00:00
Jonathan Ellis a087b97c96 merge from 0.3 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@782117 13f79535-47bb-0310-9956-ffa450edef68
2009-06-05 19:52:29 +00:00
Jonathan Ellis 76a8f7b551 merge from 0.3 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@782096 13f79535-47bb-0310-9956-ffa450edef68
2009-06-05 18:40:06 +00:00
Jonathan Ellis 04dcee09ba r/m Row.getColumnFamilyMap. replaced with Row.getColumnFamily or .getColumnFamilies as appropriate.
patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-198

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@779773 13f79535-47bb-0310-9956-ffa450edef68
2009-05-28 21:15:24 +00:00
Jonathan Ellis f116a3e4e5 merge from 0.3 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@779771 13f79535-47bb-0310-9956-ffa450edef68
2009-05-28 21:10:07 +00:00
Jonathan Ellis edacc67c26 remove unnecessary List creation in getSliceFrom and move close() cleanup for to the finally block. patch by Jun Rao; reviewed by jbellis for CASSANDRA-201
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@779322 13f79535-47bb-0310-9956-ffa450edef68
2009-05-27 21:41:04 +00:00
Jonathan Ellis 7acfcb0e45 r/m shutdown code (making Cassandra crash-only, which it has been de facto for a while).
patch by jbellis; reviewed by Eric Evans for CASSANDRA-115

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@779290 13f79535-47bb-0310-9956-ffa450edef68
2009-05-27 19:59:33 +00:00
Jonathan Ellis bb0d6dfa20 allow specifying a subset of columnfamilies to check for get_key_range.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-152

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@779261 13f79535-47bb-0310-9956-ffa450edef68
2009-05-27 18:04:56 +00:00
Jonathan Ellis 97c022f5ee short circuits sending a message if the mutation's destination is the local node. does not implement hint handling; takes the full message route if hints are involved. patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-132
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@778871 13f79535-47bb-0310-9956-ffa450edef68
2009-05-26 20:23:16 +00:00
Jonathan Ellis 56b499044b use cloneMeShallow where appropriate. patch by jbellis for CASSANDRA-79
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@777583 13f79535-47bb-0310-9956-ffa450edef68
2009-05-22 15:37:19 +00:00
Jonathan Ellis 4ac9118f7c Add get_slice_from functionality using column indexes for efficiency.
Patch by Jun Rao and jbellis for CASSANDRA-172

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@777578 13f79535-47bb-0310-9956-ffa450edef68
2009-05-22 15:33:42 +00:00
Jonathan Ellis a432e18077 more cleanup of compaction code.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-184

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@776720 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 14:58:39 +00:00
Jonathan Ellis d03d80b6ed merge from 0.3 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@776716 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 14:44:41 +00:00
Jonathan Ellis 0ae07f299e add block_for parameter to insert calls. patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-154
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@776365 13f79535-47bb-0310-9956-ffa450edef68
2009-05-19 15:51:10 +00:00
Jonathan Ellis 88edbed30c merge from 0.3 branch
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@775983 13f79535-47bb-0310-9956-ffa450edef68
2009-05-18 15:22:23 +00:00
Jonathan Ellis d52a110974 check for enough endpoints before starting a quorum wait.
patch by jbellis; reviewed by Jun Rao and Sandeep Tata for CASSANDRA-180

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@775361 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 21:37:45 +00:00
Jonathan Ellis 784d968db9 omitted to add Sandeep's SBRRC.java in last commit
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@775321 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 20:41:05 +00:00
Jonathan Ellis 20f7d032c7 add get_slice_by_name_range command. patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-53
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@775308 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 20:18:55 +00:00
Jonathan Ellis 324c3c32a1 allow specifying initial token. patch by Jun Rao; reviewed by jbellis for CASSANDRA-181
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@775203 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 15:55:35 +00:00
Jonathan Ellis 3d7203266a replace executor with locking. the interaction between the executor service terminating and the CFS
was inherently unsafe -- you would have to lock anyway to make it safe, the atomic reference wasn't
enough, so at that point you might as well get rid of the executor.

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774567 13f79535-47bb-0310-9956-ffa450edef68
2009-05-13 22:31:49 +00:00
Jonathan Ellis 735008dafc more log cleanup. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774424 13f79535-47bb-0310-9956-ffa450edef68
2009-05-13 16:47:14 +00:00
Jonathan Ellis bd3c6acf33 misc cleanup. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774166 13f79535-47bb-0310-9956-ffa450edef68
2009-05-13 02:19:34 +00:00
Jonathan Ellis f86d47c242 to avoid adding work to terminating executor (which will raise an exception) we need to check for threshold violated _first_, and move puts to the new memtable once flush has started. patch by jbellis; reviewed by Eric Evans for CASSANDRA-165
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774165 13f79535-47bb-0310-9956-ffa450edef68
2009-05-13 02:17:23 +00:00
Jonathan Ellis 3aca0737cb another workaround for register/select wonkiness. patch by jbellis; tested by Mark Robson for CASSANDRA-156
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774076 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 20:46:36 +00:00
Jonathan Ellis da441aed29 cleanup ssTable filename tracking. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774025 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 19:11:31 +00:00
Jonathan Ellis b460bd71c5 test to more reliably reproduce CME during range. fix by locking out compact during range query.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-161

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774024 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 19:11:27 +00:00
Jonathan Ellis 5886b7c9ac fix race condition in compaction -- it was possible for a read thread to "snapshot" ssTables_, then have
the compactor thread delete those (after merging them into a new file) before the read thread checked
them.  Since the read thread's "snapshot" doesn't include the new merged sstable, it incorrectly tells
the caller that the key does not exist.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-161

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774023 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 19:11:21 +00:00
Jonathan Ellis 41ee512d6f fix race condition between when memtable is replaced as the active one and when it's added to
the set of historical (pending flush) memtables.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-161

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774022 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 19:11:15 +00:00
Jonathan Ellis 2fd856de35 unregister mbean on flush. patch by daishi; reviewed by jbellis for CASSANDRA-157
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@774002 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 17:56:31 +00:00
Jonathan Ellis 5964cd4c04 extract tests that could conflict with each other to a separate test class (= gets own jvm)
patch by jbellis; reviewed by Sandeep Tata for CASSANDRA-162

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773941 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 15:26:52 +00:00
Jonathan Ellis ad2cd9a9ba more cleanup, mostly by reducing nesting level where possible. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773729 13f79535-47bb-0310-9956-ffa450edef68
2009-05-11 23:52:17 +00:00
Jonathan Ellis dd1f0972bb reformat. this is just whitespace changes, automated by the IDE. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773728 13f79535-47bb-0310-9956-ffa450edef68
2009-05-11 23:52:10 +00:00
Jonathan Ellis fe3e1a8a09 check for at-end-of-data in iterator init. patch by jbellis; reviewed by Jun Rao for CASSANDRA-153
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773727 13f79535-47bb-0310-9956-ffa450edef68
2009-05-11 23:48:34 +00:00
Jonathan Ellis dfa41ec103 cannonicalize all accesses to indexMetadataMap.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-153

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773726 13f79535-47bb-0310-9956-ffa450edef68
2009-05-11 23:48:28 +00:00
Jonathan Ellis 69bc7e97c8 unit test to expose bug system test is running into. patch by jbellis; reviewed by Jun Rao for CASSANDRA-153
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773725 13f79535-47bb-0310-9956-ffa450edef68
2009-05-11 23:48:20 +00:00
Jonathan Ellis 761e953afa clean up compaction code and refactor to allow user-specified threadhold (minimum number of CFs to compact). patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773573 13f79535-47bb-0310-9956-ffa450edef68
2009-05-11 14:26:16 +00:00
Jonathan Ellis 44a0a3a54d fix CME during range queries -- keyset call needs to go on the memtable exector.
patch by jbellis; tested by Tv for CASSANDRA-153

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773152 13f79535-47bb-0310-9956-ffa450edef68
2009-05-09 01:40:16 +00:00
Jonathan Ellis 61a8150420 fix iteration bug. it would always return hasNext=false if seekTo was called first. fixing this with maybeInit proved difficult, so init is now done in constructor and iterator itself is created lazily.
patch by jbellis; tested by nk11 for CASSANDRA-153

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773017 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 14:54:27 +00:00
Jonathan Ellis f2260f107b add more robust sanity checking of get_column arguments. patch by jbellis; reviewed by Jun Rao for CASSANDRA-151
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@773016 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 14:53:25 +00:00
Jonathan Ellis 750d0a16b0 more logging cleanout. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772790 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 22:09:13 +00:00
Jonathan Ellis 85c7c39ad1 avoid creating empty sstables on recovery flush. (a) empty sstables are still work for the compactor later, and (b) sstable.close errors out when it's empty. patch by jbellis.
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772773 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 21:09:51 +00:00
Jonathan Ellis ccfe2d7c9e make TSD threadsafe; note that BSD is not (since FailureDetector does its own locking). patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772765 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 20:33:55 +00:00
Jonathan Ellis c129b6d5d7 clean up read/write path more; include message id in logging so we can trace what
happens to an individual op.  patch by jbellis.

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772713 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 17:13:05 +00:00
Jonathan Ellis fb347bd3d1 fix CF.digest NPE. patch by jbellis; reviewed by Eric Evans for CASSANDRA-149
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772690 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 16:03:32 +00:00
Jonathan Ellis 3395efdb30 use explicit dirty flag instead of trying to cheat and use executor taskcount, which is race-prone. patch by jbellis; reviewed by Eric Evans for CASSANDRA-134
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772680 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 15:30:53 +00:00
Jonathan Ellis 4a2ba89fe3 r/m orphaned Leader code. patch by jbellis; reviewed by Eric Evans for CASSANDRA-143
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772455 13f79535-47bb-0310-9956-ffa450edef68
2009-05-06 22:40:16 +00:00
Jonathan Ellis c3f0d10a8e clean up more ad-hoc timing message and move to mbeans. add TimedStatsDeque to
simplify tracking load stats over a one-minute window.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-144

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772448 13f79535-47bb-0310-9956-ffa450edef68
2009-05-06 22:27:02 +00:00
Jonathan Ellis 65f66e982d force flush when there are pending ops on the memtable executor even when none have finished yet. this fixes test case intermittent failures. patch by jbellis; reviewed by Eric Evans for CASSANDRA-141
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772361 13f79535-47bb-0310-9956-ffa450edef68
2009-05-06 17:04:32 +00:00
Jonathan Ellis 3ed4e051b8 add pending tasks mbean to all DebuggableTPE. clean out ad-hoc queue length logging.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-135

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772030 13f79535-47bb-0310-9956-ffa450edef68
2009-05-06 02:27:54 +00:00
Jonathan Ellis 8042a4e441 allow periodic flushing on a per-CF basis for infrequently-updated CFs (i.e.,
unlikely to reach the memtable size or object count limits often).  this will allow
purging old commitlog segments in a more timely fashion.
patch by Jun Rao; reviewed by jbellis for CASSANDRA-134

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772026 13f79535-47bb-0310-9956-ffa450edef68
2009-05-06 01:55:51 +00:00
Jonathan Ellis 28e548a31c initialize configFileName_. patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-129
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772020 13f79535-47bb-0310-9956-ffa450edef68
2009-05-06 00:35:33 +00:00
Jonathan Ellis 362f287c84 refactor IColumn.addColumn to remove redundant name parameter. patch by Sandeep Tata; reviewed by jbellis for CASSANDRA-96
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@772000 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 22:47:22 +00:00
Jonathan Ellis 8dcf76ab27 tombstones take priority over non-tombstones w/ the same timestamp in supercolumn and column. this makes HH management deterministic.
patch by jbellis; reviewed by Jun Rao for CASSANDRA-34

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771935 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 17:03:25 +00:00
Jonathan Ellis f17487c541 A make hint generation include a real timestamp so we can do meaningful deletes
B call removeDeleted on the data we read locally to purge tombstones
 C because of (B) any supercolumn w/o subcolumns simply won't exist so we know we can skip re-deleting the endpoint data. so deleteKey becomes deleteHintedData.
 D because deleted data is not immediately purged, increased the scheduled interval from 20min to 60 to reduce the load of scanning the hint CF.

patch by Jun Rao and jbellis for CASSANDRA-34

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771934 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 17:03:15 +00:00
Jonathan Ellis 017b576fba cleanup and refactor HintedHandOffManager.
patch by jbellis and Jun Rao for CASSANDRA-34

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771933 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 17:03:04 +00:00
Jonathan Ellis 7779df6ce4 This patch adds ColumnFamilyStore.forceflush to the mbean so that it can be activated through the management agent. patch by Eric Evans; reviewed by jbellis for CASSANDRA-34
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771927 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 16:56:55 +00:00
Jonathan Ellis fce0ee0d7b This changeset abstracts the logic for placing a flush on the queue into a new method, Memtable.enqueueFlush. enqueueFlush is called from both forceflush and put (when a threshold is exceeded), without the need to apply a special flushKey. patch by Eric Evans; reviewed by jbellis for CASSANDRA-34
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771926 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 16:56:40 +00:00
Jonathan Ellis 494de44355 move more gossip log messages to trace and de-obfuscate some variable and method names.
patch by jbellis.

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771878 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 16:11:07 +00:00
Jonathan Ellis b2e2b1c116 use `block` flag instead of separate _blocking methods. throw exception on error instead of returning bool for success. patch by jbellis; reviewed by Eric Evans for CASSANDRA-131
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771761 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 14:54:05 +00:00
Jonathan Ellis 7b2589ddb0 add logging for httpconnection to troubleshoot #133. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771591 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 06:57:16 +00:00
Jonathan Ellis 62ed2cbc16 user-friendly error when partitioner is missing. patch by jbellis
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771465 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 22:03:52 +00:00
Jonathan Ellis 219293b2b3 clean up logging. move some of it into MBeans. patch by jbellis; reviewed by Eric Evans for CASSANDRA-130
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771412 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 19:26:23 +00:00
Jonathan Ellis 49211d5e92 change Message body to byte[]. this reveals where there are problems: everything that is using any of the send messages already needs to be doing that or they're broken. the good ones I just unwrap; the broken ones I fixed except for MoveMessage which doesn't even have a byte[] serializer yet, so I left that one broken. writeResponseResolver is the specific case that caused the bug report.
patch by jbellis; reviewed by nk11 for CASSANDRA-120

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771402 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 19:02:23 +00:00
Jonathan Ellis e044410ccd r/m DataImporter; it's not useful outside of FB
patch by jbellis; reviewed by nk11 for CASSANDRA-120

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771401 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 19:02:05 +00:00
Jonathan Ellis bcf4dcc666 refactor HttpConnection to use its own executor instead of abusing MessagingService. This will let us refactor Message body to a byte[].
patch by jbellis; reviewed by nk11 for CASSANDRA-120

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771400 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 19:02:01 +00:00
Jonathan Ellis 3bc3e4c335 add constructor to DTPE for most commonly used values (single thread, no timeout, LinkedBlockingQueue)
patch by jbellis; reviewed by nk11 for CASSANDRA-120

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771399 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 19:01:56 +00:00
Jonathan Ellis 3a4a0595da use getTempFileName / closeRename to avoid problems w/ half-written sstables.
patch by jbellis; reviewed by Eric Evans for CASSANDRA-78

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771340 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 15:59:16 +00:00
Jonathan Ellis f70a5a0c8c clean up anticompaction code a little.
patch by jbellis; reveiewed by Eric Evans for CASSANDRA-78

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771339 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 15:59:12 +00:00
Jonathan Ellis bbe89e795b do not leave variables uninitialized in ConsistencyManager constructor. fixes regression from #95. patch by jbellis for CASSANDRA-124
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771325 13f79535-47bb-0310-9956-ffa450edef68
2009-05-04 14:59:51 +00:00
Jonathan Ellis 93abe8d3e5 make sendMessage only return true after ack by recipient.
patch by Jun Rao; reviewed by jbellis for CASSANDRA-34

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@771019 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 03:26:07 +00:00
Jonathan Ellis e4e5629b13 make out-of-the-box config 1GB-friendly. patch by jbellis; reviewed by Eric Evans for CASSANDRA-118
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@770811 13f79535-47bb-0310-9956-ffa450edef68
2009-05-01 20:14:35 +00:00
Jonathan Ellis 22525a8e12 make CassandraServer constructor public
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@770688 13f79535-47bb-0310-9956-ffa450edef68
2009-05-01 14:13:11 +00:00
Jonathan Ellis 4a5620dea2 avoid raising an exception in SequenceFile.next when a key does not exist (e.g. when bloom filter gives a false positive). patch by Jun Rao; reviewed by jbellis for CASSANDRA-126
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@770517 13f79535-47bb-0310-9956-ffa450edef68
2009-05-01 02:24:10 +00:00
Jonathan Ellis ebcbeb5af9 close FileStructs after range query. patch by jbellis; reviewed by Jun Rao for CASSANDRA-71
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@770424 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 20:01:31 +00:00
Jonathan Ellis ec291721dd add string de/serialize code to TokenFactory for ApplicationState's benefit.
patch by jbellis; tested by nk11 and MarkR42 for CASSANDRA-114

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@770307 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 16:09:38 +00:00
Jonathan Ellis 71739ef76a move src/ to src/java/. patch by johano; reviewed by jbellis for CASSANDRA-112
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@769886 13f79535-47bb-0310-9956-ffa450edef68
2009-04-29 19:18:48 +00:00