natas_hw
/
cassandra
mirror of https://github.com/apache/cassandra
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove buggy concurrentlinkedhashmap library and lru cache. too late in 0.4 to try to debug the library -- will revisit for 0.5. patch by jbellis; reviewed by Chris Goffinet for CASSANDRA-405 

git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@810540 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Jonathan Ellis 2009-09-02 15:04:16 +00:00
parent fe28c47406
commit ab392a6ee7
11 changed files with 13 additions and 274 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.txt
View File

@ -6,7 +6,6 @@
* Scan all sstables for all queries to avoid situations where
different types of operation on the same ColumnFamily could
disagree on what data was present
* Configurable LRU cache for key lookups
* Snapshot support via JMX
* BinaryMemtable support for bulk load via hadoop; see
https://github.com/lenn0x/Cassandra-Hadoop-BMT/tree

11
conf/storage-conf.xml
View File

@ -42,17 +42,6 @@
-->
<Keyspaces>
<Keyspace Name="Keyspace1">
<!--
~ The fraction of keys per sstable whose locations we keep in
~ memory in "mostly LRU" order. (JUST the key locations, NOT any
~ column values.)
~ The amount of memory used by the default setting of 0.01 is
~ comparable to the amount used by the internal per-sstable key
~ index. Consider increasing this if you have fewer, wider rows.
~ Set to 0 to disable entirely.
-->
<KeysCachedFraction>0.01</KeysCachedFraction>
<!--
~ The CompareWith attribute tells Cassandra how to sort the columns
~ for slicing operations. The default is BytesType, which is a

BIN
lib/clhm-20090629.jar
View File

Binary file not shown.

202
lib/licenses/clhm-20090629.jar.LICENSE
View File

@ -1,202 +0,0 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
1. Definitions.
"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.
"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.
"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.
"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.
"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.
"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.
"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).
"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.
"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."
"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.
2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.
3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.
4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:
(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and
(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and
(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and
(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.
You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.
5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.
6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.
7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.
8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.
9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.
END OF TERMS AND CONDITIONS
APPENDIX: How to apply the Apache License to your work.
To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.
Copyright [yyyy] [name of copyright owner]
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

19
src/java/org/apache/cassandra/config/DatabaseDescriptor.java
View File

@ -89,7 +89,6 @@ public class DatabaseDescriptor
private static String d_columnValue_ = "COLUMN_VALUE";
private static String d_columnTimestamp_ = "COLUMN_TIMESTAMP";
private static Map<String, Double> tableKeysCachedFractions_;
/*
* A map from table names to the set of column families for the table and the
* corresponding meta data for that column family.
@ -401,7 +400,6 @@ public class DatabaseDescriptor
CommitLog.setSegmentSize(Integer.parseInt(value) * 1024 * 1024);
tableToCFMetaDataMap_ = new HashMap<String, Map<String, CFMetaData>>();
tableKeysCachedFractions_ = new HashMap<String, Double>();
/* See which replica placement strategy to use */
String replicaPlacementStrategyClassName = xmlUtils.getNodeValue("/Storage/ReplicaPlacementStrategy");
@ -438,17 +436,6 @@ public class DatabaseDescriptor
tables_.add(tName);
tableToCFMetaDataMap_.put(tName, new HashMap<String, CFMetaData>());
String xqlCacheSize = "/Storage/Keyspaces/Keyspace[@Name='" + tName + "']/KeysCachedFraction";
value = xmlUtils.getNodeValue(xqlCacheSize);
if (value == null)
{
tableKeysCachedFractions_.put(tName, 0.01);
}
else
{
tableKeysCachedFractions_.put(tName, Double.valueOf(value));
}
String xqlTable = "/Storage/Keyspaces/Keyspace[@Name='" + tName + "']/";
NodeList columnFamilies = xmlUtils.getRequestedNodeList(xqlTable + "ColumnFamily");
@ -573,7 +560,6 @@ public class DatabaseDescriptor
data.subcolumnComparator = new BytesType();
systemMetadata.put(HintedHandOffManager.HINTS_CF, data);
tableToCFMetaDataMap_.put(Table.SYSTEM_TABLE, systemMetadata);
tableKeysCachedFractions_.put(Table.SYSTEM_TABLE, 0.01);
/* make sure we have a directory for each table */
createTableDirectories();
@ -964,11 +950,6 @@ public class DatabaseDescriptor
return tableToCFMetaDataMap_;
}
public static double getKeysCachedFraction(String tableName)
{
return tableKeysCachedFractions_.get(tableName);
}
private static class ConfigurationException extends Exception
{
public ConfigurationException(String message)

2
src/java/org/apache/cassandra/db/BinaryMemtable.java
View File

@ -175,7 +175,7 @@ public class BinaryMemtable
writer.append(key, bytes);
}
}
cfStore.storeLocation(writer.closeAndOpenReader(DatabaseDescriptor.getKeysCachedFraction(table_)));
cfStore.storeLocation(writer.closeAndOpenReader());
columnFamilies_.clear();
}
}

4
src/java/org/apache/cassandra/db/ColumnFamilyStore.java
View File

@ -1009,7 +1009,7 @@ public final class ColumnFamilyStore implements ColumnFamilyStoreMBean
if (rangeWriter != null)
{
rangeWriter.closeAndOpenReader(DatabaseDescriptor.getKeysCachedFraction(table_));
rangeWriter.closeAndOpenReader();
if (fileList != null)
{
//Retain order. The -Data.db file needs to be last because
@ -1160,7 +1160,7 @@ public final class ColumnFamilyStore implements ColumnFamilyStoreMBean
if (writer != null)
{
// TODO if all the keys were the same nothing will be done here
ssTable = writer.closeAndOpenReader(DatabaseDescriptor.getKeysCachedFraction(table_));
ssTable = writer.closeAndOpenReader();
newfile = writer.getFilename();
}
sstableLock_.writeLock().lock();

2
src/java/org/apache/cassandra/db/Memtable.java
View File

@ -212,7 +212,7 @@ public class Memtable implements Comparable<Memtable>
writer.append(partitioner.decorateKey(key), buffer);
}
}
SSTableReader ssTable = writer.closeAndOpenReader(DatabaseDescriptor.getKeysCachedFraction(table_));
SSTableReader ssTable = writer.closeAndOpenReader();
cfStore.onMemtableFlush(cLogCtx);
cfStore.storeLocation(ssTable);
buffer.close();

32
src/java/org/apache/cassandra/io/SSTableReader.java
View File

@ -31,7 +31,6 @@ import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.db.ColumnFamily;
import org.apache.cassandra.db.marshal.AbstractType;
import org.cliffc.high_scale_lib.NonBlockingHashMap;
import com.reardencommerce.kernel.collections.shared.evictable.ConcurrentLinkedHashMap;
public class SSTableReader extends SSTable
{
@ -83,10 +82,10 @@ public class SSTableReader extends SSTable
public static synchronized SSTableReader open(String dataFileName) throws IOException
{
return open(dataFileName, StorageService.getPartitioner(), DatabaseDescriptor.getKeysCachedFraction(parseTableName(dataFileName)));
return open(dataFileName, StorageService.getPartitioner());
}
public static synchronized SSTableReader open(String dataFileName, IPartitioner partitioner, double cacheFraction) throws IOException
public static synchronized SSTableReader open(String dataFileName, IPartitioner partitioner) throws IOException
{
SSTableReader sstable = openedFiles.get(dataFileName);
if (sstable == null)
@ -97,10 +96,6 @@ public class SSTableReader extends SSTable
long start = System.currentTimeMillis();
sstable.loadIndexFile();
sstable.loadBloomFilter();
if (cacheFraction > 0)
{
sstable.keyCache = createKeyCache((int)((sstable.getIndexPositions().size() + 1) * INDEX_INTERVAL * cacheFraction));
}
if (logger.isDebugEnabled())
logger.debug("INDEX LOAD TIME for " + dataFileName + ": " + (System.currentTimeMillis() - start) + " ms.");
@ -116,20 +111,11 @@ public class SSTableReader extends SSTable
return sstable;
}
public static ConcurrentLinkedHashMap<String, Long> createKeyCache(int size)
{
return ConcurrentLinkedHashMap.create(ConcurrentLinkedHashMap.EvictionPolicy.SECOND_CHANCE, size);
}
private ConcurrentLinkedHashMap<String, Long> keyCache;
SSTableReader(String filename, IPartitioner partitioner, List<KeyPosition> indexPositions, BloomFilter bloomFilter, ConcurrentLinkedHashMap<String, Long> keyCache)
SSTableReader(String filename, IPartitioner partitioner, List<KeyPosition> indexPositions, BloomFilter bloomFilter)
{
super(filename, partitioner);
this.indexPositions = indexPositions;
this.bf = bloomFilter;
this.keyCache = keyCache;
synchronized (SSTableReader.this)
{
openedFiles.put(filename, this);
@ -202,14 +188,6 @@ public class SSTableReader extends SSTable
{
if (!bf.isPresent(decoratedKey))
return -1;
if (keyCache != null)
{
Long cachedPosition = keyCache.get(decoratedKey);
if (cachedPosition != null)
{
return cachedPosition;
}
}
long start = getIndexScanPosition(decoratedKey, partitioner);
if (start < 0)
{
@ -237,8 +215,6 @@ public class SSTableReader extends SSTable
int v = partitioner.getDecoratedKeyComparator().compare(indexDecoratedKey, decoratedKey);
if (v == 0)
{
if (keyCache != null)
keyCache.put(decoratedKey, position);
return position;
}
if (v > 0)
@ -307,7 +283,7 @@ public class SSTableReader extends SSTable
openedFiles.clear();
for (SSTableReader sstable : sstables)
{
SSTableReader.open(sstable.path, sstable.partitioner, 0.01);
SSTableReader.open(sstable.path, sstable.partitioner);
}
}

10
src/java/org/apache/cassandra/io/SSTableWriter.java
View File

@ -34,7 +34,6 @@ import org.apache.cassandra.dht.IPartitioner;
import org.apache.cassandra.service.StorageService;
import org.apache.cassandra.utils.BloomFilter;
import org.apache.cassandra.config.DatabaseDescriptor;
import com.reardencommerce.kernel.collections.shared.evictable.ConcurrentLinkedHashMap;
public class SSTableWriter extends SSTable
{
@ -115,7 +114,7 @@ public class SSTableWriter extends SSTable
/**
* Renames temporary SSTable files to valid data, index, and bloom filter files
*/
public SSTableReader closeAndOpenReader(double cacheFraction) throws IOException
public SSTableReader closeAndOpenReader() throws IOException
{
// bloom filter
FileOutputStream fos = new FileOutputStream(filterFilename());
@ -136,10 +135,7 @@ public class SSTableWriter extends SSTable
rename(filterFilename());
path = rename(path); // important to do this last since index & filter file names are derived from it
ConcurrentLinkedHashMap<String,Long> keyCache = cacheFraction > 0
? SSTableReader.createKeyCache((int) (cacheFraction * keysWritten))
: null;
return new SSTableReader(path, partitioner, indexPositions, bf, keyCache);
return new SSTableReader(path, partitioner, indexPositions, bf);
}
static String rename(String tmpFilename)
@ -154,7 +150,7 @@ public class SSTableWriter extends SSTable
SSTableWriter.rename(indexFilename(dataFileName));
SSTableWriter.rename(filterFilename(dataFileName));
dataFileName = SSTableWriter.rename(dataFileName);
return SSTableReader.open(dataFileName, StorageService.getPartitioner(), DatabaseDescriptor.getKeysCachedFraction(parseTableName(dataFileName)));
return SSTableReader.open(dataFileName, StorageService.getPartitioner());
}
}

4
test/unit/org/apache/cassandra/io/SSTableTest.java
View File

@ -41,7 +41,7 @@ public class SSTableTest extends CleanupHelper
String key = Integer.toString(1);
writer.append(key, bytes);
SSTableReader ssTable = writer.closeAndOpenReader(0.01);
SSTableReader ssTable = writer.closeAndOpenReader();
// verify
verifySingle(ssTable, bytes, key);
@ -81,7 +81,7 @@ public class SSTableTest extends CleanupHelper
{
writer.append(key, map.get(key));
}
SSTableReader ssTable = writer.closeAndOpenReader(0.01);
SSTableReader ssTable = writer.closeAndOpenReader();
// verify
verifyMany(ssTable, map);