From 189f4a9069d4c2524ee2edc9fb771eda16bfad86 Mon Sep 17 00:00:00 2001 From: Trisha Anand Date: Fri, 16 Jul 2021 20:24:18 +0530 Subject: [PATCH] Adding timeout on execution of postgres and ms sql actions (#5922) --- .../src/main/java/com/external/plugins/MssqlPlugin.java | 3 +++ .../src/main/java/com/external/plugins/PostgresPlugin.java | 2 ++ 2 files changed, 5 insertions(+) diff --git a/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java b/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java index cb42fdb2b6..3b1a50cfed 100644 --- a/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java +++ b/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java @@ -15,6 +15,7 @@ import com.appsmith.external.models.DatasourceConfiguration; import com.appsmith.external.models.DatasourceTestResult; import com.appsmith.external.models.Endpoint; import com.appsmith.external.models.Property; +import com.appsmith.external.models.PsParameterDTO; import com.appsmith.external.models.RequestParamDTO; import com.appsmith.external.models.SSLDetails; import com.appsmith.external.plugins.BasePlugin; @@ -44,6 +45,7 @@ import java.sql.Statement; import java.sql.Time; import java.sql.Timestamp; import java.sql.Types; +import java.time.Duration; import java.time.LocalDateTime; import java.time.OffsetDateTime; import java.time.format.DateTimeFormatter; @@ -324,6 +326,7 @@ public class MssqlPlugin extends BasePlugin { result.setRequest(request); return result; }) + .timeout(Duration.ofMillis(actionConfiguration.getTimeoutInMillisecond())) .subscribeOn(scheduler); } diff --git a/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java b/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java index 1c7fb73d1f..0f44c525c0 100644 --- a/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java +++ b/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java @@ -48,6 +48,7 @@ import java.sql.Statement; import java.sql.Time; import java.sql.Timestamp; import java.sql.Types; +import java.time.Duration; import java.time.LocalDateTime; import java.time.OffsetDateTime; import java.time.format.DateTimeFormatter; @@ -411,6 +412,7 @@ public class PostgresPlugin extends BasePlugin { result.setRequest(request); return result; }) + .timeout(Duration.ofMillis(actionConfiguration.getTimeoutInMillisecond())) .subscribeOn(scheduler); }