yankf21
/
mindspore2022
forked from huawei/mindspore2022
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

support single direction exchange for conv2d

This commit is contained in:
yangzhenzhang 2022-01-12 15:57:28 +08:00
parent 216567f77a
commit a9d2e255f5
3 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mindspore/OWNERS
View File

@ -8,3 +8,4 @@ approvers:
- liangchenghui
- wuxuejian
- gaoxiong1
- yangzhenzhang

6
mindspore/ccsrc/frontend/parallel/ops_info/conv2d_info.cc
View File

@ -172,12 +172,6 @@ Status Conv2DInfo::CheckHWStrategySameModeByDimension(int64_t strategy, const st
<< " when kernel_size > stride but slice shape is smaller than or equal to (k - s + 1) / 2";
return FAILED;
}
if (h_or_w_kernel_size - h_or_w_stride == 1) {
MS_LOG(ERROR) << name_ << ": The 'same' mode do not support to split " << dimension
<< " when kernel_size > stride but k - s == 1";
return FAILED;
}
}
return SUCCESS;
}

16
tests/ut/python/parallel/test_conv2d.py
View File

@ -207,16 +207,15 @@ def test_conv2d_model_parallel4():
def test_conv2d_left_and_right_no_need_to_send():
"""
Feature: same mode, k - s = 1, left pad is 0
Description: do not support that the left no need to send
Expectation: compile failed
Feature: same mode, k - s = 1, left pad is 0, single direction exchange
Description: support that the left no need to send
Expectation: compile success
"""
context.set_auto_parallel_context(parallel_mode="semi_auto_parallel", device_num=8, global_rank=0)
strategy1 = ((2, 1, 1, 4), (1, 1, 1, 1))
strategy2 = ((2, 1, 1, 4),)
net = Net(_w2, out_channel=8, kernel_size=3, pad_mode="same", stride=2, strategy1=strategy1, strategy2=strategy2)
with pytest.raises(RuntimeError):
compile_net(net)
compile_net(net)
def test_conv2d_kernel_size_larger_than_stride_and_split_h():
@ -402,16 +401,15 @@ def test_conv2d_same_mode_overlap_size_equal_to_slice_shape():
def test_kernel_size_larger_than_stride_and_left_pad_is_0():
"""
Feature: same mode, kernel_size > stride and left pad is 0
Feature: same mode, kernel_size > stride and left pad is 0, single direction exchange
Description: split w
Expectation: compile failed
Expectation: compile success
"""
context.set_auto_parallel_context(parallel_mode="semi_auto_parallel", device_num=8, global_rank=0)
strategy1 = ((1, 1, 1, 4), (1, 1, 1, 1))
strategy2 = ((1, 1, 1, 8),)
net = Net(_w1, out_channel=8, kernel_size=2, pad_mode="same", stride=1, strategy1=strategy1, strategy2=strategy2)
with pytest.raises(RuntimeError):
compile_net(net)
compile_net(net)
def test_conv2d_kernel_size_larger_than_stride_and_split_nchw():