ff1cb58174
Convert hyphens to underscores for all prefix-based arguments (e.g. --knob-, --locality-)
2021-12-14 12:01:44 -08:00
f24adc7b6a
Fix a bunch of places where we used old-style arguments. Allow hyphens for profiler args.
2021-12-14 09:59:14 -08:00
f29f487823
Unify flags ( #25 )
...
* Unify flags implementation and change help text in backup.actor.cpp
Description
Testing
* Keep LOG_GROUP unchanged
Description
Testing
* Transfer the hyphens to underscores for internal options and user's input, EXCEPT leading hyphens
Description
Testing
* Use a deep copy of the user's input flag to do the match
Description
Testing
* Convert the _ to - in Option arrays of backup.actor.cpp
Description
Testing
* Transter _ to - for files:
TLSConfig.actor.h, fdbcli.actor.cpp, fdbserver.actor.cpp, FileConverter.h, FileConverter.cpp
Description
Testing
* Change another way to unify flag: using SO_O_ICASE_HYPHEN_AND_UNDERSCORE to determine whether we do the conversion in function IsEqual
Description
Testing
* Change the config command's name from SO_O_ICASE_HYPHEN_AND_UNDERSCORE to SO_O_HYPHEN_TO_UNDERSCORE
Description
Testing
* Update the comment for the SO_O_HYPHEN_TO_UNDERSCORE
Description
Testing
* Fix left underscore in SOption arrays
Description
Testing
* Convert _ to - in several files for commands
Description
Testing
* Make the FDBService and fdbmonitor backward compatible
Description
Testing
* Fix bugs about pointers
Description
Testing
* Check underscore and hyphen at the same time for --knob_, --localily_ and --test_
And fix bugs in fdbmonitor and FDBService
Description
Testing
* Simplify the function in fdbmonitor and FDBService about retrieving arguments.
And fix some documents in masterserver.actor.cpp
Description
Testing
* Convert _ to - for knob in the setKnob functions
Description
Testing
* Convert - to _ in the setKnob functions
Description
Since key in the knob related maps only contain _
Testing
* Rename varialbe name in the fdbmonitor and FDBService for clarification
Description
Testing
Co-authored-by: Chang Liu <chang.liu@snowflake.com>
2021-12-14 08:44:39 -08:00
5b079acd66
Coordinator should reply clientInfo when it changes.
...
This bug is introduced in #5231 .
2021-12-10 16:37:48 -08:00
6978486e85
Coordinator should only reply client data if it's valid.
...
Because when a coordinator restarts or newly joins a cluster, a client trying to connect to it may already have client data, while the coordinator doesn't. In this case, the coordinator should not reply empty client data.
2021-12-10 16:37:48 -08:00
f6ea67120e
Adding explicit empty version back to change feeds for now
2021-12-10 10:04:05 -06:00
d23b8645f8
Enabling rocksdb metrics logger in simulation.
2021-12-07 15:18:29 -08:00
20ee921986
Merge pull request #5923 from sfc-gh-sgwydir/minicycletest
...
Add MiniCycle Test
2021-12-07 11:30:16 -08:00
31c0eef69c
Add Minicycle Workload
2021-12-06 15:46:40 -08:00
fd2b27d7c4
Merge pull request #6103 from sfc-gh-ajbeamon/fix-dd-merge-too-soon
...
Fix: Merge too soon bug
2021-12-06 15:01:47 -08:00
def41697bf
Merge pull request #6083 from sfc-gh-tclinkenbeard/remove-temporaries
...
Avoid creating unnecessary temporary objects
2021-12-06 13:24:56 -08:00
dc88d3fa37
use CC_ENABLE_WORKER_HEALTH_MONITOR knob to guard remoteDCIsHealthy logic
2021-12-06 09:33:45 -08:00
ce2d1e1648
Fix: the shard tracker state could become inaccurate if there is an ABA type update to the bandwith state of a shard.
2021-12-03 18:42:55 -08:00
6e9b1f18fe
Merge pull request #6095 from sfc-gh-ngoyal/fix-exclude-unreliable-from-protected
...
Don't include an unreliable process in the protected list.
2021-12-03 14:49:59 -08:00
9b0a9c4503
Return error when getRangeAndFlatMap has more & Improve simulation tests ( #6029 )
2021-12-03 12:50:07 -08:00
2725183b26
Don't include an unreliable process in the protected list.
2021-12-03 09:44:52 -08:00
b11ae4dae8
Merge pull request #5910 from sfc-gh-jslocum/bg_bindings
...
Blob Granule C bindings
2021-12-02 11:40:26 -08:00
464d9488ef
Merge remote-tracking branch 'origin/master' into fix-unused-warnings
2021-12-01 23:52:09 -08:00
6b45ef98ca
Merge remote-tracking branch 'origin/master' into remove-temporaries
2021-12-01 23:50:29 -08:00
d01a363e29
Avoid creating unnecessary temporary objects
2021-12-01 23:48:34 -08:00
90ced244eb
Fix -Wunused-but-set-variable warnings
2021-12-01 18:15:53 -08:00
3b5d23ef88
Remove unnecessary temporary objects when appending to vector of pairs
2021-12-01 18:15:16 -08:00
a82845af43
Merge branch 'master' into bg_bindings
2021-12-01 16:55:28 -06:00
404bef2f03
Merge pull request #6076 from sfc-gh-ajbeamon/fix-cstate-registration-race
...
Fix a race condition with updating the coordinated state and updating the master registration
2021-12-01 12:56:12 -08:00
ec64890ac1
Remove some usages of PRId64 by using fmt library
2021-11-30 23:35:36 -08:00
72c5fb183d
Fix: avoid updating the master registration while the cstate is written but we are not accepting commits.
2021-11-30 15:44:04 -08:00
43b3e05fd5
Merge branch 'master' of github.com:apple/foundationdb into delay-prioritized-eviction
...
# Conflicts:
# fdbserver/VersionedBTree.actor.cpp
2021-11-29 16:14:43 -08:00
ef248f3dbd
Merge pull request #6060 from sfc-gh-satherton/remove-try-evict
...
Remove unused / unwanted code in Redwood.
2021-11-29 13:26:05 -08:00
b6fd402a3c
Add option to use boost or libcoro
...
By default, use boost everywhere except windows and linux x86 (for
performance reasons)
2021-11-29 13:14:15 -08:00
1870e07ff4
Fixed pause racing with waitUntilHealthy
2021-11-29 14:19:15 -06:00
8216ad1e4e
When a cached page is hit, if it is in the prioritized eviction order don't move it to the normal order.
2021-11-28 21:04:35 -08:00
bed25f9571
Delay prioritized eviction of updated pages until after commit completes.
2021-11-28 21:03:44 -08:00
0f5535fce1
Remove explicit tryEvict(x) as it is unused and it is functionally replaced by prioritizeEviction(x).
2021-11-27 03:26:34 -08:00
e3819dad7c
fix: If a removed tlog never attempted a queue commit, the update storage loop could get stuck waiting for queueCommittingVersion to advance
2021-11-25 09:55:01 -08:00
80014d3247
Merge branch 'master' of https://github.com/apple/foundationdb into fix-best-team
...
# Conflicts:
# fdbclient/ServerKnobs.cpp
2021-11-24 11:56:23 -08:00
1afef44f19
fix: self->shardsAffectedByTeamFailure->moveShard must be called without any waits after getting the destination team or we could miss failure notifications for the storage servers in the destination team
2021-11-23 15:26:38 -08:00
37c9a1320c
added --print_sim_time to print simulated time to stdout
2021-11-23 15:01:44 -08:00
b0aad44831
change feed requests with an explicit end need to get empty versions at the end boundary
2021-11-23 15:01:44 -08:00
3360000a91
fix: an empty mutation vector did not mean that all of the data was returned
2021-11-23 15:01:44 -08:00
e97d337ffe
fix: when a feed transitions from atLatest to not atLatest stall all updates at the blocked version
2021-11-23 15:01:44 -08:00
10a925b7e9
do not return mutations larger than the dequeVersion
2021-11-23 15:01:44 -08:00
e19277160e
improved the change feed workload to test whenAtLeast
2021-11-23 15:01:44 -08:00
f3bb1d8f51
properly handle an active change feed stream when removed
2021-11-23 15:01:44 -08:00
12e68da635
Merge pull request #6036 from sfc-gh-satherton/redwood-debug-sim-fixes
...
Test-only bug fixes in Redwood along with debug logging detail improvements.
2021-11-22 11:13:28 -08:00
e43ddb09ac
Merge pull request #6034 from sfc-gh-satherton/remap-window-fix
...
Bug fix: incorrect remap cleanup window size in KeyValueStoreRedwood
2021-11-22 09:12:59 -08:00
d2149631d5
Bug fix, the remap cleanup window was being initialized incorrectly in the Redwood KVS wrapper.
2021-11-19 21:40:09 -08:00
3901d60548
Test-only bug fixes in Redwood along with debug logging detail improvements. Added clearRemapQueue() to Pager to more cleanly and reliably expire all old data and process the remap queue, fixing a bug where with certain configuration parameters and a lot of data the DestructiveSanityCheck would fail because it would not run cleanup long enough. Added more parameters to performance/set unit test.
2021-11-19 01:00:14 -08:00
c745002607
Merge remote-tracking branch 'origin/master' into add-format-warning
2021-11-18 11:13:03 -08:00
5879d611f5
Merge pull request #5899 from sfc-gh-jfu/jfu-fix-ss-segfault
...
Fix rare segfault that can occur when SS terminates while an actor that uses the StorageServer is still on the stack
2021-11-18 09:57:11 -08:00
2613ec7561
Expand use of fmt to get rid of %ld usage
2021-11-17 17:03:32 -08:00
A.J. Beamon