Commit Graph

4239 Commits

Author SHA1 Message Date
A.J. Beamon 496000477c
Merge pull request #6144 from sfc-gh-ajbeamon/unify-flags
Convert command line arguments to use hyphens rather than underscores
2021-12-15 10:47:32 -08:00
Renxuan Wang 2227fc2943 Fix a bug in getDesiredCoordinators().
When no workers are chosen, we should return 0 coordinators.
2021-12-15 10:42:28 -08:00
A.J. Beamon f24adc7b6a Fix a bunch of places where we used old-style arguments. Allow hyphens for profiler args. 2021-12-14 09:59:14 -08:00
Josh Slocum 3afe9fb6e0 MVC bug fixes 2021-12-10 12:47:53 -06:00
Josh Slocum b7b2ad0a6f Handling timeout and transaction changes for ThreadResults properly 2021-12-10 12:47:53 -06:00
Josh Slocum c24826430f Removing this check as it still won't work if the knob is set 2021-12-08 18:13:41 -06:00
Renxuan Wang 9f70e84a7b Remove trimFromHostname(). 2021-12-07 15:39:51 -08:00
Andrew Noyes def41697bf
Merge pull request #6083 from sfc-gh-tclinkenbeard/remove-temporaries
Avoid creating unnecessary temporary objects
2021-12-06 13:24:56 -08:00
Evan Tschannen 6e9b1f18fe
Merge pull request #6095 from sfc-gh-ngoyal/fix-exclude-unreliable-from-protected
Don't include an unreliable process in the protected list.
2021-12-03 14:49:59 -08:00
Tao Lin 9b0a9c4503
Return error when getRangeAndFlatMap has more & Improve simulation tests (#6029) 2021-12-03 12:50:07 -08:00
negoyal 037b30fbde Clang format. 2021-12-03 10:01:49 -08:00
negoyal 2725183b26 Don't include an unreliable process in the protected list. 2021-12-03 09:44:52 -08:00
Evan Tschannen b11ae4dae8
Merge pull request #5910 from sfc-gh-jslocum/bg_bindings
Blob Granule C bindings
2021-12-02 11:40:26 -08:00
Josh Slocum 24772e0f22 Merge branch 'master' into bg_bindings 2021-12-02 09:38:33 -06:00
sfc-gh-tclinkenbeard 464d9488ef Merge remote-tracking branch 'origin/master' into fix-unused-warnings 2021-12-01 23:52:09 -08:00
sfc-gh-tclinkenbeard 6b45ef98ca Merge remote-tracking branch 'origin/master' into remove-temporaries 2021-12-01 23:50:29 -08:00
sfc-gh-tclinkenbeard d01a363e29 Avoid creating unnecessary temporary objects 2021-12-01 23:48:34 -08:00
FoundationDB CI ca5d5ac942
apply formatting with clang 13
Signed-off-by: FoundationDB CI <foundationdb_ci@apple.com>
2021-12-02 05:13:59 +00:00
sfc-gh-tclinkenbeard 90ced244eb Fix -Wunused-but-set-variable warnings 2021-12-01 18:15:53 -08:00
sfc-gh-tclinkenbeard 3b5d23ef88 Remove unnecessary temporary objects when appending to vector of pairs 2021-12-01 18:15:16 -08:00
Josh Slocum 9cb6fb5114 fixing unrelated code formatting 2021-12-01 17:20:11 -06:00
Josh Slocum 2c63d0ae03 cleaning up prints 2021-12-01 17:17:19 -06:00
Josh Slocum c11b8a3625 Improved comments 2021-12-01 17:04:55 -06:00
Josh Slocum a82845af43 Merge branch 'master' into bg_bindings 2021-12-01 16:55:28 -06:00
Josh Slocum 73aa5017fe forgot to remove comment 2021-12-01 16:25:51 -06:00
Josh Slocum 7f4fcc8c2c Added FDBResult and made readBlobGranules use it 2021-12-01 16:22:05 -06:00
sfc-gh-tclinkenbeard ec64890ac1 Remove some usages of PRId64 by using fmt library 2021-11-30 23:35:36 -08:00
Steve Atherton 8a71ab1d5f
Merge pull request #6061 from sfc-gh-satherton/delay-prioritized-eviction
Delay prioritized eviction of updated pages in Redwood until after commit completes
2021-11-29 17:27:20 -08:00
Steve Atherton 43b3e05fd5 Merge branch 'master' of github.com:apple/foundationdb into delay-prioritized-eviction
# Conflicts:
#	fdbserver/VersionedBTree.actor.cpp
2021-11-29 16:14:43 -08:00
A.J. Beamon ba8d8a3253
Merge pull request #6068 from sfc-gh-ajbeamon/improved-client-db-logging
Fix: Check whether connRecord is null before logging it
2021-11-29 16:14:32 -08:00
A.J. Beamon 13a4743e76 Check whether connRecord is null before logging it. 2021-11-29 14:22:44 -08:00
Andrew Noyes bccda9f6fe Don't provide default for requireFunction in loadClientFunction
Recently there was an issue where we added a new symbol to the c api and
we did not include the right header version guard to see if it was
required. Let's make this not a default so that we force callers to
think about what the right header versions to require it are.
2021-11-29 14:08:28 -08:00
A.J. Beamon b8bd89f88d Shorten the name of external client threads. Add a thread name for trace logging threads. 2021-11-29 09:57:10 -08:00
A.J. Beamon 264c75b9a6 Add some extra client logging details:
1. Add a trace event when a database is created and move the cluster file / connection string from ClientStart to the new trace event
2. Add a detail for the path to the image being loaded
3. Add a detail for whether a client library is primary or not
4. Set a thread name for each external client thread that includes the release version
2021-11-29 09:57:10 -08:00
Steve Atherton bed25f9571 Delay prioritized eviction of updated pages until after commit completes. 2021-11-28 21:03:44 -08:00
sfc-gh-ngoyal f8538d0bc3
Merge pull request #5897 from sfc-gh-ahusain/ahusain-fixCommitProxyCount
Use DEFAULT_COMMIT_GRV_PROXIES_RATIO to override proxies_count if mutation supplied value is -1
2021-11-24 15:25:01 -08:00
Ata E Husain Bohra 0962fcb243 Override commit/grv proxies_count if mutation supplied new value is -1
Patch improves on handling scenarios where either commit or grv proxies
value is update to -1 OR `proxies_count` is being reset.
The code splits the proxies between two proxies by ensuring for invalid
input configuration, the min (read as 1) proxies gets provisioned, otherwise,
the split is done based on input values

Patch handles the scenario where mutation supplied values to update grv_proxies
and/or commit_proxies is -1, however, the total proxy count > 1,
uses DEFAULT_COMMIT_GRV_PROXIES_RATIO to split proxies between
grv_proxies & commit_proxies.
2021-11-24 12:52:31 -08:00
Evan Tschannen 80014d3247 Merge branch 'master' of https://github.com/apple/foundationdb into fix-best-team
# Conflicts:
#	fdbclient/ServerKnobs.cpp
2021-11-24 11:56:23 -08:00
Evan Tschannen 8fa7085c78 added a comment 2021-11-24 11:40:41 -08:00
Evan Tschannen c9ee83e1b1 fix: do not buggify PEEK_TRACKER_EXPIRATION_TIME to a value of 20 2021-11-24 11:28:57 -08:00
Evan Tschannen e3422b2443 fix: change feed streams were not being closed properly 2021-11-23 15:01:44 -08:00
Evan Tschannen 3360000a91 fix: an empty mutation vector did not mean that all of the data was returned 2021-11-23 15:01:44 -08:00
Evan Tschannen 9df287ea06 fixed empty version merge logic 2021-11-23 15:01:44 -08:00
Evan Tschannen 6d9f134bf0 fix: merge needs to update on empty versions to release other mutations blocked by the empty version 2021-11-23 15:01:44 -08:00
Evan Tschannen 014fb2f31c fix: onEmpty must check all merged streams 2021-11-23 15:01:44 -08:00
Evan Tschannen a0afe530f8 protect against the changeFeedStorageData getting destroyed 2021-11-23 15:01:44 -08:00
Evan Tschannen d9a6feea72 fix: properly initialize notAtLeast 2021-11-23 15:01:44 -08:00
Evan Tschannen 547c5899f8 whenAtLeast could return an incorrect result when the connection closed 2021-11-23 15:01:44 -08:00
Evan Tschannen 31b2414706 fixed a crash while popping change feeds 2021-11-23 15:01:44 -08:00
Evan Tschannen 11d5cae515 do not buggify peek cursor expire time too low because it could cause the log routers to fail to make progress 2021-11-23 15:00:34 -08:00