Commit Graph

58 Commits

Author SHA1 Message Date
Nim Wijetunga 6f37f55917
Restore System Keys First in Backup/Restore Workloads (#8475)
* system key restore ordering

* restore system keys before regular data

* atomic restore backup fix

* change testing

* fix compile error

* fix compile issue

* fix compile issues

* Trigger Build

* only split restore if encryption is enabled

* revert knob changes

* Update fdbserver/workloads/AtomicSwitchover.actor.cpp

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>

* Update fdbserver/workloads/AtomicSwitchover.actor.cpp

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>

* Update fdbserver/workloads/BackupCorrectness.actor.cpp

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>

* Update fdbserver/workloads/AtomicRestore.actor.cpp

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>

* add todo

* strengthen check

* seperate system restore for atomic restore

* address pr comments

* address pr comments

Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2022-10-26 09:38:27 -07:00
Markus Pilman fb1390ef3d reformat code 2022-10-14 08:47:56 -06:00
Markus Pilman 49f0cf5ab0 Force name and description of workloads to be the same 2022-10-13 20:53:48 -06:00
Nim Wijetunga 8ca6397e97
Enable Backup Tests for Encrypted Snapshots (#8419)
* enable encrypted snapshot backup tests

* address pr comments

* remove tenant cache when decoding

* remove client knob
2022-10-12 10:45:30 -07:00
Nim Wijetunga 232e23c87e
Snapshot Backup Encryption (#8095)
* inital commit

* add encryption support

* refactor passing encryption keys

* disable encryption codepath

* pass enable encryption cli arg for fdbbackup

* change encryption key passing

* only enable encryption for backup if tenant mode is required

* revert server knobs

* ignore json trace files

* --amend

* integrate ekp

* add comments

* comments

* comments

* revert knobs

* fix bug

* modify encrypted backup logic

* use common prefix

* check boundaries between begin and end key

* return system encrypt domain

* modify

* add tenant entry cache to backup

* slight revert

* format

* Trigger Build

* format

* use tenant name to fetch keys

* Trigger Build

* Trigger Build

* merge

* fix getting ekp

* fix bug

* address pr comments

* Trigger Build

* Trigger Build

* remove faulty check
2022-09-29 14:45:47 -07:00
A.J. Beamon fda0d7223d Update backup to include system key ranges needed for tenants. Run simulated backup tests with tenants. 2022-09-22 10:00:13 -07:00
A.J. Beamon 4fd64630e8 Convert literal string ref instances to use _sr suffix 2022-09-19 11:35:58 -07:00
Renxuan Wang 0a332ee1c1 Add proxy option to backup and restore params. 2022-03-28 17:10:49 -07:00
sfc-gh-tclinkenbeard a71099471b Update copyright header dates 2022-03-21 13:36:23 -07:00
Xiaoge Su abf73047ca Enforce std:: specifier rather than using namespace 2021-09-16 19:40:28 -07:00
Steve Atherton 507c1f11e3 Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use. 2021-07-26 19:55:10 -07:00
Steve Atherton f596a81073 Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs. 2021-07-17 00:11:40 -07:00
sfc-gh-tclinkenbeard 8370d92c20 Expand use of BOOLEAN_PARAM in backup code 2021-07-04 18:30:55 -07:00
sfc-gh-tclinkenbeard cadfdc551e Use BOOLEAN_PARAM for backup agents 2021-07-04 16:27:26 -07:00
RenxuanW 69d7951cfa Clang format. 2021-04-22 14:21:30 -07:00
RenxuanW b0f6cb57b8 Update simulation. 2021-04-22 14:19:16 -07:00
RenxuanW ebf37594f7 Change initialSnapshotIntervalSeconds from knob to a backup argument. 2021-04-13 19:22:13 -07:00
FDB Formatster df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
Jon Fu b90ad11483 add some more trace and comments 2020-11-05 14:23:08 -05:00
Jon Fu ac0e4c1705 unpause backup as soon as possible when waiting for version 2020-11-04 15:13:02 -05:00
Jon Fu bda72d9a3d first draft at changing snapshot backup behaviour 2020-11-02 17:12:30 -05:00
Jon Fu 602335ed97 remove buggify off + reorder container listing + temp mute failing workload 2020-10-21 17:10:41 -04:00
Jon Fu d82dccd2ad revert systemkey clear in recovery tx and backupagent on restart, moved to workload specifically 2020-10-20 17:26:16 -04:00
Jon Fu 7d8f0dfc9e Merge branch 'master' of https://github.com/apple/foundationdb into jfu-fix-snapshot-backup-agent 2020-10-15 12:44:41 -04:00
Andrew Noyes b2d9b93243
Merge pull request #3847 from sfc-gh-tclinkenbeard/refactor-workloads
Modernize TestWorkload overrides
2020-10-14 15:07:03 -07:00
Jon Fu 700f76eff2 Merge branch 'master' of https://github.com/apple/foundationdb into jfu-fix-snapshot-backup-agent 2020-10-14 17:37:31 -04:00
Jon Fu 28686b14f7 default retries to infinite 2020-10-14 17:35:30 -04:00
Jon Fu 2857a3df9d add retry limit to version gate 2020-10-14 14:31:51 -04:00
sfc-gh-tclinkenbeard c7694e7b50 Merge remote-tracking branch 'origin/master' into refactor-workloads 2020-10-14 09:21:47 -07:00
sfc-gh-tclinkenbeard 7ef8ceffcc Merge remote-tracking branch 'origin/master' into add-incremental-backup-retry 2020-10-14 09:02:34 -07:00
Jon Fu e096297bc1 add traces 2020-10-13 16:07:09 -04:00
Jon Fu bd9ff04af2 Merge branch 'master' of https://github.com/apple/foundationdb into jfu-fix-snapshot-backup-agent 2020-10-13 13:14:09 -04:00
Jon Fu 48b9846a6a adjust test spec and manual g_simulator setting 2020-10-12 17:12:20 -04:00
Jon Fu 4f7f16068a Merge branch 'master' of https://github.com/apple/foundationdb into jfu-fix-snapshot-backup-agent 2020-10-12 17:10:28 -04:00
Jon Fu 53d7d8ba63 add try-catch block that ignores backup_unneeded 2020-10-12 15:31:22 -04:00
Jon Fu 40281372e5 remove g_simulator manual setting 2020-10-12 13:09:14 -04:00
Jon Fu a94821e5e3 first attempt at fixing issue with workload 2020-10-10 02:18:18 -04:00
Jon Fu be1ca196ee turn off consistency check until after restore (where we remove the backup agent) 2020-10-09 13:30:01 -04:00
sfc-gh-tclinkenbeard eefaa30fa4 Added retry loop for getReadVersion in IncrementalBackupWorkload 2020-10-09 07:43:21 -07:00
Jon Fu 0b09833f21 add wait statement 2020-10-09 01:57:44 -04:00
Jon Fu e696c4a8eb remove redundant line 2020-10-07 15:23:17 -04:00
Jon Fu 31efdf1cc2 change race condition check logic for incremental backup container 2020-10-07 14:53:16 -04:00
Jon Fu 7e6c0c9d94 explicitly throw error when snapshot has failed rather than hitting hard-to-trace assertion 2020-10-06 14:31:41 -04:00
sfc-gh-tclinkenbeard 7f0d14c8e4 Modernize/refactor workloads directory 2020-10-04 22:29:07 -07:00
Jon Fu 44cd3b0999 add stopBackup to incrementalBackup workload 2020-09-30 14:24:52 -04:00
Jon Fu 57a80cfef2 added new SimpleAtomicAdd workload and adjusted SnapIncrementalRestore restarting test 2020-09-28 16:19:48 -04:00
Jon Fu a78da8b3ce Merge branch 'master' of https://github.com/apple/foundationdb into jfu-snapshot-record-version 2020-09-24 14:40:01 -04:00
Jon Fu ebad1cd9e6 change waitBackup result from int to EBackupState 2020-09-24 12:31:21 -04:00
Jon Fu 7553daba20 change waitVersion to waitForBackup 2020-09-23 16:13:30 -04:00
Jon Fu 285e2594ef adjusted delay and timing of version gate 2020-09-23 14:28:47 -04:00