Commit Graph

632 Commits

Author SHA1 Message Date
Trevor Clinkenbeard 0db28f6ea0
Merge pull request #4535 from jzhou77/fix-dd
Fix DD Assertion failed in canBeSet
2021-03-24 10:50:04 -07:00
Jingyu Zhou 0c3bc09524 Remove the shuttingDown flag 2021-03-21 20:12:37 -07:00
Jingyu Zhou cb26576b95 Fix DD assertion failure
This fixes #4493, where DDTeamCollection::~DDTeamCollection creates new teams
that hold pointer to the DDTeamCollection, thus later causes assertion failure
because the memory is invalid.

The fix is to cancel teamBuilder at the begining of the ~DDTeamCollection.
2021-03-21 19:54:44 -07:00
Evan Tschannen d2f9bf7eb6 added comments and fixed style 2021-03-16 15:44:49 -07:00
Evan Tschannen edefcff3ac do not kill the data distributor after removing a failed server, completely remove the failed server 2021-03-15 16:48:08 -07:00
Evan Tschannen c0a1362478 fixed a bug where DD was shutdown while still in a callback from trackExcludedServers 2021-03-15 16:26:57 -07:00
Evan Tschannen c570a7b718 added trace events 2021-03-15 15:55:02 -07:00
Evan Tschannen 403d933329 fixed trace event 2021-03-15 10:51:53 -07:00
Evan Tschannen 831224df99 fixed complier error 2021-03-15 10:48:48 -07:00
Evan Tschannen 4e4149b070 exclude failed shuts down data distribution while the server is being removed to avoid two processes making changes to the key servers at the same time 2021-03-15 10:43:06 -07:00
FDB Formatster df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
Vishesh Yadav 2bb4f2e59f Merge branch 'release-6.3-pre-format' into master-format
This merges release-6.3 branch right before it was fully formatted.
There were quite a few conflicts that are resolved here. CoroFlow had
a check for OOM errors introduced in 6.3, but didn't seem applicable in
the new implmentation which seems to use boost.
2021-03-10 09:37:41 -08:00
Chaoguang Lin 9645f489e6 Fix base trace event name inconsistency 2021-03-08 15:20:50 -08:00
Zhe Wu 59181245c1 Change SSVersionDiffLarge event log level to warning 2021-03-03 23:33:48 -08:00
Andrew Noyes 79cec09255 Apply clang-tidy's performance-inefficient-vector-operation fix
I ran this command in my build directory after compiling with
OPEN_FOR_IDE. It took a few small tweaks to get it to compile, which is
outside the scope of this commit.

    $ python run-clang-tidy.py -j $(nproc) -checks='-*,performance-inefficient-vector-operation' -fix
2021-03-04 03:58:25 +00:00
Evan Tschannen 346a4e3ecd Merge branch 'release-6.3'
# Conflicts:
#	fdbcli/fdbcli.actor.cpp
#	fdbrpc/LoadBalance.actor.h
#	fdbrpc/MultiInterface.h
#	fdbserver/ClusterController.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/masterserver.actor.cpp
2021-03-01 18:52:06 -08:00
sfc-gh-tclinkenbeard 32486a2785 Reenable tlog pops in ddSnapCreateCore even if some disable requests fail
If some tlogs successfully disable pops but others fail to, we do not
want to wait TLOG_IGNORE_POP_AUTO_ENABLE_DELAY seconds before reenabling
pops
2021-02-20 18:24:21 -08:00
Russell Sears 8025cc4571 Merge remote-tracking branch 'upstream/release-6.3' into merge-6.3-to-master-1-26-21 2021-01-26 19:46:47 +00:00
Andrew Noyes 0ef44739ea Fix OPEN_FOR_IDE build in preparation for using clang-tidy 2021-01-26 02:04:11 +00:00
Xin Dong 0cde3cc48f Make trace event happy 2021-01-25 14:04:16 -08:00
Xin Dong dce8af5b63 Change back to SevWarnAlways for now. 2021-01-25 13:54:24 -08:00
sfc-gh-tclinkenbeard bdf58d0b2f Add assertion to DDTeamCollection::overlappingMembers 2021-01-21 14:39:39 -08:00
sfc-gh-tclinkenbeard ad99bf0471 Merge remote-tracking branch 'origin' into misc-changes 2021-01-21 10:03:07 -08:00
Xin Dong 83506cda87 Log SevError instead of SevWarnAlways when all replicas of some data are lost. 2021-01-15 15:00:48 -08:00
Andrew Noyes ff7d306b09 Merge branch 'release-6.3' into anoyes/merge-6.3-to-master
Include conflict markers for now. Will resolve.
2021-01-15 18:04:09 +00:00
sfc-gh-tclinkenbeard 5b2e88b187 Use structured bindings in for loops 2020-12-27 01:46:20 -04:00
sfc-gh-tclinkenbeard 0d4e81e6b4 Use unique_ptr in DataDistribution.actor.cpp 2020-12-26 23:40:54 -04:00
sfc-gh-tclinkenbeard 19816ccdbf Improve DataDistribution const-correctness 2020-12-26 20:22:27 -04:00
sfc-gh-tclinkenbeard 26a4884eef Mark TCMachineTeamInfo::size const 2020-12-26 19:23:01 -04:00
Jingyu Zhou bbb56e4089 Merge branch 'release-6.2' of https://github.com/apple/foundationdb into release-6.3 2020-12-23 14:26:59 -08:00
Andrew Noyes 877997632d Merge branch 'release-6.3' into anoyes/merge-release-6.3-master
Include conflict markers for review purposes
2020-12-04 01:38:07 +00:00
Xin Dong 78503db523 Reset and retry transaction errors 2020-12-03 14:42:30 -08:00
Xin Dong ac02329d7d Added a command in fdbcli to allow user to manually trigger the detailed teams info loggings in data distributor 2020-12-03 14:42:30 -08:00
Andrew Noyes b8a9807336 Move trackerCancelled higher in catch block 2020-11-24 20:34:06 +00:00
Andrew Noyes dc2bac5670 Resolve conflicts 2020-11-24 19:09:42 +00:00
Andrew Noyes 1f541f02be Merge branch 'anoyes/merge-6.2-to-6.3' into anoyes/release-6.3-merge
Merge, leaving conflict markers for now
2020-11-24 16:55:34 +00:00
David Youngworth fc9b78737f Fix some merge bugs 2020-11-17 14:53:02 -08:00
David Youngworth d64cf8b9e3 Merge branch 6.3 into master 2020-11-17 11:22:45 -08:00
David Youngworth 489ba20641 Fix several merge issues 2020-11-16 14:46:36 -08:00
David Youngworth d0391db862 Merge branch 'release-6.2' into release-6.3 2020-11-16 10:15:23 -08:00
sfc-gh-tclinkenbeard ca8ea3b6ff Fix memory issues caused by cancelling data distribution tracker 2020-11-15 23:52:36 -08:00
Markus Pilman 1343f40117 don't allow empty coments 2020-11-11 14:07:54 -07:00
Markus Pilman bdd3dbfa7d remove duplicates 2020-11-10 14:01:07 -07:00
sfc-gh-tclinkenbeard 4669f837fa Add uses of makeReference 2020-11-07 22:10:18 -08:00
Jon Fu 3ae611d668 Merge branch 'master' of https://github.com/apple/foundationdb into jfu-pause-backup-snapshot 2020-11-04 14:26:49 -05:00
Jon Fu bda72d9a3d first draft at changing snapshot backup behaviour 2020-11-02 17:12:30 -05:00
sfc-gh-tclinkenbeard cf4c8e375f Merge remote-tracking branch 'origin/release-6.3' into merge 2020-10-29 22:15:41 -07:00
Steve Atherton 99c1880a83 Merge commit 'f9581de2005e6b085776e81b9fcaa16442b32589' into merge-6.2-to-6.3
# Conflicts:
#	fdbserver/Knobs.cpp
#	fdbserver/Knobs.h
2020-10-27 12:21:26 -07:00
Xin Dong be7944773f Fix a typo 2020-10-26 16:44:52 -07:00
Xin Dong 9ef29d0cea Changed getTeamID() to return a string instead of UID as suggested by reviews. 2020-10-26 16:44:52 -07:00