21336fbf12
Merge remote-tracking branch 'origin/main' into features/authz
2022-04-25 08:45:23 -06:00
1c5bf135d5
Revert "Migrate to OpenTelemetry tracing. ( #6855 )" ( #6941 )
...
This reverts commit 5df3bac110
2022-04-25 09:29:56 -05:00
9e65e15b45
Merge remote-tracking branch 'origin/main' into features/validate-trace-events-in-simulation
2022-04-22 15:39:55 -06:00
1352083d4c
Merge pull request #6884 from sfc-gh-clin/deprecate-speical-keys
...
Remove the client profiling special keys and update related documentations
2022-04-21 21:51:16 -07:00
879eb98dec
Rename registerSpecialKeySpaceModule to registerSpecialKeysImpl
2022-04-21 12:54:34 -07:00
b61c9ab329
Merge remote-tracking branch 'origin/main' into features/authz
2022-04-20 14:40:14 -06:00
3335b2686e
Merge branch 'main' into features/validate-trace-events-in-simulation
2022-04-20 12:03:33 -06:00
5df3bac110
Migrate to OpenTelemetry tracing. ( #6855 )
2022-04-20 09:26:37 -05:00
d4ee7be1d7
Reduce excessive tracing and fail after 1M traces
2022-04-19 21:11:51 -06:00
6bfa4f6ac4
Fix typos; Polish documentations according to comments
2022-04-19 13:57:11 -07:00
36c876b769
Fix a typo; Fix a format error in special-keys.rst
2022-04-18 18:10:17 -07:00
c0264a8522
Remove the client profiling special keys and update related documentations
2022-04-18 17:54:50 -07:00
58c24fdaf2
Fix compilation problems
2022-04-13 13:15:41 -06:00
f9eca3884b
implemented base logic
2022-04-12 12:02:43 -06:00
16467262f0
Merge remote-tracking branch 'origin/main' into features/private-request-streams
2022-04-10 14:12:37 -06:00
e43fde16ec
formatting
2022-04-08 17:28:16 -04:00
1b3b4166c6
Merge branch 'main' into vv
2022-04-08 17:18:13 -04:00
6276cebad9
Blob integration ( #6808 )
...
* Fixing leaked stream with explicit notify failed before destructor
* better logic to prevent races in change feed fetching
* Found new race that makes assert incorrect
* handle server overloaded in initial read from fdb
* Handling more blob error types in granule retry
* Fixing rollback metadata problem, added better debugging
* Fixing version race when fetching change feed metadata
* Better racing split request handling
* fixing assert
* Handle change feed popped check in the blob worker
* fix: do not use a RYW transaction for a versionstamp because of randomize API version (#6768 )
* more merge conflict issues
* Change feed destroy fixes
* Fixing change feed destroy and move race
* Check error condition in BG file req
* Using relative endpoints for blob worker interface
* Fixing bug in previous fix
* More destroy and move race fixes
* Don't update empty version on destroy in case it gets rolled back. moved() and removing will take care of ensuring it is not read
* Bug fix (#6796 )
* fix: do not use a RYW transaction for a versionstamp because of randomize API version
* fix: if the initialSnapshotVersion was pruned, granule history was incorrect
* added a way to compress null bytes in printable()
* Fixing durability issue with moving and destroying change feeds
* Adding fix for not fully deleting files for a granule that child granules need to re-snapshot
* More destroy and move races
* Fixing change feed destroy and pop races
* Renaming bg prune to purge, and adding a C api and unit test for it
* more cleanup
* review comments
* Observability for granule purging
* better handling for change feed not registered
* Fixed purging bugs (#6815 )
* fix: do not use a RYW transaction for a versionstamp because of randomize API version
* fix: if the initialSnapshotVersion was pruned, granule history was incorrect
* added a way to compress null bytes in printable()
* fixed a few purging bugs
Co-authored-by: Evan Tschannen <evan.tschannen@snowflake.com>
2022-04-08 14:15:25 -07:00
73a7c32982
Add fdbcli command to read/write version epoch ( #6480 )
...
* Initialize cluster version at wall-clock time
Previously, new clusters would begin at version 0. After this change,
clusters will initialize at a version matching wall-clock time. Instead
of using the Unix epoch (or Windows epoch), FDB clusters will use a new
epoch, defaulting to January 1, 2010, 01:00:00+00:00. In the future,
this base epoch will be modifiable through fdbcli, allowing
administrators to advance the cluster version.
Basing the version off of time allows different FDB clusters to share
data without running into version issues.
* Send version epoch to master
* Cleanup
* Update fdbserver/storageserver.actor.cpp
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
* Jump directly to expected version if possible
* Fix initial version issue on storage servers
* Add random recovery offset to start version in simulation
* Type fixes
* Disable reference time by default
Enable on a cluster using the fdbcli command `versionepoch add 0`.
* Use correct recoveryTransactionVersion when recovering
* Allow version epoch to be adjusted forwards (to decrease the version)
* Set version epoch in simulation
* Add quiet database check to ensure small version offset
* Fix initial version issue on storage servers
* Disable reference time by default
Enable on a cluster using the fdbcli command `versionepoch add 0`.
* Add fdbcli command to read/write version epoch
* Cause recovery when version epoch is set
* Handle optional version epoch key
* Add ability to clear the version epoch
This causes version advancement to revert to the old methodology whereas
versions attempt to advance by about a million versions per second,
instead of trying to match the clock.
* Update transaction access
* Modify version epoch to use microseconds instead of seconds
* Modify fdbcli version target API
Move commands from `versionepoch` to `targetversion` top level command.
* Add fdbcli tests for
* Temporarily disable targetversion cli tests
* Fix version epoch fetch issue
* Fix Arena issue
* Reduce max version jump in simulation to 1,000,000
* Rework fdbcli API
It now requires two commands to fully switch a cluster to using the
version epoch. First, enable the version epoch with `versionepoch
enable` or `versionepoch set <versionepoch>`. At this point, versions
will be given out at a faster or slower rate in an attempt to reach the
expected version. Then, run `versionepoch commit` to perform a one time
jump to the expected version. This is essentially irreversible.
* Temporarily disable old targetversion tests
* Cleanup
* Move version epoch buggify to sequencer
This will cause some issues with the QuietDatabase check for the version
offset - namely, it won't do anything, since the version epoch is not
being written to the txnStateStore in simulation. This will get fixed in
the future.
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2022-04-08 12:33:19 -07:00
e2c144ba8e
fix conflict NativeAPI.actor.cpp
2022-04-08 14:35:20 -04:00
5bdc525353
Merge branch 'main' into vv
2022-04-08 13:16:04 -04:00
bf956f5630
Merge remote-tracking branch 'origin/main' into features/private-request-streams
2022-04-07 13:29:27 -06:00
124aa6e5fd
clean up debug traces and fix details with delRef placement
2022-04-06 12:27:39 -04:00
1b9bd597c5
address code review comments and add some traces for manual testing
2022-04-05 15:29:02 -04:00
a1be7abdad
Clear VV cache instead of throw
2022-04-01 15:19:24 -07:00
4fd414a8ed
Merge branch 'main' into vv
...
Fix Conflicts:
fdbclient/NativeAPI.actor.cpp
2022-03-31 09:38:36 -07:00
cfcf0f152c
Merge branch 'main-4a085fc84' into vv
...
Fix Conflicts:
fdbclient/NativeAPI.actor.cpp
fdbserver/ClusterRecovery.actor.cpp
fdbserver/MasterInterface.h
fdbserver/masterserver.actor.cpp
flow/error_definitions.h
2022-03-30 22:28:06 -07:00
b34f4052cd
Merge branch 'main-f28dfc12b' into vv
...
Fix Conflicts:
fdbclient/MultiVersionTransaction.actor.cpp
fdbclient/NativeAPI.actor.cpp
fdbclient/NativeAPI.actor.h
fdbserver/storageserver.actor.cpp
2022-03-30 21:01:25 -07:00
00b57d4cce
Merge branch 'main-67eba5ec7' into vv
...
Fix Conflicts:
fdbclient/CommitProxyInterface.h
fdbclient/NativeAPI.actor.cpp
fdbclient/StorageServerInterface.h
fdbserver/CommitProxyServer.actor.cpp
fdbserver/storageserver.actor.cpp
2022-03-30 20:05:55 -07:00
0cc1b67b7a
Temporary fix for stale version vector assertion
...
Need to investigate why and fix later.
2022-03-30 19:34:58 -07:00
e9659b5dd4
Merge branch 'master-PR-6500' into vv
...
Fix Conflicts:
fdbclient/CommitProxyInterface.h
fdbclient/NativeAPI.actor.cpp
fdbserver/masterserver.actor.cpp
2022-03-30 14:53:49 -07:00
f266695a76
clear shared state map entries on version upgrade and use currentProtocolVersion instead of piping version through function parameters
2022-03-30 15:28:55 -04:00
9d0a520fe0
add ProtocolVersion to shared state and state cluster map
2022-03-30 13:28:06 -04:00
53d252fda0
Merge branch 'main' of github.com:apple/foundationdb into jfu-grv-cache-multi-threaded
2022-03-29 17:23:08 -04:00
bdbe78e48f
address code review comments
2022-03-29 17:20:22 -04:00
7fc6dfa6c5
Adding useful debugging trace events
2022-03-29 14:48:28 -05:00
fd5734c39e
Fix the case where we access the memory after cleaning
2022-03-28 13:35:42 -07:00
0ff1cd102e
Merge branch 'main' into bg_client_bindings_improvements
2022-03-24 17:19:01 -05:00
989dd8d7eb
Finished implementing beginVersion
2022-03-24 17:15:11 -05:00
b92c6ea92c
granule parallelism, metrics, and other improvements to bg client bindings
2022-03-24 13:44:09 -05:00
7af4b24966
move trace event to within if-block
2022-03-23 17:09:28 -04:00
9f72d68f1e
Make trace event SevDebug to avoid spamming logs by default
2022-03-23 17:08:17 -04:00
7c3151142e
Merge branch 'main' of github.com:apple/foundationdb into jfu-grv-cache-multi-threaded
2022-03-23 16:41:33 -04:00
4466e00716
Fix multithreaded GRV cache code and enable grv caching in multithreaded ctest suite
2022-03-23 16:09:12 -04:00
f27475e2f4
Merge branch 'main' into blob_integration
2022-03-22 11:41:58 -05:00
a71099471b
Update copyright header dates
2022-03-21 13:36:23 -07:00
35f7843d84
Merge remote-tracking branch 'origin/main' into features/private-request-streams
2022-03-21 12:33:53 +01:00
8205771e8f
ReplyPromiseStreams need synchronous disconnect to avoid change feed races
2022-03-18 17:05:12 -05:00
37e7c80f26
Merge branch 'main' into blob_integration
2022-03-17 18:45:42 -05:00
513e8887dd
Add a new C unit test that uses tenants. Fix simulation issue where resetting a transaction could cause in-flight operations to pick up the simulated default tenant for the next retry. Use the new list tenant JSON format in the tenant management test. Fix missing raw_access option in special key space correctness test.
2022-03-17 12:10:19 -07:00
4079b9f23d
Lazily assign the default tenant in simulated tests so that we can enforce that raw access isn't used on tenant transactions. Update various tests to avoid using raw access or system key access after they have performed other operations on the transaction.
2022-03-17 12:10:19 -07:00
d0dc756c6d
Allow disabling tenant mode in simulation. Fix a few bugs.
2022-03-17 12:10:18 -07:00
05495908b8
Implement some tenant tests
2022-03-17 12:10:18 -07:00
118b53b7cf
Merge remote-tracking branch 'origin/main' into features/private-request-streams
2022-03-17 12:06:44 +01:00
58de6e22cc
Add BalanceOnRequests boolean parameter for ModelInterface
2022-03-16 14:25:32 -07:00
9731d96797
Merge branch 'main' of github.com:apple/foundationdb into jfu-grv-cache-multi-threaded
2022-03-16 14:32:33 -04:00
7ab205391b
Revert "remove all multi-version client code related to grv cache"
...
This reverts commit 6d05ecffc2
2022-03-16 14:26:36 -04:00
2acc222d9a
Detect stale GRV proxy replies
...
Each GetReadVersionReply now has the GRV proxy ID that sent it so that the
client can detect old GRV proxy's replies and avoid apply stale version vector
changes.
2022-03-15 14:23:07 -07:00
a1dfd92a43
Fix merge conflict between tenants and checkpointing API. Avoid using .toString() in trace event details and rename (and move) a couple variables.
2022-03-15 14:18:06 -07:00
7464c7747c
Merge pull request #6600 from sfc-gh-ajbeamon/add-tenant-support-back-to-mapped-range
...
Add tenant support back to mapped range requests
2022-03-15 13:46:32 -07:00
e8e69e7c56
Fix formatting
2022-03-15 15:15:16 -05:00
c3a68d661e
Physical Shard Move ( #6264 )
...
Physical Shard Move part I: Checkpoint creation, transfer and restore.
2022-03-15 13:03:23 -07:00
ce5b567971
Cleanup the cleanup
2022-03-15 15:02:28 -05:00
a04934465c
Add tenant support back to mapped range requests. Fix ACTOR warning.
2022-03-15 12:41:08 -07:00
e8077b65e1
Merge pull request #6559 from sfc-gh-ajbeamon/fdb-tenant-client
...
Add client support for tenants
2022-03-15 12:40:17 -07:00
22faf8e5b3
Ignore tenants when setting watches on the metadataVersionKey or sending mutations or conflict ranges that use the metadataVersionKey.
2022-03-15 10:46:31 -07:00
a70adf9fcd
Convert cached ranges to relative ranges when using tenants.
2022-03-15 09:23:30 -07:00
149ca44b9b
Disallow setting raw access on a transaction that has specified a tenant
2022-03-15 09:23:30 -07:00
0536e56725
The tenant cache uses a simpler eviction policy. Some various improvement around the use of futures. Add documentation for C API and fix inaccurate statement in special keys documentation.
2022-03-15 09:23:30 -07:00
06f088e088
Pass along versions with GetKeyServerLocationsRequests, if we have them.
2022-03-15 09:23:30 -07:00
68069c9784
Undo some unused changes. Fix tenant cache eviction.
2022-03-15 09:23:30 -07:00
8bc2b283e1
Create a special keys API to create, delete, and read tenants. Remove the C API to create/delete tenants.
2022-03-15 09:23:30 -07:00
1e1098ca9a
Don't check whether tenants are enabled when watch is called. Support unknown_tenant error.
2022-03-15 09:23:30 -07:00
ecccfd0868
Add cache invalidation to tenant cache. Send tenant ID along with tenant name in requests to validate that the tenant hasn't changed. Fix a few bugs.
2022-03-15 09:23:30 -07:00
fb73e1857a
Some get key requests should not happen within a tenant. Don't set read_system_keys in watch logic unless necessary. Set access_system_keys in a couple movekeys functions.
2022-03-15 09:23:30 -07:00
2a21126028
Don't apply read prefixes on the client. Cache tenant data locally.
2022-03-15 09:23:30 -07:00
a168faf219
Fix bugs in serialization and tenant prefix management on the client.
2022-03-15 09:21:27 -07:00
c635dcd3ad
Add tenant support in the FDB native client
2022-03-15 09:21:27 -07:00
117ee637db
Merge remote-tracking branch 'origin/main' into features/private-request-streams
2022-03-15 17:17:47 +01:00
bed799220a
Addressed review comments, added test
2022-03-15 16:57:26 +01:00
800478ad5e
Add a new client error code stale_version_vector
2022-03-14 20:50:12 -07:00
8d88b7ca41
making range assigner boundary changes fully synchronous to ensure no races with things reading assignments
2022-03-14 14:39:00 -05:00
98eeaac1b7
More debugging and fixing a stuck merge cursor
2022-03-14 11:57:56 -05:00
8dcac2f76d
Fix typos
2022-03-13 10:02:11 -03:00
9b8c101158
Fix a rare race with version vector cache
...
The events that led to the assertion failure are:
Many txn started, some get ReadVersion1, some get ReadVersion2.
Recovery happened.
GRV proxy change detected and the client version cache is cleared.
Old GRV responded with ReadVersion1, and client version cache is updated to ReadVersion1.
A txn starts reading with ReadVersion2, triggering the assertion.
The fix is to throw an error to trigger transaction restart so that a new GRV
will update the version cache.
2022-03-12 12:03:01 -08:00
82eef0c7f7
Better CF tracing for client and server
2022-03-11 16:50:38 -06:00
2a506f2dff
Updating SS desired every mutation to avoid CF merge deadlock
2022-03-10 20:11:49 -06:00
211e5b579a
Adding back debug stream uid to help track down bugs
2022-03-10 13:55:42 -06:00
903f7adbc4
more cleanup
2022-03-10 13:53:06 -06:00
e2c7c30faf
GetMappedRange support serializable & check RYW & continuation ( #6181 )
2022-03-10 10:05:44 -08:00
1f964ac085
BM focused cleanup
2022-03-09 15:04:17 -06:00
b21d0943b9
client-focused cleanup
2022-03-09 10:01:25 -06:00
e71b3533f9
Merge branch 'main' into blob_integration
2022-03-09 08:59:56 -06:00
8fac0081a8
Merge remote-tracking branch 'origin/main' into features/private-request-streams
2022-03-09 11:00:00 +01:00
402fa4dd9e
Merge pull request #6428 from sfc-gh-ajbeamon/fdb-tenant-add-interfaces
...
Add server-side and protocol support for tenants
2022-03-08 15:33:18 -08:00
63b8b838a2
Merge pull request #6558 from sfc-gh-ajbeamon/special-keys-limits
...
Add support for a limits hint in special keys range reads
2022-03-08 15:32:59 -08:00
6f7adb04a5
Send a version along with GetKeyServerLocationsRequests to allow the proxy to reject missing tenants more quickly. Change the commit proxy tenant map to be unversioned.
2022-03-08 13:33:56 -08:00
58f5cea39b
fix typo
2022-03-07 11:20:24 -06:00
04f678d515
Fixing sample logic
2022-03-07 11:20:24 -06:00
665e182bcc
TSS Metrics improvements
2022-03-07 11:20:24 -06:00
c99c7cf55f
Apply tenant prefixes on the storage server. The commit proxy can serve tenant location requests. Fix some bugs.
2022-03-06 21:54:21 -08:00
5fa9d3e1b7
Add a tenant parameter to read and commit requests. Store a map of all tenants on commit proxy and storage servers. Add an option to require tenant mode.
2022-03-06 21:54:21 -08:00
36435af4f5
Add support for a limits hint in special keys. Fix a typo and resolve some comment formatting weirdness.
2022-03-06 21:52:39 -08:00
1a5bf25b5c
Update code base to use fmt 8.1.1
2022-03-04 15:52:06 -08:00
1555c0e2aa
Fix conflict between two recent merges by using the new errorUnsuppressed function.
2022-03-04 12:41:21 -08:00
cdebda35ab
Merge pull request #5725 from sfc-gh-jfu/jfu-grv-cache
...
Add transaction option for clients to use cached read versions
2022-03-04 09:17:27 -08:00
2b8882ca0a
Adding exponential backoff for consecutive change feed stream failures
2022-03-02 18:46:40 -06:00
e73c0a31e6
add wiggle_server_ids and wiggle_server_addresses in status json
2022-03-02 10:03:23 -08:00
5e39da7741
fixup! Reformat the source
2022-02-28 18:03:52 -08:00
02e396274f
Fix the compile error on NativeAPI.actor.cpp
2022-02-28 18:03:52 -08:00
aadd706a0a
Port back addressed comments for fixing get key location issue
2022-02-28 16:08:57 -08:00
0bdae35a2c
Address comments and move updateFailedEndpointRefreshTime
2022-02-24 16:35:30 -08:00
9c99c59b0c
Fix get key location overloading proxies
2022-02-24 16:35:30 -08:00
e5b4fb3d80
Adding explicit popVersion to change feed reply, like tlogs have
2022-02-24 15:20:18 -06:00
250a88e682
Enforce that trace event suppression calls happen first when using trace event call chaining. Fix various instances where we weren't following this requirement.
2022-02-24 12:25:52 -08:00
8cc9a5af1a
Rebase 02/23
2022-02-23 14:23:28 -05:00
ce1d71472d
Merge branch 'main' of github.com:apple/foundationdb into jfu-grv-cache
2022-02-23 12:35:25 -05:00
cf31e14904
Merge remote-tracking branch 'origin/main' into features/private-request-streams
2022-02-23 10:29:32 +01:00
622d89b552
Rebase on main.
...
Since we changed ClusterConnectionString's status flag from boolean to enum in #6422 , we need to update this PR correspondingly.
2022-02-22 16:29:59 -08:00
481587a8c6
Turn on hostname logic.
2022-02-22 16:29:59 -08:00
ae071a7211
clean up debug trace lines
2022-02-22 17:16:11 -05:00
b60cc02aa2
fix compile error
2022-02-22 13:10:30 -05:00
31d56b2f50
adjust knob setting, revert trace changes, and disable cache if onError retries transactions
2022-02-22 12:42:53 -05:00
dc973fb67e
Allow List and first test
2022-02-22 11:15:16 +01:00
a7a3dccba5
TSS Mismatch Quarantine fix
2022-02-17 19:16:07 -06:00
ef25e4fdfb
Sending empty version back immediately to establish stream connection and acknowledgement queue for change feed stream requests
2022-02-17 18:10:17 -06:00
38a75a8b89
Merge branch 'main' into blob_integration
2022-02-17 17:47:38 -06:00
26480c4705
change feed popping fixes
2022-02-15 15:12:23 -06:00
d399daebed
Merge branch 'main' of github.com:apple/foundationdb into jfu-grv-cache
2022-02-15 15:09:40 -05:00
6f1c3d50bb
add debug traces for testing
2022-02-15 15:08:53 -05:00
092b5cee4b
MVC2.0: Rollback added code
2022-02-14 13:50:42 -08:00
a63d218e9d
simplify test workload and adjust ratekeeper throttling strategy
2022-02-11 16:41:14 -05:00
2e63ac6963
code review changes: additional test checks, cleanup extra code, mark internal option hidden
2022-02-10 17:01:09 -05:00
458e708272
addressed code review comments: renamed variables, small functional changes, style changes
2022-02-10 16:17:54 -05:00
f4c235f134
propagating change_feed_popped correctly
2022-02-09 09:34:13 -06:00
72e06369a4
Merge remote-tracking branch 'apple-upstream/main' into version-vector-prototype
2022-02-08 17:47:57 +00:00
7e5ad88780
formatting for Github CI
2022-02-07 15:31:59 -05:00
9c0a512cf5
Merge branch 'main' of github.com:apple/foundationdb into jfu-grv-cache
2022-02-07 14:51:12 -05:00
ec2bbf0343
clean up some more trace lines and leftover code snippets
2022-02-07 14:50:04 -05:00
9b3f6fe452
More bugs in streaming split
2022-02-07 13:25:14 -06:00
88b1593681
Removing incorrect assert
2022-02-07 11:56:14 -06:00
88cab7fb67
More change feed fetching improvements and optimizations
2022-02-07 11:19:51 -06:00
c48ca9430d
Fixes for streaming split keys
2022-02-07 10:36:22 -06:00
809ec24184
More change feed buffer tuning
2022-02-07 08:19:19 -06:00
1736eabd33
fixes for split metrics stream
2022-02-04 18:24:55 -06:00
41a274ed9c
Fixing bug and refactoring iterative range splitting
2022-02-04 17:10:46 -06:00
ddfc301d74
Improving memory footprint of change feeds and making it configurable
2022-02-04 16:41:25 -06:00
a974773676
Handled change feed getting moved away or cancelled during move
2022-02-04 09:33:04 -06:00
2592c3f0ae
Implemented less efficient version of reply stream closing
2022-02-03 20:07:49 -06:00
9c8afdf35c
Debugged and fixed stuck change feed issue
2022-02-02 15:15:54 -06:00
Markus Pilman