2f52c5f79b
Merge branch 'release-6.3'
...
# Conflicts:
# fdbserver/RestoreLoader.actor.cpp
2020-08-11 22:45:43 -07:00
c27542d4e9
FR:SampleBackup:Send reply when receive duplicate msg
2020-08-07 16:50:36 -07:00
fccebd9b80
FR:Use ByteSampleInfo to accurately sample backup
2020-08-06 20:45:46 -07:00
87bde08695
FR:fix:sending samples may have broken promise error
...
The error should not skip the ack reply from loader to controller, saying
the file has been loaded.
Otherwise, restore controller can get stuck at waiting for the ack reply.
2020-08-06 10:41:18 -07:00
fe5902994c
Merge pull request #3605 from apple/release-6.3
...
Merge Release 6.3 to master
2020-08-05 23:37:44 -07:00
859c3145e2
FR:Fix samples not send reply and false positive failures
2020-08-05 11:32:04 -07:00
879998d01b
FR:fix compilation error
2020-08-04 23:04:38 -07:00
7992cef025
FR:Fix sample network pkg can be too big
2020-08-04 22:35:21 -07:00
fec3de9b7b
Fix RestoreLoader loadedLogBytes counter
2020-07-31 16:00:15 -07:00
1a57d88179
Add const iterator for RangeMap
2020-07-10 10:56:41 -07:00
a5af214861
Use KeyRangeMap for splitMutation
...
This simplifies code by reuse KeyRangeMap class.
2020-07-09 09:59:37 -07:00
7279beb662
Add old splitMutation for unit test
2020-07-08 17:57:20 -07:00
d6dd88c2b9
Move building of KeyRangeMap out of the loop
...
So that it is only done once.
2020-07-08 14:16:10 -07:00
a187eeebee
Add assertions back and comments for splitMutation
2020-07-08 11:08:23 -07:00
e78cc9ee4b
Use KeyRangeMap for splitMutation
...
This simplifies code by reuse KeyRangeMap class.
2020-07-08 09:53:34 -07:00
f3302833ce
Merge pull request #3435 from apple/release-6.3
...
Merge Release 6.3 to master
2020-06-30 10:08:28 -07:00
a5febfbc75
Remove spurious comments
2020-06-29 10:26:01 -07:00
8f5ee1f4aa
Refine trace events for better perf diagnosis
2020-06-29 10:22:07 -07:00
82dfb5ce3f
FastRestore:Update process metrics for restore master
2020-06-28 12:37:04 -07:00
22f7f804b8
Merge branch 'release-6.3' into mengxu/merge-6.3-PR
2020-06-28 11:19:39 -07:00
bc98c84346
RestoreLoader release data early and revert Lower priority for RestoreApplierReceiveMutations actor
...
A quick evalution shows lowering priority for receive mutation actor does not help restore speed but hurt it.
2020-06-28 11:12:06 -07:00
026a735703
Test perf without gracefully clear memory
2020-06-27 16:15:56 -07:00
d6381de16f
RestoreLoader:Clear memory per loading param
2020-06-27 15:51:19 -07:00
f18a0a242d
FastRestore:Loader frees mutation memory immediately after send mutations
2020-06-27 15:19:08 -07:00
e57dba00bd
FastRestore:Lower priority for RestoreApplierReceiveMutations actor
2020-06-27 15:16:38 -07:00
5860a5b4db
FastRestore:Suppress or mute spammy trace events
2020-06-24 22:10:54 -07:00
c13ba7aeb4
FastRestore:Cosmetic code style improvement
...
Also mute some trace events
2020-06-24 21:25:37 -07:00
d0c0d06b1e
FastRestore:Avoid calling withPrefix when addPrefix is not set
...
It help improve performance when addPrefix is not set.
2020-06-23 10:43:35 -07:00
dd5c1ec416
FastRestore:Add debug trace
...
The bug behavior is:
In transformDatabaseContents(), we write all new kvs into the DB in 100 keys batch.
We immediately read these keys out.
There are 100 keys missing.
2020-06-22 19:47:21 -07:00
f16381c7e8
FastRestore:Clean backup ranges
2020-06-22 11:43:24 -07:00
3d6f69c8e2
FastRestore:addPrefix:Transform must clear both orignal and transformed range
...
Otherwise, anything left in the range can interfer with the result.
2020-06-21 22:18:12 -07:00
8d59568dc7
FastRestore:Fix:Forgot to assign transformed key to mutations
...
The earlier change in restore logic did not really take effect.
This commit fix it and confirm the addPrefix test does cause expected
failures if we do not transform the keys at the end of the test.
2020-06-18 17:40:16 -07:00
2fcef90cbc
FastRestore:Add addPrefix and removePrefix feature
2020-06-18 11:58:42 -07:00
00b93dd562
Merge pull request #3311 from apple/release-6.3
...
Merge Release 6.3 into master
2020-06-08 21:31:10 -07:00
96c2a164bc
RestoreLoader:Wait on actorCollection error
...
so that we will not fail sildently
2020-06-05 16:45:08 -07:00
d128252e90
Merge release-6.3 into master
2020-05-22 09:25:32 -07:00
3bf38c1acd
Add a comment on restore's clear mutation
2020-05-20 14:42:30 -07:00
ccaac162e2
Resolve performance concerns of nearly-no-op debugMutation being frequently called
...
This introduces unhygenic macro variants that inline a `ENABLED &&`
before the TraceEvent. This way, they get entirely compiled out unless
enabled.
Then rewrite all debugMutation uses via sed.
2020-05-13 18:44:15 -07:00
27da91ab9e
Merge remote-tracking branch 'upstream/master' into mutation-debugging
2020-05-13 12:51:44 -07:00
68bcecd7d4
FastRestoreLoader:Clean batchData when a version batch finishes
...
Add sanity check for each loader phase to ensure an older version batch
will not be executed once a version batch has been marked as finished.
2020-05-04 11:31:42 -07:00
0ba1551116
FastRestore:Trace memory usage periodically
2020-05-04 11:20:53 -07:00
528466e0e6
FastRestore:Fix Valgrind error InvalidSuppression
...
Trace.error() must explicitly include error_code_actor_cancelled
to handle the error.
2020-05-02 19:52:05 -07:00
134dbca0ee
FastRestore:Use cannonical way to trace error
2020-05-01 13:35:13 -07:00
28178f356f
FastRestore:Minor knob change and revise comments
2020-05-01 10:47:44 -07:00
41c0a1768f
FastRestore:Make FastRestore event type more descriptive
2020-05-01 10:27:08 -07:00
05ba743f96
Control number of replies on wait in getBatchReplies
2020-05-01 10:09:08 -07:00
038f3834fc
Merge branch 'master' into mengxu/fr-code-improvement-PR
2020-05-01 09:26:29 -07:00
df63e43f79
Remove finished todo comment
2020-05-01 09:22:28 -07:00
6bd71560f0
FastRestore:Reduce trace events in real cluster environment
2020-04-30 19:12:31 -07:00
a0d67cac16
Merge branch 'master' into mengxu/fr-code-improvement-PR
2020-04-29 21:07:33 -07:00
Evan Tschannen