Chang Liu
814e3c729f
fix roll trace event issue for data distribution(master)
...
Description
Testing
2021-09-24 15:40:17 -07:00
Chang Liu
c10dd0df4b
fix roll trace event issue for data distribution
...
Description
Testing
2021-09-24 15:40:17 -07:00
He Liu
a1f6dcc2d5
merge from master
2021-09-22 13:07:38 -07:00
Xiaoxi Wang
1730d75f73
change configure test
...
add store type check
add test file
2021-09-21 18:11:04 -07:00
He Liu
2246a0bee7
switch to plain random selection
2021-09-20 11:23:54 -07:00
He Liu
4d5bf08da8
address comments
2021-09-19 17:03:06 -07:00
Xiaoge Su
abf73047ca
Enforce std:: specifier rather than using namespace
2021-09-16 19:40:28 -07:00
He Liu
ef7fdc0781
fmt
2021-09-15 10:32:09 -07:00
He Liu
c8a3413820
exclude to-be-dropped server from the random team
2021-09-15 09:07:50 -07:00
helium
fd6d088945
choose team before removing server
2021-09-14 19:24:59 -07:00
helium
7e53f8662d
added comments
2021-09-13 13:28:55 -07:00
helium
8e0b572a18
Added comments.
2021-09-02 22:29:07 -07:00
helium
6612cc00b6
Check if the src server list will be empty before removing a failed server."
2021-09-01 14:52:07 -07:00
Trevor Clinkenbeard
66df75c570
Merge pull request #5385 from sfc-gh-tclinkenbeard/debug-dd
...
Capture deep copy of `machine_info` in `printSnapshotTeamsInfo`
2021-08-20 13:25:50 -07:00
sfc-gh-tclinkenbeard
9458a6975d
Remove std::map::at usage from DataDistribution.actor.cpp
2021-08-20 12:35:26 -07:00
sfc-gh-tclinkenbeard
556e4bc283
Add assertion to overlappingMachineMembers
2021-08-13 14:56:22 -07:00
sfc-gh-tclinkenbeard
a0a4207ce2
Capture deep copy of machine_info in printSnapshotTeamsInfo
2021-08-13 12:13:54 -07:00
sfc-gh-tclinkenbeard
3f0e07d79c
Remove dead code
2021-08-13 09:54:02 -07:00
sfc-gh-tclinkenbeard
ea4f6850da
Mark ServerStatus::excludeOnRecruit const
2021-08-13 09:52:07 -07:00
sfc-gh-tclinkenbeard
0aafd9d5f0
Mark TCServerInfo::isCorrectStoreType const
2021-08-13 09:49:22 -07:00
Josh Slocum
e444d3781c
Various TSS improvements from snowblower testing
2021-08-13 10:24:15 -05:00
sfc-gh-tclinkenbeard
904deb9516
Improve DDTeamCollection const-correctness
2021-08-12 18:52:57 -07:00
sfc-gh-tclinkenbeard
cfe677c100
storageRecruiter only responds to changes in recruitStorage endpoint
2021-08-12 16:24:03 -07:00
sfc-gh-tclinkenbeard
45ac667271
Add IsPrimary boolean parameter
2021-08-12 14:05:04 -07:00
Andrew Noyes
ca9f60baef
Fix heap use after free
2021-08-11 15:42:01 -07:00
Xiaoxi Wang
2337ec7d4e
remove unused variables
2021-08-03 10:15:34 -07:00
sfc-gh-tclinkenbeard
c74047c665
Merge remote-tracking branch 'origin/master' into fix-more-clang-warnings
2021-07-28 11:51:02 -07:00
Steve Atherton
507c1f11e3
Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use.
2021-07-26 19:55:10 -07:00
sfc-gh-tclinkenbeard
a27d7c86f4
Fix more -Wreorder-ctor warnings in DataDistribution.actor.cpp
2021-07-24 22:14:43 -07:00
sfc-gh-tclinkenbeard
da50e13f3e
Fix more -Wreorder-ctor warnings in DataDistribution.actor.cpp, OldTLogServer_4_6.actor.cpp, and Net2.actor.cpp
2021-07-24 17:33:11 -07:00
sfc-gh-tclinkenbeard
6f81155784
Merge remote-tracking branch 'origin/master' into const-serverdbinfo
2021-07-20 10:18:40 -07:00
Steve Atherton
f596a81073
Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs.
2021-07-17 00:11:40 -07:00
Xiaoxi Wang
501dc339a9
relax perpetual wiggle pause condition; add trace log; correct perpetual wiggle priority setting
2021-07-12 05:46:55 +00:00
sfc-gh-tclinkenbeard
8a212862f0
Prevent dataDistributor from modifying ServerDBInfo object
2021-07-11 22:04:54 -07:00
sfc-gh-tclinkenbeard
79ff07a071
Added *BOOLEAN_PARAM macros to enforce documentation of boolean parameters
2021-07-02 15:04:42 -07:00
Neethu Haneesha Bingi
73752f441b
exclude locality:clang-format, ranged loops, documentation, tracking addStoragesever for exclusion.
2021-06-23 18:03:27 -07:00
Neethu Haneesha Bingi
62355571d0
exclude servers based on locality match
2021-06-23 18:03:27 -07:00
Xiaoxi Wang
7b713f7fd2
add knob
2021-06-23 05:49:55 +00:00
Xiaoxi Wang
f2daf20927
TEST condition
2021-06-21 06:56:03 +00:00
Xiaoxi Wang
0493d149e6
wait remove
2021-06-21 05:18:42 +00:00
Xiaoxi Wang
783520ce85
add and remove some healthy check to solve cluster status oscillation when #ss is little; simplify some code
2021-06-19 16:57:04 +00:00
Xiaoxi Wang
647138145d
adjust default value of stopWiggleSignal; better trace logic
2021-06-17 20:59:47 +00:00
Xiaoxi Wang
fdd9c30794
code refactor;change stopSignal;
2021-06-16 05:30:58 +00:00
Xiaoxi Wang
d33e43fd2b
code format
2021-06-14 23:00:02 +00:00
Xiaoxi Wang
2cd4e6d62f
check healthy team count, dd queue and disk space;
...
code refactor
2021-06-14 22:09:45 +00:00
Xiaoxi Wang
d46fccc30f
Revert "Revert "Properly set simulation test for perpetual storage wiggle and bug fixing""
...
This reverts commit ad576e8c20 .
2021-06-11 22:58:05 +00:00
Xiaoxi Wang
ad576e8c20
Revert "Properly set simulation test for perpetual storage wiggle and bug fixing"
2021-06-11 09:07:45 -07:00
Xiaoxi Wang
17ac91bac4
Merge pull request #4929 from sfc-gh-xwang/ppwtest
...
Properly set simulation test for perpetual storage wiggle and bug fixing
2021-06-10 14:09:50 -07:00
Xiaoxi Wang
cd58c0c149
add useful trace; add invalid wiggling server check
2021-06-10 06:50:44 +00:00
Xiaoxi Wang
4220a548ce
use the same health check as exclude to avoid 'best team get stuck'
2021-06-09 22:51:46 +00:00
Xiaoxi Wang
51b4cb89c2
fix server_status bug
2021-06-08 23:47:59 +00:00
Xiaoxi Wang
45ebdb1a9d
fix perpetual wiggle bug caused by multiple DCs and removeStorageServer
2021-06-08 23:33:25 +00:00
Xiaoxi Wang
6ab0ea3d0f
properly set perpetual_storage_wiggle value during tests
2021-06-07 17:55:20 +00:00
sfc-gh-tclinkenbeard
371a38e6e5
Merge remote-tracking branch 'origin/master' into remove-extra-copies
2021-06-07 10:26:06 -07:00
Xiaoxi Wang
838d847d4e
Merge pull request #4860 from sfc-gh-xwang/ppwtest
...
implement perpetual storage wiggling feature
2021-06-04 16:18:39 -07:00
Xiaoxi Wang
5be65fab5e
add comment
2021-06-04 18:40:18 +00:00
Xiaoxi Wang
e0981d6732
add code coverage mark
2021-06-03 19:58:28 +00:00
Xiaoxi Wang
351325b3af
comment modification; wait perpetual wiggling close
2021-06-03 05:13:20 +00:00
Xiaoxi Wang
21e175b16c
add comments for new actors
2021-06-02 18:49:01 +00:00
Xiaoxi Wang
944c9ad8d9
fix memory bug
2021-06-02 17:53:44 +00:00
Josh Slocum
b3e4f182ef
TSS Mapping Change
2021-06-02 17:30:09 +00:00
Xiaoxi Wang
9684d78a6e
solve recruiting conflict with TSS
2021-06-02 06:12:45 +00:00
Xiaoxi Wang
8b9c8b33fc
manually merge with master
2021-06-01 17:51:42 +00:00
Xiaoxi Wang
ce308edc5e
fix wiggler logic bug
2021-05-26 21:57:58 +00:00
Josh Slocum
4257ac2b4d
More TSS Changes/Fixes
2021-05-25 20:37:48 +00:00
Josh Slocum
ce82c9653e
Testing Storage Server implementation
2021-05-25 20:28:50 +00:00
Xiaoxi Wang
e9a23840ea
fix promise bug
2021-05-25 20:25:21 +00:00
Xiaoxi Wang
f11b7ffa5f
merge master, fix promise callback bug
2021-05-25 18:43:08 +00:00
Xiaoxi Wang
7bc55448aa
fix iterator bug
2021-05-24 19:11:28 +00:00
Xiaoxi Wang
85cd2b9945
add perpetualStorageWiggler
2021-05-20 23:31:08 +00:00
Xiaoxi Wang
3f3a81b3d9
add pid2server_info to maintain Process id set
2021-05-20 03:32:15 +00:00
sfc-gh-tclinkenbeard
f28ac955c3
Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>>
2021-05-10 16:32:50 -07:00
sfc-gh-tclinkenbeard
5c2d7b6080
Create RangeResult type alias
2021-05-03 13:14:16 -07:00
Trevor Clinkenbeard
0db28f6ea0
Merge pull request #4535 from jzhou77/fix-dd
...
Fix DD Assertion failed in canBeSet
2021-03-24 10:50:04 -07:00
Jingyu Zhou
0c3bc09524
Remove the shuttingDown flag
2021-03-21 20:12:37 -07:00
Jingyu Zhou
cb26576b95
Fix DD assertion failure
...
This fixes #4493 , where DDTeamCollection::~DDTeamCollection creates new teams
that hold pointer to the DDTeamCollection, thus later causes assertion failure
because the memory is invalid.
The fix is to cancel teamBuilder at the begining of the ~DDTeamCollection.
2021-03-21 19:54:44 -07:00
Evan Tschannen
d2f9bf7eb6
added comments and fixed style
2021-03-16 15:44:49 -07:00
Evan Tschannen
edefcff3ac
do not kill the data distributor after removing a failed server, completely remove the failed server
2021-03-15 16:48:08 -07:00
Evan Tschannen
c0a1362478
fixed a bug where DD was shutdown while still in a callback from trackExcludedServers
2021-03-15 16:26:57 -07:00
Evan Tschannen
c570a7b718
added trace events
2021-03-15 15:55:02 -07:00
Evan Tschannen
403d933329
fixed trace event
2021-03-15 10:51:53 -07:00
Evan Tschannen
831224df99
fixed complier error
2021-03-15 10:48:48 -07:00
Evan Tschannen
4e4149b070
exclude failed shuts down data distribution while the server is being removed to avoid two processes making changes to the key servers at the same time
2021-03-15 10:43:06 -07:00
FDB Formatster
df90cc89de
apply clang-format to *.c, *.cpp, *.h, *.hpp files
2021-03-10 10:18:07 -08:00
Vishesh Yadav
2bb4f2e59f
Merge branch 'release-6.3-pre-format' into master-format
...
This merges release-6.3 branch right before it was fully formatted.
There were quite a few conflicts that are resolved here. CoroFlow had
a check for OOM errors introduced in 6.3, but didn't seem applicable in
the new implmentation which seems to use boost.
2021-03-10 09:37:41 -08:00
Chaoguang Lin
9645f489e6
Fix base trace event name inconsistency
2021-03-08 15:20:50 -08:00
Zhe Wu
59181245c1
Change SSVersionDiffLarge event log level to warning
2021-03-03 23:33:48 -08:00
Andrew Noyes
79cec09255
Apply clang-tidy's performance-inefficient-vector-operation fix
...
I ran this command in my build directory after compiling with
OPEN_FOR_IDE. It took a few small tweaks to get it to compile, which is
outside the scope of this commit.
$ python run-clang-tidy.py -j $(nproc) -checks='-*,performance-inefficient-vector-operation' -fix
2021-03-04 03:58:25 +00:00
Evan Tschannen
346a4e3ecd
Merge branch 'release-6.3'
...
# Conflicts:
# fdbcli/fdbcli.actor.cpp
# fdbrpc/LoadBalance.actor.h
# fdbrpc/MultiInterface.h
# fdbserver/ClusterController.actor.cpp
# fdbserver/MasterProxyServer.actor.cpp
# fdbserver/masterserver.actor.cpp
2021-03-01 18:52:06 -08:00
sfc-gh-tclinkenbeard
32486a2785
Reenable tlog pops in ddSnapCreateCore even if some disable requests fail
...
If some tlogs successfully disable pops but others fail to, we do not
want to wait TLOG_IGNORE_POP_AUTO_ENABLE_DELAY seconds before reenabling
pops
2021-02-20 18:24:21 -08:00
Russell Sears
8025cc4571
Merge remote-tracking branch 'upstream/release-6.3' into merge-6.3-to-master-1-26-21
2021-01-26 19:46:47 +00:00
Andrew Noyes
0ef44739ea
Fix OPEN_FOR_IDE build in preparation for using clang-tidy
2021-01-26 02:04:11 +00:00
Xin Dong
0cde3cc48f
Make trace event happy
2021-01-25 14:04:16 -08:00
Xin Dong
dce8af5b63
Change back to SevWarnAlways for now.
2021-01-25 13:54:24 -08:00
sfc-gh-tclinkenbeard
bdf58d0b2f
Add assertion to DDTeamCollection::overlappingMembers
2021-01-21 14:39:39 -08:00
sfc-gh-tclinkenbeard
ad99bf0471
Merge remote-tracking branch 'origin' into misc-changes
2021-01-21 10:03:07 -08:00
Xin Dong
83506cda87
Log SevError instead of SevWarnAlways when all replicas of some data are lost.
2021-01-15 15:00:48 -08:00
Andrew Noyes
ff7d306b09
Merge branch 'release-6.3' into anoyes/merge-6.3-to-master
...
Include conflict markers for now. Will resolve.
2021-01-15 18:04:09 +00:00
sfc-gh-tclinkenbeard
5b2e88b187
Use structured bindings in for loops
2020-12-27 01:46:20 -04:00
sfc-gh-tclinkenbeard
0d4e81e6b4
Use unique_ptr in DataDistribution.actor.cpp
2020-12-26 23:40:54 -04:00