Commit Graph

3 Commits

Author SHA1 Message Date
Trevor Clinkenbeard cb9f79d484 Make AsyncFileBlobStore header private 2026-07-15 19:47:34 -07:00
Trevor Clinkenbeard a4bba6bf35 Remove additional unused includes found by IWYU 2026-05-08 12:00:22 -07:00
Arnav Aggarwal ea921e6420
Introduce blob store interface and refactor S3 classes (#12936)
* Refactor blob store classes to use interface

* update to make some methods non-pure virtual

* Complete IBlobStoreEndpoint interface refactoring

Move doRequest, connect, returnConnection, updateSecret, writeEntireFile,
listObjects, and deleteRecursively from S3BlobStoreEndpoint to the shared
IBlobStoreEndpoint base class. Introduce provider hook methods
(setRequestHeaders, normalizeResourceForRequest, simulateRequestFailure,
processRequestFailure, preRetryCheck, extractCredentialFields) so that
the request loop is provider-agnostic.

Rename s3_backup_test.sh to backup_restore_test.sh and update CMake
to reflect the provider-agnostic naming.

Fix double proxy absolute-form rewrite bug where both
S3BlobStoreEndpoint::normalizeResourceForRequest and the base doRequest
would prepend http://host:port for proxy connections.

Fix getResourceURL duplication by having S3's override delegate to the
base class for shared knob-params/extra-headers logic.

* resolve review comments

* remove gcs auto region block

* clang format

* Enable +x bit.

* clang tidy
2026-04-17 09:17:15 -07:00