Jingyu Zhou
3bf38c1acd
Add a comment on restore's clear mutation
2020-05-20 14:42:30 -07:00
Meng Xu
68bcecd7d4
FastRestoreLoader:Clean batchData when a version batch finishes
...
Add sanity check for each loader phase to ensure an older version batch
will not be executed once a version batch has been marked as finished.
2020-05-04 11:31:42 -07:00
Meng Xu
0ba1551116
FastRestore:Trace memory usage periodically
2020-05-04 11:20:53 -07:00
Meng Xu
528466e0e6
FastRestore:Fix Valgrind error InvalidSuppression
...
Trace.error() must explicitly include error_code_actor_cancelled
to handle the error.
2020-05-02 19:52:05 -07:00
Meng Xu
134dbca0ee
FastRestore:Use cannonical way to trace error
2020-05-01 13:35:13 -07:00
Meng Xu
28178f356f
FastRestore:Minor knob change and revise comments
2020-05-01 10:47:44 -07:00
Meng Xu
41c0a1768f
FastRestore:Make FastRestore event type more descriptive
2020-05-01 10:27:08 -07:00
Meng Xu
05ba743f96
Control number of replies on wait in getBatchReplies
2020-05-01 10:09:08 -07:00
Meng Xu
038f3834fc
Merge branch 'master' into mengxu/fr-code-improvement-PR
2020-05-01 09:26:29 -07:00
Meng Xu
df63e43f79
Remove finished todo comment
2020-05-01 09:22:28 -07:00
Meng Xu
6bd71560f0
FastRestore:Reduce trace events in real cluster environment
2020-04-30 19:12:31 -07:00
Meng Xu
a0d67cac16
Merge branch 'master' into mengxu/fr-code-improvement-PR
2020-04-29 21:07:33 -07:00
Jingyu Zhou
b315163033
Fix a memory corruption error
2020-04-28 15:39:23 -07:00
Meng Xu
9f18146f4a
FastRestore:Loader:Free memory after send
2020-04-25 17:59:33 -07:00
Meng Xu
8569f1a93f
FastRestore:Loader:Use shallow copy for single key mutations when send mutation messages to appliers
2020-04-25 17:30:01 -07:00
Meng Xu
96855d9b47
FastRestore:Loader:Enable sending mutation messages out of order
2020-04-25 17:21:17 -07:00
Meng Xu
70ae22e72f
FastRestore:Loader:Deep copy splitted mutation
...
otherwise, the mutation buffer will have an invalid address for MutationRef
when it was sent to applier.
2020-04-24 10:31:30 -07:00
Meng Xu
f073049865
FastRestore:Revise trace events to be descriptive
...
Revert changes that send mutations to appliers out of order
2020-04-24 10:31:08 -07:00
Meng Xu
38193a3866
Merge branch 'master' into mengxu/fr-code-improvement-PR
2020-04-22 10:51:33 -07:00
Meng Xu
9b2f6d5c13
FastRestore:Loader:Enable sending message out of order
2020-04-22 08:57:11 -07:00
Meng Xu
d85a39df69
FastRestore:Loader:Make requests no longer state varialbe
2020-04-21 22:21:59 -07:00
Meng Xu
d21da5065a
FastRestore:Loader:Merge MutationsVec and LogMessageVersionVec into VersionedMutationsVec
...
Remove the actor that sends one mutation message batch in the previous commit,
because that actor no longer reduces the code complexity.
2020-04-21 22:05:34 -07:00
Jingyu Zhou
6909f0b8fc
Remove decodeRangeFileBlock from parallel restore
...
Reuse the one from fileBackup namespace.
2020-04-21 13:42:24 -07:00
Meng Xu
9ade63a685
FastRestore:Loader:Add sendOneMutationBatchToAppliers actor
2020-04-21 11:36:21 -07:00
Meng Xu
00188c3157
Merge branch 'master' into mengxu/fr-code-improvement-PR
2020-04-19 11:52:42 -07:00
Meng Xu
d6021132a8
FastRestore:Merge mutationMap and mutationPartMap for efficiency
2020-04-19 11:52:17 -07:00
Meng Xu
719eda9421
FastRestore:Add an assertion in handleRestoreSysInfoRequest
...
as suggested in code review.
2020-04-18 22:42:46 -07:00
Meng Xu
10a6461d13
FastRestore:Change __inline__ to inline
...
__inline__ is compiler specific while inline is the standard keyword
2020-04-17 22:31:44 -07:00
Meng Xu
916d361587
BackupAndParallelRestoreCorrectness:Remove unnecessary checking optional variable
2020-04-17 18:32:14 -07:00
Meng Xu
c8d049d0bb
FastRestore:Loader:Add counter oldLogMutations
2020-04-17 15:21:59 -07:00
Meng Xu
d6c1baa784
FastRestore:Filter out log mutations whose version is smaller than range mutation version
2020-04-15 19:45:03 -07:00
Meng Xu
acdf6816b8
FastRestore:Loader:Fix:Last version in each RA is forgotten
2020-04-13 17:28:21 -07:00
Meng Xu
061bcd2fb4
FastRestore:Replace typeString with safe getTypeString func
...
Also fix compilation error in previous commit
2020-04-13 15:15:54 -07:00
Meng Xu
56cdd18224
FastRestore:Loader:Allow sending not all mutations at a version to appliers
2020-04-13 13:59:21 -07:00
Meng Xu
68adbef5bf
FastRestore:Loader:Send multiple versions of mutations in a message to appliers
2020-04-12 11:18:41 -07:00
Meng Xu
dbc9c23193
FastRestore:Loader:Send mutations at different versions in the same message to appliers
...
This increases the bandwidth sent from loaders to appliers.
2020-04-12 10:46:58 -07:00
Meng Xu
2325ab209f
FastRestore:Applier:Avoid extra copy in getAndComputeStagingKeys
2020-04-08 12:22:08 -07:00
Meng Xu
da7249ed1c
FastRestore:Minor revision based on review comments
2020-04-02 11:15:22 -07:00
Meng Xu
6bce67ca75
FastRestore:Apply clang-format
2020-04-01 21:27:54 -07:00
Meng Xu
33c4be9c42
Improve debug message for debug mutations
2020-03-31 16:00:51 -07:00
Meng Xu
e286f316b9
Increase generated key length for splitMutation unit test
2020-03-31 14:27:07 -07:00
Meng Xu
b7da76223c
Fix a tricky splitMutation bug
...
splitMutation result may include the end key of a clearrange mutation
2020-03-31 13:38:58 -07:00
Meng Xu
ccbbdc4ba4
Unit test:Verify splitMutation by comparing with intersectingRanges result
2020-03-31 12:13:02 -07:00
Meng Xu
8a30526336
FastRestore:Remove commented assertion
2020-03-28 13:11:32 -07:00
Meng Xu
404a3e2619
FastRestore:Loader:Remove sanity chech for the order of sending log and range mutations
2020-03-27 23:36:13 -07:00
Meng Xu
97f8e46388
Sanity check subversion for log mutations
2020-03-27 13:07:08 -07:00
Jingyu Zhou
99f4ef6e0c
Fix restore loader to handle mutation sub number
...
For old backup format, give them a sub sequence number starting from 0 for each
commit version.
2020-03-26 13:04:00 -07:00
Jingyu Zhou
4bdb32be14
Batch sending all mutations of a version from RestoreLoader
...
This optimization is to reduce the number of messages sent from loader to
applier, which was unintentionally done when introducing sub sequence numbers
for mutations.
2020-03-20 20:15:09 -07:00
Jingyu Zhou
799f0b4b0e
Small code refactor
2020-03-20 20:15:09 -07:00
Jingyu Zhou
e40f937d3a
Fix missing mutations in splitMutation
...
When a range mutation is larger than the last split point, this mutation can
become missing in the RestoreLoader, which is fixed in this commit.
2020-03-20 20:15:09 -07:00