29cf5f1fbf
Fix an ASSERT when an fdbcli command times out ( #6857 )
...
* Re-throw operation_cancelled
There's a few places in fdbcli where we don't rethrow operation
cancelled but wait on a future. It's very unusual that you don't want to
rethrow operation_cancelled.
* Update ASSERT
It's possible to get error_code_broken_promise here if the network has
already shutdown.
2022-04-14 12:09:25 -07:00
5861ff2dc6
Merge pull request #6717 from sfc-gh-ajbeamon/thread-future-safety-check
...
Disallow anonymous standalone thread futures in safeThreadFutureToFuture
2022-04-04 13:39:37 -07:00
75247affa3
Renamed member for better readability.
2022-03-30 13:39:33 -07:00
5d74e4d091
Added comments to explain some invariants with ThreadMultiCallback and ThreadCallback and how they are enforced.
2022-03-30 12:38:57 -07:00
e6457b1656
A few changes for clarity / readability.
2022-03-30 11:31:46 -07:00
01facc8dfa
Refactored callback tracking in ThreadCallback and ThreadMultiCallback to not use an unordered_map of pointers to prevent it from falsely triggering the DEBUG_DETERMINISM check, plus it is lower overhead, saving about 6% CPU in the AbortableSingleAssignmentVar unit test.
2022-03-29 21:13:13 -07:00
ce99f4ec30
Disallow anonymous thread futures in safeThreadFutureToFuture when those thread futures contain a standalone type.
2022-03-29 15:50:31 -07:00
a71099471b
Update copyright header dates
2022-03-21 13:36:23 -07:00
250a88e682
Enforce that trace event suppression calls happen first when using trace event call chaining. Fix various instances where we weren't following this requirement.
2022-02-24 12:25:52 -08:00
3afe9fb6e0
MVC bug fixes
2021-12-10 12:47:53 -06:00
0f2f5bc0b6
Cleanup of ThreadResult
2021-12-01 16:24:28 -06:00
7f4fcc8c2c
Added FDBResult and made readBlobGranules use it
2021-12-01 16:22:05 -06:00
d51b93390d
Proper handling of reset and transaction destruction. Add some comments.
2021-09-17 18:10:56 -06:00
2c788c233d
apply clang-format to *.c, *.cpp, *.h, *.hpp files
2021-08-27 17:07:47 -07:00
bf0d0598dc
Refactor all ThrottleAPI functions using template and remove duplicate copies
2021-08-11 23:59:25 +00:00
618c72f7e2
Draft to use template to rewrite ThrottleApi
2021-08-11 01:07:36 +00:00
ce4b2de6e7
Merge pull request #5290 from apple/anoyes/avoid-network-thread
...
Bring back optimization that avoids hop to network thread
2021-08-02 15:07:27 -07:00
1d64a53b34
Apply suggestions from code review
...
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-08-02 13:42:30 -07:00
ba13b86bff
Fix comment grammar (add a period)
2021-08-02 13:41:03 -07:00
1b1cd1e856
Fix releaseMemory deadlock and add comments
2021-08-02 13:37:09 -07:00
9eec9376bd
Merge pull request #5285 from sfc-gh-clin/refactor-throttle-command
...
Refactor throttle command
2021-07-28 13:43:15 -07:00
94a65865d9
Merge remote-tracking branch 'origin/master' into fix-clang-warnings
2021-07-28 12:29:27 -07:00
fa6fc0a0f2
Bring back optimization that avoids hop to network thread
2021-07-27 13:56:38 -07:00
d49bd6807f
Fix a comment typo in safeThreadFutureToFuture
2021-07-27 17:51:57 +00:00
507c1f11e3
Add .log() to bare TraceEvent() invocations without any .detail()s to avoid clang-tidy warning about immediate destruction of object without use.
2021-07-26 19:55:10 -07:00
e62e6503ac
Fix most delete-non-virtual-dtor clang warnings
2021-07-21 23:32:44 -07:00
23fc685518
Update flow/ThreadHelper.actor.h
...
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:36 -04:00
119a52c2e9
Update flow/ThreadHelper.actor.h
...
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:23 -04:00
1c2d4119c2
Update flow/ThreadHelper.actor.h
...
Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
2021-06-29 13:31:15 -04:00
1e0c233d40
Add some documentation for the onMainThread functions
2021-06-24 17:44:54 -04:00
73fdb55f4b
Add headers in new files
2021-05-06 16:43:56 -07:00
26569273b0
Update safeThreadFutureToFuture and remove the unnecessary wrapper
2021-04-22 19:34:49 -07:00
4fdfca0dc0
Update the thread-safe Future-to-ThreadFuture method, added two TSAN unit tests
2021-04-13 13:21:04 -07:00
60747a52a5
Add a thread-safe function that converts ThreadFuture into Future
2021-03-30 14:52:56 -07:00
df90cc89de
apply clang-format to *.c, *.cpp, *.h, *.hpp files
2021-03-10 10:18:07 -08:00
4669f837fa
Add uses of makeReference
2020-11-07 22:10:18 -08:00
ccf2ca73f3
Fix Windows CMake build
2020-10-08 23:58:58 -07:00
a3de8c333b
Use override where applicable in fdbclient
2020-10-07 16:57:38 -07:00
268ba0bddc
Merge remote-tracking branch 'origin/release-6.3' into merge-6.3
2020-10-01 14:14:06 -06:00
2d788b309f
Merge branch 'release-6.2' into release-6.3
...
# Conflicts:
# documentation/sphinx/source/api-error-codes.rst
# flow/ThreadHelper.actor.h
# flow/error_definitions.h
2020-09-24 17:16:58 -07:00
0ac08f6a9b
Replace NULL with nullptr in flow
2020-09-20 11:31:49 -07:00
01998a238f
Add blockUntilReadyCheckOnMainThread
2020-09-17 20:26:28 +00:00
f6412c9f82
Only throw if the future is not ready
2020-09-16 21:34:13 +00:00
0beab42b78
Add blocked_from_network_thread error
2020-09-15 16:49:12 +00:00
3c3943f64f
Disallow calling blockUntilReady from main thread
...
Also fix a data race that apparently hasn't been ported to 6.2 yet
2020-09-14 16:01:45 +00:00
81ac8211d1
Add comment
2020-09-10 08:32:52 -07:00
0e49542d59
Fix data race described in #3749
2020-09-05 13:58:22 -07:00
a49cb41de7
Merge branch 'release-6.3'
...
# Conflicts:
# CMakeLists.txt
# cmake/ConfigureCompiler.cmake
# fdbserver/Knobs.cpp
# fdbserver/StorageCache.actor.cpp
# fdbserver/storageserver.actor.cpp
# flow/ThreadHelper.actor.h
# flow/serialize.h
# tests/CMakeLists.txt
2020-07-29 00:31:55 -07:00
a88bbd6405
s/fake/declval/
2020-07-15 23:33:01 +00:00
99bf993815
Replace BOOST_NOEXCEPT with noexcept
2020-06-09 22:39:19 -07:00
Andrew Noyes