Commit Graph

737 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard 90ced244eb Fix -Wunused-but-set-variable warnings 2021-12-01 18:15:53 -08:00
Josh Slocum 1870e07ff4 Fixed pause racing with waitUntilHealthy 2021-11-29 14:19:15 -06:00
Evan Tschannen 964d0209ca
Merge pull request #5637 from sfc-gh-ljoswiak/features/data-loss-prevention
Data loss protection when joining new cluster
2021-11-15 15:26:32 -08:00
Ata E Husain Bohra 82c3e8bf79
Trigger buildTeam operation if server transition from unhealthy -> healthy (#5930)
* Trigger buildTeam operation if server transition from unhealthy -> healthy

DataDistribution actor helps in building teams as server count changes
(add/removal), however, it is possible that total_healthy_server count
is insufficient to allow team formation. If happens, even healthy server
count recover, the buildTeam operation will not be triggered.

Patch proposal is to trigger `checkBuildTeam` operation if server
transitions from unhealthy -> healthy state. Incase system already
has created enough teams (desiredTeamCount/maxTeamCount), the operation
incurs a very minimal cost.
2021-11-12 09:41:01 -08:00
Lukas Joswiak 15e0d5b29f Add explicit transaction options when reading cluster ID 2021-11-09 12:29:49 -08:00
Lukas Joswiak 3988b11fd6 Cleanup 2021-11-09 12:29:48 -08:00
Lukas Joswiak 30867750b5 Add protection against storage and tlog data deletion when joining a new cluster 2021-11-09 12:29:47 -08:00
sfc-gh-tclinkenbeard 30cef51746 Improve tracing in ddSnapCreateCore 2021-11-04 12:59:50 -07:00
sfc-gh-tclinkenbeard d0c9cf4fb0 Enable mismatched-tags clang warning 2021-11-01 14:18:31 -07:00
Xiaoxi Wang e4fd0023b7 don't disable machine team remover 2021-10-27 09:08:37 -07:00
Xiaoxi Wang 75ef854563 format 2021-10-27 09:08:37 -07:00
Xiaoxi Wang db7ee9d389 disable team remover 2021-10-27 09:08:37 -07:00
Xiaoxi Wang 14fa32f208 change boolean 2021-10-27 09:08:37 -07:00
Xiaoxi Wang 1a2a838df3 add knob 2021-10-27 09:08:37 -07:00
Xiaoxi Wang c320391c4c restartRecruiting 2021-10-27 09:08:37 -07:00
Xiaoxi Wang dc630d63bd add asyncvar 2021-10-27 09:08:37 -07:00
Xiaoxi Wang 654c0a1f14 format 2021-10-27 09:08:37 -07:00
Xiaoxi Wang 8a10966126 wait extra time 2021-10-27 09:08:37 -07:00
Xiaoxi Wang d1959122af consider wiggling when waitUntilHealthy 2021-10-27 09:08:37 -07:00
Xiaoxi Wang 69190ed04e format 2021-10-27 09:08:37 -07:00
Xiaoxi Wang 0053b4793e change knob and delete redundant doBuildTeam 2021-10-27 09:08:37 -07:00
Xiaoxi Wang db7b48b71c wiggling teams calculation replace 2021-10-27 09:08:37 -07:00
Xiaoxi Wang 3a6359e202 minus wiggling teams when build team 2021-10-27 09:08:37 -07:00
He Liu 16ae2b76e5 Merge branch 'master' of https://github.com/apple/foundationdb into clean-sim-test-data-loss 2021-10-21 09:16:53 -07:00
Trevor Clinkenbeard 504d0b71b2
Fix invalid memory access when dataDistribution actor is cancelled (#5791)
* Fix valgrind error when dataDistribution actor is cancelled

* Trace Sev30 when dataDistribution actor is cancelled outside of simulation

* Rethrow actor_cancelled error in dataDistribution catch block
2021-10-18 14:21:29 -07:00
He Liu dbfeb06c97 Reproduced user data loss incident, and tested the improved exclude tool
can fix the system metadata.
2021-10-14 14:08:39 -07:00
Steve Atherton f339b603a5 Bug fix: printSnapshotTeamsInfo() could crash when looking up status for a storage server that was very recently added because its entry in server_status was not yet created.
Bug fix:  printSnapshotTeamsInfo()'s local server_status map would not see status updates for server UIDs that already existed in the map.
2021-10-10 01:48:31 -07:00
Neethu Haneesha Bingi 3ea7209013 Simulation changes to randomly wiggle with locality filter and review comments. 2021-09-30 10:00:33 -07:00
Neethu Haneesha Bingi 3e79299898 Locality filter support to perpetual storage wiggler feature. 2021-09-30 10:00:33 -07:00
Chang Liu f50a3f08de Fix format problem for file fdbserver/DataDistribution.actor.cpp.
Description

Testing
2021-09-24 15:40:17 -07:00
Chang Liu 8761960cdc fix roll trace event issue for data distribution(master)
Description

Testing
2021-09-24 15:40:17 -07:00
Chang Liu 731c1fffac fix roll trace event issue for data distribution(master)
Description

Testing
2021-09-24 15:40:17 -07:00
Chang Liu 814e3c729f fix roll trace event issue for data distribution(master)
Description

Testing
2021-09-24 15:40:17 -07:00
Chang Liu c10dd0df4b fix roll trace event issue for data distribution
Description

Testing
2021-09-24 15:40:17 -07:00
He Liu a1f6dcc2d5 merge from master 2021-09-22 13:07:38 -07:00
Xiaoxi Wang 1730d75f73 change configure test
add store type check
add test file
2021-09-21 18:11:04 -07:00
He Liu 2246a0bee7 switch to plain random selection 2021-09-20 11:23:54 -07:00
He Liu 4d5bf08da8 address comments 2021-09-19 17:03:06 -07:00
Xiaoge Su abf73047ca Enforce std:: specifier rather than using namespace 2021-09-16 19:40:28 -07:00
He Liu ef7fdc0781 fmt 2021-09-15 10:32:09 -07:00
He Liu c8a3413820 exclude to-be-dropped server from the random team 2021-09-15 09:07:50 -07:00
helium fd6d088945 choose team before removing server 2021-09-14 19:24:59 -07:00
helium 7e53f8662d added comments 2021-09-13 13:28:55 -07:00
helium 8e0b572a18 Added comments. 2021-09-02 22:29:07 -07:00
helium 6612cc00b6 Check if the src server list will be empty before removing a failed server." 2021-09-01 14:52:07 -07:00
Trevor Clinkenbeard 66df75c570
Merge pull request #5385 from sfc-gh-tclinkenbeard/debug-dd
Capture deep copy of `machine_info` in `printSnapshotTeamsInfo`
2021-08-20 13:25:50 -07:00
sfc-gh-tclinkenbeard 9458a6975d Remove std::map::at usage from DataDistribution.actor.cpp 2021-08-20 12:35:26 -07:00
sfc-gh-tclinkenbeard 556e4bc283 Add assertion to overlappingMachineMembers 2021-08-13 14:56:22 -07:00
sfc-gh-tclinkenbeard a0a4207ce2 Capture deep copy of machine_info in printSnapshotTeamsInfo 2021-08-13 12:13:54 -07:00
sfc-gh-tclinkenbeard 3f0e07d79c Remove dead code 2021-08-13 09:54:02 -07:00