d35445a868
enforce include modularization in cmake
2022-06-23 14:37:35 -06:00
00b805d8e0
fixup! Reformat source
2022-06-14 10:43:13 -07:00
e493f1c3cd
fixup! Add a retry mechanism in changeQuorumChecker and changeQuorum
...
This is to fix an issue when recovery and change coordinator key happens
together. The issue will occur when:
1. Recovery starts
2. Coordinator key change transaction started
3. During the recovery the coordinator key is read from cluster file and
stored in the storage server
4. The cluster controller received `ChangeCoordiatorsRequest`, and
updated the cluster name with the new value.
at this stage, the value related to coordinator key in storage server and
the worker is inconsistent.
5. changeQuorumChecker is called, which will verify such consistency.
Since they are different, the call is returning failure and the
caller, which could be a TEST_CASE, fails.
This is a rare race issue, and it is also noticed that when the
recovery/coordinator key change process is done, the database is in a
proper state which allows changeQuorumChecker behave properly. In this
case, a retry mechanism should be sufficiently fix corresponding test
failures.
2022-06-14 10:43:13 -07:00
d6920cde28
Implemented blob granule merging
2022-06-09 10:50:53 -05:00
fd35fde481
Merge branch 'main' of https://github.com/apple/foundationdb into readaware
2022-05-23 15:09:03 -07:00
df4e0deb4d
coordinatorsKey should not always store IP addresses. ( #7204 )
...
* coordinatorsKey should not storing IP addresses.
Currently, when we do a commit of coordinator change, we are always converting hostnames to IP addresses and store the converted results in coordinatorsKey (\xff/coordinators). This result in ForwardRequest also sending IP addresses, and receivers will update their cluster files with IPs, then we lose the dynamic IP feature.
* Remove the legacy coordinators() function.
* Update async_resolve().
ip::basic_resolver::async_resolve(const query & q, ResolveHandler && handler) is deprecated.
* Clean code format.
* Fix typo.
* Remove SpecifiedQuorumChange and NoQuorumChange.
2022-05-23 11:42:56 -07:00
69985ba251
Merge branch 'main' of https://github.com/apple/foundationdb into readaware
2022-05-02 10:53:22 -07:00
c69a07a858
Check in the new Hostname logic. ( #6926 )
...
* Revert #6655 .
20220407-031010-renxuan-c101052c21da8346 compressed=True data_size=31004844 duration=4310801 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=1:04:15 sanity=False started=100047 stopped=20220407-041425 submitted=20220407-031010 timeout=5400 username=renxuan
* Revert #6271 .
20220407-051532-renxuan-470f0fe6aac1c217 compressed=True data_size=30982370 duration=3491067 ended=100002 fail_fast=10 max_runs=100000 pass=100002 priority=100 remaining=0 runtime=0:59:57 sanity=False started=100141 stopped=20220407-061529 submitted=20220407-051532 timeout=5400 username=renxuan
* Revert #6266 .
Remove resolving-related functionalities in connection string. Connection string will be used for storing purpose only, and non-mutable.
20220407-175119-renxuan-55d30ee1a4b42c2f compressed=True data_size=30970443 duration=5437659 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=0:59:31 sanity=False started=100154 stopped=20220407-185050 submitted=20220407-175119 timeout=5400 username=renxuan
* Add hostname to coordinator interfaces.
* Turn on the new hostname logic.
* Add the corresponding change in config txns.
The most notable change is before calling basicLoadBalance(), we need to call tryInitializeRequestStream() to initialize request streams first.
Passed correctness tests.
* Return error when hostnames cannot be resolved in coordinators command.
* Minor fixes.
2022-04-27 21:54:13 -07:00
0639810b66
merge upstream/main
2022-04-22 11:09:15 -07:00
6c9ff6ee5e
Add sharded rocksdb type ( #6862 )
...
* add-sharded-rocksdb-type
* address comments
Co-authored-by: Zhe Wang <zhewang@Zhes-MacBook-Pro.local>
2022-04-21 22:53:14 -04:00
61a1f7683b
fix dd command line read special key space error
2022-04-11 22:49:21 -07:00
dd15489605
rename ssd-rocksdb-experimental as ssd-rocksdb-v1.
2022-03-29 10:53:38 -07:00
f27475e2f4
Merge branch 'main' into blob_integration
2022-03-22 11:41:58 -05:00
a71099471b
Update copyright header dates
2022-03-21 13:36:23 -07:00
37e7c80f26
Merge branch 'main' into blob_integration
2022-03-17 18:45:42 -05:00
62f547ff6e
Add line before actorcompiler.h include (to prevent IDE from reordering includes)
2022-03-16 14:15:48 -07:00
66d71e107d
Move actorcompiler.h include to the end of includes
2022-03-16 00:09:16 -07:00
e71b3533f9
Merge branch 'main' into blob_integration
2022-03-09 08:59:56 -06:00
6a2e54d955
Rename OPTIONAL to avoid windows macro conflict
2022-03-08 13:45:29 -08:00
72a34945ce
Add the ability to disable tenants. Server processes verify the ID of tenants being read or written.
2022-03-06 21:54:21 -08:00
5fa9d3e1b7
Add a tenant parameter to read and commit requests. Store a map of all tenants on commit proxy and storage servers. Add an option to require tenant mode.
2022-03-06 21:54:21 -08:00
36435af4f5
Add support for a limits hint in special keys. Fix a typo and resolve some comment formatting weirdness.
2022-03-06 21:52:39 -08:00
1a5bf25b5c
Update code base to use fmt 8.1.1
2022-03-04 15:52:06 -08:00
233c918ffb
Replace printf() and fprintf() with fmt::print().
2022-02-25 19:06:57 -08:00
f7eb66441d
Try eliminating warnings in macOS and Windows CI builds.
...
MacOS warnings are format warnings, e.g., `format specifies type 'long' but the argument has type 'Version' (aka 'long long')`.
Windows warnings are `ACTOR does not contain a wait() statement`.
2022-02-25 19:06:57 -08:00
06b1d06d38
Support hostname in coordinators commands.
2022-02-24 23:02:29 -08:00
70d723f70c
Move the construction of ConnectionString in changeQuorumChecker() to coordinatorsCommitActor().
2022-02-24 23:02:29 -08:00
250a88e682
Enforce that trace event suppression calls happen first when using trace event call chaining. Fix various instances where we weren't following this requirement.
2022-02-24 12:25:52 -08:00
59ac1dffb4
change storage_migration_mode to storage_migration_type
2022-02-22 09:36:30 -08:00
38a75a8b89
Merge branch 'main' into blob_integration
2022-02-17 17:47:38 -06:00
8418cb2839
Mark various externally exposed system transactions as read/access system keys. Also adjust a few lock aware declarations to read lock aware.
2022-01-27 13:58:33 -08:00
2227fc2943
Fix a bug in getDesiredCoordinators().
...
When no workers are chosen, we should return 0 coordinators.
2021-12-15 10:42:28 -08:00
cb568bbd55
Add watch on config key.
2021-12-10 14:00:34 -06:00
037b30fbde
Clang format.
2021-12-03 10:01:49 -08:00
2725183b26
Don't include an unreliable process in the protected list.
2021-12-03 09:44:52 -08:00
464d9488ef
Merge remote-tracking branch 'origin/master' into fix-unused-warnings
2021-12-01 23:52:09 -08:00
90ced244eb
Fix -Wunused-but-set-variable warnings
2021-12-01 18:15:53 -08:00
ec64890ac1
Remove some usages of PRId64 by using fmt library
2021-11-30 23:35:36 -08:00
c53f5aa110
Renamed redwood to redwood-1-experimental and file extension to .redwood-v1.
2021-11-16 02:15:22 -08:00
6f7558b8ea
Merge branch 'master' of https://github.com/apple/foundationdb into feature-range-feed
...
# Conflicts:
# tests/CMakeLists.txt
2021-10-24 21:06:33 -07:00
e882eb33fc
Abstract the cluster file into a cluster connection record that can be backed by something other than the filesystem.
2021-10-22 11:05:18 -07:00
3f7df58a77
fixed a number of issues
2021-10-19 13:56:52 -07:00
3ea7209013
Simulation changes to randomly wiggle with locality filter and review comments.
2021-09-30 10:00:33 -07:00
3e79299898
Locality filter support to perpetual storage wiggler feature.
2021-09-30 10:00:33 -07:00
65956ae6b7
Refactor configure command; refactor changeConfig to template code to reuse existing tests
2021-09-21 10:06:04 -07:00
abf73047ca
Enforce std:: specifier rather than using namespace
2021-09-16 19:40:28 -07:00
e7d3516084
solve comments
2021-09-14 11:04:02 -07:00
9992a7b33f
Added StorageMigrationType and cli commands
2021-09-14 09:55:41 -05:00
8ed041132f
Rewrite cache_range related functions to template code; Remove duplicate code; fix the existing bug in cache_range;
2021-08-20 13:42:50 -07:00
f596a81073
Rename ::TRUE and ::FALSE in BooleanParams to ::True and ::False so as to not conflict with the TRUE and FALSE macros provided by the Windows and MacOS SDKs.
2021-07-17 00:11:40 -07:00
2abdbff11f
add Knobs
2021-07-12 05:33:23 +00:00
8cc40e3a2b
Expand use of BOOLEAN_PARAM
2021-07-02 21:41:50 -07:00
f9d7c874ac
Fix invalid read
2021-07-01 21:40:02 -07:00
decfb610ff
Minor review comments.
2021-06-25 15:04:49 -07:00
66f2518405
exclude to work with any locality data match.
2021-06-23 18:03:27 -07:00
cbe714acd0
Status json schema update, includelocalities back for consistency check, review comments.
2021-06-23 18:03:27 -07:00
4ad5926a25
Snake naming of keys and added comments to all new functions.
2021-06-23 18:03:27 -07:00
73752f441b
exclude locality:clang-format, ranged loops, documentation, tracking addStoragesever for exclusion.
2021-06-23 18:03:27 -07:00
62355571d0
exclude servers based on locality match
2021-06-23 18:03:27 -07:00
371a38e6e5
Merge remote-tracking branch 'origin/master' into remove-extra-copies
2021-06-07 10:26:06 -07:00
fbe96939ba
Avoid likely use after destruction
...
This manifested in UBSAN as use of an invalid vptr, which usually means
use after destruction. Give shared ownership to the getDesired actor to
avoid use after destruction. It is not clear to me when this doesn't
seem to manifest as a heap-use-after-free in e.g. ASAN or valgrind.
2021-06-04 09:54:06 -07:00
d67184163b
Merge pull request #4556 from sfc-gh-jslocum/tss
...
Testing Storage Server
2021-06-01 09:11:10 -07:00
4a753a0bce
Merge pull request #4623 from dlambrig/issue4252
...
CDs reject requests using different connection descriptor
2021-05-28 10:45:51 -07:00
10289ef8f1
Respond to AJs comments
2021-05-27 09:14:32 -04:00
64c10d3625
fix joshua failures, formatting
2021-05-27 08:08:07 -04:00
fcfb78162c
misc cleanup for publishing
2021-05-27 08:08:07 -04:00
742c22cef2
Don't allow changing desriptor if knob is set
2021-05-27 08:08:07 -04:00
4257ac2b4d
More TSS Changes/Fixes
2021-05-25 20:37:48 +00:00
ce82c9653e
Testing Storage Server implementation
2021-05-25 20:28:50 +00:00
8b1f9f7337
Add command line support
2021-05-17 20:57:54 +00:00
f28ac955c3
Remove unnecessary temporary objects while growing objects of type std::vector<std::pair<A, B>>
2021-05-10 16:32:50 -07:00
5c2d7b6080
Create RangeResult type alias
2021-05-03 13:14:16 -07:00
df90cc89de
apply clang-format to *.c, *.cpp, *.h, *.hpp files
2021-03-10 10:18:07 -08:00
79cec09255
Apply clang-tidy's performance-inefficient-vector-operation fix
...
I ran this command in my build directory after compiling with
OPEN_FOR_IDE. It took a few small tweaks to get it to compile, which is
outside the scope of this commit.
$ python run-clang-tidy.py -j $(nproc) -checks='-*,performance-inefficient-vector-operation' -fix
2021-03-04 03:58:25 +00:00
e9b7e22e02
Merge branch 'rel-6.3'
2021-02-22 08:47:22 -08:00
e49cc68bbc
Merge branch 'rel-6.2' into rel-6.3
2021-02-21 00:15:31 -08:00
9fb396e372
Merge pull request #4255 from sfc-gh-clin/add-coordinators-into-special-keys
...
Add coordinators into special keys
2021-02-18 18:26:07 -08:00
af77fae131
Fix bug in code I recently added where the process name memory was not long-lived and was later used.
2021-02-18 18:33:23 +00:00
bcd9a00a50
Backport #4285 and 1513df22f3 to release-6.2
...
Fixes #4342
2021-02-17 00:35:25 +00:00
731ee8a121
Update ChangeConfig to test coordinators special keys
2021-02-16 13:01:37 -08:00
76a4293d1d
Merge branch 'release-6.3'
...
# Conflicts:
# fdbserver/fdbserver.actor.cpp
2021-02-15 02:13:06 -08:00
5b74556733
Fix bug in code I recently added where the process name memory was not long-lived and was later used.
2021-02-10 10:46:02 -08:00
3def9731a4
Merge branch 'master' of github.com:apple/foundationdb into add-coordinators-into-special-keys
2021-02-08 18:52:45 -08:00
be57b70dbb
Fix function call where the signature changed
2021-02-08 14:00:47 -08:00
aaf0a9aa7b
Merge branch 'release-6.3' into merge-release-6.3-into-master
...
# Conflicts:
# build/docker-compose.yaml
# cmake/ConfigureCompiler.cmake
# fdbclient/FileBackupAgent.actor.cpp
# fdbrpc/AsyncFileCached.actor.h
# fdbrpc/IAsyncFile.h
# fdbrpc/IRateControl.h
# fdbrpc/simulator.h
# fdbserver/KeyValueStoreSQLite.actor.cpp
# fdbserver/storageserver.actor.cpp
# fdbservice/ServiceBase.cpp
2021-02-08 12:58:34 -08:00
84be77958e
Add a simulator guard
2021-02-05 22:47:49 -08:00
53d8bd5799
If a quorum change has to retry, it's possible that one of our previously chosen coordinators could be rebooting.
2021-02-05 22:36:54 -08:00
5c4863b33e
Fix unit test that set coordinators to fake processes that the simulator didn't know about
2021-02-05 22:07:40 -08:00
618585f9dd
Fix a bug in simulated coordinator selection that could allow an unreliable process to be chosen as coordinator despite the intent that this not happen.
2021-02-05 15:59:14 -08:00
766de6574a
Add trace
2021-01-29 15:32:53 -08:00
5a62e0c084
Fix repeated code usage
2021-01-29 12:20:30 -08:00
e1182f2f86
Add coordinators to special keys
2021-01-29 11:45:52 -08:00
d64cf8b9e3
Merge branch 6.3 into master
2020-11-17 11:22:45 -08:00
cc13ef08bd
Sort the failed sets before modifying them in attempts to make changes consistent
2020-11-12 16:26:34 -05:00
0718329705
Make getDesiredClusterKeyName const
...
This fixes a virtual function overload in NameQuorumChange
2020-10-15 10:39:38 -07:00
ccf2ca73f3
Fix Windows CMake build
2020-10-08 23:58:58 -07:00
a9607bdcec
Explicitly seal classes that inherit but aren't inherited from
2020-10-07 21:58:24 -07:00
a3de8c333b
Use override where applicable in fdbclient
2020-10-07 16:57:38 -07:00
c7a55fe15f
Merge pull request #3829 from yliucode/process-class
...
Support specifying proxy as process class and converting it to commit proxy
2020-09-30 16:46:24 -07:00
0c579674e6
Add more help messages for configuring 'proxies'
2020-09-30 13:29:01 -07:00
c34385ef7b
Support proxy process class
2020-09-30 01:23:10 -07:00
6c726ba8dd
Improve ConfigurationResult and CoordinatorsResult type safety
2020-09-27 15:29:15 -07:00
3278e21b0b
Change description of GRV proxy and Commit proxy in docs and add backward compatibility support for configuring proxies in fdbcli
2020-09-25 10:50:48 -07:00
cf69f455a9
Merge pull request #3785 from apple/release-6.3
...
Merge Release 6.3 to master
2020-09-17 14:43:56 -07:00
cc5bc16bd8
Rename more places from proxy to commit proxy
2020-09-15 22:29:49 -07:00
35bef73a1c
Rename proxy to commit proxy
2020-09-10 17:44:15 -07:00
1155d015c9
fetch current log generation as well
2020-09-09 11:54:58 -07:00
79ce16650d
merge master branch
2020-08-11 19:22:10 -07:00
d6a23a4d6b
Resolve comments to make GRV proxy a separate process class
2020-08-06 00:01:57 -07:00
b682ad75f9
Fix a memory bug, change \xff\xff/management/options/exclude/force to .../excluded/force
2020-08-05 13:18:39 -07:00
df4beb629e
fix the bug where we call old \xff\xff/conf special keys
2020-07-31 13:28:24 -07:00
db8bb69196
Solve conflicts from master
2020-07-30 19:02:19 -07:00
f2662a9a74
Merge remote-tracking branch 'upstream/master' into add-management-api-into-special-key-space
2020-07-30 19:01:11 -07:00
fad18ad85a
Remove more debug traces
2020-07-29 08:06:15 -07:00
30ea639666
Remove debug traces
2020-07-29 07:55:05 -07:00
f7b76a92af
pass joshua
2020-07-29 07:26:55 -07:00
a2089b354a
RemoveServersSafely:Safety check toKill1 to avoid cluster getting stuck
...
toKill1 and toKill2 are a random subset of all processes. If simply kill all processes in toKill1 or toKill2,
we may kill too many processes to make the cluster unavailable and stuck.
Similar as what toKill2 were modified if it can cause cluster unavailable,
we should do the same thing for toKill1
2020-07-28 21:07:31 -07:00
27a7a28fc5
Change to ryw in checkForExcludingServers
2020-07-28 13:40:14 -07:00
8a5fde1b85
change SPECIAL_KEY_SPACE_CHANGE_CONFIGURATION to SPECIAL_KEY_SPACE_ENABLE_WRITES
2020-07-28 12:03:00 -07:00
1826ac75d5
Add some trace events to debug
2020-07-25 18:16:08 -07:00
ff4bae5cd3
Fix status test
2020-07-23 12:04:02 -07:00
0d4fd085d1
Add some extra braces to for and if statements
2020-07-21 09:19:19 -07:00
abaae40453
Modified ComposedIdentifier to prevent file identifier conflicts at
...
compile-time
2020-07-20 18:52:44 -07:00
1e5096990e
Add the function to return the special key for given management api command and option
2020-07-17 12:32:42 -07:00
96e5a4c827
Replace all \xff\xff/conf with managementApiRange.begin
2020-07-17 11:56:27 -07:00
5fa6785fb8
Add special keys for command options
2020-07-16 18:15:35 -07:00
3593ceffde
Add back previous implementation code for versioning
2020-07-14 12:38:06 -07:00
1635e8e0ba
using special keys in management api for include when api_version >= 700
2020-07-14 10:31:19 -07:00
4d7e573469
using special keys in management api for exclude when api_version >= 700
2020-07-14 09:52:38 -07:00
b0b601478c
Add TODO comments
2020-07-13 13:34:15 -07:00
2a434791ad
Exposing transaction based function to get excluded and failed server addresses
2020-07-13 10:28:34 -07:00
407985e142
Revert separating excluding function into excluded and failed
2020-07-13 10:25:36 -07:00
b8251878c4
Separating two functions for excluded and failed list. Exposing transaction based interface from Management Api
2020-07-12 10:41:46 -07:00
5f6093b59e
Add an option to enable write in special key space, which is by default not allowed
2020-07-08 15:49:34 -07:00
784d0f6d00
A basic feasible version for exclude and include commands
2020-07-06 11:02:48 -07:00
96206a8032
Merge pull request #3368 from apple/release-6.3
...
Merge Release 6.3 to master
2020-06-15 20:15:22 -07:00
acbfe2e4c9
Revert "Revert "Initial RocksDB""
2020-06-15 12:45:36 -04:00
9cd1614c82
Revert "Initial RocksDB"
2020-06-11 15:29:46 -07:00
cf13e00a8f
Merge remote-tracking branch 'origin/release-6.3' into fdb_cache_wo_allocator
2020-06-01 17:38:31 -07:00
8731700d80
Merge remote-tracking branch 'upstream/release-6.3' into rocksdb-6.3
2020-05-27 20:02:25 +00:00
ced65cd30b
finished explicitly versioning everything stored in the database
2020-05-22 17:14:21 -07:00
5d361fe532
Copy/paste rebase onto 6.3
2020-05-22 15:02:51 +00:00
3a8efb2d0b
Added advanceversion command to fdbcli
2020-05-20 15:47:31 -07:00
dd033736ed
Merge branch 'master' into fdb_cache_subfeature2
2020-05-04 17:29:43 -07:00
93400d25c8
Added advanceversion command to fdbcli
2020-04-15 20:01:01 -07:00
927282771a
Update fdbclient/ManagementAPI.actor.cpp
...
Co-Authored-By: Trevor Clinkenbeard <trevorclinkenbeard@gmail.com>
2020-04-13 12:17:54 -07:00
acaf91ac47
Merge branch 'master' into fdb_cache_subfeature2
2020-03-26 13:33:08 -07:00
abd03ba998
Clear the range correctly when adding/deleting a cache range.
2020-03-17 17:13:44 -07:00
7f559bc712
Cleanup code and apply clang-format
...
Self code review
2020-03-16 15:08:32 -07:00
1513df22f3
AutoQuorumChange:Exclude unreliable node from coordinator in simulation
2020-03-16 14:39:25 -07:00
Markus Pilman