Commit Graph

338 Commits

Author SHA1 Message Date
Jingyu Zhou 5cd3dad986
Merge pull request #3409 from sears/assert_strings
Print out the text (to stderr and as trace) of the failed condition o…
2020-06-24 14:58:12 -07:00
Russell Sears 422003df34 Print out the text (to stderr and as trace) of the failed condition on assert failure 2020-06-24 14:21:48 -07:00
A.J. Beamon 3c684313db Merge branch 'release-6.2' into merge-release-6.2-into-release-6.3
# Conflicts:
#	documentation/sphinx/source/release-notes.rst
#	fdbserver/Status.actor.cpp
#	fdbserver/storageserver.actor.cpp
2020-06-16 13:06:29 -07:00
A.J. Beamon c00e6e7ad9 Reorder call to setting up watch future with waiting for data->version to advance to avoid missing potential mutations. Also add tests for and fix the case where reading the value throws a transaction_too_old error. 2020-06-05 11:24:47 -07:00
A.J. Beamon 2f85ee360a Watches could return future_version errors unnecessarily 2020-06-04 17:18:25 -07:00
Evan Tschannen 5013bc9106 fixed client compile issues; reduced the size of storage server interface 2020-05-18 17:20:15 -07:00
A.J. Beamon d3f465fd56
Merge pull request #3102 from mpilman/features/trace-roles
Emit traces regularly about role assignment
2020-05-15 08:12:25 -07:00
Markus Pilman eaaceab845 fixed compiler issues 2020-05-14 13:48:19 -07:00
Markus Pilman c2bc75516f Merge branch 'release-6.3' of github.com:apple/foundationdb into features/trace-roles 2020-05-14 10:34:53 -07:00
A.J. Beamon e0526e0095 Add busiest read tags to storage server status 2020-05-12 15:49:40 -07:00
A.J. Beamon 4f3f70e0c5 Fix: BusiestReadTag was logged before the first interval 2020-05-12 14:12:02 -07:00
Evan Tschannen c90ff6a6c3 revert loadBalanceDelay because it hurts read performance 2020-05-11 18:17:57 -07:00
Evan Tschannen dbdf6ddbd7 removed an unnecessary try/catch 2020-05-09 16:00:36 -07:00
Evan Tschannen f298436db7 made the style consistent 2020-05-09 15:17:22 -07:00
Evan Tschannen d497910fa2 fixed merge conflict 2020-05-09 13:34:51 -07:00
Evan Tschannen 69affebe40 merge master 2020-05-09 13:29:18 -07:00
Evan Tschannen 2dfae85dc7 the delay for reads is about 15% of the total cost of the read, so start multiple reads with the same delay 2020-05-09 13:26:38 -07:00
Evan Tschannen a4fc593a3a refactored some actors in the storage server to improve performance 2020-05-08 21:08:52 -07:00
Markus Pilman 5f9b127e56 Emit traces regularly about role assignment
We are currently emitting Role transition traces when a role starts and
when it ends. While this is useful for debugging, it doesn't work well
with tools that inject data and might potentially miss some trace lines.

We do decorate each trace lines with the roles assigned to that
particular process, however, this is not sufficient for tools that can
make use of the UID -> Role mapping
2020-05-08 16:27:57 -07:00
A.J. Beamon b1055a8501 Merge branch 'master' into transaction-tagging 2020-05-05 16:03:39 -07:00
Evan Tschannen f329164fb4
Merge pull request #2532 from dongxinEric/feature/hot-read-key-detection-part-2
Feature/hot read key detection part 2
2020-05-05 14:33:34 -07:00
Evan Tschannen b68980d686
Merge pull request #2028 from negoyal/cache_storageq_results
Cache storageq results
2020-05-04 11:27:02 -07:00
A.J. Beamon 36454bb3b8 Merge branch 'master' into transaction-tagging
# Conflicts:
#	fdbclient/MasterProxyInterface.h
#	fdbclient/NativeAPI.actor.cpp
2020-05-04 10:23:25 -07:00
A.J. Beamon bb3d4b6b89 Add a bunch of TEST macros and some other little things 2020-05-04 10:11:36 -07:00
negoyal 4fa04c5891 Fixed a corruptionbug. 2020-05-02 09:22:15 -07:00
Evan Tschannen aed2d34bcb Merge branch 'master' into feature-proxy-load-balance
# Conflicts:
#	fdbclient/NativeAPI.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	flow/Knobs.cpp
2020-05-01 09:19:39 -07:00
A.J. Beamon 41c517a5dd Merge branch 'master' into transaction-tagging
# Conflicts:
#	fdbclient/NativeAPI.actor.cpp
2020-04-27 13:05:24 -07:00
A.J. Beamon 9bf5c06d15 Adjust and knobify cost function for ops on the storage server 2020-04-22 14:39:32 -07:00
negoyal 2fa7d485f5 Merge branch 'master' into cache_storageq_results 2020-04-21 17:28:17 -07:00
A.J. Beamon 6619a1a36a Rename transaction tag map. 2020-04-17 09:06:45 -07:00
Xin Dong 7dd7406c59
Merge branch 'master' into feature/hot-read-key-detection-part-2 2020-04-16 14:54:05 -07:00
A.J. Beamon 0fba8c47be Checkpoint: Ratekeeper sets absolute limits for tag throttles and enforces them by distributing requests to proxies, who distribute them to clients.
A few refactorings.
2020-04-16 14:43:22 -07:00
A.J. Beamon 6508c891fc Make the TagSet sent to the storage servers optional so we can distinguish no tags from unsampled. 2020-04-10 13:29:28 -07:00
A.J. Beamon 29b2c2f3aa Add hash to StringRef. Use unordered maps for storing tags. Create some helpful typedefs. 2020-04-10 12:54:59 -07:00
A.J. Beamon ebeca10bce Change the serialization of tags sent in some messages. Add communication of the sampling rate from cluster to clients. 2020-04-09 16:55:56 -07:00
Balachandar Namasivayam 73272fc72e Version difference is now the diff between TLog versions and SS version. 2020-04-03 19:04:43 -07:00
Balachandar Namasivayam ad1dd4fd9b Mark the storage servers that are continually lagging as unhealthy and so this will give the Data Distributor the chance to move data out of this server. 2020-03-31 18:25:39 -07:00
A.J. Beamon 26b7e02d4c Some initial work to support tagging transactions and passing them around. 2020-03-20 11:23:11 -07:00
Evan Tschannen 96258b9809 Merge branch 'release-6.2'
# Conflicts:
#	documentation/sphinx/source/release-notes.rst
#	fdbcli/fdbcli.actor.cpp
#	fdbclient/ManagementAPI.actor.cpp
#	fdbrpc/FlowTransport.actor.cpp
#	fdbserver/ClusterController.actor.cpp
#	fdbserver/DataDistribution.actor.cpp
#	fdbserver/DataDistribution.actor.h
#	fdbserver/DataDistributionQueue.actor.cpp
#	fdbserver/KeyValueStoreMemory.actor.cpp
#	fdbserver/MasterProxyServer.actor.cpp
#	fdbserver/QuietDatabase.actor.cpp
#	fdbserver/SkipList.cpp
#	fdbserver/StorageMetrics.actor.h
#	fdbserver/TLogServer.actor.cpp
#	fdbserver/fdbserver.actor.cpp
#	fdbserver/storageserver.actor.cpp
#	fdbserver/workloads/KVStoreTest.actor.cpp
#	flow/CMakeLists.txt
#	flow/Knobs.cpp
#	flow/Knobs.h
#	flow/genericactors.actor.cpp
#	flow/serialize.h
2020-02-21 19:09:16 -08:00
A.J. Beamon 5586e6f6d8
Merge pull request #2697 from etschannen/feature-correctness-fixes
A variety of correctness fixes
2020-02-20 13:32:18 -08:00
Evan Tschannen 4326984b1d fix: wait metrics can take a really long time to detect that two shards have been merged into one if both shards are assigned to the same team. Additional information should be added to the request to improve this. 2020-02-19 15:20:38 -08:00
Meng Xu 132f5aa9ba FastRestore:Improve trace name and cosmetic change 2020-02-18 16:41:19 -08:00
A.J. Beamon 60f6b928f6 Slight reorganization of code to make it clearer. 2020-02-12 14:07:02 -08:00
A.J. Beamon 529200018a Merge branch 'release-6.2' into fix-reverse-range-read-byte-limit-bug
# Conflicts:
#	documentation/sphinx/source/release-notes.rst
2020-02-10 12:23:52 -08:00
mpilman 5a9d420cb7 Merge remote-tracking branch 'upstream/release-6.2' into release-merges/20200210 2020-02-10 10:02:05 -08:00
A.J. Beamon fa920a6cef Step 5 of fixing storage server range reads: update the logic of reverse range reads to match forward range reads 2020-02-07 10:02:52 -08:00
A.J. Beamon 16167b07d5 Step 4 of fixing storage server range reads: remove another unneeded iteration case in the forward direction when we don't exhaust our limits in the disk read. This also hopefully makes the code a bit clearer. 2020-02-06 13:27:04 -08:00
A.J. Beamon df2b0452b4 Step 3 of fixing storage server range reads: change return type of readRange from VectorRef<KeyValueRef> to RangeResultRef. 2020-02-06 13:19:24 -08:00
A.J. Beamon 1c61957ca1 Step 2 of fixing storage server range reads: eliminate some unnecessary iterations in the forward case 2020-02-06 12:58:59 -08:00
A.J. Beamon 7037edc3f8 Step 1 of fixing storage server range reads: cleanup of the forward direction. This should not change any behavior. 2020-02-06 12:49:02 -08:00