Commit Graph

9 Commits

Author SHA1 Message Date
sfc-gh-tclinkenbeard 841e6b211b Run clang-format on flow/serialize.cpp 2021-11-01 14:54:24 -07:00
Trevor Clinkenbeard 70b5ee35b9 Add comment to flow/serialize/Downgrade/WriteNew unit test
Co-authored-by: Andrew Noyes <andrew.noyes@snowflake.com>
2021-11-01 14:54:24 -07:00
sfc-gh-tclinkenbeard 2e3f3ea2af Remove unused constants from serialize.cpp 2021-11-01 14:54:24 -07:00
sfc-gh-tclinkenbeard e08721c7f4 Added flow/serialize/Downgrade unit tests 2021-11-01 14:54:24 -07:00
FDB Formatster df90cc89de apply clang-format to *.c, *.cpp, *.h, *.hpp files 2021-03-10 10:18:07 -08:00
mpilman 8576665a90 Revert "Revert "Make protocol version a type""
This reverts commit 455bf3b3ec.
2019-06-18 14:49:04 -07:00
Alex Miller 455bf3b3ec Revert "Make protocol version a type" 2019-06-18 10:59:17 -07:00
mpilman da53a92bec Make protocol version a type
This fixes #1214

The basic idea is that ProtocolVersion is now its own type. This
alone is an improvement as it makes many things more typesafe. For
each version, we can now add breaking features (for example Fearless).
After that, there's no need to test against actual (confusing) version
numbers. Instead a developer can simply test
`protocolVersion->hasFearless()` and this will return true iff the
protocolVersion is newer than the newest version that didn't support
fearless.
2019-06-16 09:59:15 -07:00
Evan Tschannen 8e05713a5d do not log a SevError trace event if we cannot deserialize the connect packet 2019-04-10 17:41:02 -07:00