Commit Graph

5 Commits

Author SHA1 Message Date
Michael Stack 07d35a32a9
Fix assertion failure in BulkLoad manifest reading during DD cancellation (#13256)
When the Data Distributor exits due to a movekeys_conflict (normal
ownership change), all child actors are cancelled. If the BulkLoad job
manager is mid-read of the job manifest file, the actor_cancelled error
propagates into AsyncFileDetachable::read(), which asserts that reads
must not be cancelled (assertOnReadWriteCancel=true), triggering a
BugDetected internal_error.

Wrap the file->read() in getBulkLoadJobFileManifestEntryFromJobManifestFile
with uncancellable(), matching the pattern already used in
readBulkFileBytes in the same file. This prevents the cancellation from
reaching the file I/O layer while still allowing the actor to be
cancelled after the read completes.

Reproduces with: BulkDumpingS3.toml -s 2030534189
2026-05-21 10:10:45 -07:00
Trevor Clinkenbeard 7fee2d81ea Rename RocksDBCheckpointUtils* files 2026-04-12 15:31:46 +00:00
Trevor Clinkenbeard a760f2cf4e Rename StorageMetrics.actor.h 2026-03-31 10:40:40 -07:00
Trevor Clinkenbeard 457a4931a0 Post coroutine conversion linting 2026-03-28 05:29:41 +00:00
Trevor Clinkenbeard 98b567d0c1 Rename BulkLoadUtil.actor.* files 2026-03-28 05:26:40 +00:00