Trevor Clinkenbeard
caeba8b37c
Merge pull request #13303 from tclinkenbeard-oai/dev/tclinkenbeard/actorcompiler-include-cleanup
...
Clean up actor compiler includes
2026-05-29 14:21:00 -07:00
Trevor Clinkenbeard
eec3cd49a0
Clean up actor compiler includes
2026-05-29 12:46:35 -07:00
Trevor Clinkenbeard
c15b88ff7d
Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/inline-buggify-function
...
# Conflicts:
# fdbserver/core/ServerKnobs.cpp
# fdbserver/tlog/TLogServer.cpp
2026-05-28 07:29:13 -07:00
Trevor Clinkenbeard
23b972297b
Merge pull request #13213 from tclinkenbeard-oai/dev/tclinkenbeard/apply-fdb-ast-grep-rules
...
More AST-grep linting
2026-05-26 14:53:10 -07:00
Trevor Clinkenbeard
091aa15a2f
Address clang-tidy warnings
2026-05-24 18:14:26 -07:00
Trevor Clinkenbeard
1bc151d47f
Add more clang-tidy checks
2026-05-24 15:15:47 -07:00
Trevor Clinkenbeard
b46c58415c
Replace BUGGIFY macros with inline function
2026-05-20 14:54:51 -07:00
Trevor Clinkenbeard
73fc36e935
Apply explicit constructor cleanup from ast-grep
2026-05-13 08:38:45 -07:00
Trevor Clinkenbeard
3940a34011
Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/logsystem-consumer
...
# Conflicts:
# fdbserver/commitproxy/CommitProxyServer.cpp
2026-05-11 14:47:53 -07:00
Trevor Clinkenbeard
26c3ae04e6
Remove LogSystem consumer compatibility wrappers
2026-05-11 10:57:25 -07:00
Trevor Clinkenbeard
ae322fbae6
Use LogSystemConsumer for commit proxy pops
2026-05-11 10:25:57 -07:00
Trevor Clinkenbeard
3c5d435095
Fix formatting
2026-05-07 12:02:45 -07:00
Trevor Clinkenbeard
9cf7ef92d0
Rename CommitProxyServer source to cpp
2026-05-07 11:49:48 -07:00
Trevor Clinkenbeard
5f10e545b2
Refactor commit proxy server core into a class
2026-05-07 11:48:37 -07:00
Trevor Clinkenbeard
b435ec8001
Convert commit proxy helpers to coroutines
2026-05-05 17:42:37 -07:00
Trevor Clinkenbeard
8b53f357d5
Create IdempotencyIdsExpireServer class
2026-04-27 04:08:12 +00:00
Trevor Clinkenbeard
37bd3fbacc
Convert transactionLogging to standard coroutine
2026-04-27 03:42:05 +00:00
Trevor Clinkenbeard
cfa12826c7
Convert reportTxnTagCommitCost to standard coroutines
2026-04-27 00:21:17 +00:00
Trevor Clinkenbeard
ce4b77f02d
Convert ddMetricsRequestServer to standard coroutine
2026-04-26 23:56:25 +00:00
Trevor Clinkenbeard
a51aa03ab1
Remove unnecessary choose block
2026-04-26 23:53:04 +00:00
Trevor Clinkenbeard
b122bbce52
Merge pull request #13051 from tclinkenbeard-oai/dev/tclinkenbeard/commit-proxy-coro
...
Convert several `CommitProxyServer.actor.cpp` actors to standard coroutines
2026-04-24 20:10:31 -05:00
Trevor Clinkenbeard
c4e396705d
Remove unnecessary const_cast
2026-04-24 16:38:22 -07:00
Trevor Clinkenbeard
8405c2a0b6
Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/move-ikvstore2
2026-04-24 16:30:01 -07:00
Trevor Clinkenbeard
147d992cf0
Remove outdated CMAKE_CURRENT_BINARY_DIR references from CMakeLists.txt files
2026-04-24 06:20:40 +00:00
Trevor Clinkenbeard
4b29daebe7
Rely on transitive dependency for fdbserver_kvstore
2026-04-23 19:19:43 +00:00
Trevor Clinkenbeard
f120430025
Move IKeyValueStore.h to fdbserver/kvstore
2026-04-23 19:16:58 +00:00
Trevor Clinkenbeard
8a9d6d7a45
Merge remote-tracking branch 'apple/main' into dev/tclinkenbeard/commit-proxy-coro
2026-04-22 22:32:01 +00:00
Trevor Clinkenbeard
0255c46ab4
Remove ReleaseResolvingAfterCallback class
2026-04-22 22:31:48 +00:00
Trevor Clinkenbeard
3a66f79c12
Add comment for ReleaseResolvingAfterCallback class
2026-04-21 18:43:38 +00:00
Trevor Clinkenbeard
1c2d3da012
CommitProxyServer.actor.cpp optimizations
2026-04-21 17:24:55 +00:00
Trevor Clinkenbeard
f139415af7
Convert several CommitProxyServer.actor.cpp actors to standard coroutines
2026-04-21 17:24:55 +00:00
Trevor Clinkenbeard
93ef0e335b
Merge remote-tracking branch 'apple/main' into dev/tclinkenbeard/remove-ilogsystem
2026-04-17 17:56:51 +00:00
Trevor Clinkenbeard
6c876a89c0
Merge pull request #12978 from tclinkenbeard-oai/dev/tclinkenbeard/move-grv-proxy-interf
...
Move `GetReadVersion*` structs to `GrvProxyInterface.h`
2026-04-16 03:40:21 -05:00
Trevor Clinkenbeard
b20ac72d5f
Move GetReadVersion* structs to GrvProxyInterface.h
2026-04-13 18:38:30 +00:00
Trevor Clinkenbeard
629f977c0f
Fix fdbserver/core link test
2026-04-12 06:39:52 +00:00
Trevor Clinkenbeard
29bcabb8c3
Rename TagPartitionedLogSystem to simply LogSystem
2026-04-12 04:21:51 +00:00
Trevor Clinkenbeard
6d39afbb08
Remove ILogSystem interface
2026-04-12 04:08:21 +00:00
Trevor Clinkenbeard
7b2e921503
Convert several CommitProxyServer.actor.cpp actors to standard coroutines
2026-04-11 23:40:28 +00:00
Trevor Clinkenbeard
697decb134
Merge pull request #12909 from tclinkenbeard-oai/dev/tclinkenbeard/role-entry-coro
...
Convert several role `ACTOR`s to standard coroutines
2026-04-07 15:28:52 -07:00
Trevor Clinkenbeard
fe4469f0ca
Merge remote-tracking branch 'apple/main' into dev/tclinkenbeard/move-proxy-commit-data
2026-04-03 02:38:42 +00:00
gxglass
bca167fe96
Remove parallel restore feature ( #12903 )
...
This parallel restore feature has been slated for removal for at least a year. This PR is closely based on earlier PR #12107 .
This blog post explains some of the problems with the parallel restore feature: https://medium.com/@jingyuzhou/why-foundationdb-restore-is-slow-and-what-can-be-done-about-it-e73a821fdd33
As far as large feature removal changes go, this one is very straightforward, with most relevant files and test cases simply being deleted. There is one knob rename where storageserver.actor.cpp was using a knob with FASTRESTORE in the name. Other than that, changes to shared files mainly involve removing fastrestore-specific CLI and role support.
In progress:
20260330-222511-gglass-5ee0142213471b70 compressed=True data_size=35343375 duration=4611964 ended=100000 fail=1 fail_fast=1000 max_runs=100000 pass=99999 priority=100 remaining=0 runtime=0:58:23 sanity=False started=100000 stopped=20260330-232334 submitted=20260330-222511 timeout=5400 username=gglass
The one failure was in SwizzledCycleTest.toml with too many lines of output and a timeout. I kind of suspect it's unrelated but haven't looked further.
* Remove parallel restore feature. This is based on earlier PR 12107. Compiles but untested.
* AI generated commit:
⏺ The fix restores a single if block that was accidentally deleted when removing the FASTRESTORE_TOOL code:
if (!restoreSystemKeys && !restoreUserKeys && backupKeys.empty()) {
addDefaultBackupRanges(backupKeys);
}
When no explicit key ranges are specified on the command line and neither --user-data nor --system-metadata flags are set, this populates backupKeys with the default backup ranges
(essentially all user data). Without it, backupKeys stays empty and hits the ASSERT(!backupRanges.empty()) in submitBackup().
* Remove a believed-to-be-dead code path, and update .gitignore
* Remove duplicate definition of restoreRequestDoneKey
2026-04-01 15:57:12 -07:00
Trevor Clinkenbeard
96ebe9aca4
Rename files
2026-03-31 19:46:04 +00:00
Trevor Clinkenbeard
cc3cbc4492
Convert commitProxyServer to standard coroutine
2026-03-31 19:29:06 +00:00
Trevor Clinkenbeard
a0aa992af6
Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/actor-header-rename
2026-03-30 22:39:26 -07:00
Trevor Clinkenbeard
ba8927f461
Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/replace-descr
2026-03-30 16:53:34 -07:00
Trevor Clinkenbeard
80ee3d105f
Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/actor-header-rename
2026-03-29 14:23:25 -07:00
Trevor Clinkenbeard
ff7eff733a
Add comments
2026-03-28 19:47:29 +00:00
Trevor Clinkenbeard
24309870db
Fix build issues
2026-03-28 19:39:23 +00:00
Trevor Clinkenbeard
9eabeda0e6
Create ApplyMetadataRangeLock interface
2026-03-28 19:23:40 +00:00
Trevor Clinkenbeard
edf1d27834
Rename ProxyCommitData.actor.h
2026-03-28 19:10:10 +00:00