From df7a801945f0e607af784205c57eb8e29bb35c47 Mon Sep 17 00:00:00 2001 From: Xiaoxi Wang Date: Thu, 12 Aug 2021 14:10:34 -0700 Subject: [PATCH] remove FIXME --- fdbclient/ServerKnobs.cpp | 2 +- fdbserver/LogRouter.actor.cpp | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/fdbclient/ServerKnobs.cpp b/fdbclient/ServerKnobs.cpp index 1e90c5a38b..0873b072dc 100644 --- a/fdbclient/ServerKnobs.cpp +++ b/fdbclient/ServerKnobs.cpp @@ -64,7 +64,7 @@ void ServerKnobs::initialize(Randomize randomize, ClientKnobs* clientKnobs, IsSi init( TLOG_MESSAGE_BLOCK_BYTES, 10e6 ); init( TLOG_MESSAGE_BLOCK_OVERHEAD_FACTOR, double(TLOG_MESSAGE_BLOCK_BYTES) / (TLOG_MESSAGE_BLOCK_BYTES - MAX_MESSAGE_SIZE) ); //1.0121466709838096006362758832473 init( PEEK_TRACKER_EXPIRATION_TIME, 600 ); if( randomize && BUGGIFY ) PEEK_TRACKER_EXPIRATION_TIME = deterministicRandom()->coinflip() ? 0.1 : 120; - init( PEEK_USING_STREAMING, true ); + init( PEEK_USING_STREAMING, true ); init( PARALLEL_GET_MORE_REQUESTS, 32 ); if( randomize && BUGGIFY ) PARALLEL_GET_MORE_REQUESTS = 2; init( MULTI_CURSOR_PRE_FETCH_LIMIT, 10 ); init( MAX_QUEUE_COMMIT_BYTES, 15e6 ); if( randomize && BUGGIFY ) MAX_QUEUE_COMMIT_BYTES = 5000; diff --git a/fdbserver/LogRouter.actor.cpp b/fdbserver/LogRouter.actor.cpp index 22348fe8b3..7e3316b28d 100644 --- a/fdbserver/LogRouter.actor.cpp +++ b/fdbserver/LogRouter.actor.cpp @@ -694,11 +694,9 @@ ACTOR Future logRouterCore(TLogInterface interf, req.reply, &logRouterData, req.begin, req.tag, req.returnIfBlocked, req.onlySpilled, req.sequence)); } when(TLogPeekStreamRequest req = waitNext(interf.peekStreamMessages.getFuture())) { - // FIXME: currently LogRouter doesn't support streaming peek request TraceEvent(SevDebug, "LogRouterPeekStream", logRouterData.dbgid) .detail("Token", interf.peekStreamMessages.getEndpoint().token); addActor.send(logRouterPeekStream(&logRouterData, req)); - // req.reply.sendError(operation_failed()); } when(TLogPopRequest req = waitNext(interf.popMessages.getFuture())) { // Request from remote tLog to pop data from LR