diff --git a/fdbserver/TLogServer.actor.cpp b/fdbserver/TLogServer.actor.cpp index a5ad779aea..d4847338b6 100644 --- a/fdbserver/TLogServer.actor.cpp +++ b/fdbserver/TLogServer.actor.cpp @@ -583,7 +583,7 @@ ACTOR Future updatePersistentData( TLogData* self, Reference logD } } - self->persistentData->set( KeyValueRef( BinaryWriter::toValue(logData->logId,Unversioned()).withPrefix(persistCurrentVersionKeys.begin), BinaryWriter::toValue(newPersistentDataVersion, Unversioned()) ) ); + self->persistentData->set( KeyValueRef( BinaryWriter::toValue(logData->logId,Unversioned()).withPrefix(persistCurrentVersionKeys.begin), BinaryWriter::toValue(newPersistentDataVersion, Unversioned()) ) ); self->persistentData->set( KeyValueRef( BinaryWriter::toValue(logData->logId,Unversioned()).withPrefix(persistKnownCommittedVersionKeys.begin), BinaryWriter::toValue(logData->knownCommittedVersion, Unversioned()) ) ); logData->persistentDataVersion = newPersistentDataVersion; @@ -843,7 +843,7 @@ void commitMessages( Reference self, Version version, const std::vector addedBytes += SERVER_KNOBS->VERSION_MESSAGES_ENTRY_BYTES_WITH_OVERHEAD; } } - + msgSize -= msg.message.size(); } self->messageBlocks.push_back( std::make_pair(version, block) ); @@ -1186,7 +1186,7 @@ ACTOR Future tLogCommit( TraceEvent(SevWarn, "TLogUpdateLag", logData->logId) .detail("Version", logData->version.get()) .detail("PersistentDataVersion", logData->persistentDataVersion) - .detail("PersistentDataDurableVersion", logData->persistentDataDurableVersion).suppressFor(1.0); + .detail("PersistentDataDurableVersion", logData->persistentDataDurableVersion); waitStartT = now(); } Void _ = wait( delayJittered(.005, TaskTLogCommit) ); @@ -1240,7 +1240,7 @@ ACTOR Future initPersistentState( TLogData* self, Reference logDa // PERSIST: Initial setup of persistentData for a brand new tLog for a new database IKeyValueStore *storage = self->persistentData; storage->set( persistFormat ); - storage->set( KeyValueRef( BinaryWriter::toValue(logData->logId,Unversioned()).withPrefix(persistCurrentVersionKeys.begin), BinaryWriter::toValue(logData->version.get(), Unversioned()) ) ); + storage->set( KeyValueRef( BinaryWriter::toValue(logData->logId,Unversioned()).withPrefix(persistCurrentVersionKeys.begin), BinaryWriter::toValue(logData->version.get(), Unversioned()) ) ); storage->set( KeyValueRef( BinaryWriter::toValue(logData->logId,Unversioned()).withPrefix(persistKnownCommittedVersionKeys.begin), BinaryWriter::toValue(logData->knownCommittedVersion, Unversioned()) ) ); storage->set( KeyValueRef( BinaryWriter::toValue(logData->logId,Unversioned()).withPrefix(persistLocalityKeys.begin), BinaryWriter::toValue(logData->locality, Unversioned()) ) ); storage->set( KeyValueRef( BinaryWriter::toValue(logData->logId,Unversioned()).withPrefix(persistLogRouterTagsKeys.begin), BinaryWriter::toValue(logData->logRouterTags, Unversioned()) ) ); @@ -1487,7 +1487,7 @@ ACTOR Future pullAsyncData( TLogData* self, Reference logData, st TraceEvent(SevWarn, "TLogUpdateLag", logData->logId) .detail("Version", logData->version.get()) .detail("PersistentDataVersion", logData->persistentDataVersion) - .detail("PersistentDataDurableVersion", logData->persistentDataDurableVersion).suppressFor(1.0); + .detail("PersistentDataDurableVersion", logData->persistentDataDurableVersion); waitStartT = now(); } Void _ = wait( delayJittered(.005, TaskTLogCommit) ); diff --git a/fdbserver/storageserver.actor.cpp b/fdbserver/storageserver.actor.cpp index 1279bbbb8e..becea24b93 100644 --- a/fdbserver/storageserver.actor.cpp +++ b/fdbserver/storageserver.actor.cpp @@ -293,7 +293,7 @@ public: allHistoryCopy = allHistory; hist = &allHistoryCopy; } - + while(hist->size() && v > hist->back().first ) { logSystem->pop( v, hist->back().second ); hist->pop_back(); @@ -452,7 +452,7 @@ public: shuttingDown(false), debug_inApplyUpdate(false), debug_lastValidateTime(0), watchBytes(0), logProtocol(0), counters(this), tag(invalidTag), maxQueryQueue(0), thisServerID(ssi.id()), readQueueSizeMetric(LiteralStringRef("StorageServer.ReadQueueSize")), - behind(false), byteSampleClears(false, LiteralStringRef("\xff\xff\xff")), noRecentUpdates(false), + behind(false), byteSampleClears(false, LiteralStringRef("\xff\xff\xff")), noRecentUpdates(false), lastUpdate(now()), poppedAllAfter(std::numeric_limits::max()) { version.initMetric(LiteralStringRef("StorageServer.Version"), counters.cc.id); @@ -814,7 +814,7 @@ ACTOR Future watchValue_impl( StorageServer* data, WatchValueRequest req ) ACTOR Future watchValueQ( StorageServer* data, WatchValueRequest req ) { state Future watch = watchValue_impl( data, req ); state double startTime = now(); - + loop { double timeoutDelay = -1; if(data->noRecentUpdates.get()) { @@ -2327,7 +2327,7 @@ ACTOR Future update( StorageServer* data, bool* pReceivedUpdate ) if (now() - waitStartT >= 1) { TraceEvent(SevWarn, "StorageServerUpdateLag", data->thisServerID) .detail("Version", data->version.get()) - .detail("DurableVersion", data->durableVersion.get()).suppressFor(1.0); + .detail("DurableVersion", data->durableVersion.get()); waitStartT = now(); } @@ -2341,7 +2341,7 @@ ACTOR Future update( StorageServer* data, bool* pReceivedUpdate ) state Reference cursor = data->logCursor; //TraceEvent("SSUpdatePeeking", data->thisServerID).detail("MyVer", data->version.get()).detail("Epoch", data->updateEpoch).detail("Seq", data->updateSequence); - + loop { Void _ = wait( cursor->getMore() ); if(!cursor->isExhausted()) { @@ -3289,7 +3289,7 @@ ACTOR Future replaceInterface( StorageServer* self, StorageServerInterface tr.addReadConflictRange(singleKeyRange(tagLocalityListKeyFor(ssi.locality.dcId()))); tr.set(serverListKeyFor(ssi.id()), serverListValue(ssi)); - + if(rep.newLocality) { tr.addReadConflictRange(tagLocalityListKeys); tr.set( tagLocalityListKeyFor(ssi.locality.dcId()), tagLocalityListValue(rep.newTag.get().locality) );