scnuwjh
/
mindspore2022
forked from huawei/mindspore2022
0
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

!30978 Priority replay buffer bugfix 

Merge pull request !30978 from chenweifeng/priority-replay-buffer-fix
This commit is contained in:
i-robot 2022-03-09 03:37:46 +00:00 committed by Gitee
parent e2eef76c99 8a358f0817
commit 5fb502fdb4
No known key found for this signature in database
GPG Key ID: 173E9B9CA92EEF8F
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mindspore/ccsrc/plugin/device/cpu/kernel/rl/priority_replay_buffer.cc
View File

@ -36,10 +36,11 @@ PriorityItem PriorityTree::ReduceOp(const PriorityItem &lhs, const PriorityItem
size_t PriorityTree::GetPrefixSumIdx(float prefix_sum) {
size_t idx = 1;
while (idx < capacity_) {
if (prefix_sum <= buffer_[kNumSubnodes * idx].sum_priority) {
const auto &left_priority = buffer_[kNumSubnodes * idx].sum_priority;
if (prefix_sum <= left_priority) {
idx = kNumSubnodes * idx;
} else {
prefix_sum -= buffer_[kRightOffset * idx].sum_priority;
prefix_sum -= left_priority;
idx = kNumSubnodes * idx + kRightOffset;
}
}
@ -69,13 +70,13 @@ bool PriorityReplayBuffer::UpdatePriorities(const std::vector<size_t> &indices,
return false;
}
for (size_t idx = 0; idx < indices.size(); idx++) {
float priority = pow(priorities[idx], alpha_);
for (size_t i = 0; i < indices.size(); i++) {
float priority = pow(priorities[i], alpha_);
if (priority <= 0.0f) {
MS_LOG(WARNING) << "The priority is " << priority << ". It may lead to converge issue.";
priority = kMinPriority;
}
priority_tree_->Insert(idx, {priority, priority});
priority_tree_->Insert(indices[i], {priority, priority});
// Record max priority of transitions
max_priority_ = std::max(max_priority_, priority);