log_main.h:67:40: warning: code should be clang-formatted [-Wclang-format-violations]
constexpr int __fake_use_va_args(Ts...) {
^
log_main.h:67:42: warning: code should be clang-formatted [-Wclang-format-violations]
constexpr int __fake_use_va_args(Ts...) {
^
log_main.h:85:41: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:88:48: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:102:45: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:123:44: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:124:34: warning: code should be clang-formatted [-Wclang-format-violations]
__android_log_assert(cond, tag, \
^
log_main.h:125:64: warning: code should be clang-formatted [-Wclang-format-violations]
_android_second(0, ##VA_ARGS_, NULL) \
^
log_main.h:135:39: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:136:63: warning: code should be clang-formatted [-Wclang-format-violations]
((_predict_false(cond)) ? (FAKE_USE_VA_ARGS(VA_ARGS_), \
^
log_main.h:137:90: warning: code should be clang-formatted [-Wclang-format-violations]
((void)android_printAssert(#cond, LOG_TAG, ##_VA_ARGS_))) \
^
log_main.h:142:30: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:201:19: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:202:7: warning: code should be clang-formatted [-Wclang-format-violations]
do { \
^
log_main.h:203:37: warning: code should be clang-formatted [-Wclang-format-violations]
_FAKE_USE_VA_ARGS(VA_ARGS_); \
^
log_main.h:204:17: warning: code should be clang-formatted [-Wclang-format-violations]
if (false)
{ \ ^ log_main.h:205:28: warning: code should be clang-formatted [-Wclang-format-violations] __ALOGV(__VA_ARGS__); \ ^ log_main.h:206:6: warning: code should be clang-formatted [-Wclang-format-violations] }
\
^
log_main.h:217:28: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:218:27: warning: code should be clang-formatted [-Wclang-format-violations]
((__predict_false(cond)) \
^
log_main.h:219:90: warning: code should be clang-formatted [-Wclang-format-violations]
? (_FAKE_USE_VA_ARGS(VA_ARGS), (void)ALOG(LOG_VERBOSE, LOG_TAG, __VA_ARGS_)) \
^
log_main.h:232:28: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:233:27: warning: code should be clang-formatted [-Wclang-format-violations]
((__predict_false(cond)) \
^
log_main.h:234:88: warning: code should be clang-formatted [-Wclang-format-violations]
? (_FAKE_USE_VA_ARGS(VA_ARGS), (void)ALOG(LOG_DEBUG, LOG_TAG, __VA_ARGS_)) \
^
log_main.h:246:28: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:247:27: warning: code should be clang-formatted [-Wclang-format-violations]
((__predict_false(cond)) \
^
log_main.h:248:87: warning: code should be clang-formatted [-Wclang-format-violations]
? (_FAKE_USE_VA_ARGS(VA_ARGS), (void)ALOG(LOG_INFO, LOG_TAG, __VA_ARGS_)) \
^
log_main.h:260:28: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:261:27: warning: code should be clang-formatted [-Wclang-format-violations]
((__predict_false(cond)) \
^
log_main.h:262:87: warning: code should be clang-formatted [-Wclang-format-violations]
? (_FAKE_USE_VA_ARGS(VA_ARGS), (void)ALOG(LOG_WARN, LOG_TAG, __VA_ARGS_)) \
^
log_main.h:274:28: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:275:27: warning: code should be clang-formatted [-Wclang-format-violations]
((__predict_false(cond)) \
^
log_main.h:276:88: warning: code should be clang-formatted [-Wclang-format-violations]
? (_FAKE_USE_VA_ARGS(VA_ARGS), (void)ALOG(LOG_ERROR, LOG_TAG, __VA_ARGS_)) \
^
log_main.h:368:35: warning: code should be clang-formatted [-Wclang-format-violations]
^
log_main.h:371:35: warning: code should be clang-formatted [-Wclang-format-violations]
^
Signed-off-by: cuiziwei <cuiziwei@xiaomi.com>
When the type of basic value is double, can't using void *value as buffer to get value.
==3263760==ERROR: AddressSanitizer: stack-buffer-overflow on address 0xefe13c30 at pc 0x577c0356 bp 0xefe139b8 sp 0xefe139a8
WRITE of size 8 at 0xefe13c30 thread T0
#0 0x577c0355 in _dbus_marshal_read_basic dbus/dbus/dbus-marshal-basic.c:581
#1 0x5783bedb in _dbus_type_reader_read_basic dbus/dbus/dbus-marshal-recursive.c:879
#2 0x5776ef72 in dbus_message_iter_get_basic dbus/dbus/dbus-message.c:2376
#3 0x57e06daa in iter_append_iter gdbus/client.c:222
#4 0x57e070b1 in prop_entry_update gdbus/client.c:265
#5 0x57e07454 in prop_entry_new gdbus/client.c:286
#6 0x57e0793a in add_property gdbus/client.c:322
#7 0x57e09abd in properties_changed_non_standard gdbus/client.c:544
#8 0x57df2e00 in signal_filter gdbus/watch.c:394
#9 0x57df4d57 in message_filter gdbus/watch.c:544
#10 0x57752dc6 in dbus_connection_dispatch dbus/dbus/dbus-connection.c:4703
#11 0x57dde7d5 in message_dispatch gdbus/mainloop.c:59
#12 0x5790e3b8 in g_idle_dispatch glib/glib/gmain.c:6157
#13 0x57900a31 in g_main_dispatch glib/glib/gmain.c:3477
#14 0x579080d3 in g_main_context_dispatch glib/glib/gmain.c:4195
#15 0x57908bcc in g_main_context_iterate glib/glib/gmain.c:4271
#16 0x57909e7f in g_main_loop_run glib/glib/gmain.c:4471
#17 0x57dde5b7 in telephonytool_main /home/djz/workspace/test/sim/frameworks/telephony/telephony_tool.c:878
#18 0x56ea66b5 in nxtask_startup sched/task_startup.c:70
#19 0x56e541a8 in nxtask_start task/task_start.c:134
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
There are still three fail test cases (android property test):
1. empty key test, reason: kvdb do not support empty key;
2. long key test, reason: (a) read only property value length can be
arbitrarily-long in android, kvdb do not support; (b) read only
property can be set if the property do not exist before, kvdb
not allowed this action;
3. cached property test, reason: (a) android cached property uses
serial to judge the [key, value] changed, kvdb can't handle this
very well; (b) android cached property return the value pointer
from the shared memory directly for read only property, kvdb
can't handle this well too.
Signed-off-by: wangbowen6 <wangbowen6@xiaomi.com>
cuiziwei