From 86a9e8272c61a1f8c907ac253e835fc033c52274 Mon Sep 17 00:00:00 2001 From: nordligulv Date: Wed, 27 Mar 2013 19:17:01 +0400 Subject: [PATCH] improve logger name truncation --- .../main/java/org/slf4j/impl/AndroidLoggerFactory.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/slf4j-android/src/main/java/org/slf4j/impl/AndroidLoggerFactory.java b/slf4j-android/src/main/java/org/slf4j/impl/AndroidLoggerFactory.java index 75b7c0fc..550a080e 100755 --- a/slf4j-android/src/main/java/org/slf4j/impl/AndroidLoggerFactory.java +++ b/slf4j-android/src/main/java/org/slf4j/impl/AndroidLoggerFactory.java @@ -96,9 +96,9 @@ public class AndroidLoggerFactory implements ILoggerFactory { // token of one character appended as is otherwise truncate it to one character int tokenLength = lastPeriodIndex - lastTokenIndex; if (tokenLength > 1) { - tagName.append("*"); + tagName.append('*'); } - tagName.append("."); + tagName.append('.'); lastTokenIndex = lastPeriodIndex + 1; } // last token (usually class name) appended as is @@ -109,9 +109,9 @@ public class AndroidLoggerFactory implements ILoggerFactory { // Either we had no useful dot location at all or name still too long. // Take leading part and append '*' to indicate that it was truncated - lastPeriodIndex = loggerName.lastIndexOf("."); + lastPeriodIndex = loggerName.lastIndexOf('.'); return lastPeriodIndex != -1 && length - (lastPeriodIndex + 1) <= TAG_MAX_LENGTH ? loggerName.substring(lastPeriodIndex + 1) - : "*" + loggerName.substring(length - TAG_MAX_LENGTH + 1); + : '*' + loggerName.substring(length - TAG_MAX_LENGTH + 1); } }