natas_hw
/
openvino
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[GPU] Remove paddings on set_state() call (#23828) 

### Details:
 - Fix accuracy issue due to wrong pad size after set_state call
This commit is contained in:
Vladimir Paramuzov 2024-04-03 03:14:02 -07:00 committed by GitHub
parent 5637b78d7f
commit 902c370ca1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/intel_gpu/src/plugin/variable_state.cpp
View File

@ -58,6 +58,8 @@ void VariableState::set_layout(const cldnn::layout& new_layout) {
void VariableState::set_state(const ov::SoPtr<ov::ITensor>& state) {
m_layout.set_partial_shape(state->get_shape());
size_t rank = state->get_shape().size();
m_layout.data_padding = cldnn::padding(std::vector<int32_t>(rank, 0), std::vector<int32_t>(rank, 0), 0, m_layout.data_padding.get_dynamic_pad_dims());
update_device_buffer();
convert_and_copy(state._ptr.get(), m_memory, m_context->get_engine().get_service_stream());
set();

15
src/plugins/intel_gpu/tests/functional/subgraph_tests/dynamic/kv_cache.cpp
View File

@ -258,7 +258,8 @@ class KVCacheTests: public ::testing::Test {
int64_t concat_axis = 2,
ov::element::Type model_element_type = ov::element::f16,
size_t num_iter = 10,
size_t num_groups = 1) {
size_t num_groups = 1,
bool set_state_on_each_iter = false) {
#if defined(ANDROID)
GTEST_SKIP();
#endif
@ -437,6 +438,14 @@ class KVCacheTests: public ::testing::Test {
infer_request.infer();
compare_tensors({ ref_results[1] }, {matmul_out});
if (set_state_on_each_iter) {
auto state = infer_request.query_state()[0].get_state();
compare_tensors({ ref_kv_cache }, {state});
infer_request.query_state()[0].set_state(state);
auto state_1 = infer_request.query_state()[0].get_state();
compare_tensors({ ref_kv_cache }, {state_1});
}
}
auto state = infer_request.query_state()[0].get_state();
@ -494,4 +503,8 @@ TEST_F(KVCacheTests, smoke_multipleIterations_stateful_same_shape_after_reset) {
this->test_smoke_multipleIterations_stateful(false, false, false, 1, 2, ov::element::f16, 0);
}
TEST_F(KVCacheTests, smoke_multipleIterations_stateful_with_set_state) {
this->test_smoke_multipleIterations_stateful(false, true, true, 1, 2, ov::element::f16, 5, 1, true);
}
} // namespace