natas_hw
/
openvino
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed KW warning and review issues (#2262)

This commit is contained in:
Ilya Churaev 2020-09-16 15:33:10 +03:00 committed by GitHub
parent ebf009d1a1
commit 528e6f9328
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ngraph/core/include/ngraph/node.hpp
View File

@ -155,9 +155,11 @@ namespace ngraph
protected:
/// \brief Construct an unitialized Node
Node() {}
Node() = default;
/// \brief Copying a node
Node(const Node&);
/// \brief Assignment operator
Node& operator=(const Node&);
/// \brief Construct an unitialized Node
/// \param output_size Number of outputs for this node

4
ngraph/core/reference/include/ngraph/runtime/reference/gather.hpp
View File

@ -149,6 +149,8 @@ namespace ngraph
auto out_outer_coord_iter = out_outer_transform.begin();
for (const Coordinate& params_outer_coord : params_outer_transform)
{
if (out_outer_coord_iter == out_outer_transform.end())
break;
const T* params_prime =
&params[params_outer_transform.index(params_outer_coord)];
T* out_outer = &out[out_outer_transform.index(*out_outer_coord_iter)];
@ -156,6 +158,8 @@ namespace ngraph
auto out_inner_coord_iter = out_inner_transform.begin();
for (const Coordinate& indices_outer_coord : indices_outer_transform)
{
if (out_inner_coord_iter == out_inner_transform.end())
break;
const U* indices_prime =
&indices[indices_outer_transform.index(indices_outer_coord)];
T* out_prime = &out_outer[out_inner_transform.index(*out_inner_coord_iter)];

20
ngraph/core/src/node.cpp
View File

@ -55,6 +55,26 @@ Node::Node(const Node& node)
}
}
Node& Node::operator=(const Node& node)
{
this->m_control_dependents = node.m_control_dependents;
this->m_control_dependencies = node.m_control_dependencies;
this->m_instance_id = m_next_instance_id.fetch_add(1);
this->m_friendly_name = node.m_friendly_name;
this->m_provenance_tags = node.m_provenance_tags;
this->m_provenance_group = node.m_provenance_group;
this->m_inputs = node.m_inputs;
this->m_op_annotations = node.m_op_annotations;
this->m_rt_info = node.m_rt_info;
// cannot do it without copying node.m_inputs first due to too limiting const qualifiers
for (auto& input : m_inputs)
{
input = descriptor::Input(this, input.get_index(), input.get_output());
input.get_output().add_input(&input);
}
return *this;
}
Node::Node(size_t output_size)
: Node()
{