From 0f52eacd7bd8794c793b4fac478dd241d1ea6cb7 Mon Sep 17 00:00:00 2001
From: Xiuchuan Zhai <xiuchuan.zhai@intel.com>
Date: Wed, 3 Apr 2024 22:03:23 +0800
Subject: [PATCH] [CPU] fix coverity in cpu plugin (#23830)

### Details:
 - *fix coverity in cpu plugin*

### Tickets:
 - *ticket-id*
---
 src/plugins/intel_cpu/src/dnnl_scratch_pad.h                   | 2 +-
 src/plugins/intel_cpu/src/graph_context.h                      | 2 +-
 src/plugins/intel_cpu/src/node.cpp                             | 3 +--
 src/plugins/intel_cpu/src/nodes/concat.h                       | 2 +-
 .../src/transformations/cpu_opset/common/pass/split_fc.cpp     | 3 ++-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/plugins/intel_cpu/src/dnnl_scratch_pad.h b/src/plugins/intel_cpu/src/dnnl_scratch_pad.h
index f2689e842ad..a589b9dbb0c 100644
--- a/src/plugins/intel_cpu/src/dnnl_scratch_pad.h
+++ b/src/plugins/intel_cpu/src/dnnl_scratch_pad.h
@@ -17,7 +17,7 @@ class DnnlScratchPad {
     dnnl::engine eng;
 
 public:
-    DnnlScratchPad(dnnl::engine eng, int numa_node = -1) : eng(eng) {
+    DnnlScratchPad(const dnnl::engine& eng, int numa_node = -1) : eng(eng) {
         mgrPtr = std::make_shared<DnnlMemoryMngr>(make_unique<MemoryMngrWithReuse>(numa_node));
     }
 
diff --git a/src/plugins/intel_cpu/src/graph_context.h b/src/plugins/intel_cpu/src/graph_context.h
index 84ad2d7adb8..3cfbb0274f7 100644
--- a/src/plugins/intel_cpu/src/graph_context.h
+++ b/src/plugins/intel_cpu/src/graph_context.h
@@ -23,7 +23,7 @@ public:
                  bool isGraphQuantized,
                  ov::threading::IStreamsExecutor::Ptr streamExecutor = nullptr)
         : config(config),
-          weightsCache(w_cache),
+          weightsCache(std::move(w_cache)),
           isGraphQuantizedFlag(isGraphQuantized),
           streamExecutor(streamExecutor) {
         rtParamsCache = std::make_shared<MultiCache>(config.rtCacheCapacity);
diff --git a/src/plugins/intel_cpu/src/node.cpp b/src/plugins/intel_cpu/src/node.cpp
index b5662823d4f..62b564780e3 100644
--- a/src/plugins/intel_cpu/src/node.cpp
+++ b/src/plugins/intel_cpu/src/node.cpp
@@ -913,8 +913,7 @@ void Node::toNumaNode(int numaNodeID) {
     // create scratch pad from specified numa node
     if (scratchpadMem) {
         scratchpadMem = context->getScratchPad(numaNodeID)->createScratchPadMem(scratchpadMem->getDescPtr());
-        auto mem = scratchpadMem->getPrimitive();
-        primArgs[DNNL_ARG_SCRATCHPAD] = mem;
+        primArgs[DNNL_ARG_SCRATCHPAD] = scratchpadMem->getPrimitive();
     }
 
     // mbind constant prim args to numa nodes
diff --git a/src/plugins/intel_cpu/src/nodes/concat.h b/src/plugins/intel_cpu/src/nodes/concat.h
index 5b2b6c73940..9ed331bee4f 100644
--- a/src/plugins/intel_cpu/src/nodes/concat.h
+++ b/src/plugins/intel_cpu/src/nodes/concat.h
@@ -43,7 +43,7 @@ private:
     void exec1DCase();
     std::vector<VectorDims> inputStrides;
     std::vector<size_t> nelemToCopy; // byte moved in each iter
-    size_t nelemTotal;
+    size_t nelemTotal = 0;
     std::vector<size_t> dstOffset; // dst offset for each input
     std::vector<const uint8_t*> srcPtrs;
     bool hasOuterLoop = false;
diff --git a/src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/split_fc.cpp b/src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/split_fc.cpp
index 8ff585cbdd4..4a7149b9b44 100644
--- a/src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/split_fc.cpp
+++ b/src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/split_fc.cpp
@@ -41,6 +41,7 @@ ov::intel_cpu::SplitFC::SplitFC(int sub_stream_num) {
 
         // needn't to split fc when the dim is 0.
         const auto& wgt_shape = fc_weight_node->get_shape();
+        // weight shape size 660000 is a trade-off value, which is summarized and verified by LLMs.
         if (wgt_shape[split_dim] <= 1 || ov::shape_size(wgt_shape) < 6600000) {
             return false;
         }
@@ -185,7 +186,7 @@ ov::intel_cpu::SplitFC::SplitFC(int sub_stream_num) {
         }
 
         // concat all small fc for result.
-        ov::NodeVector concat_args(fc_node_vec);
+        ov::NodeVector concat_args(std::move(fc_node_vec));
         // concat happens on the latest dimension.
         constexpr size_t concat_dim = -1;
         auto concat_node = std::make_shared<ov::op::v0::Concat>(concat_args, concat_dim);