natas_hw
/
openvino
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Snippets] Fixed Invalid Read in FuseLoops pass (#24880) 

### Details:
- *Fixed Invalid Read in FuseLoops pass. Before we save loop ports by
reference from `current_loop_info`. However, this `current_loop_Info`
might be changed (another shared pointer) and the previous saved loop
ports by reference are invalid (the original `current_loop_info` is
expired)*
 - *`Valgrind` doesn't throw exception anymore with this fix*

### Tickets:
 - *N/A*
This commit is contained in:
Alexandra Sidorova 2024-06-07 09:29:01 +03:00 committed by GitHub
parent 416c4ffb7e
commit 00510e69fd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/common/snippets/src/lowered/pass/fuse_loops.cpp
View File

@ -220,10 +220,11 @@ bool FuseLoops::run(LinearIR& linear_ir, lowered::LinearIR::constExprIt begin, l
// Loop_0 (Upper) | // Loop_0 (Upper) |
// | => | // | => |
// Loop_1 (Current) Loop_0 + Loop_1 => new `Loop_1` // Loop_1 (Current) Loop_0 + Loop_1 => new `Loop_1`
const auto& input_ports = current_loop_info->get_input_ports(); // Make a copy of `input_ports` (not ref), since current_loop_info might be changed and ref will be invalid
const auto input_ports = current_loop_info->get_input_ports();
bool was_fusion_up = false; bool was_fusion_up = false;
for (size_t in_port = 0; in_port < input_ports.size() && !was_fusion_up; ++in_port) { for (size_t in_port = 0; !was_fusion_up && in_port < input_ports.size(); ++in_port) {
const auto input_port = input_ports[in_port]; const auto& input_port = input_ports[in_port];
const auto parent_expr_output = *input_port.expr_port->get_connected_ports().begin(); const auto parent_expr_output = *input_port.expr_port->get_connected_ports().begin();
const auto& parent_expr = parent_expr_output.get_expr(); const auto& parent_expr = parent_expr_output.get_expr();
const auto parent = parent_expr->get_node(); const auto parent = parent_expr->get_node();
@ -265,10 +266,10 @@ bool FuseLoops::run(LinearIR& linear_ir, lowered::LinearIR::constExprIt begin, l
// Loop_0 (Current) Loop_0 + Loop_1 => new `Loop_0` // Loop_0 (Current) Loop_0 + Loop_1 => new `Loop_0`
// | => | // | => |
// Loop_1 (Lower) | // Loop_1 (Lower) |
const auto& output_ports = current_loop_info->get_output_ports();
bool was_fusion_down = false; bool was_fusion_down = false;
for (size_t out_port = 0; out_port < output_ports.size() && !was_fusion_down; ++out_port) { const auto& output_ports = current_loop_info->get_output_ports();
const auto output_port = output_ports[out_port]; for (size_t out_port = 0; !was_fusion_down && out_port < output_ports.size(); ++out_port) {
const auto& output_port = output_ports[out_port];
const auto consumer_exprs_inputs = output_port.expr_port->get_connected_ports(); const auto consumer_exprs_inputs = output_port.expr_port->get_connected_ports();
for (const auto& consumer_expr_input : consumer_exprs_inputs) { for (const auto& consumer_expr_input : consumer_exprs_inputs) {
const auto& consumer_expr = consumer_expr_input.get_expr(); const auto& consumer_expr = consumer_expr_input.get_expr();