From 92a19a1ba485b405a9ba5d2afd77b75c4658d089 Mon Sep 17 00:00:00 2001
From: Fedor Isakov <fisakov@gmail.com>
Date: Wed, 2 Oct 2024 15:11:38 +0200
Subject: [PATCH] Change API method signature for more optimal usage

---
 reactor/Core/src/jetbrains/mps/unification/Term.java         | 4 ++--
 .../Test/src/jetbrains/mps/unification/test/MockTerm.java    | 5 ++---
 .../test/jetbrains/mps/unification/test/SolverTests.java     | 4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/reactor/Core/src/jetbrains/mps/unification/Term.java b/reactor/Core/src/jetbrains/mps/unification/Term.java
index c27bc194..446e15bb 100644
--- a/reactor/Core/src/jetbrains/mps/unification/Term.java
+++ b/reactor/Core/src/jetbrains/mps/unification/Term.java
@@ -17,11 +17,11 @@
 package jetbrains.mps.unification;
 
 import jetbrains.mps.logic.reactor.logical.Logical;
-import jetbrains.mps.logic.reactor.logical.LogicalOwner;
 import org.jetbrains.annotations.NotNull;
 
 import java.util.Collection;
 import java.util.Collections;
+import java.util.List;
 
 /**
  * Represents a node in a term graph. The graph may contain cycles. A node in a term
@@ -46,7 +46,7 @@ public interface Term extends Comparable<Term> {
     /**
      * Arguments of a function term.
      */
-    Collection<? extends Term> arguments();
+    List<? extends Term> arguments();
 
     /**
      * A collection of all instances of {@link jetbrains.mps.logic.reactor.logical.Logical}
diff --git a/reactor/Test/src/jetbrains/mps/unification/test/MockTerm.java b/reactor/Test/src/jetbrains/mps/unification/test/MockTerm.java
index 44d1c73d..90311ce2 100644
--- a/reactor/Test/src/jetbrains/mps/unification/test/MockTerm.java
+++ b/reactor/Test/src/jetbrains/mps/unification/test/MockTerm.java
@@ -22,7 +22,6 @@ import jetbrains.mps.unification.Term;
 import org.jetbrains.annotations.NotNull;
 
 import java.util.Arrays;
-import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
 
@@ -69,7 +68,7 @@ public abstract class MockTerm implements Term {
     }
 
     @Override
-    public Collection<? extends Term> arguments() {
+    public List<? extends Term> arguments() {
         return Collections.emptyList();
     }
 
@@ -99,7 +98,7 @@ public abstract class MockTerm implements Term {
         }
 
         @Override
-        public Collection<Term> arguments() {
+        public List<? extends Term> arguments() {
             return Collections.unmodifiableList(myArgs);
         }
 
diff --git a/reactor/Test/test/jetbrains/mps/unification/test/SolverTests.java b/reactor/Test/test/jetbrains/mps/unification/test/SolverTests.java
index 7d269fea..4ec19c80 100644
--- a/reactor/Test/test/jetbrains/mps/unification/test/SolverTests.java
+++ b/reactor/Test/test/jetbrains/mps/unification/test/SolverTests.java
@@ -26,8 +26,8 @@ import org.jetbrains.annotations.NotNull;
 import org.junit.Ignore;
 import org.junit.Test;
 
-import java.util.Collection;
 import java.util.Collections;
+import java.util.List;
 
 import static jetbrains.mps.unification.Substitution.FailureCause.CYCLE_DETECTED;
 import static jetbrains.mps.unification.Substitution.FailureCause.SYMBOL_CLASH;
@@ -456,7 +456,7 @@ public class SolverTests {
             }
 
             @Override
-            public Collection<? extends Term> arguments() {
+            public List<? extends Term> arguments() {
                 return Collections.emptyList();
             }