From 78f847747b925287b63abe5a23562b70e185ca4a Mon Sep 17 00:00:00 2001 From: Fedor Isakov Date: Fri, 26 Aug 2022 13:58:07 +0200 Subject: [PATCH] Drop unstable hacks, simplify code --- build.xml | 18 +- .../jetbrains.mps.coderules.ideaplugin.msd | 2 +- .../jetbrains.mps.coderules.ideaplugin.mps | 439 +++++------- .../source.caches/deps.cp | 17 + .../mps/coderules/ideaplugin/dependencies | 17 + .../mps/coderules/ideaplugin/generated | 5 + .../ideaplugin/TypecheckingOptions.java | 60 +- .../mps/coderules/ideaplugin/trace.info | 233 ++++--- ...rains.mps.coderules.typechecking@tests.mps | 21 +- ...ains.mps.coderules.typechecking.plugin.mps | 649 +----------------- .../jetbrains.mps.lang.coderules.aspect.mps | 42 +- ...s.mps.baseLanguageExt.test.types@tests.mps | 7 +- 12 files changed, 442 insertions(+), 1068 deletions(-) create mode 100644 coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/deps.cp create mode 100644 coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/jetbrains/mps/coderules/ideaplugin/dependencies create mode 100644 coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/jetbrains/mps/coderules/ideaplugin/generated diff --git a/build.xml b/build.xml index 39becda4..72d0a7b3 100644 --- a/build.xml +++ b/build.xml @@ -62,14 +62,14 @@ - + - + @@ -1461,14 +1461,14 @@ - + - + @@ -2607,14 +2607,14 @@ - + - + @@ -3751,12 +3751,12 @@ - + - + @@ -5964,7 +5964,7 @@ - + diff --git a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/jetbrains.mps.coderules.ideaplugin.msd b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/jetbrains.mps.coderules.ideaplugin.msd index d69d184a..f497c7f7 100644 --- a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/jetbrains.mps.coderules.ideaplugin.msd +++ b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/jetbrains.mps.coderules.ideaplugin.msd @@ -1,5 +1,5 @@ - + diff --git a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/models/jetbrains.mps.coderules.ideaplugin.mps b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/models/jetbrains.mps.coderules.ideaplugin.mps index 695bd105..183354cc 100644 --- a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/models/jetbrains.mps.coderules.ideaplugin.mps +++ b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/models/jetbrains.mps.coderules.ideaplugin.mps @@ -217,11 +217,6 @@ - - - - - @@ -742,61 +737,207 @@ - - - - - - - - - - - - - - - - + + + + - - - - + + + + - + - - + + + - + - - - - - - - - + + + + + - - - + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -981,222 +1122,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/deps.cp b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/deps.cp new file mode 100644 index 00000000..0280e3f4 --- /dev/null +++ b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/deps.cp @@ -0,0 +1,17 @@ + + + + + + + + + + + + + + + + + diff --git a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/jetbrains/mps/coderules/ideaplugin/dependencies b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/jetbrains/mps/coderules/ideaplugin/dependencies new file mode 100644 index 00000000..0280e3f4 --- /dev/null +++ b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/jetbrains/mps/coderules/ideaplugin/dependencies @@ -0,0 +1,17 @@ + + + + + + + + + + + + + + + + + diff --git a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/jetbrains/mps/coderules/ideaplugin/generated b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/jetbrains/mps/coderules/ideaplugin/generated new file mode 100644 index 00000000..bd2f5ba1 --- /dev/null +++ b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source.caches/jetbrains/mps/coderules/ideaplugin/generated @@ -0,0 +1,5 @@ + + + + + diff --git a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source/jetbrains/mps/coderules/ideaplugin/TypecheckingOptions.java b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source/jetbrains/mps/coderules/ideaplugin/TypecheckingOptions.java index 35bb32b1..0bac09af 100644 --- a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source/jetbrains/mps/coderules/ideaplugin/TypecheckingOptions.java +++ b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source/jetbrains/mps/coderules/ideaplugin/TypecheckingOptions.java @@ -2,8 +2,6 @@ package jetbrains.mps.coderules.ideaplugin; /*Generated by MPS */ -import java.util.Map; -import jetbrains.mps.internal.collections.runtime.MapSequence; public class TypecheckingOptions { public static final String PREFIX = "mps.coderules.typechecking."; @@ -60,12 +58,37 @@ public class TypecheckingOptions { return USER_CONFIG; } - public static Config getParamConfig(Map paramMap) { - Config config = getUserConfig().copy(); - registerParamMapProvider(config, paramMap); + public static Config getUiConfig() { + Config config = TypecheckingOptions.getUserConfig().copy(); + registerUiProvider(config); return config; } + private static void registerUiProvider(Config config) { + + config.registerProvider(Config.Level.UI, PREFIX, (String key) -> { + + TypecheckingSettings settings = TypecheckingSettings.getInstace(); + if (OPTION_TYPECHECKING_ENABLED.equals(key)) { + return settings.isTypecheckingEnabled(); + } + + if (OPTION_TYPECHECKING_WATCHING.equals(key)) { + return settings.isWatchingEnabled(); + } + + if (OPTION_TYPECHECKING_REPORTING.equals(key)) { + return settings.isReportingEnabled(); + } + + if (OPTION_TYPECHECKING_TRACE.equals(key)) { + return settings.isTracingEnabled(); + } + + return null; + }); + } + private static void registerDefaultProviders(Config config) { CoderulesOptions.registerDefaultProviders(config); @@ -95,31 +118,4 @@ public class TypecheckingOptions { }); } - public static void registerParamMapProvider(Config config, final Map paramMap) { - config.registerProvider(Config.Level.UI, PREFIX, (String key) -> { - - if (OPTION_TYPECHECKING_ENABLED.equals(key)) { - - return (MapSequence.fromMap(paramMap).get(OPTION_TYPECHECKING_ENABLED) != null ? MapSequence.fromMap(paramMap).get(OPTION_TYPECHECKING_ENABLED) : false); - } - - if (OPTION_TYPECHECKING_WATCHING.equals(key)) { - return (MapSequence.fromMap(paramMap).get(OPTION_TYPECHECKING_WATCHING) != null ? MapSequence.fromMap(paramMap).get(OPTION_TYPECHECKING_WATCHING) : false); - - } - - if (OPTION_TYPECHECKING_REPORTING.equals(key)) { - return (MapSequence.fromMap(paramMap).get(OPTION_TYPECHECKING_REPORTING) != null ? MapSequence.fromMap(paramMap).get(OPTION_TYPECHECKING_REPORTING) : false); - - } - - if (OPTION_TYPECHECKING_TRACE.equals(key)) { - return (MapSequence.fromMap(paramMap).get(OPTION_TYPECHECKING_TRACE) != null ? MapSequence.fromMap(paramMap).get(OPTION_TYPECHECKING_TRACE) : false); - - } - - return null; - }); - } - } diff --git a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source/jetbrains/mps/coderules/ideaplugin/trace.info b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source/jetbrains/mps/coderules/ideaplugin/trace.info index 8796061e..a6fd5eb9 100644 --- a/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source/jetbrains/mps/coderules/ideaplugin/trace.info +++ b/coderules/solutions/jetbrains.mps.coderules.ideaplugin/source/jetbrains/mps/coderules/ideaplugin/trace.info @@ -627,138 +627,135 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - + - + - + - - - - - - + + + + - - - - - - - - + + + - + + + + + + + - - - - - - + + + + + + diff --git a/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking@tests.mps b/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking@tests.mps index b72ad67d..5cd13ea5 100644 --- a/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking@tests.mps +++ b/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking@tests.mps @@ -3852,10 +3852,9 @@ - - - - + + + @@ -4084,10 +4083,9 @@ - - - - + + + @@ -4328,10 +4326,9 @@ - - - - + + + diff --git a/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.plugin.mps b/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.plugin.mps index 14e0a181..738e0e1d 100644 --- a/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.plugin.mps +++ b/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.plugin.mps @@ -657,100 +657,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -890,12 +796,9 @@ - - + + - - - @@ -1328,73 +1231,15 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + - - - @@ -1408,7 +1253,16 @@ - + + + + + + + + + + @@ -1418,39 +1272,18 @@ - - - - - - - - - - - - - - - + + + - + - - - - - - - - - @@ -1483,26 +1316,7 @@ - - - - - - - - - - - - - - - - - - - - + @@ -6517,12 +6331,9 @@ - - - - - - + + + @@ -8211,410 +8022,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -9187,15 +8594,9 @@ - - - - - - - - - + + + diff --git a/coderules/solutions/jetbrains.mps.lang.coderules.template/models/jetbrains.mps.lang.coderules.aspect.mps b/coderules/solutions/jetbrains.mps.lang.coderules.template/models/jetbrains.mps.lang.coderules.aspect.mps index e4add28b..9b7fc334 100644 --- a/coderules/solutions/jetbrains.mps.lang.coderules.template/models/jetbrains.mps.lang.coderules.aspect.mps +++ b/coderules/solutions/jetbrains.mps.lang.coderules.template/models/jetbrains.mps.lang.coderules.aspect.mps @@ -192,6 +192,11 @@ + + + + + @@ -721,32 +726,41 @@ - - - - - - - - - + + + + + + + + + + + + + + + - - + + + + + @@ -755,6 +769,12 @@ + + + + + + diff --git a/samples/mpscore/solutions/jetbrains.mps.baseLanguageExt.test/models/jetbrains.mps.baseLanguageExt.test.types@tests.mps b/samples/mpscore/solutions/jetbrains.mps.baseLanguageExt.test/models/jetbrains.mps.baseLanguageExt.test.types@tests.mps index 5d8462af..cd9f2bc8 100644 --- a/samples/mpscore/solutions/jetbrains.mps.baseLanguageExt.test/models/jetbrains.mps.baseLanguageExt.test.types@tests.mps +++ b/samples/mpscore/solutions/jetbrains.mps.baseLanguageExt.test/models/jetbrains.mps.baseLanguageExt.test.types@tests.mps @@ -466,10 +466,9 @@ - - - - + + +