From 43297ce5c67754ae4b7d2e9883e14d563657ccc4 Mon Sep 17 00:00:00 2001 From: Grigorii Kirgizov Date: Tue, 14 Apr 2020 16:32:27 +0300 Subject: [PATCH] Separate logic of being able to report feedback from handling it (i.e. recovering from failure), fixes MPSCR-57 Also rename ruleTag param in feedback methods to 'feedbackKey', what it really is. feedbackKey is used in TypesCache internal ReportItem map as a key. --- .../jetbrains.mps.lang.coderules.eval.mps | 945 ++++++++++-------- ...s.mps.coderules.typechecking.test.util.mps | 364 +++---- ...rains.mps.coderules.typechecking@tests.mps | 49 +- ...ins.mps.coderules.typechecking.service.mps | 4 +- .../models/service.mps | 91 +- .../models/service.mps | 2 +- 6 files changed, 735 insertions(+), 720 deletions(-) diff --git a/coderules/languages/jetbrains.mps.lang.coderules/runtime/models/jetbrains.mps.lang.coderules.eval.mps b/coderules/languages/jetbrains.mps.lang.coderules/runtime/models/jetbrains.mps.lang.coderules.eval.mps index 41f24a9f..51067494 100644 --- a/coderules/languages/jetbrains.mps.lang.coderules/runtime/models/jetbrains.mps.lang.coderules.eval.mps +++ b/coderules/languages/jetbrains.mps.lang.coderules/runtime/models/jetbrains.mps.lang.coderules.eval.mps @@ -8968,96 +8968,33 @@ - - - - + + + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + - + @@ -9081,288 +9018,263 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - + + + + + + + + + + + @@ -9375,33 +9287,291 @@ - - - - - - - - - - - - + + + + + + + + + - - - + + + + + + + + + + + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -9502,12 +9672,12 @@ - - + + - - + + @@ -9519,33 +9689,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking.test.util.mps b/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking.test.util.mps index 834eef3f..d2a2e7ec 100644 --- a/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking.test.util.mps +++ b/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking.test.util.mps @@ -100,7 +100,6 @@ - @@ -121,9 +120,7 @@ - - - + @@ -141,9 +138,6 @@ - - - @@ -189,7 +183,6 @@ - @@ -247,13 +240,6 @@ - - - - - - - @@ -267,9 +253,6 @@ - - - @@ -283,7 +266,6 @@ - @@ -314,10 +296,6 @@ - - - - @@ -333,7 +311,6 @@ - @@ -1100,61 +1077,59 @@ - - - - - + + + + + - - - + + + - - - - - - - - - - - - + + + + - - - + + + - - - - + + + + - - - + + + - + - + - - - + + + + + + + + + - + - - + + @@ -1167,11 +1142,11 @@ - + - + @@ -1183,7 +1158,7 @@ - + @@ -1191,12 +1166,12 @@ - + - + @@ -1206,7 +1181,7 @@ - + @@ -1215,6 +1190,30 @@ + + + + + + + + + + + + + + + + + + + + + + + + @@ -2923,21 +2922,6 @@ - - - - - - - - - - - - - - - @@ -2962,28 +2946,26 @@ - - - - - - - + + + + - - - - - - - - - + + + + + + + + + + @@ -3183,107 +3165,35 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -3312,24 +3222,6 @@ - - - - - - - - - - - - - - - - - - @@ -3395,39 +3287,25 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + diff --git a/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking@tests.mps b/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking@tests.mps index e37000ec..21ae1e05 100644 --- a/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking@tests.mps +++ b/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking@tests.mps @@ -1303,48 +1303,19 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + - - - - - - - - - + + - - - - - - diff --git a/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.service.mps b/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.service.mps index 722ae437..e2994917 100644 --- a/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.service.mps +++ b/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.service.mps @@ -5074,7 +5074,7 @@ - + @@ -5112,7 +5112,7 @@ - + diff --git a/coderules/solutions/jetbrains.mps.coderules/models/service.mps b/coderules/solutions/jetbrains.mps.coderules/models/service.mps index 68ea8648..8f42e743 100644 --- a/coderules/solutions/jetbrains.mps.coderules/models/service.mps +++ b/coderules/solutions/jetbrains.mps.coderules/models/service.mps @@ -1939,20 +1939,19 @@ - - + + - - - + + + - - - + + + - - - + + @@ -1961,31 +1960,38 @@ - - - + + + + - + - - - - + + + + - + - + - + - + - - - + + + + + + + + + @@ -1994,7 +2000,7 @@ - + @@ -2002,17 +2008,17 @@ - + - - + + - + - + @@ -2021,7 +2027,7 @@ - + @@ -2030,6 +2036,23 @@ + + + + + + + + + + + + + + + + + @@ -2667,7 +2690,7 @@ - + diff --git a/coderules/solutions/jetbrains.mps.controlflow/models/service.mps b/coderules/solutions/jetbrains.mps.controlflow/models/service.mps index 6c175fee..f3477e7c 100644 --- a/coderules/solutions/jetbrains.mps.controlflow/models/service.mps +++ b/coderules/solutions/jetbrains.mps.controlflow/models/service.mps @@ -450,7 +450,7 @@ - +