From 417fc459333f79ed85b593e9117d29f0fcab63f6 Mon Sep 17 00:00:00 2001 From: Fedor Isakov Date: Mon, 17 Feb 2020 11:53:04 +0100 Subject: [PATCH] Restore origin ref in RuleEx interface, fix terminology in templates API. To avoid confusion, a rule defines "target ref", which is supposed to indicate the source code location for possible errors. The origin node is to be referred as "origin" as before. Temporarily rename OriginSpec's alias to "target" to reflect change in semantics. --- .../generator/template/main@generator.mps | 308 +++++++----------- .../languageModels/structure.mps | 2 +- .../jetbrains.mps.lang.coderules.eval.mps | 8 +- ...s.mps.coderules.typechecking.test.util.mps | 53 ++- .../models/plugin.mps | 8 +- .../jetbrains.mps.lang.coderules.template.mps | 121 ++++++- ...baseLanguageExt.test.incremental@tests.mps | 8 +- 7 files changed, 256 insertions(+), 252 deletions(-) diff --git a/coderules/languages/jetbrains.mps.lang.coderules/generator/template/main@generator.mps b/coderules/languages/jetbrains.mps.lang.coderules/generator/template/main@generator.mps index de85621b..517ff9d1 100644 --- a/coderules/languages/jetbrains.mps.lang.coderules/generator/template/main@generator.mps +++ b/coderules/languages/jetbrains.mps.lang.coderules/generator/template/main@generator.mps @@ -274,6 +274,9 @@ + + + @@ -830,7 +833,7 @@ - + @@ -1456,7 +1459,7 @@ - + @@ -1495,7 +1498,7 @@ - + @@ -14236,7 +14239,7 @@ - + @@ -16124,7 +16127,7 @@ - + @@ -16133,13 +16136,13 @@ - + - + @@ -16149,7 +16152,7 @@ - + @@ -16192,110 +16195,12 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + @@ -16476,103 +16381,126 @@ - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - + + + + + + + + + + + - + - + - + diff --git a/coderules/languages/jetbrains.mps.lang.coderules/languageModels/structure.mps b/coderules/languages/jetbrains.mps.lang.coderules/languageModels/structure.mps index 300ce9ce..95644b5e 100644 --- a/coderules/languages/jetbrains.mps.lang.coderules/languageModels/structure.mps +++ b/coderules/languages/jetbrains.mps.lang.coderules/languageModels/structure.mps @@ -1382,7 +1382,7 @@ - + diff --git a/coderules/languages/jetbrains.mps.lang.coderules/runtime/models/jetbrains.mps.lang.coderules.eval.mps b/coderules/languages/jetbrains.mps.lang.coderules/runtime/models/jetbrains.mps.lang.coderules.eval.mps index 0053c1f7..48f18a73 100644 --- a/coderules/languages/jetbrains.mps.lang.coderules/runtime/models/jetbrains.mps.lang.coderules.eval.mps +++ b/coderules/languages/jetbrains.mps.lang.coderules/runtime/models/jetbrains.mps.lang.coderules.eval.mps @@ -8676,17 +8676,17 @@ + + + - + - - - diff --git a/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking.test.util.mps b/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking.test.util.mps index dc3ef520..3d259778 100644 --- a/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking.test.util.mps +++ b/coderules/solutions/jetbrains.mps.coderules.typechecking.test/models/jetbrains.mps.coderules.typechecking.test.util.mps @@ -3036,15 +3036,20 @@ - - + + - - - + + + + + + + + - - + + @@ -3143,24 +3148,17 @@ - - - - - - - - - - - - - - - + + + + + + + + @@ -3169,15 +3167,8 @@ - - - - - - - - - + + diff --git a/coderules/solutions/jetbrains.mps.coderules.ui/models/plugin.mps b/coderules/solutions/jetbrains.mps.coderules.ui/models/plugin.mps index 5fef3bd3..2d89249d 100644 --- a/coderules/solutions/jetbrains.mps.coderules.ui/models/plugin.mps +++ b/coderules/solutions/jetbrains.mps.coderules.ui/models/plugin.mps @@ -18490,8 +18490,8 @@ - - + + @@ -21392,8 +21392,8 @@ - - + + diff --git a/coderules/solutions/jetbrains.mps.lang.coderules.template/models/jetbrains.mps.lang.coderules.template.mps b/coderules/solutions/jetbrains.mps.lang.coderules.template/models/jetbrains.mps.lang.coderules.template.mps index 9ef6a899..21270455 100644 --- a/coderules/solutions/jetbrains.mps.lang.coderules.template/models/jetbrains.mps.lang.coderules.template.mps +++ b/coderules/solutions/jetbrains.mps.lang.coderules.template/models/jetbrains.mps.lang.coderules.template.mps @@ -2692,14 +2692,48 @@ - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -2710,6 +2744,13 @@ + + + + + + + @@ -2835,7 +2876,7 @@ - + @@ -2911,12 +2952,12 @@ - + - + @@ -4749,8 +4790,15 @@ + + + + + + + - + @@ -5165,7 +5213,7 @@ - + @@ -5752,15 +5800,28 @@ + + + + + + + + + + + + + - + - + @@ -5877,8 +5938,14 @@ - + + + + + + + @@ -5950,8 +6017,26 @@ - + + + + + + + + + + + + + + + + + + + @@ -5960,7 +6045,7 @@ - + @@ -6299,17 +6384,17 @@ - + - - + + - - - - + + + + diff --git a/samples/mpscore/solutions/jetbrains.mps.baseLanguageExt.test/models/jetbrains.mps.baseLanguageExt.test.incremental@tests.mps b/samples/mpscore/solutions/jetbrains.mps.baseLanguageExt.test/models/jetbrains.mps.baseLanguageExt.test.incremental@tests.mps index 69810916..31e5c8ab 100644 --- a/samples/mpscore/solutions/jetbrains.mps.baseLanguageExt.test/models/jetbrains.mps.baseLanguageExt.test.incremental@tests.mps +++ b/samples/mpscore/solutions/jetbrains.mps.baseLanguageExt.test/models/jetbrains.mps.baseLanguageExt.test.incremental@tests.mps @@ -778,8 +778,8 @@ - - + + @@ -794,8 +794,8 @@ - - + +