From 1e5c83dd93c8179434398a67f85d7d969ed5bc0a Mon Sep 17 00:00:00 2001
From: Fedor Isakov <fisakov@gmail.com>
Date: Fri, 18 Oct 2019 17:03:56 +0200
Subject: [PATCH] Avoid failing with NPE if a project pref component is not
 available.

---
 ...ains.mps.coderules.typechecking.plugin.mps | 169 ++++++++++--------
 1 file changed, 90 insertions(+), 79 deletions(-)

diff --git a/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.plugin.mps b/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.plugin.mps
index bd7e0848..64b023be 100644
--- a/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.plugin.mps
+++ b/coderules/solutions/jetbrains.mps.coderules.typechecking/models/jetbrains.mps.coderules.typechecking.plugin.mps
@@ -4723,95 +4723,106 @@
                 </node>
                 <node concept="3clFbS" id="7iCybvTyBsS" role="1bW5cS">
                   <node concept="3clFbH" id="7iCybvTyBIw" role="3cqZAp" />
-                  <node concept="3clFbJ" id="7iCybvTyBUS" role="3cqZAp">
-                    <node concept="3clFbS" id="7iCybvTyBUU" role="3clFbx">
-                      <node concept="3cpWs6" id="7iCybvTyCRL" role="3cqZAp">
-                        <node concept="2OqwBi" id="7iCybvTyFDs" role="3cqZAk">
-                          <node concept="2OqwBi" id="7iCybvTyF9d" role="2Oq$k0">
-                            <node concept="37vLTw" id="7iCybvTyEME" role="2Oq$k0">
-                              <ref role="3cqZAo" node="7iCybvTyDYC" resolve="project" />
-                            </node>
-                            <node concept="LR4Ub" id="7iCybvTyF$k" role="2OqNvi">
-                              <ref role="LR4Ua" node="uB9WAZagv8" resolve="Typechecking" />
-                            </node>
-                          </node>
-                          <node concept="34pFcN" id="7iCybvTyFI4" role="2OqNvi">
-                            <ref role="2WH_rO" node="14pL6xi901F" resolve="typecheckingEnabled" />
-                          </node>
+                  <node concept="3cpWs8" id="5gVsyvEZeb$" role="3cqZAp">
+                    <node concept="3cpWsn" id="5gVsyvEZeb_" role="3cpWs9">
+                      <property role="TrG5h" value="pref" />
+                      <node concept="34_ZPX" id="5gVsyvEZ5zE" role="1tU5fm">
+                        <ref role="34A7Nh" node="uB9WAZagv8" resolve="Typechecking" />
+                      </node>
+                      <node concept="2OqwBi" id="5gVsyvEZebA" role="33vP2m">
+                        <node concept="37vLTw" id="5gVsyvEZebB" role="2Oq$k0">
+                          <ref role="3cqZAo" node="7iCybvTyDYC" resolve="project" />
                         </node>
-                      </node>
-                    </node>
-                    <node concept="2OqwBi" id="7iCybvTyCd5" role="3clFbw">
-                      <node concept="37vLTw" id="7iCybvTyUUv" role="2Oq$k0">
-                        <ref role="3cqZAo" node="7iCybvTyUUs" resolve="OPTION_TYPECHECKING_ENABLED" />
-                      </node>
-                      <node concept="liA8E" id="7iCybvTyCAG" role="2OqNvi">
-                        <ref role="37wK5l" to="wyt6:~String.equals(java.lang.Object)" resolve="equals" />
-                        <node concept="37vLTw" id="7iCybvTyCHb" role="37wK5m">
-                          <ref role="3cqZAo" node="7iCybvTyBuB" resolve="key" />
+                        <node concept="LR4Ub" id="5gVsyvEZebC" role="2OqNvi">
+                          <ref role="LR4Ua" node="uB9WAZagv8" resolve="Typechecking" />
                         </node>
                       </node>
                     </node>
                   </node>
-                  <node concept="3clFbH" id="7iCybvTyG2a" role="3cqZAp" />
-                  <node concept="3clFbJ" id="7iCybvTyFXl" role="3cqZAp">
-                    <node concept="3clFbS" id="7iCybvTyFXm" role="3clFbx">
-                      <node concept="3cpWs6" id="7iCybvTyFXn" role="3cqZAp">
-                        <node concept="2OqwBi" id="7iCybvTyFXo" role="3cqZAk">
-                          <node concept="2OqwBi" id="7iCybvTyFXp" role="2Oq$k0">
-                            <node concept="37vLTw" id="7iCybvTyFXq" role="2Oq$k0">
-                              <ref role="3cqZAo" node="7iCybvTyDYC" resolve="project" />
-                            </node>
-                            <node concept="LR4Ub" id="7iCybvTyFXr" role="2OqNvi">
-                              <ref role="LR4Ua" node="uB9WAZagv8" resolve="Typechecking" />
+                  <node concept="3clFbJ" id="5gVsyvEZfcD" role="3cqZAp">
+                    <node concept="3clFbS" id="5gVsyvEZfcF" role="3clFbx">
+                      <node concept="3clFbJ" id="7iCybvTyBUS" role="3cqZAp">
+                        <node concept="3clFbS" id="7iCybvTyBUU" role="3clFbx">
+                          <node concept="3cpWs6" id="7iCybvTyCRL" role="3cqZAp">
+                            <node concept="2OqwBi" id="7iCybvTyFDs" role="3cqZAk">
+                              <node concept="37vLTw" id="5gVsyvEZebD" role="2Oq$k0">
+                                <ref role="3cqZAo" node="5gVsyvEZeb_" resolve="pref" />
+                              </node>
+                              <node concept="34pFcN" id="7iCybvTyFI4" role="2OqNvi">
+                                <ref role="2WH_rO" node="14pL6xi901F" resolve="typecheckingEnabled" />
+                              </node>
                             </node>
                           </node>
-                          <node concept="34pFcN" id="7iCybvTyGmp" role="2OqNvi">
-                            <ref role="2WH_rO" node="14IknWHoSHp" resolve="incrementalityEnabled" />
+                        </node>
+                        <node concept="2OqwBi" id="7iCybvTyCd5" role="3clFbw">
+                          <node concept="37vLTw" id="7iCybvTyUUv" role="2Oq$k0">
+                            <ref role="3cqZAo" node="7iCybvTyUUs" resolve="OPTION_TYPECHECKING_ENABLED" />
+                          </node>
+                          <node concept="liA8E" id="7iCybvTyCAG" role="2OqNvi">
+                            <ref role="37wK5l" to="wyt6:~String.equals(java.lang.Object)" resolve="equals" />
+                            <node concept="37vLTw" id="7iCybvTyCHb" role="37wK5m">
+                              <ref role="3cqZAo" node="7iCybvTyBuB" resolve="key" />
+                            </node>
+                          </node>
+                        </node>
+                      </node>
+                      <node concept="3clFbH" id="7iCybvTyG2a" role="3cqZAp" />
+                      <node concept="3clFbJ" id="7iCybvTyFXl" role="3cqZAp">
+                        <node concept="3clFbS" id="7iCybvTyFXm" role="3clFbx">
+                          <node concept="3cpWs6" id="7iCybvTyFXn" role="3cqZAp">
+                            <node concept="2OqwBi" id="7iCybvTyFXo" role="3cqZAk">
+                              <node concept="37vLTw" id="5gVsyvEZebE" role="2Oq$k0">
+                                <ref role="3cqZAo" node="5gVsyvEZeb_" resolve="pref" />
+                              </node>
+                              <node concept="34pFcN" id="7iCybvTyGmp" role="2OqNvi">
+                                <ref role="2WH_rO" node="14IknWHoSHp" resolve="incrementalityEnabled" />
+                              </node>
+                            </node>
+                          </node>
+                        </node>
+                        <node concept="2OqwBi" id="7iCybvTyFXt" role="3clFbw">
+                          <node concept="37vLTw" id="7iCybvTyVt0" role="2Oq$k0">
+                            <ref role="3cqZAo" node="7iCybvTyVsX" resolve="OPTION_TYPECHECKING_INCREMENTAL" />
+                          </node>
+                          <node concept="liA8E" id="7iCybvTyFXv" role="2OqNvi">
+                            <ref role="37wK5l" to="wyt6:~String.equals(java.lang.Object)" resolve="equals" />
+                            <node concept="37vLTw" id="7iCybvTyFXw" role="37wK5m">
+                              <ref role="3cqZAo" node="7iCybvTyBuB" resolve="key" />
+                            </node>
+                          </node>
+                        </node>
+                      </node>
+                      <node concept="3clFbH" id="7iCybvTyGG0" role="3cqZAp" />
+                      <node concept="3clFbJ" id="7iCybvTyGA8" role="3cqZAp">
+                        <node concept="3clFbS" id="7iCybvTyGA9" role="3clFbx">
+                          <node concept="3cpWs6" id="7iCybvTyGAa" role="3cqZAp">
+                            <node concept="2OqwBi" id="7iCybvTyGAb" role="3cqZAk">
+                              <node concept="37vLTw" id="5gVsyvEZebF" role="2Oq$k0">
+                                <ref role="3cqZAo" node="5gVsyvEZeb_" resolve="pref" />
+                              </node>
+                              <node concept="34pFcN" id="7iCybvTyGQe" role="2OqNvi">
+                                <ref role="2WH_rO" node="7iCybvTnn8F" resolve="traceEnabled" />
+                              </node>
+                            </node>
+                          </node>
+                        </node>
+                        <node concept="2OqwBi" id="7iCybvTyGAg" role="3clFbw">
+                          <node concept="37vLTw" id="7iCybvTyWow" role="2Oq$k0">
+                            <ref role="3cqZAo" node="7iCybvTyWot" resolve="OPTION_TYPECHECKING_TRACE" />
+                          </node>
+                          <node concept="liA8E" id="7iCybvTyGAi" role="2OqNvi">
+                            <ref role="37wK5l" to="wyt6:~String.equals(java.lang.Object)" resolve="equals" />
+                            <node concept="37vLTw" id="7iCybvTyGAj" role="37wK5m">
+                              <ref role="3cqZAo" node="7iCybvTyBuB" resolve="key" />
+                            </node>
                           </node>
                         </node>
                       </node>
                     </node>
-                    <node concept="2OqwBi" id="7iCybvTyFXt" role="3clFbw">
-                      <node concept="37vLTw" id="7iCybvTyVt0" role="2Oq$k0">
-                        <ref role="3cqZAo" node="7iCybvTyVsX" resolve="OPTION_TYPECHECKING_INCREMENTAL" />
-                      </node>
-                      <node concept="liA8E" id="7iCybvTyFXv" role="2OqNvi">
-                        <ref role="37wK5l" to="wyt6:~String.equals(java.lang.Object)" resolve="equals" />
-                        <node concept="37vLTw" id="7iCybvTyFXw" role="37wK5m">
-                          <ref role="3cqZAo" node="7iCybvTyBuB" resolve="key" />
-                        </node>
-                      </node>
-                    </node>
-                  </node>
-                  <node concept="3clFbH" id="7iCybvTyGG0" role="3cqZAp" />
-                  <node concept="3clFbJ" id="7iCybvTyGA8" role="3cqZAp">
-                    <node concept="3clFbS" id="7iCybvTyGA9" role="3clFbx">
-                      <node concept="3cpWs6" id="7iCybvTyGAa" role="3cqZAp">
-                        <node concept="2OqwBi" id="7iCybvTyGAb" role="3cqZAk">
-                          <node concept="2OqwBi" id="7iCybvTyGAc" role="2Oq$k0">
-                            <node concept="37vLTw" id="7iCybvTyGAd" role="2Oq$k0">
-                              <ref role="3cqZAo" node="7iCybvTyDYC" resolve="project" />
-                            </node>
-                            <node concept="LR4Ub" id="7iCybvTyGAe" role="2OqNvi">
-                              <ref role="LR4Ua" node="uB9WAZagv8" resolve="Typechecking" />
-                            </node>
-                          </node>
-                          <node concept="34pFcN" id="7iCybvTyGQe" role="2OqNvi">
-                            <ref role="2WH_rO" node="7iCybvTnn8F" resolve="traceEnabled" />
-                          </node>
-                        </node>
-                      </node>
-                    </node>
-                    <node concept="2OqwBi" id="7iCybvTyGAg" role="3clFbw">
-                      <node concept="37vLTw" id="7iCybvTyWow" role="2Oq$k0">
-                        <ref role="3cqZAo" node="7iCybvTyWot" resolve="OPTION_TYPECHECKING_TRACE" />
-                      </node>
-                      <node concept="liA8E" id="7iCybvTyGAi" role="2OqNvi">
-                        <ref role="37wK5l" to="wyt6:~String.equals(java.lang.Object)" resolve="equals" />
-                        <node concept="37vLTw" id="7iCybvTyGAj" role="37wK5m">
-                          <ref role="3cqZAo" node="7iCybvTyBuB" resolve="key" />
-                        </node>
+                    <node concept="3y3z36" id="5gVsyvEZfAo" role="3clFbw">
+                      <node concept="10Nm6u" id="5gVsyvEZfEJ" role="3uHU7w" />
+                      <node concept="37vLTw" id="5gVsyvEZfhG" role="3uHU7B">
+                        <ref role="3cqZAo" node="5gVsyvEZeb_" resolve="pref" />
                       </node>
                     </node>
                   </node>
@@ -4860,7 +4871,7 @@
                               <ref role="3cqZAo" node="7iCybvTyUUs" resolve="OPTION_TYPECHECKING_ENABLED" />
                             </node>
                             <node concept="Xl_RD" id="7iCybvTzMCH" role="37wK5m">
-                              <property role="Xl_RC" value="true" />
+                              <property role="Xl_RC" value="false" />
                             </node>
                           </node>
                         </node>