a type var's constraint now also tracks whether the type var was compared to a stable type
if it was, we probably shouldn't widen the type argument that's inferred for this var,
as the result will surely fail to type check
NOTE: must be enabled using -Xexperimental
review by extempore
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25862 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
instead of barring types that have been skolemized after the TypeVar they're being compared against, (isRelatable)
simply remember when a type var is compared to a type skolem from a later skolemization level
finally, repack the solution for the type var into a fresh existential if the compared level exceeded ours
NOTE: must be enabled using -Xexperimental
review by extempore
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25861 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
can't believe I missed that one...
closes SI-5033
more complete test case to make sure the multi-arglist case works as well
no review
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25860 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
for now, left the old if(settings.YdepMethTpes.value) guards in comments
removed *.flags containing -Ydependent-method-types
also updated one check file with one fewer error
no review
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25859 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
however, it must be possible to inline Ensuring, ArrowAssoc methods
renamed the public val x to something a little less intrusive
fixed check file to reflect better error message (see! it wasn't that uncommon for people to write `foo.x` -- NEWS AT ELEVEN)
no review
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25858 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
Having I think established this isn't merely a dance around the
maypole, I'm going to continue breaking down Namers because it's
hard to figure out where my stubbing mechanism is colliding with
the existing logic. Getting there, no review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25855 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
Contributed by Todd Vierling with minor mods by extempore. This is an
obvious extension of AbstractFunctionN which I had some issue making
work at the time. Sounds kind of pitiful given that the compiler patch
is about two lines, but let's all agree to believe it was a different
world then.
This example program is impacted as follows:
class A {
def f: PartialFunction[Any, Int] = { case x: String => 1 }
def g: PartialFunction[Any, Int] = f orElse { case x: List[_] => 2 }
def h: PartialFunction[Any, Int] = g orElse { case x: Set[_] => 3 }
}
Before: 34943 bytes of bytecode
After: 4217 bytes of bytecode
A mere 88% reduction in size. "'Tis but a trifle!" Closes SI-5096, SI-5097.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25854 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
If extempore is going to fix the hard bugs then first he is going to
make them less hard to fix. The major work of interest in here is the
decomplification of the bitmap logic. Hopefully this will come in handy
for anyone wishing to try out other encodings.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25853 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
Notice when a typeref's info creates an obvious cycle, so we can see an
error instead of a stack overflow. Closes SI-5093, review by moors.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25852 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
Impressed at the amount of ticket traffic for an unadvertised internal
method. All the more reason to work toward that support repl API.
Don't worry, it'll come. Closes SI-4899, no review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25848 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
Don't mark shutdown hooks as daemon threads, although it does
not seem to make any difference. Instead have the code which
waits for all threads to be complete be smarted about which
codes to monitor. No review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25847 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
true == new java.lang.Boolean(true) will in fact sometimes be true.
Also fixes a bug caused by this change in r23627.
- lazy val SerializableClass = getClass(sn.Serializable)
+ lazy val SerializableClass = getClass("scala.Serializable")
It used to be java.io.Serializable. Hey, let's not change the meaning
of existing symbols which are in active use. No review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25846 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
I can't go bear hunting without a clean gun. Basically I iterated over
Namers until I could understand it. I added a variety of documentation
there and elsewhere. There shouldn't be anything particularly behavioral
changing in this commit, but I did delete some years-old code (having
huge commented out blocks of way-out-of-date code is not a boon to
understanding) and the debugging output will look different. Better,
one can hope.
How about, review by moors.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25845 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
This is small correction of fix committed in r25814.
We need to swap terms in logical conjuction so
java.rmi.* stuff is accessed only if triggered by
@remote annotation.
No review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25841 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
In one of those unlikely accidents, I managed to lose the call
to evalOnce while still fixing the reported bug in a different
way (function composition led to the target only being called
once anyway.) No review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25839 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
An interesting bug during cleanup: runtime checks on the target of a
structural invocation duplicated the selection without regard for the
fact that it might be an expression. So if the name of the method being
invoked allowed the possibility that the target was a primitive type
(such as "toInt") the expression would be evaluated three times.
Closes SI-5080, no review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25838 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
added section headers, tightened the wording, shortened the list of
selected important packages, and explained automatic imports more
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25837 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
Pulling back from expensive path normalization caused a regression
where companions were no longer recognized as such after specialization.
(Specifically, the paths turned up as "test.scala" and "./test.scala".)
I made it a two-level check, doing the expensive one before failing.
Closes SI-5023, no review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25831 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
When many methods are missing, print a list of signatures the way they
need to be implemented, and throw in ??? stub implementations so it
should be compilable code. If anyone would like this logic exposed
more generally (for the IDE or whatever) just let me know. No review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25829 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
Taking adriaan's advice for what name would better describe
this method. Yours in reduction of ambiguous terminology, no review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25827 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
It took me a long time to find a trivial error while adjusting the
annotation packages, so I spent even longer trying to make sure next
time it would take me less time. It's the usual business of eliminating
duplication and unnecessary indirection.
Behavioral note: there was no consistency or deducible reasoning
regarding when annotation checks would be performed against the
typeSymbol directly (thus excluding annotation subclasses) or when they
would do a subclass check. I saw no reason it shouldn't always be a
subclass check; if the annotation isn't supposed to be subclassed it
should be final, and if it is, then the subclasses had probably better
not stop exhibiting the behavior of the base class.
Example: this now draws deprecated warnings, but did not before.
class bippy extends deprecated("hi mom", "burma shave")
@bippy def f = 5
(The deprecation message isn't printed so we're not there yet,
but closer.)
There is some new internal documentation on annotations, sadly lacking
in my famous ascii diagrams, and some new conveniences. Review by rytz.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25811 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
(T*)U now eta-expands to Seq[T] => U, not T* => U. There is a
transition command line switch to get the old behavior for any who
may have relied upon it:
-Yeta-expand-keeps-star
Closes SI-4176, no review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25809 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
One's devotion to aesthetics must not be allowed to trump one's
commitment to clearly delineated tuplehood. Closes SI-5067, no review.
git-svn-id: http://lampsvn.epfl.ch/svn-repos/scala/scala/trunk@25808 5e8d7ff9-d8ef-0310-90f0-a4852d11357a
moors