grpc/doc
Mark D. Roth 2395bb1b86 [xDS] fix "tls" channel cred in bootstrap to actually work (#36726)
This fixes a fairly embarrassing bug and lack of testing from #33234.  Prior to this fix, attempting to use the "tls" creds type would always cause a crash.

@gtcooke94 @matthewstevenson88 Note that the root cause of this bug was that when I wrote this code, I assumed that `grpc_tls_credentials_options` had a reasonable default for the cert verifier.  But it turns out that it doesn't do that directly; instead, we are only imposing that default in [`CredentialOptionSanityCheck()`](621aa4e5ce/src/core/lib/security/credentials/tls/tls_credentials.cc (L85)), which is called only when we call [`grpc_tls_credentials_create()`](621aa4e5ce/src/core/lib/security/credentials/tls/tls_credentials.cc (L160)), not when we directly instantiate `TlsCredentials` as my code was doing.  As part of the TlsCreds API cleanup you're working on, we should fix this so that callers get the right behavior even if they are internal callers that instantiate the TlsCreds object directly rather than calling the C-core API.

Closes #36726

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36726 from markdroth:xds_bootstrap_mtls_creds_fix dac2789e10
PiperOrigin-RevId: 637993734
2024-05-28 13:00:28 -07:00
..
core [doc] Add address proxy documentation. (#34750) 2023-10-19 14:48:02 -07:00
cpp Remove `include/grpcpp/impl/codegen/client_context.h` (#31006) 2022-10-03 18:01:22 -04:00
images Writing a doc with steps to contribute to the grpc code base. 2024-02-06 00:31:06 -08:00
python [Python o11y] Fix readme (#35988) 2024-02-23 13:26:20 -08:00
.gitignore Upgrade virtualenv pip in Python docgen 2016-07-20 17:23:45 -07:00
PROTOCOL-HTTP2.md [Doc] Update PROTOCOL-HTTP2.md (#34907) 2023-12-15 01:26:47 -08:00
PROTOCOL-WEB.md web: make HTTP field names case-insensitive (#32364) 2023-03-17 15:37:40 -07:00
bazel_support.md [CI] Moved to Bazel 7 (#36105) 2024-03-20 16:16:12 -07:00
binary-logging.md Fix a broken link (#28647) 2022-07-12 13:07:19 -07:00
c-style-guide.md Give guidance on prefixing struct/enum/#define names 2017-09-13 10:39:28 -07:00
command_line_tool.md [doc] Add note on current status of grpc_cli tool (#35675) 2024-01-31 10:44:38 -08:00
compression.md [docs] Clarify expected semantics of deflate compression (#36113) 2024-03-20 15:06:44 -07:00
compression_cookbook.md Compression Cookbook 2016-07-08 20:56:25 -07:00
connection-backoff-interop-test-description.md Replacing 'HTTP' by 'HTTPS' for securing links 2019-11-20 21:08:24 +07:00
connection-backoff.md Updated backoff to spec. 2016-11-24 00:47:51 -08:00
connectivity-semantics-and-api.md Fix many typos in doc 2019-02-14 11:14:16 +07:00
cpp-style-guide.md cpp doc nits 2017-05-05 11:02:07 -07:00
environment_variables.md [xDS] move CDS and EDS watchers into xds resolver (#35011) 2024-01-02 09:20:06 -08:00
fail_fast.md cpp doc nits 2017-05-05 11:02:07 -07:00
fork_support.md Update the fork-support doc (#28567) 2022-01-14 12:58:57 -08:00
g_stands_for.md [Release] Bump version to 1.65.0-dev (on master branch) (#36544) 2024-05-06 14:41:36 -07:00
grpc_release_schedule.md add link to release support policy 2021-02-16 15:05:10 -08:00
grpc_security_audit.pdf security audit report 2019-10-23 14:54:08 -07:00
grpc_xds_features.md [xDS] fix "tls" channel cred in bootstrap to actually work (#36726) 2024-05-28 13:00:28 -07:00
health-checking.md [doc] Remove the suggested format for health check name (#32841) 2023-04-11 09:04:47 -07:00
http-grpc-status-mapping.md Add HTTP->gRPC status code mapping 2016-03-31 12:30:08 -07:00
http2-interop-test-descriptions.md Remove trailing-spaces from doc/* 2020-02-10 23:53:33 +09:00
internationalization.md Remove trailing-spaces from doc/* 2020-02-10 23:53:33 +09:00
interop-test-descriptions.md [interop test docs] document --additional_metadata flag (#33180) 2023-05-25 13:05:19 -07:00
keepalive.md [C++ Examples] Add an example for keepalive (#33191) 2023-05-19 11:15:25 -07:00
load-balancing.md update load balancing doc (#27612) 2021-10-06 12:05:01 -07:00
naming.md [core] Add support for vsock transport (#33309) 2023-06-07 13:55:53 -07:00
qos-dscp.md [core] Add a channel argument to set DSCP on streams (#28322) 2023-06-30 16:10:21 -07:00
security_audit.md Remove trailing-spaces from doc/* 2020-02-10 23:53:33 +09:00
server-reflection.md [doc] Fix the link to the protocol (#35330) 2023-12-19 15:13:57 -08:00
server_reflection_tutorial.md Add Python Reflection Client (#29085) 2022-03-29 15:25:25 -07:00
server_side_auth.md Remove `include/grpcpp/impl/codegen/security/auth_context.h` (#31292) 2022-10-26 11:39:47 -04:00
service_config.md docs: service_config.md: fix pb syntax, add highlighting (#35232) 2023-12-07 16:25:58 -08:00
ssl-performance.md split table 2020-08-05 16:08:07 -07:00
status_ordering.md Don't consider receiving non-OK status as an error for HTTP2 2020-08-14 11:22:37 -07:00
statuscodes.md [status-doc] clarify status code behavior outside the defined range of codes (#34588) 2023-10-06 11:04:15 -07:00
unit_testing.md Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
versioning.md Remove trailing-spaces from doc/* 2020-02-10 23:53:33 +09:00
wait-for-ready.md Fix many typos in doc 2019-02-14 11:14:16 +07:00
workarounds.md Fix a typo referred on #11118 2017-08-24 09:35:10 -07:00
xds-test-descriptions.md [doc] Fix typo in xds-test-descriptions.md (#34329) 2023-10-31 12:58:11 -07:00