Compare commits

...

2 Commits

Author SHA1 Message Date
eugeneo 436463b1a9 Automated change: Fix sanity tests 2024-02-13 17:06:52 +00:00
Eugene Ostroukhov de59548834
[experiments] Set call_status_override_on_cancellation default to `false` from `debug` 2024-02-13 08:58:30 -08:00
3 changed files with 7 additions and 49 deletions

View File

@ -183,11 +183,6 @@ const char* const description_wrr_delegate_to_pick_first =
"Change WRR code to delegate to pick_first as per dualstack backend " "Change WRR code to delegate to pick_first as per dualstack backend "
"design."; "design.";
const char* const additional_constraints_wrr_delegate_to_pick_first = "{}"; const char* const additional_constraints_wrr_delegate_to_pick_first = "{}";
#ifdef NDEBUG
const bool kDefaultForDebugOnly = false;
#else
const bool kDefaultForDebugOnly = true;
#endif
} // namespace } // namespace
namespace grpc_core { namespace grpc_core {
@ -196,7 +191,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
{"call_status_override_on_cancellation", {"call_status_override_on_cancellation",
description_call_status_override_on_cancellation, description_call_status_override_on_cancellation,
additional_constraints_call_status_override_on_cancellation, nullptr, 0, additional_constraints_call_status_override_on_cancellation, nullptr, 0,
kDefaultForDebugOnly, true}, false, true},
{"call_v3", description_call_v3, additional_constraints_call_v3, nullptr, 0, {"call_v3", description_call_v3, additional_constraints_call_v3, nullptr, 0,
false, true}, false, true},
{"canary_client_privacy", description_canary_client_privacy, {"canary_client_privacy", description_canary_client_privacy,
@ -456,11 +451,6 @@ const char* const description_wrr_delegate_to_pick_first =
"Change WRR code to delegate to pick_first as per dualstack backend " "Change WRR code to delegate to pick_first as per dualstack backend "
"design."; "design.";
const char* const additional_constraints_wrr_delegate_to_pick_first = "{}"; const char* const additional_constraints_wrr_delegate_to_pick_first = "{}";
#ifdef NDEBUG
const bool kDefaultForDebugOnly = false;
#else
const bool kDefaultForDebugOnly = true;
#endif
} // namespace } // namespace
namespace grpc_core { namespace grpc_core {
@ -469,7 +459,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
{"call_status_override_on_cancellation", {"call_status_override_on_cancellation",
description_call_status_override_on_cancellation, description_call_status_override_on_cancellation,
additional_constraints_call_status_override_on_cancellation, nullptr, 0, additional_constraints_call_status_override_on_cancellation, nullptr, 0,
kDefaultForDebugOnly, true}, false, true},
{"call_v3", description_call_v3, additional_constraints_call_v3, nullptr, 0, {"call_v3", description_call_v3, additional_constraints_call_v3, nullptr, 0,
false, true}, false, true},
{"canary_client_privacy", description_canary_client_privacy, {"canary_client_privacy", description_canary_client_privacy,
@ -729,11 +719,6 @@ const char* const description_wrr_delegate_to_pick_first =
"Change WRR code to delegate to pick_first as per dualstack backend " "Change WRR code to delegate to pick_first as per dualstack backend "
"design."; "design.";
const char* const additional_constraints_wrr_delegate_to_pick_first = "{}"; const char* const additional_constraints_wrr_delegate_to_pick_first = "{}";
#ifdef NDEBUG
const bool kDefaultForDebugOnly = false;
#else
const bool kDefaultForDebugOnly = true;
#endif
} // namespace } // namespace
namespace grpc_core { namespace grpc_core {
@ -742,7 +727,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
{"call_status_override_on_cancellation", {"call_status_override_on_cancellation",
description_call_status_override_on_cancellation, description_call_status_override_on_cancellation,
additional_constraints_call_status_override_on_cancellation, nullptr, 0, additional_constraints_call_status_override_on_cancellation, nullptr, 0,
kDefaultForDebugOnly, true}, false, true},
{"call_v3", description_call_v3, additional_constraints_call_v3, nullptr, 0, {"call_v3", description_call_v3, additional_constraints_call_v3, nullptr, 0,
false, true}, false, true},
{"canary_client_privacy", description_canary_client_privacy, {"canary_client_privacy", description_canary_client_privacy,

View File

@ -57,16 +57,7 @@ namespace grpc_core {
#ifdef GRPC_EXPERIMENTS_ARE_FINAL #ifdef GRPC_EXPERIMENTS_ARE_FINAL
#if defined(GRPC_CFSTREAM) #if defined(GRPC_CFSTREAM)
#ifndef NDEBUG inline bool IsCallStatusOverrideOnCancellationEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_CALL_STATUS_OVERRIDE_ON_CANCELLATION
#endif
inline bool IsCallStatusOverrideOnCancellationEnabled() {
#ifdef NDEBUG
return false;
#else
return true;
#endif
}
inline bool IsCallV3Enabled() { return false; } inline bool IsCallV3Enabled() { return false; }
inline bool IsCanaryClientPrivacyEnabled() { return false; } inline bool IsCanaryClientPrivacyEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_CLIENT_IDLENESS #define GRPC_EXPERIMENT_IS_INCLUDED_CLIENT_IDLENESS
@ -119,16 +110,7 @@ inline bool IsWriteSizeCapEnabled() { return true; }
inline bool IsWrrDelegateToPickFirstEnabled() { return true; } inline bool IsWrrDelegateToPickFirstEnabled() { return true; }
#elif defined(GPR_WINDOWS) #elif defined(GPR_WINDOWS)
#ifndef NDEBUG inline bool IsCallStatusOverrideOnCancellationEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_CALL_STATUS_OVERRIDE_ON_CANCELLATION
#endif
inline bool IsCallStatusOverrideOnCancellationEnabled() {
#ifdef NDEBUG
return false;
#else
return true;
#endif
}
inline bool IsCallV3Enabled() { return false; } inline bool IsCallV3Enabled() { return false; }
inline bool IsCanaryClientPrivacyEnabled() { return false; } inline bool IsCanaryClientPrivacyEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_CLIENT_IDLENESS #define GRPC_EXPERIMENT_IS_INCLUDED_CLIENT_IDLENESS
@ -182,16 +164,7 @@ inline bool IsWriteSizeCapEnabled() { return true; }
inline bool IsWrrDelegateToPickFirstEnabled() { return true; } inline bool IsWrrDelegateToPickFirstEnabled() { return true; }
#else #else
#ifndef NDEBUG inline bool IsCallStatusOverrideOnCancellationEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_CALL_STATUS_OVERRIDE_ON_CANCELLATION
#endif
inline bool IsCallStatusOverrideOnCancellationEnabled() {
#ifdef NDEBUG
return false;
#else
return true;
#endif
}
inline bool IsCallV3Enabled() { return false; } inline bool IsCallV3Enabled() { return false; }
inline bool IsCanaryClientPrivacyEnabled() { return false; } inline bool IsCanaryClientPrivacyEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_CLIENT_IDLENESS #define GRPC_EXPERIMENT_IS_INCLUDED_CLIENT_IDLENESS

View File

@ -41,7 +41,7 @@
# Supported platforms: ios, windows, posix # Supported platforms: ios, windows, posix
- name: call_status_override_on_cancellation - name: call_status_override_on_cancellation
default: debug default: false
- name: call_v3 - name: call_v3
default: false default: false
- name: canary_client_privacy - name: canary_client_privacy