Commit Graph

389 Commits

Author SHA1 Message Date
Mehrdad Afshari bb3d95b643 Use https://grpc.io consistently as the canonical URL 2017-07-10 22:24:28 +00:00
Vijay Pai c0baec60a1 Internalize structs and methods meant for being exposed through codegen
or that interface with core and are only for internal use
2017-07-10 14:33:53 -07:00
yang-g d03594fb73 second try 2017-07-10 14:23:00 -07:00
yang-g 0d9caecde2 Unref the call first in case the collection is still used in call 2017-07-10 11:24:53 -07:00
yang-g a3d929169f Use pointer to avoid assignment and race. 2017-07-08 00:57:20 -07:00
Vijay Pai 17bf3e1434 Merge pull request #11705 from vjpai/typos
Resolve typos
2017-07-07 08:44:33 -07:00
Vijay Pai 28ee1ecdf0 Resolve typos 2017-07-06 14:46:37 -07:00
Noah Eisen 67a40548ca Initialize pending_ops false 2017-07-06 09:34:06 -07:00
ncteisen 36bb8a0006 s/hanging/pending/g 2017-07-05 11:21:25 -07:00
ncteisen 43f2b55a07 Add repro and fix to bidi case 2017-07-05 10:33:21 -07:00
ncteisen 95f7a51746 Fix writelast bug 2017-07-05 10:33:21 -07:00
Nicolas "Pixel" Noble 5d80dc4985 Merge branch 'master' of https://github.com/grpc/grpc into import 2017-06-26 22:01:11 +02:00
Vijay Pai 10c040d455 Move collection reset before unref (since unref could destroy obj) 2017-06-22 13:41:41 -07:00
Vijay Pai d35730d185 Fix use of terminal underscores in field names. 2017-06-22 12:06:44 -07:00
Vijay Pai fc539eb193 Re-enable public constructor for ClientAsyncResponseReader to avoid busting client that bypassed code generator. This code is deprecated-on-arrival as it is a performance pessimization. This code path should not be used. 2017-06-22 09:40:09 -07:00
Noah Eisen 5f5415eae3 Merge pull request #11429 from gkelly/fix-extra-semis
Remove extraneous semicolons.
2017-06-08 10:08:57 -07:00
Jan Tattermusch 7897ae9308 auto-fix most of licenses 2017-06-08 11:22:41 +02:00
Garret Kelly 0cd689202d Remove extraneous semicolons.
Fixes compilation if building with -Wextra-semi.
2017-06-07 14:56:06 -04:00
yang-g 63610c4740 Update comments to discourage having an OK status with error_message 2017-06-02 16:30:54 -07:00
Nicolas "Pixel" Noble 7bc55fdaa3 Merge remote-tracking branch 'ctiller/build-wtf' into import 2017-05-26 00:32:47 +02:00
Mark D. Roth 34011f19ed Merge pull request #11246 from markdroth/doc_fixes
More Doxygen comment improvements.
2017-05-23 09:20:39 -07:00
Craig Tiller 840931eec9 More import fixes 2017-05-19 15:37:45 -07:00
Mark D. Roth 127fdaeace More Doxygen comment improvements. 2017-05-19 13:16:13 -07:00
Mehrdad Afshari a64ea5496d Corrected spelling 2017-05-17 23:16:48 -07:00
apolcyn 5d0b1aeade Merge pull request #10992 from apolcyn/doxygen_cpp_nits
Doxygen cpp nits
2017-05-17 22:45:27 -07:00
Alexander Polcyn 16153d11f8 address comments, description changes 2017-05-15 09:48:49 -07:00
Alexander Polcyn bb2c338924 format changes, address comments 2017-05-11 15:15:29 -07:00
Alexander Polcyn d6ba5ecc34 fix bad line breaks and lengths 2017-05-10 16:21:56 -07:00
Alexander Polcyn 41ff2e1ee6 address comments, format changes 2017-05-10 15:39:58 -07:00
ncteisen 22dbd73b43 Add static assert to enforce subtype invariant 2017-05-10 09:16:22 -07:00
Alexander Polcyn 0f02908e67 address comments 2017-05-09 14:28:58 -07:00
Alexander Polcyn d809a15ec4 cpp doc nits 2017-05-05 11:02:07 -07:00
ncteisen fde16afefa Merge branch 'master' of https://github.com/grpc/grpc into serialization-refactor 2017-05-05 10:27:17 -07:00
Vijay Pai 611e7e78de Reintroduce a lambda capture as part of C++11-izing code 2017-05-01 15:09:30 -07:00
David Garcia Quintas 97106a7ef2 Removed 3rd party dep on thrift 2017-04-28 13:11:11 -07:00
Craig Tiller 017b452b7b Use larger block size in proto write 2017-04-26 07:55:38 -07:00
ncteisen cc7e17b2d6 Merge branch 'master' of https://github.com/grpc/grpc into serialization-refactor 2017-04-21 08:06:12 -07:00
Craig Tiller 50f7e1aa84 Merge github.com:grpc/grpc into hybrid 2017-04-21 06:38:04 -07:00
Craig Tiller f5a1b75065 Merge pull request #10761 from ctiller/ubsan
Fix ubsan reported failure
2017-04-20 15:03:36 -07:00
Craig Tiller 59db187c85 Merge branch 'tsan-c++' into hybrid 2017-04-20 19:24:57 +00:00
Craig Tiller 56bbe02ca1 Fix ubsan reported failure 2017-04-20 08:37:36 -07:00
Craig Tiller 06a30eef36 Merge github.com:grpc/grpc into cpparena 2017-04-19 14:40:20 -07:00
ncteisen e107b0d439 Add to codegen interface, refactor proto serialization
This change allows for some internal proto serialization
changes to be made
2017-04-19 14:01:13 -07:00
yang-g 6bc701659c Remove status_helper as it is not needed any more 2017-04-18 10:36:36 -07:00
Craig Tiller c3666d7090 Merge github.com:grpc/grpc into hybrid 2017-04-14 13:15:56 -07:00
Craig Tiller 2c6f63731c Merge github.com:grpc/grpc into cpparena 2017-04-14 13:14:10 -07:00
Craig Tiller 957562780a Merge pull request #10583 from ctiller/server_start
Threading robustness
2017-04-14 08:53:01 -07:00
Craig Tiller a103f7bbdf update comments 2017-04-13 09:25:44 -07:00
Craig Tiller 57e6485e2d Merge github.com:grpc/grpc into hybrid 2017-04-13 06:46:27 -07:00
Sree Kuchibhotla aa5a92800f Merge branch 'master' into cq_create_api_changes 2017-04-13 03:13:17 -07:00
Craig Tiller c20fa90c60 Merge github.com:grpc/grpc into cpparena 2017-04-12 06:44:00 -07:00
Craig Tiller 75bfb97548 Finish hybrid server stuff, ensure it gets tested 2017-04-11 17:55:12 -07:00
Craig Tiller 334c4678a3 Start building out C++ interface 2017-04-11 16:26:07 -07:00
yang-g eceec8eaf6 Add helper function to supply and parse error_details from Status. 2017-04-11 16:07:24 -07:00
Craig Tiller 9d9313cfc6 Threading robustness
Move server startup to a separate thread.
Where there is no opportunity for failure, do not return bool.
2017-04-11 15:05:46 -07:00
Sree Kuchibhotla f2b949b94a Merge branch 'master' into cq_create_api_changes 2017-04-10 13:35:50 -07:00
yang-g f4c8addded support C++ error_details 2017-04-07 15:52:16 -07:00
Sree Kuchibhotla a6ff103446 Merge branch 'master' into cq_create_api_changes 2017-04-06 13:09:17 -07:00
Craig Tiller d4e9a4863a Convert all async client stream types to not allocate 2017-04-05 15:41:59 -07:00
Craig Tiller fa416cbe3b Dont break codegen barrier 2017-04-05 15:14:30 -07:00
Craig Tiller 41f46ab665 Merge github.com:grpc/grpc into cpparena 2017-04-05 14:05:38 -07:00
Craig Tiller be094fc5e6 Fix compile 2017-04-04 09:31:28 -07:00
Craig Tiller e3b5921559 Potential msan fix 2017-04-04 09:28:54 -07:00
Sree Kuchibhotla 3f182df7de Fix C asan error and check_sources_and_headers.py 2017-04-02 03:44:43 -07:00
Sree Kuchibhotla c1a32fa46e Merge branch 'master' into cq_create_api_changes 2017-04-01 17:36:15 -07:00
Sree Kuchibhotla fa71f6f369 Fix ASAN failure 2017-04-01 17:32:34 -07:00
Craig Tiller 66051c618f Async end2end test passes 2017-03-31 09:16:35 -07:00
Craig Tiller dd36b15315 Call ref/unref, bugfixes 2017-03-31 08:27:28 -07:00
Craig Tiller 547631eaf8 Merge github.com:grpc/grpc into cpparena 2017-03-31 07:50:01 -07:00
David G. Quintas d58e74e784 Merge pull request #10381 from dgquintas/remove_lr_from_server_context
Removed wrong LR include from codegen
2017-03-30 14:19:41 -07:00
Sree Kuchibhotla e04906dc54 Merge branch 'master' into cq_create_api_changes 2017-03-30 13:20:00 -07:00
David Garcia Quintas 55c895a6a4 Removed wrong LR include from codegen 2017-03-30 10:43:14 -07:00
Sree Kuchibhotla ef8e00230e Do not call grpc_init() for per-call-completion-queues created by a C++
synchronous server
2017-03-28 18:11:09 -07:00
Sree Kuchibhotla 2c614a7a7b clang 2017-03-28 12:54:20 -07:00
Sree Kuchibhotla 14ab588166 Merge branch 'master' into cq_create_api_changes 2017-03-28 12:37:00 -07:00
Yuxuan Li e5ddd4b906 change EnsureInitialMetadataSent to use template 2017-03-27 13:25:33 -07:00
Sree Kuchibhotla 74f419fe74 undo prev change 2017-03-24 15:11:06 -07:00
Sree Kuchibhotla 057230b0cd Minor bug 2017-03-24 15:03:55 -07:00
Sree Kuchibhotla 5bec133ba0 clang format 2017-03-24 10:03:22 -07:00
Sree Kuchibhotla f2c32150ef Update C++ code 2017-03-22 03:01:24 -07:00
Vijay Pai 60a41907a0 Remove delete assertion on base class and change to full fetch-add 2017-03-21 09:39:11 -07:00
Yuxuan Li 8d00f52d5b fix EnsureInitialMetadataSent type casting 2017-03-20 12:35:38 -07:00
Yuxuan Li b39eeac79e merge init_ops, writes_done_ops and write_ops 2017-03-20 12:00:34 -07:00
Vijay Pai 379be59d0a Pour one out for shared ptr 2017-03-17 21:05:41 -07:00
Craig Tiller 5845091432 [EXPERIMENTAL] allocate unary response writer against call arena 2017-03-16 09:42:43 -07:00
Yuxuan Li 0aac9d06e2 change last_message bit to be in C++ layer only 2017-03-10 14:34:59 -08:00
Yuxuan Li bdc76ab37b bug fix 2017-03-08 10:59:31 -08:00
Yuxuan Li 34894e4b1c Implemented stream coalescing design
(RFC:https://github.com/grpc/proposal/pull/3). Add necessary
microbenchmarks to show reduced writes/iter for short streams. Add
necessary end2end test to test out newly added apis. Filter those tests
using *WithCoalescingApi*.
2017-03-08 10:59:31 -08:00
Sree Kuchibhotla 1dbd981cf8 Prefix grpc_cq_polling_type enums with GRPC_CQ_ 2017-03-03 14:27:44 -08:00
Sree Kuchibhotla 9f71b17707 Fix clang formatting issues 2017-03-03 12:54:58 -08:00
Sree Kuchibhotla 982a6f2b1c C++ code changes in response to grpc_completion_queue_create() API change 2017-03-03 02:19:31 -08:00
yang-g c42d844d27 Let ServerContext own the initial_metadata array for sync calls 2017-02-22 23:04:06 -08:00
yang-g f07ed45439 Restore the NextMessageSize for streamed calls 2017-02-16 23:01:28 -08:00
David Garcia Quintas f31f096274 Use call context to propagare LR costs 2017-02-13 16:26:00 -08:00
Harvey Tuch 5f3cfe960f Fix read from uninitialized memory bug in GrpcBufferWriter.
This commit fixes an issue in which the following sequence of operations
leads to use of uninitialized memory:

1. Caller invokes GrpcBufferWriter::Next(), and then makes use of 8191
   bytes in the returned buffer (which is 8192 bytes in size).

2. Caller then returns the unused single byte via
   GrpcBufferWriter::BackUp(). This method invokes
   g_core_codegen_interface->grpc_slice_split_tail(), which causes
   backup_slice_ to be a grpc_slice with one byte.

3. At the next invocation of GrpcBufferWriter::Next(), a reference to
   the single byte grpc_slice is returned to the caller.

The problem here is that the returned reference is to the inlined buffer
in the grpc_slice, which is resident in slice_, not the location of the
buffer inside slice_buffer_ after
g_core_codegen_interface->grpc_slice_buffer_add() in
GrpcBufferWriter::Next(). As a result, any data the caller writes to the
returned void* data is lost.

The solution is to avoid inlined backup slices.
2017-02-07 15:45:44 -05:00
Craig Tiller 68bb6a8453 Merge github.com:grpc/grpc into rollfwd 2017-01-27 06:52:13 -08:00
Craig Tiller 4edd56751f Merge github.com:grpc/grpc into maxmsgsz 2017-01-26 13:50:14 -08:00
Craig Tiller afceb2edbd Merge github.com:grpc/grpc into rollfwd 2017-01-26 12:21:28 -08:00
Mark D. Roth 448c1f002c Move parameters for all grpc_op types into their own sub-structs. 2017-01-25 10:44:30 -08:00
Craig Tiller 7c70b6c144 Revert "Revert "Metadata handling rewrite""
This reverts commit 5e01e2ac97.
2017-01-23 07:48:42 -08:00