Commit Graph

143 Commits

Author SHA1 Message Date
AJ Heller e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) (#28901)" (#28916)
This reverts commit fc7314c701.
2022-02-17 17:56:19 -08:00
AJ Heller fc7314c701
Avoid fully qualifying namespaces (and add check) (#28901)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
Alisha Nanda 0a502d8f2e
Fix race between Read and ServerContext::IsCancelled in Sync API (#27056)
* Fix OOM issues in qps tests

* Add more verbose logging.

* Fix clang error

* Fix race between IsCancelled and Read

* Fix build errors from using bool in C code
2021-09-15 12:29:02 -07:00
Craig Tiller ea389c00c2
Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
Vijay Pai 0f80378a21
Resolve race between OnReadDone(ok=false) and IsCancelled (#26245)
* Resolve and test race between OnReadDone(ok=false) and IsCancelled

* Fix retry case

* Fix health check case

* Address reviewer comments.

* ADD TODO requested by markdroth
2021-05-19 14:05:46 -07:00
Esun Kim fb5543c7c6
Add g_gli_initializer to server_context (#25759) 2021-03-18 16:06:49 -07:00
Yash Tibrewal f4e55b85bc Replace disrespectful term 2021-02-08 15:29:53 -08:00
Vijay Pai 83eab334a3 Delay ServerContextBase unref until lock freed since it could delete 2020-12-01 09:39:12 -08:00
Esun Kim e7434d385e Fix by tidy-modernize-use-override 2020-10-16 14:01:06 -07:00
Vijay Pai f8b046e819 Eliminate ServerContextBase::Clear/Setup and fix unref process for core call 2020-09-22 00:37:25 -07:00
Karthik Ravi Shankar 375d92be8d Merge branch 'master' into sync-stream 2020-09-08 15:14:48 -07:00
Karthik Ravi Shankar b657c8d79c
Revert "Revert "Move ServerContext from ::grpc_impl to ::grpc"" 2020-09-02 10:17:00 -07:00
Karthik Ravi Shankar f1abdd1725
Revert "Move ServerContext from ::grpc_impl to ::grpc" 2020-09-01 22:54:54 -07:00
Karthik Ravi Shankar dc3e1097e9 Merge branch 'master' into server-context 2020-08-19 14:18:27 -07:00
donnadionne 6b80f4d7f2
Merge pull request #23569 from sammyKhan/master
Return blank span if no call is active.
2020-08-18 13:35:01 -07:00
Karthik Ravi Shankar 56d7d9e804 Move ServerContext from ::grpc_impl to ::grpc 2020-08-13 14:24:29 -07:00
Karthik Ravi Shankar 15cce00f52
Revert "Revert "Fold Channel and CompletionQueue from grpc_impl to grpc"" 2020-08-06 20:42:54 -07:00
Karthik Ravi Shankar f3f9e8941a
Revert "Fold Channel and CompletionQueue from grpc_impl to grpc" 2020-08-06 15:56:09 -07:00
Karthik Ravi Shankar ab775de1a2 Build and formatting fixes 2020-08-04 13:31:42 -07:00
Sam Khan 9dc71643fa Return blank span if no call is active.
Otherwise unit tests of gRPC servers that call GetSpanFromServerContext
segfault.
2020-07-23 11:46:37 +02:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
Vijay Pai 1dd7a01bc7
Avoid a use of ReleasableMutexLock 2020-06-16 08:25:12 -07:00
Vijay Pai 1f0cdd5aad Construct DefaultReactor lazily since not always needed 2020-01-23 08:52:21 -08:00
Vijay Pai 94a8c5888a Remove namespace experimental from namespace grpc_impl 2019-12-02 15:36:05 -08:00
Vijay Pai be6979202b Revamp server-side C++ callback API, message allocator, and mocking 2019-11-20 16:56:18 -08:00
Esun Kim f40a702441 Clean up headers 2019-11-15 09:38:31 -08:00
Vijay Pai ab72f441d8 Remove unused-parameter warnings, round 2 (14 of 19) 2019-10-21 09:16:34 -07:00
Vijay Pai 41d89242ad Remove unused parameter warning (2 of 20) 2019-10-17 08:50:44 -07:00
Vijay Pai 6f9fe64626 Improve logging on API misuse assert 2019-10-16 10:44:10 -07:00
Moiz Haidry bf994e48d9 Move grpc async, callback and sync implementation to grpc_impl namespace 2019-07-01 14:05:54 -07:00
Moiz Haidry 226e63dd0c Move server context implementation to grpc_impl namespace and typedef the ref to it 2019-06-05 10:41:30 -07:00
Soheil Hassas Yeganeh 2b9448a71c Revert "Revert "Introduce C++ wrappers for gpr_mu and gpr_cv.""
This reverts commit d09c9f8e20.
2019-04-17 14:35:29 -04:00
Alexander Polcyn d09c9f8e20 Revert "Introduce C++ wrappers for gpr_mu and gpr_cv."
This reverts commit a26c09dd25.
2019-04-11 16:52:54 -07:00
Vijay Pai 41c6cba9f5 Make sure that OnCancel happens after OnStarted 2019-04-10 11:32:34 -07:00
Soheil Hassas Yeganeh a26c09dd25 Introduce C++ wrappers for gpr_mu and gpr_cv.
Introduce RAII wrappers in the grpc::internal and grpc_core
namespaces, and use them in place of std::mutex and
std::condition_variable.

Note that, since std::mutex is also used by the public
C++ headers we cannot introduce these wrappers in grpc_core.

Also, note that in grpcpp we cannot use gRPC core and vice versa.
So we had to duplicate the code, once using core_codegen_interface
and once using direct calls.
2019-04-08 18:27:07 -04:00
Vijay Pai 04a6b8467c Support callback on cancellation of server-side unary RPCs 2019-03-18 12:00:57 -07:00
Soheil Hassas Yeganeh 059e104475 Use grpc_core::RefCount for ServerContext. 2019-03-02 23:25:18 -05:00
Vijay Pai 8feb16171a Add an expectation and fix a ServerContext bug 2019-02-25 00:48:11 -08:00
Vijay Pai 2a0c0d7ad6 Streaming API for callback servers 2018-11-30 16:14:21 -08:00
Vijay Pai 0e29d7b9bc Properly clear metadata and other structs when reusing ServerContext 2018-11-13 12:44:56 -08:00
Yash Tibrewal 193b4b57ec
Merge pull request #17072 from yashykt/interceptor_cancellation
Interceptors should see a Cancellation notification
2018-11-06 14:56:24 -08:00
Vijay Pai 1e850944e9 Release the CallbackWithSuccessTag from a server context completionop 2018-11-06 11:49:17 -08:00
Vijay Pai 526d2e6004 Refactoring of CallbackWithSuccessTag 2018-11-06 11:20:50 -08:00
Yash Tibrewal fd88dcaf55 Add cancellation notification 2018-11-01 11:58:46 -07:00
Vijay Pai 932abf48a3 Address reviewer comments. 2018-10-31 01:02:07 -07:00
Vijay Pai 2f47137a6e Add support for IsCancelled check 2018-10-30 23:15:59 -07:00
Vijay Pai 84e763f10a Experimental C++ server callback unary API 2018-10-29 13:41:25 -07:00
Yash Tibrewal 3896dabb85 Merge branch 'master' into interceptors 2018-10-25 19:50:10 -07:00
Yash Tibrewal 281de1bb30 Solve memory leak due to double setting of set_server_rpc_info 2018-10-24 15:54:08 -07:00
Vijay Pai 45dfbe097e Arena-allocate the ServerContext::CompletionOp 2018-10-24 02:11:50 -07:00