Commit Graph

73 Commits

Author SHA1 Message Date
Muxi Yan 121e04bc1e address comments 2 2019-01-09 15:22:05 -08:00
Muxi Yan d4fa274bf2 address comments 2019-01-09 09:38:47 -08:00
Muxi Yan 8b55c6a871 clang-format 2019-01-07 16:54:37 -08:00
Muxi Yan d7650a841b Bug fix for GRXConcurrentWriter 2019-01-07 16:51:08 -08:00
Muxi Yan 3cdc0db838 clang-format 2019-01-07 10:27:20 -08:00
Muxi Yan 03232ba46f Polish comments and correct concurrent writeable behavior 2019-01-07 10:27:20 -08:00
Muxi Yan 5e10a3b037 Make gRPC ObjC thread safety right 2019-01-07 10:27:20 -08:00
Muxi Yan 4d6644ada8
Merge pull request #15429 from grpc/fix-conc-self
Fix self use in GRXConcurrentWriteable
2018-05-25 13:56:44 -07:00
Muxi Yan 76facd4a7f Move GRXMappingWriter to root directory 2018-05-23 17:03:15 -07:00
Muxi Yan b43c3336ac
Fix self use in GRXConcurrentWriteable 2018-05-17 10:47:57 -07:00
Muxi Yan c92d90aba2 clang-format objective-c files 2018-04-11 18:10:02 -07:00
Muxi Yan 53a295bca7
Fix a typo 2018-02-05 10:16:15 -08:00
Muxi Yan d65458dde8 Fix reference of self in block 2018-02-05 09:52:33 -08:00
Muxi Yan 0c0ebc57e2 Fix gRPC ObjC void function definition 2017-10-20 14:49:26 -07:00
Muxi Yan 4e1b26ec1b Replace dispatch_once_t with BOOL 2017-08-18 11:03:35 -07:00
Muxi Yan 860b1da060 Resume GRXBufferedPipe when it gets dealloced 2017-07-29 12:05:19 -07:00
Muxi Yan c05d1b41c2 Some fixes for tests and change contract 2017-06-26 17:25:01 -07:00
Muxi Yan bea9fe4b4e Merge remote-tracking branch 'upstream/master' into fix-pipe-buffer 2017-06-26 17:09:12 -07:00
Muxi Yan d6cee15135 Simply queue up writesFinishedWithError without cancelling pending messages 2017-06-26 17:09:09 -07:00
Muxi Yan 08fef09ed1 Fix minor problems 2017-06-26 12:19:27 -07:00
Muxi Yan 9ae2a7dc86 Remove conditionals covered by invoke agreement 2017-06-17 15:20:09 -07:00
Muxi Yan d4792e9d8d Polish GRXBufferedPipe 2017-06-13 10:00:53 -07:00
Jan Tattermusch 7897ae9308 auto-fix most of licenses 2017-06-08 11:22:41 +02:00
Muxi Yan d7d6a2e12b Better concurrency handling 2017-06-06 14:39:15 -07:00
Muxi Yan e09e47ccb8 Use getter/setter 2017-06-05 15:14:47 -07:00
Muxi Yan d6545bb3df Comments on BufferedPipe 2017-06-05 09:22:15 -07:00
Muxi Yan 033db460ba Fix pipeline finishing bug 2017-05-23 17:17:20 -07:00
Muxi Yan 49b7f8349b Remove synchronization in GRXBufferedPipe:writesFinishedWithError and change tests correspondingly 2017-05-22 10:39:48 -07:00
Muxi Yan ec8e82507e Use dispatch_queue to serialize writes 2017-05-15 14:59:07 -07:00
Muxi Yan 91d7bb0c2e Sync writes with queue 2017-05-10 14:26:40 -07:00
Muxi Yan 895f3d83da Support configuring dispatch queue in GRPCCall and below 2017-04-05 13:12:30 -07:00
Muxi Yan 29a912df09 Add more comments 2017-03-27 15:14:23 -07:00
Muxi Yan c2e53b5af4 Addressed the comments 2017-03-22 14:30:16 -07:00
Muxi Yan 01bbf87bf7 Add comments for map function 2017-03-10 15:02:28 -08:00
Muxi Yan a40ccd8580 Packet coalescing Objc layer and interop tests 2017-01-04 22:10:05 -08:00
Jorge Canizales ea5325c484 Avoid static initialization of the kIdentity block
Unlike other Objective-C objects, there's no hard reason why the compiler wouldn't be able to initialize a block statically (as it does with NSString literals). And it certainly doesn't complain about it (like it does with other object initializers). But as I haven't been able to find confirmation of this, and we're seeing a weird crash occur near this code, let's play it safe.
2016-08-24 18:47:51 -07:00
Craig Tiller 6169d5f7b0 Update copyrights 2016-03-31 07:46:18 -07:00
Jorge Canizales 7cfb396bf6 Make copyright not expire one year too soon. 2016-03-14 19:03:54 -07:00
Jorge Canizales 5a8ec75012 Use a named constant for error domain and code 2016-03-11 18:41:54 -08:00
Jorge Canizales 5e67232030 Make Writeable with single handler robust against stream Writers 2016-03-11 12:26:42 -08:00
Nicolas Noble dcd35b8ad6 Merge pull request #3969 from grpc/release-0_11
Release 0 11 -> master
2015-10-26 17:41:17 -07:00
Jorge Canizales b10776c509 Reformat comments as Cocoadocs 2015-10-26 10:44:55 -07:00
Scott84 fbc1139aa0 Update GRXWriter.m
Corrected compiler warning for effectively pure virtual ObjC methods.
2015-10-02 09:01:28 -07:00
Jorge Canizales f95ddbaa1e Rename SingleValueHandler->SingleHandler, StreamHandler->EventHandler 2015-08-12 12:56:03 -07:00
Jorge Canizales 297ed7bd81 Don’t set the request writer to nil, as @synchr(nil) is undefined behavior.
Also clarify in GRXWriter.h that the writeable is released whenever the
writer finishes.
2015-08-08 16:48:47 -07:00
Jorge Canizales fd51dff8b8 Clarify invalid-argument message for already-started writers 2015-08-08 16:12:52 -07:00
Jorge Canizales 67ce098ccf Clarify thread-safety expectations of GRXWriters 2015-08-07 23:10:49 -07:00
Jorge Canizales c678c30cf1 Fix ForwardingWriter init preconditions 2015-08-07 18:28:29 -07:00
Michael Lumish cd329560d3 Merge pull request #2526 from jcanizales/accept-nil-container
Accept [GRXWriter writerWithContainer:nil] for consistency with the rest
2015-07-20 10:03:08 -07:00
Michael Lumish 51c69e6a6f Merge pull request #2525 from jcanizales/fix-emptywriter
Fix [GRXWriter emptyWriter] not being reusable.
2015-07-20 10:02:44 -07:00