Commit Graph

42 Commits

Author SHA1 Message Date
Tanvi Jagtap 9cbde967bb [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36517)
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log

In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.

We have the following mapping
1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)

Closes #36517

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36517 from tanvi-jagtap:gpr_log_init 4c886dafff
PiperOrigin-RevId: 630551354
2024-05-03 18:37:34 -07:00
Tanvi Jagtap b0de95507c [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT (#36441)
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK

These changes have been made using string replacement and regex.

Will not be replacing all instances of CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only ones which are doable using very simple regex with least chance of failure will be replaced.

Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #36441

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36441 from tanvi-jagtap:tjagtap_util_01 ca10292925
PiperOrigin-RevId: 627961969
2024-04-24 22:46:32 -07:00
Craig Tiller 67f364e23e
[cleanup] Eliminate usage of GRPC_ASSERT(false...); (#31757)
* crash function

* progress

* fix

* fix

* Automated change: Fix sanity tests

* fix

* fix

* fix

* fixes

* Automated change: Fix sanity tests

* fix

* Automated change: Fix sanity tests

* fix

* fix

* use cpp attr

* Automated change: Fix sanity tests

* fix

* fix

* fix

* fix

* fix

* fix

* add exclusion

* fix

* typo

* fix

* fmt

* Update tcp_socket_utils.cc

* Automated change: Fix sanity tests

* fix

* revert php changes

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2023-01-11 08:50:32 -08:00
Yijie Ma f99b8b5bc4
Convert c-style comments to C++-style comments (#31923)
* baseline

* fix clang-tidy

* manually revert these files

* manually fixup at eof

* revert 2 more files

* change check_deprecated_grpc++.py

* change end2end_defs.include template

* fix check_include_guards.py

* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py

not yet ready to be submitted

* fix

yapf check_include_guards.py
remove a space...

* fix version.cc.template

* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Craig Tiller ea389c00c2
Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
capstan 131579d52d Roll forward of commit 7883b51: Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.

This reverts commit da66b7d14e.

NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440.
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
2020-11-06 16:07:19 +01:00
Nathan Herring da66b7d14e
Revert "Abseil Flags" 2020-10-24 15:19:55 -07:00
capstan 7883b5133d Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.
2020-10-23 19:36:33 +02:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
Jan Tattermusch a960546ff9
Revert "[7/n] Avoid using hardcoded test credentials" 2020-04-28 17:41:24 +02:00
ZhenLian c13f3c5a50 test using ReadFile 2020-04-25 11:49:51 -07:00
ZhenLian 2c84dec7da try adding extern 2020-04-21 10:08:34 -07:00
ZhenLian dd44231a32 [No Review] Test 2020-04-19 16:04:41 -07:00
Wayne Zhang bd2756e482 Fix format 2019-05-28 15:39:53 -07:00
Wayne Zhang edc506849f Expose interop test for others 2019-05-22 15:24:33 -07:00
Karthik Ravi Shankar 603d014f0e Changes to fold credentials into grpc_impl from grpc 2019-04-23 13:54:26 -07:00
Karthik Ravi Shankar ecfc107f32 Make more changes to remove grpc qualifier from tests 2019-03-21 18:40:00 -07:00
Karthik Ravi Shankar 54171e276f Fold server credentials from grpc to grpc_impl namespace 2019-03-20 10:00:34 -07:00
Alexander Polcyn f3c3c55fad Allow choosing google default credentials in the C++ interop clients 2018-07-13 18:23:14 -07:00
Yihua Zhang 0dcbb83420 add alts to interop tests 2018-04-20 08:50:45 -07:00
Jan Tattermusch 7897ae9308 auto-fix most of licenses 2017-06-08 11:22:41 +02:00
yang-g cc5910228d manual revert of #8901 2017-01-11 11:10:43 -08:00
Craig Tiller 3b45b8d60b Revert "Test credentials provider update" 2016-11-29 12:31:14 -08:00
yang-g 8e9fc9bd0e Test credentials provider update 2016-11-22 23:12:49 -08:00
Vijay Pai 320ed13d3e Deprecate grpc::thread and sync in favor of std::thread,mutex,etc 2016-11-01 17:16:55 -07:00
Vijay Pai 713c7b87e1 clang-format 2016-11-01 16:33:18 -07:00
Vijay Pai c0b2acb1a0 Use C++11 final and override 2016-11-01 16:31:56 -07:00
David Garcia Quintas c79b0650d2 removed codegen/log.h 2016-07-27 21:11:58 -07:00
Vijay Pai a63271c77f Deal with to_string, proper usage of nullptr, and lack of map::emplace 2016-06-15 12:56:38 -07:00
Vijay Pai 12bf3801b8 Got carried away with grpc:: 2016-06-15 11:24:10 -07:00
Vijay Pai efa8430e39 Enforce gcc-4.4 compatibility on test_credentials_provider by changing
a map to 2 vectors. Additional minor changes needed (e.g., override->GRPC_OVERRIDE,
nullptr->grpc::nullptr)
2016-06-15 10:23:34 -07:00
Craig Tiller f40df23eeb Auto-changes 2016-03-25 13:38:14 -07:00
Craig Tiller 7fe08a23f1 clang-format 2016-02-29 20:17:48 -08:00
Dan Born 1b5a264eb8 Allow new credential types to be added to tests. 2016-02-24 18:52:39 -08:00
Dan Born 53a94ef4e7 Use standard include paths. 2016-02-24 15:44:43 -08:00
Dan Born 7275f36411 Initialize mutex to nullptr. 2016-02-24 15:09:16 -08:00
Dan Born f30941cd95 Injectable test credentials provider interface. 2016-02-24 14:55:02 -08:00
yang-g 12a0a2c20b move tls type name to .cc file 2016-02-19 00:22:20 -08:00
yang-g 4c8aed3dba Add a helper to return all the secure types 2016-02-19 00:19:39 -08:00
yang-g 17197ddc71 Revert "make an enum"
This reverts commit 5152cd29f8.
2016-02-19 00:04:22 -08:00
yang-g 5152cd29f8 make an enum 2016-02-18 16:37:51 -08:00
yang-g 7d2a3e1917 Refactor end2end_test. Make the credentials a separate library. 2016-02-18 15:41:56 -08:00